Re: [U-Boot] [RFC PATCH v2 15/20] fastboot: Merge boot common across USB and UDP

2018-05-08 Thread Alex Kiernan
On Tue, May 8, 2018 at 7:09 AM Joe Hershberger wrote: > On Mon, May 7, 2018 at 4:59 PM, Jocelyn Bohr wrote: > > Optional nit: Consider renaming "fastbootcmd" to "fb_bootcmd" or similar. > > IMO "fastbootcmd" is > > ambiguous as there can be multiple env

Re: [U-Boot] [RFC PATCH v2 15/20] fastboot: Merge boot common across USB and UDP

2018-05-08 Thread Joe Hershberger
On Mon, May 7, 2018 at 4:59 PM, Jocelyn Bohr wrote: > Optional nit: Consider renaming "fastbootcmd" to "fb_bootcmd" or similar. > IMO "fastbootcmd" is > ambiguous as there can be multiple env variable commands related to > fastboot. Seems like a good suggestion to me. > On Thu,

Re: [U-Boot] [RFC PATCH v2 15/20] fastboot: Merge boot common across USB and UDP

2018-05-07 Thread Jocelyn Bohr
Optional nit: Consider renaming "fastbootcmd" to "fb_bootcmd" or similar. IMO "fastbootcmd" is ambiguous as there can be multiple env variable commands related to fastboot. On Thu, May 3, 2018 at 2:21 PM Joe Hershberger wrote: > On Mon, Apr 30, 2018 at 3:32 AM, Alex

Re: [U-Boot] [RFC PATCH v2 15/20] fastboot: Merge boot common across USB and UDP

2018-05-03 Thread Joe Hershberger
On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan wrote: > Merge USB and UDP boot code. The USB implementation stays the same, but > UDP no longer passes an fdt. We introduce a new environment variable > 'fastbootcmd' which if set overrides the hardcoded boot command, setting