Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.
On 09/09/2019 18:03, Neil Armstrong wrote: Hi Bin, On 08/09/2019 14:35, Bin Meng wrote: Hi Neil, On Sun, Sep 8, 2019 at 8:33 PM Neil Armstrong wrote: Hi Bin, Le 07/09/2019 à 05:44, Bin Meng a écrit : Hi Neil, On Thu, Sep 5, 2019 at 11:48 PM Neil Armstrong wrote: Hi Bin, I've been having the same behavior on the Amlogic S905X SoC with a DWC3 XHCI controller connected to 2 HS-only PHYs and no SS PHY. When a device is connected on the second PHY, I have the same BUG(), but no more when a device is also connected on the first PHY, and no issues at all on the first PHY. XHCI timeout on event type 33... cannot recover. What kind of debug output would you need to debug this ? => When Port 1 is disconnected, but Port 2 is populated: usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 0x0 clear port connect change, actual port 2 status = 0x6e1 ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 0x0 clear port reset change, actual port 2 status = 0x603 => When Port 1 is populated: usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 0x0 clear port connect change, actual port 2 status = 0x6e1 ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = HIGHSPEED ... usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 0x0 clear port reset change, actual port 2 status = 0xe03 When Port 1 is populated, Port 2 status correctly switches to HIGHSPEED, but why ? This looks really strange. Sounds like a hardware internal state depends on the first USB port. Do you know if Linux works? Yes, Linux works fine, is it worth tracing the Linux XHCI driver aswell ? Yes, that will definitely help. I did a extensive debug and print session today agains the amlogic u-boot release and Linux, and only : clrbits_le32(_reg->g_usb2phycfg, DWC3_GUSB2PHYCFG_SUSPHY); was missing in drivers/usb/host/xhci-dwc3.c because xhci-dwc3 is not using the dwc3 core init. it should use the dwc3 core init instead of a copy, that correctly handles the quirks. I posted today the v4 of a series that uses the DWC3 core for host operations. Can you give it try? The goal is ultimately to be able to replace platform-specific dwc3 host implementation. JJ Neil Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.
Hi Bin, On 08/09/2019 14:35, Bin Meng wrote: > Hi Neil, > > On Sun, Sep 8, 2019 at 8:33 PM Neil Armstrong wrote: >> >> Hi Bin, >> >> Le 07/09/2019 à 05:44, Bin Meng a écrit : >>> Hi Neil, >>> >>> On Thu, Sep 5, 2019 at 11:48 PM Neil Armstrong >>> wrote: Hi Bin, I've been having the same behavior on the Amlogic S905X SoC with a DWC3 XHCI controller connected to 2 HS-only PHYs and no SS PHY. When a device is connected on the second PHY, I have the same BUG(), but no more when a device is also connected on the first PHY, and no issues at all on the first PHY. XHCI timeout on event type 33... cannot recover. What kind of debug output would you need to debug this ? => When Port 1 is disconnected, but Port 2 is populated: usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 0x0 clear port connect change, actual port 2 status = 0x6e1 ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 0x0 clear port reset change, actual port 2 status = 0x603 => When Port 1 is populated: usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 0x0 clear port connect change, actual port 2 status = 0x6e1 ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = HIGHSPEED ... usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 0x0 clear port reset change, actual port 2 status = 0xe03 When Port 1 is populated, Port 2 status correctly switches to HIGHSPEED, but why ? >>> >>> This looks really strange. Sounds like a hardware internal state >>> depends on the first USB port. Do you know if Linux works? >> >> Yes, Linux works fine, is it worth tracing the Linux XHCI driver aswell ? > > Yes, that will definitely help. I did a extensive debug and print session today agains the amlogic u-boot release and Linux, and only : clrbits_le32(_reg->g_usb2phycfg, DWC3_GUSB2PHYCFG_SUSPHY); was missing in drivers/usb/host/xhci-dwc3.c because xhci-dwc3 is not using the dwc3 core init. it should use the dwc3 core init instead of a copy, that correctly handles the quirks. Neil > > Regards, > Bin > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.
Hi Neil, On Sun, Sep 8, 2019 at 8:33 PM Neil Armstrong wrote: > > Hi Bin, > > Le 07/09/2019 à 05:44, Bin Meng a écrit : > > Hi Neil, > > > > On Thu, Sep 5, 2019 at 11:48 PM Neil Armstrong > > wrote: > >> > >> Hi Bin, > >> > >> I've been having the same behavior on the Amlogic S905X SoC with a DWC3 > >> XHCI controller > >> connected to 2 HS-only PHYs and no SS PHY. > >> > >> When a device is connected on the second PHY, I have the same BUG(), > >> but no more when a device is also connected on the first PHY, and no issues > >> at all on the first PHY. > >> > >> XHCI timeout on event type 33... cannot recover. > >> > >> What kind of debug output would you need to debug this ? > >> > >> => When Port 1 is disconnected, but Port 2 is populated: > >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 > >> length 0x0 > >> clear port connect change, actual port 2 status = 0x6e1 > >> ... > >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 > >> length 0x0 > >> ... > >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 > >> length 0x4 > >> SPEED = FULLSPEED > >> ... > >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 > >> length 0x0 > >> ... > >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 > >> length 0x4 > >> SPEED = FULLSPEED > >> ... > >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 > >> length 0x0 > >> clear port reset change, actual port 2 status = 0x603 > >> > >> > >> => When Port 1 is populated: > >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 > >> length 0x0 > >> clear port connect change, actual port 2 status = 0x6e1 > >> ... > >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 > >> length 0x0 > >> ... > >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 > >> length 0x4 > >> SPEED = FULLSPEED > >> ... > >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 > >> length 0x0 > >> ... > >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 > >> length 0x4 > >> SPEED = HIGHSPEED > >> ... > >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 > >> length 0x0 > >> clear port reset change, actual port 2 status = 0xe03 > >> > >> When Port 1 is populated, Port 2 status correctly switches to HIGHSPEED, > >> but why ? > >> > > > > This looks really strange. Sounds like a hardware internal state > > depends on the first USB port. Do you know if Linux works? > > Yes, Linux works fine, is it worth tracing the Linux XHCI driver aswell ? Yes, that will definitely help. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.
Hi Bin, Le 07/09/2019 à 05:44, Bin Meng a écrit : > Hi Neil, > > On Thu, Sep 5, 2019 at 11:48 PM Neil Armstrong > wrote: >> >> Hi Bin, >> >> I've been having the same behavior on the Amlogic S905X SoC with a DWC3 XHCI >> controller >> connected to 2 HS-only PHYs and no SS PHY. >> >> When a device is connected on the second PHY, I have the same BUG(), >> but no more when a device is also connected on the first PHY, and no issues >> at all on the first PHY. >> >> XHCI timeout on event type 33... cannot recover. >> >> What kind of debug output would you need to debug this ? >> >> => When Port 1 is disconnected, but Port 2 is populated: >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 >> length 0x0 >> clear port connect change, actual port 2 status = 0x6e1 >> ... >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length >> 0x0 >> ... >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length >> 0x4 >> SPEED = FULLSPEED >> ... >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length >> 0x0 >> ... >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length >> 0x4 >> SPEED = FULLSPEED >> ... >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 >> length 0x0 >> clear port reset change, actual port 2 status = 0x603 >> >> >> => When Port 1 is populated: >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 >> length 0x0 >> clear port connect change, actual port 2 status = 0x6e1 >> ... >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length >> 0x0 >> ... >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length >> 0x4 >> SPEED = FULLSPEED >> ... >> usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length >> 0x0 >> ... >> usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length >> 0x4 >> SPEED = HIGHSPEED >> ... >> usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 >> length 0x0 >> clear port reset change, actual port 2 status = 0xe03 >> >> When Port 1 is populated, Port 2 status correctly switches to HIGHSPEED, >> but why ? >> > > This looks really strange. Sounds like a hardware internal state > depends on the first USB port. Do you know if Linux works? Yes, Linux works fine, is it worth tracing the Linux XHCI driver aswell ? Neil > > Regards, > Bin > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.
Hi Neil, On Thu, Sep 5, 2019 at 11:48 PM Neil Armstrong wrote: > > Hi Bin, > > I've been having the same behavior on the Amlogic S905X SoC with a DWC3 XHCI > controller > connected to 2 HS-only PHYs and no SS PHY. > > When a device is connected on the second PHY, I have the same BUG(), > but no more when a device is also connected on the first PHY, and no issues > at all on the first PHY. > > XHCI timeout on event type 33... cannot recover. > > What kind of debug output would you need to debug this ? > > => When Port 1 is disconnected, but Port 2 is populated: > usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length > 0x0 > clear port connect change, actual port 2 status = 0x6e1 > ... > usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length > 0x0 > ... > usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length > 0x4 > SPEED = FULLSPEED > ... > usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length > 0x0 > ... > usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length > 0x4 > SPEED = FULLSPEED > ... > usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length > 0x0 > clear port reset change, actual port 2 status = 0x603 > > > => When Port 1 is populated: > usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length > 0x0 > clear port connect change, actual port 2 status = 0x6e1 > ... > usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length > 0x0 > ... > usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length > 0x4 > SPEED = FULLSPEED > ... > usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length > 0x0 > ... > usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length > 0x4 > SPEED = HIGHSPEED > ... > usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length > 0x0 > clear port reset change, actual port 2 status = 0xe03 > > When Port 1 is populated, Port 2 status correctly switches to HIGHSPEED, > but why ? > This looks really strange. Sounds like a hardware internal state depends on the first USB port. Do you know if Linux works? Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [usb dwc3] xHCI driver -- a hint needed.
Hi Bin, I've been having the same behavior on the Amlogic S905X SoC with a DWC3 XHCI controller connected to 2 HS-only PHYs and no SS PHY. When a device is connected on the second PHY, I have the same BUG(), but no more when a device is also connected on the first PHY, and no issues at all on the first PHY. XHCI timeout on event type 33... cannot recover. What kind of debug output would you need to debug this ? => When Port 1 is disconnected, but Port 2 is populated: usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 0x0 clear port connect change, actual port 2 status = 0x6e1 ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 0x0 clear port reset change, actual port 2 status = 0x603 => When Port 1 is populated: usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 0x0 clear port connect change, actual port 2 status = 0x6e1 ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = FULLSPEED ... usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0 ... usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4 SPEED = HIGHSPEED ... usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 0x0 clear port reset change, actual port 2 status = 0xe03 When Port 1 is populated, Port 2 status correctly switches to HIGHSPEED, but why ? Neil On 09/04/2018 15:11, Yuri Frolov wrote: > Hi, > > I've been trying to bring up a dwc3 usb controller included in 32-bit MIPS > chip. > Usb is the one port usb2.0 host module, compliant with xHCI Revision 1.0, > UTMI+ Low Pin interface (ULPI) Revision 1.1 and AMBA AXI Protocol > specification. g_snpsid register reports 0x5533290a revision. > > It's verified, that linux kernel support is ok, usb is fully functional. > > axi { > <...> > > usb@1F04D050 { > compatible = "be,baikal-dwc3"; > reg = <0x1f04d050 0x4>; > interrupts = <0x0 0x45 0x4>; > #address-cells = <0x1>; > #size-cells = <0x1>; > clocks = <0xf 0x0>; > clock-names = "usb"; > ranges; > status = "okay"; > > dwc3@1F10 { > compatible = "snps,dwc3", "synopsys,dwc3", "generic-xhci"; > reg = <0x1f10 0x1>; > interrupts = <0x0 0x44 0x4>; > dr_mode = "host"; > tx-fifo-resize; > maximum-speed = "high-speed"; > }; > }; > }; > > whereas in u-boot 'usb start' fails on hub initialization (as I can see): > > Any ideas why this could happen?.. Any direction where to look at? > Any suggestions will be greatly appreciated. > > # usb start > (Re)start USB... > USB0: dwc3_reg->g_snpsid: 0x5533290a > Register 1000140 NbrPorts 1 > Starting the controller > USB XHCI 1.00 > scanning bus 0 for devices... New Device 0 > set address 1 > usb_control_msg: request: 0x5, requesttype: 0x0, value 0x1 index 0x0 length > 0x0 > usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 > length 0x12 > usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 > length 0x9 > usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 > length 0x1F > get_conf_no 0 Result 25, wLength 31 > if 0, ep 0 > ##EP epmaxpacketin[1] = 8 > set configuration 1 > usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length > 0x0 > new device strings: Mfr=1, Product=2, SerialNumber=0 > usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 > length 0xFF > USB device number 1 default language ID 0x409 > usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x409 > length 0xFF > usb_control_msg: request: 0x6, requesttype: 0x80, value 0x302 index 0x409 > length 0xFF > Manufacturer U-Boot > Product XHCI Host Controller > SerialNumber > USB hub found > usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2A00 index 0x0 > length 0x4 > usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2A00 index 0x0 > length 0xC > 1 ports detected > ganged power switching > standalone hub > individual port over-current protection > TT requires at most 8 FS bit times (666 ns) > power on to power good time: 20ms > hub controller current requirement: 0mA > port 1 is removable > usb_control_msg: request: 0x0, requesttype: 0xA0, value 0x0 index 0x0 length >