Re: [U-Boot] Please pull u-boot-dm
On Thu, Nov 14, 2019 at 08:08:09PM -0700, Simon Glass wrote: > Hi Tom, > > Passing run here: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/1306 > > > The following changes since commit 3ff1ff3ff76c15efe0451309af084ee6c096c583: > > Merge branch '2019-11-12-migrate-SYS_REDUNDAND_ENVIRONMENT' > (2019-11-12 13:40:58 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-14nov19 > > for you to fetch changes up to 677dac23d8ebfc0342f903aeee2a75e737fd4d7e: > > patman: fix coverletter cc list with nulls (2019-11-14 07:09:34 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Oct 29, 2019 at 05:35:08PM -0600, Simon Glass wrote: > Hi Tom, > > Test results here: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/1131 > > > The following changes since commit ffc379b42c85466e1dd4c8fee8268801f26d2ab8: > > Merge tag 'mips-pull-2019-10-25' of git://git.denx.de/u-boot-mips > (2019-10-25 20:07:24 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-29oct19 > > for you to fetch changes up to d60ae4c59df55c08dc96202ff58fed21ab3afb7d: > > fdt: Fix alignment issue when reading 64-bits properties from fdt > (2019-10-27 13:01:53 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Oct 15, 2019 at 08:46:46AM -0600, Simon Glass wrote: > Hi Tom, > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/950 > > > The following changes since commit 6891152a4596d38ac25d2fe1238e3b6a938554b8: > > Merge branch 'master' of git://git.denx.de/u-boot-socfpga > (2019-10-14 21:00:10 -0400) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm.git tags/dm-pull-15oct19 > > for you to fetch changes up to d11ef4d54cab0e740efbceb9c6b5697a41770eea: > > sandbox: fix build error due to missing struct udevice definition > (2019-10-15 08:40:03 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Mon, Jul 29, 2019 at 03:27:59PM -0600, Simon Glass wrote: > Hi Tom, > > Gitlab is here: > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/356 > > The following changes since commit 75551c8bfc9545e31ec2ce238cac3857904007b8: > > Merge branch '2019-07-26-ti-imports' (2019-07-27 19:50:52 -0400) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm.git > tags/dm-pull-29jul19 > > for you to fetch changes up to 4f4fb85ec0bfe45da11aa23ada565387ee676e80: > > Makefile: fix implementation of BINMAN_DEBUG (2019-07-29 09:38:06 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 3)
On Wed, Jul 24, 2019 at 01:03:37PM -0700, Simon Glass wrote: > Hi Tom, > > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > Merge tag 'u-boot-stm32-20190723' of > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > 14:16:21 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-24jul19-take3 > > for you to fetch changes up to 44e02e39a91cd91aae5a28d90259d3a6996010bf: > > dm: device: make power domain calls optional (2019-07-24 12:54:08 -0700) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
On Wed, Jul 24, 2019 at 10:22 PM Tom Rini wrote: > > On Wed, Jul 24, 2019 at 10:09:29PM +0200, Simon Goldschmidt wrote: > > Am 24.07.2019 um 22:03 schrieb Simon Glass: > > >Hi Tom, > > > > > >On Wed, 24 Jul 2019 at 10:13, Tom Rini wrote: > > >> > > >>On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > > >> > > >>>Hi Tom, > > >>> > > >>>This includes the gitlab fix and also I updated ifwitool.c to drop the > > >>>unused inline functions. > > >>> > > >>> > > >>>The following changes since commit > > >>>ff8c23e784f57a7098e91a200ed7f5a48612b653: > > >>> > > >>> Merge tag 'u-boot-stm32-20190723' of > > >>>https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > > >>>14:16:21 -0400) > > >>> > > >>>are available in the Git repository at: > > >>> > > >>> git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > >>> > > >>>for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > >>> > > >>> dm: device: make power domain calls optional (2019-07-23 20:27:58 > > >>> -0700) > > >>> > > >> > > >>We're still not there yet, sorry. Taking a look at > > >>https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > > >>things but ifwitool is failing. Can you please take a look? You will > > >>need the patch I posted that brings us up to a newer image that has > > >>lzma-alone. Thanks! > > > > > >OK, this is another update that is needed to the gitlab config, this > > >time the --toolpath argument. Will send an update. > > > > > >I was rather hoping that pushing to gitlab u-boot-dm would start a > > >build but it does not, for me. I probably need to do some more > > >reading. > > > > > >BTW Is there an intent to shut down travis? > > > > Even if everyone seems to be switching to gitlab, can we keep the travis > > config in the repository? That makes it easy for people (like me) creating a > > github clone to ensure the world keeps building after a patch. > > > > Or is there a similar free and easy to use gitlab service comparable to > > travis? > > So that's the rub. There are free "runners" in GitLab terms for > projects but they are limited in time to I think an hour per job, so we > get back to the unmaintainable mess of splitting the build like we have > on Travis. Anyone can use their own machine as the runner, but that may > or may not be faster or even slower than Travis is. I can assure you using my own PC is not an option for me compared to Travis. I don't know how many non-custodians there are using this (and I can probably arrange with Marek to use socfpga custodian access), but having a free-to-use CI seems worth much to me. I don't know how much effort it is to keep and maintain the Travis config files though... Regards, Simon > > -- > Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
On Wed, Jul 24, 2019 at 10:09:29PM +0200, Simon Goldschmidt wrote: > Am 24.07.2019 um 22:03 schrieb Simon Glass: > >Hi Tom, > > > >On Wed, 24 Jul 2019 at 10:13, Tom Rini wrote: > >> > >>On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > >> > >>>Hi Tom, > >>> > >>>This includes the gitlab fix and also I updated ifwitool.c to drop the > >>>unused inline functions. > >>> > >>> > >>>The following changes since commit > >>>ff8c23e784f57a7098e91a200ed7f5a48612b653: > >>> > >>> Merge tag 'u-boot-stm32-20190723' of > >>>https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > >>>14:16:21 -0400) > >>> > >>>are available in the Git repository at: > >>> > >>> git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > >>> > >>>for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > >>> > >>> dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > >>> > >> > >>We're still not there yet, sorry. Taking a look at > >>https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > >>things but ifwitool is failing. Can you please take a look? You will > >>need the patch I posted that brings us up to a newer image that has > >>lzma-alone. Thanks! > > > >OK, this is another update that is needed to the gitlab config, this > >time the --toolpath argument. Will send an update. > > > >I was rather hoping that pushing to gitlab u-boot-dm would start a > >build but it does not, for me. I probably need to do some more > >reading. > > > >BTW Is there an intent to shut down travis? > > Even if everyone seems to be switching to gitlab, can we keep the travis > config in the repository? That makes it easy for people (like me) creating a > github clone to ensure the world keeps building after a patch. > > Or is there a similar free and easy to use gitlab service comparable to > travis? So that's the rub. There are free "runners" in GitLab terms for projects but they are limited in time to I think an hour per job, so we get back to the unmaintainable mess of splitting the build like we have on Travis. Anyone can use their own machine as the runner, but that may or may not be faster or even slower than Travis is. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
On Wed, Jul 24, 2019 at 01:03:20PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 24 Jul 2019 at 10:13, Tom Rini wrote: > > > > On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > This includes the gitlab fix and also I updated ifwitool.c to drop the > > > unused inline functions. > > > > > > > > > The following changes since commit > > > ff8c23e784f57a7098e91a200ed7f5a48612b653: > > > > > > Merge tag 'u-boot-stm32-20190723' of > > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > > > 14:16:21 -0400) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > > > > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > > > > > dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > > > > > > > We're still not there yet, sorry. Taking a look at > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > > things but ifwitool is failing. Can you please take a look? You will > > need the patch I posted that brings us up to a newer image that has > > lzma-alone. Thanks! > > OK, this is another update that is needed to the gitlab config, this > time the --toolpath argument. Will send an update. > > I was rather hoping that pushing to gitlab u-boot-dm would start a > build but it does not, for me. I probably need to do some more > reading. Take a look at the email I sent to the custodians list :) You'll need to flip a switch or two on the -dm tree for it to happen, and you can provide more build power for just your tree in addition to the shared runner we have currently. > BTW Is there an intent to shut down travis? As in remove the file? Not immediately, no, there's still the question of what to do about non-custodians being able to run CI before submitting. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
Am 24.07.2019 um 22:03 schrieb Simon Glass: Hi Tom, On Wed, 24 Jul 2019 at 10:13, Tom Rini wrote: On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: Hi Tom, This includes the gitlab fix and also I updated ifwitool.c to drop the unused inline functions. The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: Merge tag 'u-boot-stm32-20190723' of https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 14:16:21 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) We're still not there yet, sorry. Taking a look at https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running things but ifwitool is failing. Can you please take a look? You will need the patch I posted that brings us up to a newer image that has lzma-alone. Thanks! OK, this is another update that is needed to the gitlab config, this time the --toolpath argument. Will send an update. I was rather hoping that pushing to gitlab u-boot-dm would start a build but it does not, for me. I probably need to do some more reading. BTW Is there an intent to shut down travis? Even if everyone seems to be switching to gitlab, can we keep the travis config in the repository? That makes it easy for people (like me) creating a github clone to ensure the world keeps building after a patch. Or is there a similar free and easy to use gitlab service comparable to travis? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
Hi Tom, On Wed, 24 Jul 2019 at 10:13, Tom Rini wrote: > > On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > This includes the gitlab fix and also I updated ifwitool.c to drop the > > unused inline functions. > > > > > > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > > > Merge tag 'u-boot-stm32-20190723' of > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > > 14:16:21 -0400) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > > > dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > > > > We're still not there yet, sorry. Taking a look at > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running > things but ifwitool is failing. Can you please take a look? You will > need the patch I posted that brings us up to a newer image that has > lzma-alone. Thanks! OK, this is another update that is needed to the gitlab config, this time the --toolpath argument. Will send an update. I was rather hoping that pushing to gitlab u-boot-dm would start a build but it does not, for me. I probably need to do some more reading. BTW Is there an intent to shut down travis? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote: > Hi Tom, > > This includes the gitlab fix and also I updated ifwitool.c to drop the > unused inline functions. > > > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653: > > Merge tag 'u-boot-stm32-20190723' of > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23 > 14:16:21 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2 > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2: > > dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700) > We're still not there yet, sorry. Taking a look at https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running things but ifwitool is failing. Can you please take a look? You will need the patch I posted that brings us up to a newer image that has lzma-alone. Thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On Tue, 23 Jul 2019 at 20:23, Tom Rini wrote: > > On Tue, Jul 23, 2019 at 08:08:03PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 23 Jul 2019 at 11:16, Tom Rini wrote: > > > > > > On Mon, Jul 22, 2019 at 08:48:45AM -0600, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > Build is here: https://travis-ci.org/sglass68/u-boot/builds/561552377 > > > > > > > > The following changes since commit > > > > 0de815356474912ef5bef9a69f0327a5a93bb2c2: > > > > > > > > Merge branch '2019-07-17-master-imports' (2019-07-18 11:31:37 -0400) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-22jul19 > > > > > > > > for you to fetch changes up to 857ad7985ff63989c3c7feff56c2dc353d7d7c9a: > > > > > > > > dm: device: make power domain calls optional (2019-07-20 19:50:44 > > > > -0600) > > > > > > > > > > First, in my LLVM-7 test: > > > /home/trini/u-boot/u-boot/tools/ifwitool.c:584:23: warning: unused > > > function 'read_le8' [-Wunused-function] > > > static inline uint8_t read_le8(const void *src) > > > ^ > > > /home/trini/u-boot/u-boot/tools/ifwitool.c:695:20: warning: unused > > > function 'zero_n' [-Wunused-function] > > > static inline void zero_n(void *dest, size_t n) > > > > > > Which is simple to fix. But I don't see why it's not being caught in > > > the travis test off-hand. > > > > I'm not sure either. Possible it depends on the compiler used? > > I'm concerned the travis job isn't running LLVM like we think it is. > > > > And I further see I didn't get LLVM-7 > > > included in GitLab at all yet. > > > > > > Next however I see: > > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1222 > > > which is the binman tests failing and needs to be fixed. > > > > Oh dear, I don't seem to have any idea about gitlab yet. Have updated > > the gitlab config file. Should I stop using travis completely now? > > Long term I think GitLab CI is going to be better for custodians as > we'll have more build resources available and thus the jobs will > complete quicker. I don't know why the binman testsuite doesn't fail in > travis like it does there. Well that is because I updated the travis config but not the gitlab. Doing that. > The good news is the gitlab job runs in a > defined docker container you can pull and try locally :) OK good. Will give this all a crack at some point. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Jul 23, 2019 at 08:08:03PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 23 Jul 2019 at 11:16, Tom Rini wrote: > > > > On Mon, Jul 22, 2019 at 08:48:45AM -0600, Simon Glass wrote: > > > > > Hi Tom, > > > > > > Build is here: https://travis-ci.org/sglass68/u-boot/builds/561552377 > > > > > > The following changes since commit > > > 0de815356474912ef5bef9a69f0327a5a93bb2c2: > > > > > > Merge branch '2019-07-17-master-imports' (2019-07-18 11:31:37 -0400) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-22jul19 > > > > > > for you to fetch changes up to 857ad7985ff63989c3c7feff56c2dc353d7d7c9a: > > > > > > dm: device: make power domain calls optional (2019-07-20 19:50:44 -0600) > > > > > > > First, in my LLVM-7 test: > > /home/trini/u-boot/u-boot/tools/ifwitool.c:584:23: warning: unused function > > 'read_le8' [-Wunused-function] > > static inline uint8_t read_le8(const void *src) > > ^ > > /home/trini/u-boot/u-boot/tools/ifwitool.c:695:20: warning: unused function > > 'zero_n' [-Wunused-function] > > static inline void zero_n(void *dest, size_t n) > > > > Which is simple to fix. But I don't see why it's not being caught in > > the travis test off-hand. > > I'm not sure either. Possible it depends on the compiler used? I'm concerned the travis job isn't running LLVM like we think it is. > > And I further see I didn't get LLVM-7 > > included in GitLab at all yet. > > > > Next however I see: > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1222 > > which is the binman tests failing and needs to be fixed. > > Oh dear, I don't seem to have any idea about gitlab yet. Have updated > the gitlab config file. Should I stop using travis completely now? Long term I think GitLab CI is going to be better for custodians as we'll have more build resources available and thus the jobs will complete quicker. I don't know why the binman testsuite doesn't fail in travis like it does there. The good news is the gitlab job runs in a defined docker container you can pull and try locally :) -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On Tue, 23 Jul 2019 at 11:16, Tom Rini wrote: > > On Mon, Jul 22, 2019 at 08:48:45AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > Build is here: https://travis-ci.org/sglass68/u-boot/builds/561552377 > > > > The following changes since commit 0de815356474912ef5bef9a69f0327a5a93bb2c2: > > > > Merge branch '2019-07-17-master-imports' (2019-07-18 11:31:37 -0400) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-22jul19 > > > > for you to fetch changes up to 857ad7985ff63989c3c7feff56c2dc353d7d7c9a: > > > > dm: device: make power domain calls optional (2019-07-20 19:50:44 -0600) > > > > First, in my LLVM-7 test: > /home/trini/u-boot/u-boot/tools/ifwitool.c:584:23: warning: unused function > 'read_le8' [-Wunused-function] > static inline uint8_t read_le8(const void *src) > ^ > /home/trini/u-boot/u-boot/tools/ifwitool.c:695:20: warning: unused function > 'zero_n' [-Wunused-function] > static inline void zero_n(void *dest, size_t n) > > Which is simple to fix. But I don't see why it's not being caught in > the travis test off-hand. I'm not sure either. Possible it depends on the compiler used? > And I further see I didn't get LLVM-7 > included in GitLab at all yet. > > Next however I see: > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1222 > which is the binman tests failing and needs to be fixed. Oh dear, I don't seem to have any idea about gitlab yet. Have updated the gitlab config file. Should I stop using travis completely now? > > -- > Tom Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Mon, Jul 22, 2019 at 08:48:45AM -0600, Simon Glass wrote: > Hi Tom, > > Build is here: https://travis-ci.org/sglass68/u-boot/builds/561552377 > > The following changes since commit 0de815356474912ef5bef9a69f0327a5a93bb2c2: > > Merge branch '2019-07-17-master-imports' (2019-07-18 11:31:37 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-22jul19 > > for you to fetch changes up to 857ad7985ff63989c3c7feff56c2dc353d7d7c9a: > > dm: device: make power domain calls optional (2019-07-20 19:50:44 -0600) > First, in my LLVM-7 test: /home/trini/u-boot/u-boot/tools/ifwitool.c:584:23: warning: unused function 'read_le8' [-Wunused-function] static inline uint8_t read_le8(const void *src) ^ /home/trini/u-boot/u-boot/tools/ifwitool.c:695:20: warning: unused function 'zero_n' [-Wunused-function] static inline void zero_n(void *dest, size_t n) Which is simple to fix. But I don't see why it's not being caught in the travis test off-hand. And I further see I didn't get LLVM-7 included in GitLab at all yet. Next however I see: https://gitlab.denx.de/u-boot/u-boot/-/jobs/1222 which is the binman tests failing and needs to be fixed. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Jul 11, 2019 at 11:18:43AM -0600, Simon Glass wrote: > Hi Tom, > > I picked up a different patch for the unicode handling. > > Passing build here: > https://travis-ci.org/sglass68/u-boot/builds/557041198 > > > The following changes since commit ef8b7e045ec744dce385cac4b1438c9be6e2bbc8: > > Merge https://gitlab.denx.de/u-boot/custodians/u-boot-i2c (2019-07-10 > 13:51:53 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-9jul19-take2 > > for you to fetch changes up to 7ea33579576d2bcd19df76bd8769e7ab3b4a169b: > > trace: trace buffer may exceed 2GiB (2019-07-10 16:52:58 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On Wed, 10 Jul 2019 at 08:39, Tom Rini wrote: > > On Tue, Jul 09, 2019 at 11:16:18AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > Build is here: > > > > https://travis-ci.org/sglass68/u-boot/builds/556001438 > > > > (looks like there is a unicode issue I need to look at) > > > > The following changes since commit e5aee22e4be75e75a854ab64503fc80598bc2004: > > > > Prepare v2019.07 (2019-07-08 15:23:28 -0400) > > > > are available in the Git repository at: > > > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm.git tags/dm-pull-9jul19 > > > > for you to fetch changes up to b7eb801e0e6bdf42a592087a797deda1b0f03d69: > > > > trace: trace buffer may exceed 2GiB (2019-07-08 15:23:09 -0600) > > > > Since that unicode problem fails travis, I do need that fixed before I > can take this, thanks! Ah yes. I saw the timeout and thought it was some sort of infra problem, but of course it is buildman. I'll send a new email. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Jul 09, 2019 at 11:16:18AM -0600, Simon Glass wrote: > Hi Tom, > > Build is here: > > https://travis-ci.org/sglass68/u-boot/builds/556001438 > > (looks like there is a unicode issue I need to look at) > > The following changes since commit e5aee22e4be75e75a854ab64503fc80598bc2004: > > Prepare v2019.07 (2019-07-08 15:23:28 -0400) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm.git tags/dm-pull-9jul19 > > for you to fetch changes up to b7eb801e0e6bdf42a592087a797deda1b0f03d69: > > trace: trace buffer may exceed 2GiB (2019-07-08 15:23:09 -0600) > Since that unicode problem fails travis, I do need that fixed before I can take this, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (wandboard fix)
On Sun, Jul 07, 2019 at 07:17:42AM -0600, Simon Glass wrote: > Hi Tom, > > Sorry if this is too late, but I still have this patch pending. > > > The following changes since commit 1f83431f0053f6fb20c511c391ffc687433848cf: > > board: amlogic: add mailing-list to MAINTAINERS (2019-07-04 11:36:52 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-7jul19 > > for you to fetch changes up to c2f3dade2a8efb90c20b46b3c76a81a15fafe96e: > > imx6: wandboard: allow booting from MMC 2 (2019-07-07 07:13:49 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, May 22, 2019 at 07:13:24AM -0600, Simon Glass wrote: > Hi Tom, > > Results here: > > https://travis-ci.org/sglass68/u-boot/builds/535552345 > > The following changes since commit e1a2ed7180adeefb6164239a18249dca5701319d: > > Merge git://git.denx.de/u-boot-mpc83xx (2019-05-21 07:13:35 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-22may19 > > for you to fetch changes up to ee730a7cd2afe445e53e92b5c37396a5b118f7af: > > dm: core: Fix dm_extended_scan_fdt() (2019-05-21 17:33:23 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Apr 24, 2019 at 09:22:43AM -0600, Simon Glass wrote: > Hi Tom, > > Build/test: > https://travis-ci.org/sglass68/u-boot/builds/523770406 > > > The following changes since commit 6c5f8dd540d7a8eff244d4c27a09451ca12c8d20: > > Merge branch 'master' of git://git.denx.de/u-boot-usb (2019-04-21 > 19:00:04 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-24apr19 > > for you to fetch changes up to 8781d04f422e110fef864dd849085054fe5b0e65: > > pci: pci.h: add missing maskbit (2019-04-23 20:26:43 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Fri, Apr 12, 2019 at 03:51:52PM -0600, Simon Glass wrote: > Hi Tom, > > Build result at https://travis-ci.org/sglass68/u-boot/builds/519059521 > > > The following changes since commit 02f173ca156cee8526dff87603d5e446b443cde3: > > Merge branch 'master' of git://git.denx.de/u-boot-usb (2019-04-11 > 14:29:37 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-12apr19 > > for you to fetch changes up to 73c02e5e4fc1ef53d06289232edd6cc52e3d73f6: > > fdt: Fix mkimage list to try every header type (2019-04-11 20:10:50 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Sun, Feb 10, 2019 at 03:27:56AM -0600, Simon Glass wrote: > Hi Tom, > > I thought I had already sent these but just noticed that I had not. > > The following changes since commit 97276a91db8e98f081a40ddf9dc8f81d4032a756: > > Prepare v2019.04-rc1 (2019-02-07 21:32:19 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-10feb19 > > for you to fetch changes up to afcd64579486e1745a3cb964bfe36267d90b4c3e: > > sound: Allow audio codecs to be used by other SoCs (2019-02-09 12:50:22 > -0700) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On Sun, 10 Feb 2019 at 10:28, Simon Glass wrote: > > +Tom > > On Sun, 10 Feb 2019 at 03:27, Simon Glass wrote: > > > > Hi Tom, > > > > I thought I had already sent these but just noticed that I had not. > > > > The following changes since commit 97276a91db8e98f081a40ddf9dc8f81d4032a756: Also the build result is here: https://travis-ci.org/sglass68/u-boot/builds/491045229 [..] Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
+Tom On Sun, 10 Feb 2019 at 03:27, Simon Glass wrote: > > Hi Tom, > > I thought I had already sent these but just noticed that I had not. > > The following changes since commit 97276a91db8e98f081a40ddf9dc8f81d4032a756: > > Prepare v2019.04-rc1 (2019-02-07 21:32:19 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-10feb19 > > for you to fetch changes up to afcd64579486e1745a3cb964bfe36267d90b4c3e: > > sound: Allow audio codecs to be used by other SoCs (2019-02-09 12:50:22 > -0700) > > > Samsung sound patches (applied for Samsung maintainer) > Common sound support > buildman environment support > of-platdata documentation improvements > > > Chris Packham (1): > buildman: fix typo > > Lokesh Vutla (3): > Revert "power: regulator: Return success on attempt to disable > an always-on regulator" > power: regulator: Introduce regulator_set_enable_if_allowed api > mmc: omap_hsmmc: Use regulator_set_enable_if_allowed for > enabling regulator > > Simon Glass (15): > Convert CONFIG_BOARD_TYPES to Kconfig > exynos: Drop duplicate 'model' line > exynos: Convert to use CONFIG_BLK > sound: Add a driver for max98088 > spring: Update sound to use max98088 codec > spring: Update flashmap details > samsung: Drop board_enable_audio_codec() > samsung: mmc: Drop old MMC init code > fdt: samsung: Drop unused fdt_compat_id values > fdt: tegra: Drop COMPAT_AMS_AS3722 > buildman: Write the environment out to an 'env' file > misc: Allow child devices > sound: samsung: Fix 'regiter' typo > sound: i2s: Tidy up a few comments > sound: Allow audio codecs to be used by other SoCs > > Simon Goldschmidt (1): > of-platdata: improve documentation > > arch/arm/dts/exynos5250-spring.dts | 77 ++--- > arch/arm/mach-exynos/Kconfig | 7 + > arch/arm/mach-exynos/include/mach/mmc.h| 2 - > arch/arm/mach-s5pc1xx/Kconfig | 2 + > arch/arm/mach-s5pc1xx/Makefile | 1 + > arch/arm/mach-s5pc1xx/pinmux.c | 20 +++ > board/samsung/common/board.c | 52 +-- > board/samsung/common/exynos5-dt.c | 29 > common/Kconfig | 8 + > configs/axs101_defconfig | 1 + > configs/axs103_defconfig | 1 + > configs/odroid-xu3_defconfig | 1 + > configs/odroid_defconfig | 1 + > configs/spring_defconfig | 1 + > doc/driver-model/of-plat.txt | 31 ++-- > drivers/misc/misc-uclass.c | 3 + > drivers/mmc/omap_hsmmc.c | 16 +- > drivers/mmc/s5p_sdhci.c| 50 -- > drivers/power/regulator/regulator-uclass.c | 13 +- > drivers/sound/Kconfig | 14 +- > drivers/sound/Makefile | 1 + > drivers/sound/max98088.c | 424 > ++ > drivers/sound/max98088.h | 192 +++ > drivers/sound/max98090.c | 7 - > drivers/sound/max98095.c | 7 - > drivers/sound/maxim_codec.c| 3 - > drivers/sound/samsung-i2s.c| 16 +- > drivers/sound/samsung_sound.c | 6 +- > dts/Kconfig| 6 +- > include/configs/axs10x.h | 5 - > include/configs/hsdk.h | 5 - > include/configs/odroid.h | 1 - > include/configs/odroid_xu3.h | 1 - > include/fdtdec.h | 7 - > include/i2s.h | 11 +- > include/power/regulator.h | 11 ++ > include/samsung/misc.h | 2 - > lib/fdtdec.c | 7 - > scripts/config_whitelist.txt | 1 - > test/dm/regulator.c| 21 +++ > tools/buildman/builderthread.py| 3 + > tools/buildman/control.py | 2 +- > 42 files changed, 829 insertions(+), 240 deletions(-) > create mode 100644 arch/arm/mach-s5pc1xx/pinmux.c > create mode 100644 drivers/sound/max98088.c > create mode 100644 drivers/sound/max98088.h > > Regards, > SImon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Jan 15, 2019 at 08:57:23AM -0700, Simon Glass wrote: > Hi Tom, > > https://travis-ci.org/sglass68/u-boot/builds > > The following changes since commit d3689267f92c5956e09cc7d1baa4700141662bff: > > Prepare v2019.01 (2019-01-14 17:02:36 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-15jan19 > > for you to fetch changes up to f51f6715a5013f37620c38f0430e21d4736e235a: > > lib: fdtdec: fdtdec_get_addr_size_fixed remove checks (2019-01-14 > 17:47:20 -0700) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom,
On Fri, 4 Jan 2019 at 22:00, Tom Rini wrote:
>
> On Fri, Jan 04, 2019 at 01:47:08PM -0700, Simon Glass wrote:
>
> > Hi Tom,
> >
> > https://travis-ci.org/sglass68/u-boot/builds/474968097
> >
> >
> > The following changes since commit f97c49d6a2f504d0f0a8aab37c67aa314e006250:
> >
> > Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-01-01
> > 19:55:05 -0500)
> >
> > are available in the Git repository at:
> >
> > git://git.denx.de/u-boot-dm.git tags/dm-pull-4jan19
> >
> > for you to fetch changes up to 1b4770dfe03b5dd1dfd2a6076c4c85ee566e360a:
> >
> > sandbox: Correct SDL build flags (2019-01-03 11:06:07 -0700)
>
> So, the clang switch doesn't catch warnings anymore. While travis is
> clean, my local hand-build shows:
> /home/trini/u-boot/u-boot/lib/efi_loader/efi_file.c:224:61: warning: format
> specifies type 'wchar_t *' (aka 'unsigned short *') but the argument has type
> 's16 *' (aka 'short *') [-Wformat]
> EFI_ENTRY("%p, %p, \"%ls\", %llx, %llu", file, new_handle, file_name,
> ~~~ ^
> /home/trini/u-boot/u-boot/include/efi_loader.h:40:15: note: expanded from
> macro 'EFI_ENTRY'
> __func__, ##__VA_ARGS__); \
> ^~~
> /home/trini/u-boot/u-boot/include/log.h:164:28: note: expanded from macro
> 'debug'
> debug_cond(_DEBUG, fmt, ##args)
> ^~~~
> /home/trini/u-boot/u-boot/include/log.h:144:41: note: expanded from macro
> 'debug_cond'
> log(LOG_CATEGORY, LOGL_DEBUG, fmt, ##args); \
> ^~~~
> /home/trini/u-boot/u-boot/include/log.h:121:25: note: expanded from macro
> 'log'
> pr_fmt(_fmt), ##_args); \
> ^
> 1 warning generated.
>
> So the log changes have a problem, and the buildman integration doesn't
> promote warnings right :(
Actually this uncovered a problem that I had not noticed before. I
sent a new series to take care of it. But given that today is release
day, I am unfortunately a little late!
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Fri, Jan 04, 2019 at 01:47:08PM -0700, Simon Glass wrote:
> Hi Tom,
>
> https://travis-ci.org/sglass68/u-boot/builds/474968097
>
>
> The following changes since commit f97c49d6a2f504d0f0a8aab37c67aa314e006250:
>
> Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2019-01-01
> 19:55:05 -0500)
>
> are available in the Git repository at:
>
> git://git.denx.de/u-boot-dm.git tags/dm-pull-4jan19
>
> for you to fetch changes up to 1b4770dfe03b5dd1dfd2a6076c4c85ee566e360a:
>
> sandbox: Correct SDL build flags (2019-01-03 11:06:07 -0700)
So, the clang switch doesn't catch warnings anymore. While travis is
clean, my local hand-build shows:
/home/trini/u-boot/u-boot/lib/efi_loader/efi_file.c:224:61: warning: format
specifies type 'wchar_t *' (aka 'unsigned short *') but the argument has type
's16 *' (aka 'short *') [-Wformat]
EFI_ENTRY("%p, %p, \"%ls\", %llx, %llu", file, new_handle, file_name,
~~~ ^
/home/trini/u-boot/u-boot/include/efi_loader.h:40:15: note: expanded from macro
'EFI_ENTRY'
__func__, ##__VA_ARGS__); \
^~~
/home/trini/u-boot/u-boot/include/log.h:164:28: note: expanded from macro
'debug'
debug_cond(_DEBUG, fmt, ##args)
^~~~
/home/trini/u-boot/u-boot/include/log.h:144:41: note: expanded from macro
'debug_cond'
log(LOG_CATEGORY, LOGL_DEBUG, fmt, ##args); \
^~~~
/home/trini/u-boot/u-boot/include/log.h:121:25: note: expanded from macro 'log'
pr_fmt(_fmt), ##_args); \
^
1 warning generated.
So the log changes have a problem, and the buildman integration doesn't
promote warnings right :(
--
Tom
signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Fri, Dec 14, 2018 at 08:43:09AM -0700, Simon Glass wrote: > Hi Tom, > > See here (the one failure seems to be a network error) > https://travis-ci.org/sglass68/u-boot/builds/46333 Those are annoying and I wish it would auto-restart those jobs since it should be able to catch that as the failure most of the time. You can restart individual tasks BTW, I do that as needed. > > > The following changes since commit d117d8f19b0625f88309e47a8a32c2faa384dddc: > > Merge branch 'master' of git://git.denx.de/u-boot-i2c (2018-12-13 > 09:36:55 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-14dec18 > > for you to fetch changes up to f987177db9c988142032ed8142a093cce2378a90: > > dm: sound: Use the correct number of channels for sound (2018-12-13 > 16:37:10 -0700) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tuesday 11 December 2018 06:34 AM, Simon Glass wrote: > Hi, > > On Tue, 4 Dec 2018 at 21:10, Keerthy wrote: >> >> >> >> On Friday 30 November 2018 08:25 PM, Tom Rini wrote: >>> On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote: >>> Hi Tom, The following changes since commit e16c888fab5014b022d5781dc534f204460a073b: Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/pull-29nov18 for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315: core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700) Results here: https://travis-ci.org/sglass68/u-boot/builds/461363284 >>> >>> NAK. I don't know _why_ but I can confirm that both within travis: >>> https://travis-ci.org/trini/u-boot/jobs/461494951 >>> and then locally when I installed clang-7.0 from https://apt.llvm.org/ I >>> see that: >>> 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit >>> commit 5ca3927deff30458f5d5b384f6699f70b9509315 >>> Author: Keerthy >>> Date: Mon Nov 19 11:44:48 2018 +0530 >>> >>> core: ofnode: Add ofnode_get_addr_size_index >>> >>> is totally breaking test.py on sandbox. It still starts and I don't see >>> the obvious whats wrong, but I've bisected twice to this same commit. >>> >> >> Okay i am not sure either what is going wrong there. I will take a look at >> this. > > I am worried that this might be a unicode problem. > > - build outputs error messages with backquotes, UTF-8, etc. > - pipe from builder thread to buildman breaks things into 4KB chunks > - sometimes a UTF-8 char break across a 4KB boundary > - I/O error results > > I suspect this because buildman's unicode handling is actually a bit > broken - see how quotes come through in messages on some machines. > > But it might be something else entirely. Adding Lokesh Hey Lokesh, I am yet to dig into this. Seems my patch is breaking test.py on sandbox and hence it was not pulled. Regards, Keerthy > > Regards, > Simon > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi, On Tue, 4 Dec 2018 at 21:10, Keerthy wrote: > > > > On Friday 30 November 2018 08:25 PM, Tom Rini wrote: > > On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote: > > > >> Hi Tom, > >> > >> The following changes since commit > >> e16c888fab5014b022d5781dc534f204460a073b: > >> > >> Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500) > >> > >> are available in the Git repository at: > >> > >> git://git.denx.de/u-boot-dm.git tags/pull-29nov18 > >> > >> for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315: > >> > >> core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700) > >> > >> Results here: > >> > >> https://travis-ci.org/sglass68/u-boot/builds/461363284 > > > > NAK. I don't know _why_ but I can confirm that both within travis: > > https://travis-ci.org/trini/u-boot/jobs/461494951 > > and then locally when I installed clang-7.0 from https://apt.llvm.org/ I > > see that: > > 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit > > commit 5ca3927deff30458f5d5b384f6699f70b9509315 > > Author: Keerthy > > Date: Mon Nov 19 11:44:48 2018 +0530 > > > > core: ofnode: Add ofnode_get_addr_size_index > > > > is totally breaking test.py on sandbox. It still starts and I don't see > > the obvious whats wrong, but I've bisected twice to this same commit. > > > > Okay i am not sure either what is going wrong there. I will take a look at > this. I am worried that this might be a unicode problem. - build outputs error messages with backquotes, UTF-8, etc. - pipe from builder thread to buildman breaks things into 4KB chunks - sometimes a UTF-8 char break across a 4KB boundary - I/O error results I suspect this because buildman's unicode handling is actually a bit broken - see how quotes come through in messages on some machines. But it might be something else entirely. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Dec 05, 2018 at 06:30:48PM -0700, Simon Glass wrote: > Hi Tom, > > The following changes since commit 2e2a2a5d4f0c2e2642326d9000ce1f1553632e6a: > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-12-04 > 19:22:31 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-pull-5dec18 > > for you to fetch changes up to b288cd9600724ad3a0e55c8786e70741dd13deae: > > x86: acpi: Generate SPCR table (2018-12-05 07:23:16 -0700) > > > Travis here > > https://travis-ci.org/sglass68/u-boot/builds/463866708 > > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Friday 30 November 2018 08:25 PM, Tom Rini wrote: > On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote: > >> Hi Tom, >> >> The following changes since commit e16c888fab5014b022d5781dc534f204460a073b: >> >> Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500) >> >> are available in the Git repository at: >> >> git://git.denx.de/u-boot-dm.git tags/pull-29nov18 >> >> for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315: >> >> core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700) >> >> Results here: >> >> https://travis-ci.org/sglass68/u-boot/builds/461363284 > > NAK. I don't know _why_ but I can confirm that both within travis: > https://travis-ci.org/trini/u-boot/jobs/461494951 > and then locally when I installed clang-7.0 from https://apt.llvm.org/ I > see that: > 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit > commit 5ca3927deff30458f5d5b384f6699f70b9509315 > Author: Keerthy > Date: Mon Nov 19 11:44:48 2018 +0530 > > core: ofnode: Add ofnode_get_addr_size_index > > is totally breaking test.py on sandbox. It still starts and I don't see > the obvious whats wrong, but I've bisected twice to this same commit. > Okay i am not sure either what is going wrong there. I will take a look at this. Thanks, Keerthy ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi. On Mon, 3 Dec 2018 at 00:42, Simon Goldschmidt wrote: > > On Mon, Dec 3, 2018 at 8:27 AM Kever Yang wrote: > > > > Hi Tom, > > > > With this merge, my boards can't work correctly in SPL, the console > > output is mess up. > > > > I have test on rk3229 and rk3399 boards, and finally I identify that > > below patch is the root cause: > > > > 6f57c34473 serial: ns16550: fix debug uart putc called before init > > Henri Roosen reported this to me last week. The root cause seems to be > that the ns16550 baudrate prescaler is read as 0 on his rk3399 board. > > He helped me try an additional fix but that didn't work either. > > So we can either try and fix this if it is only a problem for rockchip > boards or revert the patch and I'll think of a different solution to > fix this issue (debug uart putc called before init) for the socfpga > platform. > > I still think it would be good to fix this globally: there's nothing > keeping us from accidentally adding putc code before the debug uart is > initialized and this is something that should be detected, I think. I think it would be better to have this discussion on the patch rather than the pull request. Regards, Simon [..] ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Mon, Dec 3, 2018 at 8:27 AM Kever Yang wrote: > > Hi Tom, > > With this merge, my boards can't work correctly in SPL, the console > output is mess up. > > I have test on rk3229 and rk3399 boards, and finally I identify that > below patch is the root cause: > > 6f57c34473 serial: ns16550: fix debug uart putc called before init Henri Roosen reported this to me last week. The root cause seems to be that the ns16550 baudrate prescaler is read as 0 on his rk3399 board. He helped me try an additional fix but that didn't work either. So we can either try and fix this if it is only a problem for rockchip boards or revert the patch and I'll think of a different solution to fix this issue (debug uart putc called before init) for the socfpga platform. I still think it would be good to fix this globally: there's nothing keeping us from accidentally adding putc code before the debug uart is initialized and this is something that should be detected, I think. Regards, Simon > > > Thanks, > - Kever > On 11/16/2018 09:45 PM, Tom Rini wrote: > > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: > >> Hi Tom, > >> > >> On 11 October 2018 at 07:10, Tom Rini wrote: > >>> On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > >>> > Hi Tom, > > Here is my attempt at a signed pull request. I've brought in most of the > outstanding dm patches. Please let me know if it looks OK. Do you have my > public key? > >>> Is it on the public key servers? > >> Yes, here: > >> > >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium=index > > So yes, it is working. On your latest PR: > > $ git show --show-signature > > commit 1d6edcbfed2af33c748f2beb399810a0441888da > > merged tag 'pull-14nov18' > > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > > 9008ADE6 > > gpg: Good signature from "Simon Glass " > > Merge: f6206f8587fc 4c6e27f63c88 > > Author: Tom Rini > > Date: Fri Nov 16 08:37:50 2018 -0500 > > > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > > > Thanks again! > > > > > > > > ___ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, With this merge, my boards can't work correctly in SPL, the console output is mess up. I have test on rk3229 and rk3399 boards, and finally I identify that below patch is the root cause: 6f57c34473 serial: ns16550: fix debug uart putc called before init Thanks, - Kever On 11/16/2018 09:45 PM, Tom Rini wrote: > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: >> Hi Tom, >> >> On 11 October 2018 at 07:10, Tom Rini wrote: >>> On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: >>> Hi Tom, Here is my attempt at a signed pull request. I've brought in most of the outstanding dm patches. Please let me know if it looks OK. Do you have my public key? >>> Is it on the public key servers? >> Yes, here: >> >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium=index > So yes, it is working. On your latest PR: > $ git show --show-signature > commit 1d6edcbfed2af33c748f2beb399810a0441888da > merged tag 'pull-14nov18' > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > 9008ADE6 > gpg: Good signature from "Simon Glass " > Merge: f6206f8587fc 4c6e27f63c88 > Author: Tom Rini > Date: Fri Nov 16 08:37:50 2018 -0500 > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > Thanks again! > > > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
On Fri, Nov 30, 2018 at 12:29:18PM -0700, Simon Glass wrote: > Hi Tom, > > See: > > https://travis-ci.org/sglass68/u-boot/builds/461837218?utm_medium=notification_source=email > > > The following changes since commit e16c888fab5014b022d5781dc534f204460a073b: > > Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-30nov18 > > for you to fetch changes up to 1678754f5e2cbc14f9612e953b39cc08ada66866: > > core: ofnode: Fix ofnode_get_addr_index function (2018-11-29 09:30:06 > -0700) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Nov 29, 2018 at 01:55:14PM -0700, Simon Glass wrote: > Hi Tom, > > The following changes since commit e16c888fab5014b022d5781dc534f204460a073b: > > Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-29nov18 > > for you to fetch changes up to 5ca3927deff30458f5d5b384f6699f70b9509315: > > core: ofnode: Add ofnode_get_addr_size_index (2018-11-29 09:30:06 -0700) > > Results here: > > https://travis-ci.org/sglass68/u-boot/builds/461363284 NAK. I don't know _why_ but I can confirm that both within travis: https://travis-ci.org/trini/u-boot/jobs/461494951 and then locally when I installed clang-7.0 from https://apt.llvm.org/ I see that: 5ca3927deff30458f5d5b384f6699f70b9509315 is the first bad commit commit 5ca3927deff30458f5d5b384f6699f70b9509315 Author: Keerthy Date: Mon Nov 19 11:44:48 2018 +0530 core: ofnode: Add ofnode_get_addr_size_index is totally breaking test.py on sandbox. It still starts and I don't see the obvious whats wrong, but I've bisected twice to this same commit. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Nov 21, 2018 at 05:25:59PM -0700, Simon Glass wrote: > Hi Tom, > > The following changes since commit a3e1653ddeb02f39481eba572275016171e9670c: > > Merge git://git.denx.de/u-boot-marvell (2018-11-20 12:39:16 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-tg18 > > for you to fetch changes up to a58986ca8b53d8c7a441397082f84edc7f47d19f: > > sf: Add a method to obtain the block-protect setting (2018-11-20 > 19:14:22 -0700) > > https://travis-ci.org/sglass68/u-boot/builds/457752510 > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 16 November 2018 at 05:45, Tom Rini wrote: > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: >> Hi Tom, >> >> On 11 October 2018 at 07:10, Tom Rini wrote: >> > On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: >> > >> >> Hi Tom, >> >> >> >> Here is my attempt at a signed pull request. I've brought in most of the >> >> outstanding dm patches. Please let me know if it looks OK. Do you have my >> >> public key? >> > >> > Is it on the public key servers? >> >> Yes, here: >> >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium=index > > So yes, it is working. On your latest PR: > $ git show --show-signature > commit 1d6edcbfed2af33c748f2beb399810a0441888da > merged tag 'pull-14nov18' > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > 9008ADE6 > gpg: Good signature from "Simon Glass " > Merge: f6206f8587fc 4c6e27f63c88 > Author: Tom Rini > Date: Fri Nov 16 08:37:50 2018 -0500 > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > Thanks again! OK that's good to see, thanks! - SImon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Nov 15, 2018 at 08:32:30AM -0800, Simon Glass wrote: > Hi Tom, > > The following changes since commit 208ecbad2ea8e8f3c9933213867addf16f4a: > > Merge branch 'next' (2018-11-14 11:30:07 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-14nov18 > > for you to fetch changes up to 4c6e27f63c88d065a98f438085dfc36af47d3a23: > > Revert "imx8qxp_mek: Disable CONFIG_DISPLAY_CPUINFO" (2018-11-14 > 09:16:28 -0800) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: > Hi Tom, > > On 11 October 2018 at 07:10, Tom Rini wrote: > > On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > > > >> Hi Tom, > >> > >> Here is my attempt at a signed pull request. I've brought in most of the > >> outstanding dm patches. Please let me know if it looks OK. Do you have my > >> public key? > > > > Is it on the public key servers? > > Yes, here: > > https://pgp.mit.edu/pks/lookup?search=sjg%40chromium=index So yes, it is working. On your latest PR: $ git show --show-signature commit 1d6edcbfed2af33c748f2beb399810a0441888da merged tag 'pull-14nov18' gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID 9008ADE6 gpg: Good signature from "Simon Glass " Merge: f6206f8587fc 4c6e27f63c88 Author: Tom Rini Date: Fri Nov 16 08:37:50 2018 -0500 Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm Thanks again! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 11 October 2018 at 07:10, Tom Rini wrote: > On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > >> Hi Tom, >> >> Here is my attempt at a signed pull request. I've brought in most of the >> outstanding dm patches. Please let me know if it looks OK. Do you have my >> public key? > > Is it on the public key servers? Yes, here: https://pgp.mit.edu/pks/lookup?search=sjg%40chromium=index > >> >> >> The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: >> >> Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 >> -0400) >> >> are available in the Git repository at: >> >> git://git.denx.de/u-boot-dm.git tags/dm-9oct18 >> >> for you to fetch changes up to 41b781ddf1869f5349e05ace888979f3673fe8c6: >> >> dtoc: Fix the value of SetInt() (2018-10-09 04:40:27 -0600) >> > > Applied to u-boot/master, thanks! > > -- > Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 15 November 2018 at 13:02, Tom Rini wrote: > > On Thu, Nov 15, 2018 at 12:21:15PM -0800, Simon Glass wrote: > > Hi Tom, > > > > On 15 November 2018 at 08:32, Simon Glass wrote: > > > Hi Tom, > > > > > > The following changes since commit > > > 208ecbad2ea8e8f3c9933213867addf16f4a: > > > > > > Merge branch 'next' (2018-11-14 11:30:07 -0500) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-14nov18 > > > > > > for you to fetch changes up to 4c6e27f63c88d065a98f438085dfc36af47d3a23: > > > > > > Revert "imx8qxp_mek: Disable CONFIG_DISPLAY_CPUINFO" (2018-11-14 > > > 09:16:28 -0800) > > > > > > > > > - virtio implementation and supporting patches > > > - DM_FLAG_PRE_RELOC fixes > > > - regmap improvements > > > - minor buildman and sandbox things > > > > > > > > > > I am seeing strange failures with travis-ci. > > > > https://travis-ci.org/sglass68/u-boot/builds/455582198?utm_medium=notification_source=email > > > > I thought it was something strange with travis-ci but the above run is > > my second attempt and it fails with the same builds. Lots of stuff > > about the filesystem tests. But they have been there for a while! > > > > Do you have any ideas? > > Yes: https://patchwork.ozlabs.org/patch/998330/ which I'm pushing > now'ish, since my WIP branch completed again with that applied. Thanks Tom, great to hear. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Nov 15, 2018 at 12:21:15PM -0800, Simon Glass wrote: > Hi Tom, > > On 15 November 2018 at 08:32, Simon Glass wrote: > > Hi Tom, > > > > The following changes since commit 208ecbad2ea8e8f3c9933213867addf16f4a: > > > > Merge branch 'next' (2018-11-14 11:30:07 -0500) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/pull-14nov18 > > > > for you to fetch changes up to 4c6e27f63c88d065a98f438085dfc36af47d3a23: > > > > Revert "imx8qxp_mek: Disable CONFIG_DISPLAY_CPUINFO" (2018-11-14 > > 09:16:28 -0800) > > > > > > - virtio implementation and supporting patches > > - DM_FLAG_PRE_RELOC fixes > > - regmap improvements > > - minor buildman and sandbox things > > > > > > I am seeing strange failures with travis-ci. > > https://travis-ci.org/sglass68/u-boot/builds/455582198?utm_medium=notification_source=email > > I thought it was something strange with travis-ci but the above run is > my second attempt and it fails with the same builds. Lots of stuff > about the filesystem tests. But they have been there for a while! > > Do you have any ideas? Yes: https://patchwork.ozlabs.org/patch/998330/ which I'm pushing now'ish, since my WIP branch completed again with that applied. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 15 November 2018 at 08:32, Simon Glass wrote: > Hi Tom, > > The following changes since commit 208ecbad2ea8e8f3c9933213867addf16f4a: > > Merge branch 'next' (2018-11-14 11:30:07 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-14nov18 > > for you to fetch changes up to 4c6e27f63c88d065a98f438085dfc36af47d3a23: > > Revert "imx8qxp_mek: Disable CONFIG_DISPLAY_CPUINFO" (2018-11-14 > 09:16:28 -0800) > > > - virtio implementation and supporting patches > - DM_FLAG_PRE_RELOC fixes > - regmap improvements > - minor buildman and sandbox things > > I am seeing strange failures with travis-ci. https://travis-ci.org/sglass68/u-boot/builds/455582198?utm_medium=notification_source=email I thought it was something strange with travis-ci but the above run is my second attempt and it fails with the same builds. Lots of stuff about the filesystem tests. But they have been there for a while! Do you have any ideas? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Nov 06, 2018 at 07:42:39PM -0700, Simon Glass wrote: > Hi Bin, > > On 6 November 2018 at 19:29, Bin Meng wrote: > > Hi Simon, > > > > On Wed, Nov 7, 2018 at 10:25 AM Simon Glass wrote: > >> > >> Hi Bin, > >> > >> On 6 November 2018 at 19:22, Bin Meng wrote: > >> > > >> > Hi Simon, > >> > > >> > On Wed, Nov 7, 2018 at 10:07 AM Simon Glass wrote: > >> > > > >> > > Hi Bin, > >> > > > >> > > On 6 November 2018 at 18:04, Bin Meng wrote: > >> > > > > >> > > > Hi Simon, > >> > > > > >> > > > On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: > >> > > > > > >> > > > > Hi Tom, > >> > > > > > >> > > > > The following changes since commit > >> > > > > 5ef76e59c12c79d106ebda70b710468aa6bd8b75: > >> > > > > > >> > > > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 > >> > > > > 08:12:21 -0500) > >> > > > > > >> > > > > are available in the Git repository at: > >> > > > > > >> > > > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 > >> > > > > > >> > > > > for you to fetch changes up to > >> > > > > 9413033c3d5d2bc44eefd1919c60522598cc1bd6: > >> > > > > > >> > > > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes > >> > > > > (2018-11-06 13:56:18 -0700) > >> > > > > > >> > > > > > >> > > > > dm: DM_FLAG_PRE_RELOC fixes for release > >> > > > > sandbox CPU fixes for release > >> > > > > > >> > > > > >> > > > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did > >> > > > not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean > >> > > > up series should be a follow-up to that tag. > >> > > > >> > > I abandoned that as I think Tom felt that with the flag problem it was > >> > > a bit to late to fix everything. > >> > > > >> > > If your series relies on that then I think we have a problem... > >> > > >> > Actually this DM_FLAG_PRE_RELOC clean up series is to make previous > >> > series complementary, IOW fix potential issues. Previously Tom > >> > rejected that was because that broken Tegra which Stephen reported, > >> > and with the clean up series this should be fine. > >> > >> We are just a week from the release. What is broken if we apply none > >> of these patches and pull them in after the release? > > > > I suspect we need revert the patch that is causing all these issues > > ... If that's the way we prefer to do, I will take a look ... > > I am happy to make it work - will await Tom's thoughts also. I suppose at this point in time, a revert for release is probably best. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Bin, On 6 November 2018 at 19:29, Bin Meng wrote: > Hi Simon, > > On Wed, Nov 7, 2018 at 10:25 AM Simon Glass wrote: >> >> Hi Bin, >> >> On 6 November 2018 at 19:22, Bin Meng wrote: >> > >> > Hi Simon, >> > >> > On Wed, Nov 7, 2018 at 10:07 AM Simon Glass wrote: >> > > >> > > Hi Bin, >> > > >> > > On 6 November 2018 at 18:04, Bin Meng wrote: >> > > > >> > > > Hi Simon, >> > > > >> > > > On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: >> > > > > >> > > > > Hi Tom, >> > > > > >> > > > > The following changes since commit >> > > > > 5ef76e59c12c79d106ebda70b710468aa6bd8b75: >> > > > > >> > > > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 >> > > > > 08:12:21 -0500) >> > > > > >> > > > > are available in the Git repository at: >> > > > > >> > > > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 >> > > > > >> > > > > for you to fetch changes up to >> > > > > 9413033c3d5d2bc44eefd1919c60522598cc1bd6: >> > > > > >> > > > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes >> > > > > (2018-11-06 13:56:18 -0700) >> > > > > >> > > > > >> > > > > dm: DM_FLAG_PRE_RELOC fixes for release >> > > > > sandbox CPU fixes for release >> > > > > >> > > > >> > > > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did >> > > > not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean >> > > > up series should be a follow-up to that tag. >> > > >> > > I abandoned that as I think Tom felt that with the flag problem it was >> > > a bit to late to fix everything. >> > > >> > > If your series relies on that then I think we have a problem... >> > >> > Actually this DM_FLAG_PRE_RELOC clean up series is to make previous >> > series complementary, IOW fix potential issues. Previously Tom >> > rejected that was because that broken Tegra which Stephen reported, >> > and with the clean up series this should be fine. >> >> We are just a week from the release. What is broken if we apply none >> of these patches and pull them in after the release? > > I suspect we need revert the patch that is causing all these issues > ... If that's the way we prefer to do, I will take a look ... > I am happy to make it work - will await Tom's thoughts also. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Simon, On Wed, Nov 7, 2018 at 10:25 AM Simon Glass wrote: > > Hi Bin, > > On 6 November 2018 at 19:22, Bin Meng wrote: > > > > Hi Simon, > > > > On Wed, Nov 7, 2018 at 10:07 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On 6 November 2018 at 18:04, Bin Meng wrote: > > > > > > > > Hi Simon, > > > > > > > > On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: > > > > > > > > > > Hi Tom, > > > > > > > > > > The following changes since commit > > > > > 5ef76e59c12c79d106ebda70b710468aa6bd8b75: > > > > > > > > > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 > > > > > 08:12:21 -0500) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 > > > > > > > > > > for you to fetch changes up to > > > > > 9413033c3d5d2bc44eefd1919c60522598cc1bd6: > > > > > > > > > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes > > > > > (2018-11-06 13:56:18 -0700) > > > > > > > > > > > > > > > dm: DM_FLAG_PRE_RELOC fixes for release > > > > > sandbox CPU fixes for release > > > > > > > > > > > > > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did > > > > not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean > > > > up series should be a follow-up to that tag. > > > > > > I abandoned that as I think Tom felt that with the flag problem it was > > > a bit to late to fix everything. > > > > > > If your series relies on that then I think we have a problem... > > > > Actually this DM_FLAG_PRE_RELOC clean up series is to make previous > > series complementary, IOW fix potential issues. Previously Tom > > rejected that was because that broken Tegra which Stephen reported, > > and with the clean up series this should be fine. > > We are just a week from the release. What is broken if we apply none > of these patches and pull them in after the release? I suspect we need revert the patch that is causing all these issues ... If that's the way we prefer to do, I will take a look ... Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Bin, On 6 November 2018 at 19:22, Bin Meng wrote: > > Hi Simon, > > On Wed, Nov 7, 2018 at 10:07 AM Simon Glass wrote: > > > > Hi Bin, > > > > On 6 November 2018 at 18:04, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > > The following changes since commit > > > > 5ef76e59c12c79d106ebda70b710468aa6bd8b75: > > > > > > > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 > > > > 08:12:21 -0500) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 > > > > > > > > for you to fetch changes up to 9413033c3d5d2bc44eefd1919c60522598cc1bd6: > > > > > > > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes > > > > (2018-11-06 13:56:18 -0700) > > > > > > > > > > > > dm: DM_FLAG_PRE_RELOC fixes for release > > > > sandbox CPU fixes for release > > > > > > > > > > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did > > > not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean > > > up series should be a follow-up to that tag. > > > > I abandoned that as I think Tom felt that with the flag problem it was > > a bit to late to fix everything. > > > > If your series relies on that then I think we have a problem... > > Actually this DM_FLAG_PRE_RELOC clean up series is to make previous > series complementary, IOW fix potential issues. Previously Tom > rejected that was because that broken Tegra which Stephen reported, > and with the clean up series this should be fine. We are just a week from the release. What is broken if we apply none of these patches and pull them in after the release? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Simon, On Wed, Nov 7, 2018 at 10:07 AM Simon Glass wrote: > > Hi Bin, > > On 6 November 2018 at 18:04, Bin Meng wrote: > > > > Hi Simon, > > > > On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: > > > > > > Hi Tom, > > > > > > The following changes since commit > > > 5ef76e59c12c79d106ebda70b710468aa6bd8b75: > > > > > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 > > > 08:12:21 -0500) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 > > > > > > for you to fetch changes up to 9413033c3d5d2bc44eefd1919c60522598cc1bd6: > > > > > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes (2018-11-06 > > > 13:56:18 -0700) > > > > > > > > > dm: DM_FLAG_PRE_RELOC fixes for release > > > sandbox CPU fixes for release > > > > > > > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did > > not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean > > up series should be a follow-up to that tag. > > I abandoned that as I think Tom felt that with the flag problem it was > a bit to late to fix everything. > > If your series relies on that then I think we have a problem... Actually this DM_FLAG_PRE_RELOC clean up series is to make previous series complementary, IOW fix potential issues. Previously Tom rejected that was because that broken Tegra which Stephen reported, and with the clean up series this should be fine. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Bin, On 6 November 2018 at 18:04, Bin Meng wrote: > > Hi Simon, > > On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: > > > > Hi Tom, > > > > The following changes since commit 5ef76e59c12c79d106ebda70b710468aa6bd8b75: > > > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 08:12:21 > > -0500) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 > > > > for you to fetch changes up to 9413033c3d5d2bc44eefd1919c60522598cc1bd6: > > > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes (2018-11-06 > > 13:56:18 -0700) > > > > > > dm: DM_FLAG_PRE_RELOC fixes for release > > sandbox CPU fixes for release > > > > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did > not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean > up series should be a follow-up to that tag. I abandoned that as I think Tom felt that with the flag problem it was a bit to late to fix everything. If your series relies on that then I think we have a problem... Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Simon, On Wed, Nov 7, 2018 at 5:51 AM Simon Glass wrote: > > Hi Tom, > > The following changes since commit 5ef76e59c12c79d106ebda70b710468aa6bd8b75: > > Merge branch 'master' of git://git.denx.de/u-boot-sh (2018-11-04 08:12:21 > -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-6-nov-18 > > for you to fetch changes up to 9413033c3d5d2bc44eefd1919c60522598cc1bd6: > > cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes (2018-11-06 > 13:56:18 -0700) > > > dm: DM_FLAG_PRE_RELOC fixes for release > sandbox CPU fixes for release > What happened to the last PR from u-boot-dm, tag pull-15oct-18? I did not see that was merged to u-boot/master. The DM_FLAG_PRE_RELOC clean up series should be a follow-up to that tag. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Oct 24, 2018 at 08:33:01AM -0600, Simon Glass wrote: > Hi Tom, > > On 24 October 2018 at 08:28, Bin Meng wrote: > > Hi Simon, > > > > On Wed, Oct 24, 2018 at 10:14 PM Simon Glass wrote: > >> > >> Hi Tom, > >> > >> On 19 October 2018 at 06:10, Tom Rini wrote: > >> > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: > >> >> Hi, > >> >> > >> >> On 17 October 2018 at 11:14, Stephen Warren > >> >> wrote: > >> >> > On 10/16/18 8:33 PM, Bin Meng wrote: > >> >> >> > >> >> >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > >> >> >>> > >> >> >>> > >> >> >>> Hi Stephen, > >> >> >>> > >> >> >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > >> >> >>> > >> >> >>> wrote: > >> >> > >> >> > >> >> On 10/15/18 5:43 PM, Bin Meng wrote: > >> >> > > >> >> > Hi Stephen, > >> >> > > >> >> > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > >> >> > > >> >> > wrote: > >> >> >> > >> >> >> > >> >> >> On 10/15/18 3:53 PM, Stephen Warren wrote: > >> >> >>> > >> >> >>> On 10/15/18 2:17 PM, Simon Glass wrote: > >> >> > >> >> Hi Tom, > >> >> > >> >> The following changes since commit > >> >> 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > >> >> > >> >> Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > >> >> git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > >> >> > >> >> are available in the Git repository at: > >> >> > >> >> git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > >> >> > >> >> for you to fetch changes up to > >> >> 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > >> >> > >> >> buildman: Add a --boards option to specify particular > >> >> boards to > >> >> build (2018-10-15 08:20:43 -0600) > >> >> >>> > >> >> >>> > >> >> >>> There's something wrong with these patches; both Jetson TX1 and > >> >> >>> Jetson > >> >> >>> TX2 (both 64-bit ARM without SPL) fail to boot with this > >> >> >>> branch; the > >> >> >>> system hangs with no output at all from U-Boot. Jetson TK1 > >> >> >>> (32-bit > >> >> >>> ARM > >> >> >>> with SPL) and sandbox boot fine. > >> >> >> > >> >> >> > >> >> >> Reverting the following solves the issue: > >> >> >> > >> >> >> 1) dm: core: Mirror the chosen node parse logic in the livetree > >> >> >> scanning > >> >> >> > >> >> >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > >> >> >> lists_bind_fdt() > >> >> >> > >> >> >> Reverting just (1) or just (2) does not. Can you please take a > >> >> >> look? > >> >> >> Thanks. > >> >> > > >> >> > > >> >> > The failure is probably due to some drivers that Tegra uses are > >> >> > not > >> >> > properly written, ie: these drivers are declared via U_BOOT_DRIVER > >> >> > with flags DM_FLAG_PRE_RELOC yet it was never working (bound > >> >> > before > >> >> > relocation) until patch (1) & (2). Now these drivers get bound > >> >> > before > >> >> > relocation but they were never bound before (assume they were > >> >> > never > >> >> > required before relocation), so we should identify which driver > >> >> > were > >> >> > wrongly written, but as a quick solution, can you please enlarge > >> >> > the > >> >> > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > >> >> > >> >> > >> >> Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves > >> >> the > >> >> issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > >> >> tegra186_gpio.c (depending on board/SoC) also solves this. > >> >> > >> >> I suppose the correct solution is to remove the DM flag from the > >> >> driver, > >> >> since if it never used to work before your patches, it's clear > >> >> that the > >> >> flag/feature is not actually required. > >> >> >>> > >> >> >>> > >> >> >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio > >> >> >>> driver. > >> >> > >> >> Thanks Bin, > >> >> > >> >> >> > >> >> >> > >> >> >> Ah, it turns out so many drivers/dts are mis-written ... > >> >> >> > >> >> >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > >> >> >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > >> >> >> have been added to workaround the DM bug (fixed in patch 1 & 2 > >> >> >> mentioned in this thread). But now since the DM bug has been fixed, > >> >> >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I > >> >> >> am > >> >> >> afraid I don't have the knowledge to clean up all of these. > >> >> >> > >> >> >> Of course, I've identified some additional drivers that have > >> >> >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have > >> >> >> "u-boot,dm-pre-reloc". These drivers should
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 24 October 2018 at 08:28, Bin Meng wrote: > Hi Simon, > > On Wed, Oct 24, 2018 at 10:14 PM Simon Glass wrote: >> >> Hi Tom, >> >> On 19 October 2018 at 06:10, Tom Rini wrote: >> > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: >> >> Hi, >> >> >> >> On 17 October 2018 at 11:14, Stephen Warren wrote: >> >> > On 10/16/18 8:33 PM, Bin Meng wrote: >> >> >> >> >> >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: >> >> >>> >> >> >>> >> >> >>> Hi Stephen, >> >> >>> >> >> >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren >> >> >>> >> >> >>> wrote: >> >> >> >> >> >> On 10/15/18 5:43 PM, Bin Meng wrote: >> >> > >> >> > Hi Stephen, >> >> > >> >> > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren >> >> > >> >> > wrote: >> >> >> >> >> >> >> >> >> On 10/15/18 3:53 PM, Stephen Warren wrote: >> >> >>> >> >> >>> On 10/15/18 2:17 PM, Simon Glass wrote: >> >> >> >> Hi Tom, >> >> >> >> The following changes since commit >> >> 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: >> >> >> >> Merge tag 'arc-more-updates-for-2018.11-rc2-2' of >> >> git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) >> >> >> >> are available in the Git repository at: >> >> >> >> git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 >> >> >> >> for you to fetch changes up to >> >> 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: >> >> >> >> buildman: Add a --boards option to specify particular >> >> boards to >> >> build (2018-10-15 08:20:43 -0600) >> >> >>> >> >> >>> >> >> >>> There's something wrong with these patches; both Jetson TX1 and >> >> >>> Jetson >> >> >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; >> >> >>> the >> >> >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit >> >> >>> ARM >> >> >>> with SPL) and sandbox boot fine. >> >> >> >> >> >> >> >> >> Reverting the following solves the issue: >> >> >> >> >> >> 1) dm: core: Mirror the chosen node parse logic in the livetree >> >> >> scanning >> >> >> >> >> >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in >> >> >> lists_bind_fdt() >> >> >> >> >> >> Reverting just (1) or just (2) does not. Can you please take a >> >> >> look? >> >> >> Thanks. >> >> > >> >> > >> >> > The failure is probably due to some drivers that Tegra uses are not >> >> > properly written, ie: these drivers are declared via U_BOOT_DRIVER >> >> > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before >> >> > relocation) until patch (1) & (2). Now these drivers get bound >> >> > before >> >> > relocation but they were never bound before (assume they were never >> >> > required before relocation), so we should identify which driver were >> >> > wrongly written, but as a quick solution, can you please enlarge the >> >> > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? >> >> >> >> >> >> Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the >> >> issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or >> >> tegra186_gpio.c (depending on board/SoC) also solves this. >> >> >> >> I suppose the correct solution is to remove the DM flag from the >> >> driver, >> >> since if it never used to work before your patches, it's clear that >> >> the >> >> flag/feature is not actually required. >> >> >>> >> >> >>> >> >> >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio >> >> >>> driver. >> >> >> >> Thanks Bin, >> >> >> >> >> >> >> >> >> >> >> Ah, it turns out so many drivers/dts are mis-written ... >> >> >> >> >> >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts >> >> >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must >> >> >> have been added to workaround the DM bug (fixed in patch 1 & 2 >> >> >> mentioned in this thread). But now since the DM bug has been fixed, >> >> >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am >> >> >> afraid I don't have the knowledge to clean up all of these. >> >> >> >> >> >> Of course, I've identified some additional drivers that have >> >> >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have >> >> >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the >> >> >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. >> >> > >> >> > >> >> > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the >> >> > Tegra >> >> > GPIO driver specifically, so I think a simple patch removing the >> >> > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of >> >> > course, I didn't look at any non-Tegra DTs, or at drivers other than >> >> >
Re: [U-Boot] Please pull u-boot-dm
Hi Simon, On Wed, Oct 24, 2018 at 10:14 PM Simon Glass wrote: > > Hi Tom, > > On 19 October 2018 at 06:10, Tom Rini wrote: > > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: > >> Hi, > >> > >> On 17 October 2018 at 11:14, Stephen Warren wrote: > >> > On 10/16/18 8:33 PM, Bin Meng wrote: > >> >> > >> >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > >> >>> > >> >>> > >> >>> Hi Stephen, > >> >>> > >> >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > >> >>> wrote: > >> > >> > >> On 10/15/18 5:43 PM, Bin Meng wrote: > >> > > >> > Hi Stephen, > >> > > >> > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > >> > > >> > wrote: > >> >> > >> >> > >> >> On 10/15/18 3:53 PM, Stephen Warren wrote: > >> >>> > >> >>> On 10/15/18 2:17 PM, Simon Glass wrote: > >> > >> Hi Tom, > >> > >> The following changes since commit > >> 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > >> > >> Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > >> git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > >> > >> are available in the Git repository at: > >> > >> git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > >> > >> for you to fetch changes up to > >> 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > >> > >> buildman: Add a --boards option to specify particular boards > >> to > >> build (2018-10-15 08:20:43 -0600) > >> >>> > >> >>> > >> >>> There's something wrong with these patches; both Jetson TX1 and > >> >>> Jetson > >> >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; > >> >>> the > >> >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit > >> >>> ARM > >> >>> with SPL) and sandbox boot fine. > >> >> > >> >> > >> >> Reverting the following solves the issue: > >> >> > >> >> 1) dm: core: Mirror the chosen node parse logic in the livetree > >> >> scanning > >> >> > >> >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > >> >> lists_bind_fdt() > >> >> > >> >> Reverting just (1) or just (2) does not. Can you please take a look? > >> >> Thanks. > >> > > >> > > >> > The failure is probably due to some drivers that Tegra uses are not > >> > properly written, ie: these drivers are declared via U_BOOT_DRIVER > >> > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > >> > relocation) until patch (1) & (2). Now these drivers get bound before > >> > relocation but they were never bound before (assume they were never > >> > required before relocation), so we should identify which driver were > >> > wrongly written, but as a quick solution, can you please enlarge the > >> > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > >> > >> > >> Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > >> issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > >> tegra186_gpio.c (depending on board/SoC) also solves this. > >> > >> I suppose the correct solution is to remove the DM flag from the > >> driver, > >> since if it never used to work before your patches, it's clear that > >> the > >> flag/feature is not actually required. > >> >>> > >> >>> > >> >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio > >> >>> driver. > >> > >> Thanks Bin, > >> > >> >> > >> >> > >> >> Ah, it turns out so many drivers/dts are mis-written ... > >> >> > >> >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > >> >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > >> >> have been added to workaround the DM bug (fixed in patch 1 & 2 > >> >> mentioned in this thread). But now since the DM bug has been fixed, > >> >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am > >> >> afraid I don't have the knowledge to clean up all of these. > >> >> > >> >> Of course, I've identified some additional drivers that have > >> >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have > >> >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the > >> >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. > >> > > >> > > >> > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the > >> > Tegra > >> > GPIO driver specifically, so I think a simple patch removing the > >> > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of > >> > course, I didn't look at any non-Tegra DTs, or at drivers other than > >> > Tegra > >> > GPIO. > >> > >> OK. > >> > >> I tend to agree that it is getting a bit late. I am considering > >> delaying this pull request until the next merge window. I still have > >> regmap and virtio to bring in.
Re: [U-Boot] Please pull u-boot-dm
Hi BIn, On 24 October 2018 at 07:40, Bin Meng wrote: > Hi Simon, > > On Mon, Oct 22, 2018 at 7:11 PM Tom Rini wrote: >> >> On Mon, Oct 22, 2018 at 05:46:20PM +0800, Bin Meng wrote: >> > Hi Simon, >> > >> > On Fri, Oct 19, 2018 at 8:10 PM Tom Rini wrote: >> > > >> > > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: >> > > > Hi, >> > > > >> > > > On 17 October 2018 at 11:14, Stephen Warren >> > > > wrote: >> > > > > On 10/16/18 8:33 PM, Bin Meng wrote: >> > > > >> >> > > > >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: >> > > > >>> >> > > > >>> >> > > > >>> Hi Stephen, >> > > > >>> >> > > > >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren >> > > > >>> >> > > > >>> wrote: >> > > > >> > > > >> > > > On 10/15/18 5:43 PM, Bin Meng wrote: >> > > > > >> > > > > Hi Stephen, >> > > > > >> > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren >> > > > > >> > > > > wrote: >> > > > >> >> > > > >> >> > > > >> On 10/15/18 3:53 PM, Stephen Warren wrote: >> > > > >>> >> > > > >>> On 10/15/18 2:17 PM, Simon Glass wrote: >> > > > >> > > > Hi Tom, >> > > > >> > > > The following changes since commit >> > > > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: >> > > > >> > > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of >> > > > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) >> > > > >> > > > are available in the Git repository at: >> > > > >> > > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 >> > > > >> > > > for you to fetch changes up to >> > > > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: >> > > > >> > > > buildman: Add a --boards option to specify particular >> > > > boards to >> > > > build (2018-10-15 08:20:43 -0600) >> > > > >>> >> > > > >>> >> > > > >>> There's something wrong with these patches; both Jetson TX1 and >> > > > >>> Jetson >> > > > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this >> > > > >>> branch; the >> > > > >>> system hangs with no output at all from U-Boot. Jetson TK1 >> > > > >>> (32-bit >> > > > >>> ARM >> > > > >>> with SPL) and sandbox boot fine. >> > > > >> >> > > > >> >> > > > >> Reverting the following solves the issue: >> > > > >> >> > > > >> 1) dm: core: Mirror the chosen node parse logic in the livetree >> > > > >> scanning >> > > > >> >> > > > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in >> > > > >> lists_bind_fdt() >> > > > >> >> > > > >> Reverting just (1) or just (2) does not. Can you please take a >> > > > >> look? >> > > > >> Thanks. >> > > > > >> > > > > >> > > > > The failure is probably due to some drivers that Tegra uses are >> > > > > not >> > > > > properly written, ie: these drivers are declared via >> > > > > U_BOOT_DRIVER >> > > > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound >> > > > > before >> > > > > relocation) until patch (1) & (2). Now these drivers get bound >> > > > > before >> > > > > relocation but they were never bound before (assume they were >> > > > > never >> > > > > required before relocation), so we should identify which driver >> > > > > were >> > > > > wrongly written, but as a quick solution, can you please enlarge >> > > > > the >> > > > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? >> > > > >> > > > >> > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves >> > > > the >> > > > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c >> > > > or >> > > > tegra186_gpio.c (depending on board/SoC) also solves this. >> > > > >> > > > I suppose the correct solution is to remove the DM flag from the >> > > > driver, >> > > > since if it never used to work before your patches, it's clear >> > > > that the >> > > > flag/feature is not actually required. >> > > > >>> >> > > > >>> >> > > > >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio >> > > > >>> driver. >> > > > >> > > > Thanks Bin, >> > > > >> > > > >> >> > > > >> >> > > > >> Ah, it turns out so many drivers/dts are mis-written ... >> > > > >> >> > > > >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts >> > > > >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must >> > > > >> have been added to workaround the DM bug (fixed in patch 1 & 2 >> > > > >> mentioned in this thread). But now since the DM bug has been fixed, >> > > > >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I >> > > > >> am >> > > > >> afraid I don't have the knowledge to clean up all of these. >> > > > >> >> > > > >> Of course, I've identified some
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 19 October 2018 at 06:10, Tom Rini wrote: > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: >> Hi, >> >> On 17 October 2018 at 11:14, Stephen Warren wrote: >> > On 10/16/18 8:33 PM, Bin Meng wrote: >> >> >> >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: >> >>> >> >>> >> >>> Hi Stephen, >> >>> >> >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren >> >>> wrote: >> >> >> On 10/15/18 5:43 PM, Bin Meng wrote: >> > >> > Hi Stephen, >> > >> > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren >> > wrote: >> >> >> >> >> >> On 10/15/18 3:53 PM, Stephen Warren wrote: >> >>> >> >>> On 10/15/18 2:17 PM, Simon Glass wrote: >> >> Hi Tom, >> >> The following changes since commit >> 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: >> >> Merge tag 'arc-more-updates-for-2018.11-rc2-2' of >> git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) >> >> are available in the Git repository at: >> >> git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 >> >> for you to fetch changes up to >> 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: >> >> buildman: Add a --boards option to specify particular boards to >> build (2018-10-15 08:20:43 -0600) >> >>> >> >>> >> >>> There's something wrong with these patches; both Jetson TX1 and >> >>> Jetson >> >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the >> >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit >> >>> ARM >> >>> with SPL) and sandbox boot fine. >> >> >> >> >> >> Reverting the following solves the issue: >> >> >> >> 1) dm: core: Mirror the chosen node parse logic in the livetree >> >> scanning >> >> >> >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in >> >> lists_bind_fdt() >> >> >> >> Reverting just (1) or just (2) does not. Can you please take a look? >> >> Thanks. >> > >> > >> > The failure is probably due to some drivers that Tegra uses are not >> > properly written, ie: these drivers are declared via U_BOOT_DRIVER >> > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before >> > relocation) until patch (1) & (2). Now these drivers get bound before >> > relocation but they were never bound before (assume they were never >> > required before relocation), so we should identify which driver were >> > wrongly written, but as a quick solution, can you please enlarge the >> > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? >> >> >> Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the >> issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or >> tegra186_gpio.c (depending on board/SoC) also solves this. >> >> I suppose the correct solution is to remove the DM flag from the driver, >> since if it never used to work before your patches, it's clear that the >> flag/feature is not actually required. >> >>> >> >>> >> >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio >> >>> driver. >> >> Thanks Bin, >> >> >> >> >> >> >> Ah, it turns out so many drivers/dts are mis-written ... >> >> >> >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts >> >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must >> >> have been added to workaround the DM bug (fixed in patch 1 & 2 >> >> mentioned in this thread). But now since the DM bug has been fixed, >> >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am >> >> afraid I don't have the knowledge to clean up all of these. >> >> >> >> Of course, I've identified some additional drivers that have >> >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have >> >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the >> >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. >> > >> > >> > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the Tegra >> > GPIO driver specifically, so I think a simple patch removing the >> > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of >> > course, I didn't look at any non-Tegra DTs, or at drivers other than Tegra >> > GPIO. >> >> OK. >> >> I tend to agree that it is getting a bit late. I am considering >> delaying this pull request until the next merge window. I still have >> regmap and virtio to bring in. Tom, what do you think? >> > > Start the PR over and look for things it really makes sense to grab at > -rc2 (bugfixes, Kconfig migrations, etc) is what I think we need to do > at this point, thanks! Just to follow up, I really don't see anything that fits that category. Bin, are any of your patches necessary for this release to actually fix boards? Regards, Simon
Re: [U-Boot] Please pull u-boot-dm
Hi Simon, On Mon, Oct 22, 2018 at 7:11 PM Tom Rini wrote: > > On Mon, Oct 22, 2018 at 05:46:20PM +0800, Bin Meng wrote: > > Hi Simon, > > > > On Fri, Oct 19, 2018 at 8:10 PM Tom Rini wrote: > > > > > > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: > > > > Hi, > > > > > > > > On 17 October 2018 at 11:14, Stephen Warren > > > > wrote: > > > > > On 10/16/18 8:33 PM, Bin Meng wrote: > > > > >> > > > > >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > > > > >>> > > > > >>> > > > > >>> Hi Stephen, > > > > >>> > > > > >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > > > > >>> > > > > >>> wrote: > > > > > > > > > > > > On 10/15/18 5:43 PM, Bin Meng wrote: > > > > > > > > > > Hi Stephen, > > > > > > > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > > > > > > > > > wrote: > > > > >> > > > > >> > > > > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > > > > >>> > > > > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > > The following changes since commit > > > > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > > > > > > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > > > > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > > > > > > > for you to fetch changes up to > > > > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > > > > > > > buildman: Add a --boards option to specify particular > > > > boards to > > > > build (2018-10-15 08:20:43 -0600) > > > > >>> > > > > >>> > > > > >>> There's something wrong with these patches; both Jetson TX1 and > > > > >>> Jetson > > > > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this > > > > >>> branch; the > > > > >>> system hangs with no output at all from U-Boot. Jetson TK1 > > > > >>> (32-bit > > > > >>> ARM > > > > >>> with SPL) and sandbox boot fine. > > > > >> > > > > >> > > > > >> Reverting the following solves the issue: > > > > >> > > > > >> 1) dm: core: Mirror the chosen node parse logic in the livetree > > > > >> scanning > > > > >> > > > > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > > > > >> lists_bind_fdt() > > > > >> > > > > >> Reverting just (1) or just (2) does not. Can you please take a > > > > >> look? > > > > >> Thanks. > > > > > > > > > > > > > > > The failure is probably due to some drivers that Tegra uses are > > > > > not > > > > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > > > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound > > > > > before > > > > > relocation) until patch (1) & (2). Now these drivers get bound > > > > > before > > > > > relocation but they were never bound before (assume they were > > > > > never > > > > > required before relocation), so we should identify which driver > > > > > were > > > > > wrongly written, but as a quick solution, can you please enlarge > > > > > the > > > > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > > > > > > > > > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves > > > > the > > > > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > > > > tegra186_gpio.c (depending on board/SoC) also solves this. > > > > > > > > I suppose the correct solution is to remove the DM flag from the > > > > driver, > > > > since if it never used to work before your patches, it's clear > > > > that the > > > > flag/feature is not actually required. > > > > >>> > > > > >>> > > > > >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio > > > > >>> driver. > > > > > > > > Thanks Bin, > > > > > > > > >> > > > > >> > > > > >> Ah, it turns out so many drivers/dts are mis-written ... > > > > >> > > > > >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > > > > >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > > > > >> have been added to workaround the DM bug (fixed in patch 1 & 2 > > > > >> mentioned in this thread). But now since the DM bug has been fixed, > > > > >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I > > > > >> am > > > > >> afraid I don't have the knowledge to clean up all of these. > > > > >> > > > > >> Of course, I've identified some additional drivers that have > > > > >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have > > > > >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the > > > > >> DM_FLAG_PRE_RELOC flag like the Tegra
Re: [U-Boot] Please pull u-boot-dm
On Mon, Oct 22, 2018 at 05:46:20PM +0800, Bin Meng wrote: > Hi Simon, > > On Fri, Oct 19, 2018 at 8:10 PM Tom Rini wrote: > > > > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On 17 October 2018 at 11:14, Stephen Warren wrote: > > > > On 10/16/18 8:33 PM, Bin Meng wrote: > > > >> > > > >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > > > >>> > > > >>> > > > >>> Hi Stephen, > > > >>> > > > >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > > > >>> > > > >>> wrote: > > > > > > > > > On 10/15/18 5:43 PM, Bin Meng wrote: > > > > > > > > Hi Stephen, > > > > > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > > > > > > > wrote: > > > >> > > > >> > > > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > > > >>> > > > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > The following changes since commit > > > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > > > > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > > > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > > > > > for you to fetch changes up to > > > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > > > > > buildman: Add a --boards option to specify particular > > > boards to > > > build (2018-10-15 08:20:43 -0600) > > > >>> > > > >>> > > > >>> There's something wrong with these patches; both Jetson TX1 and > > > >>> Jetson > > > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; > > > >>> the > > > >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit > > > >>> ARM > > > >>> with SPL) and sandbox boot fine. > > > >> > > > >> > > > >> Reverting the following solves the issue: > > > >> > > > >> 1) dm: core: Mirror the chosen node parse logic in the livetree > > > >> scanning > > > >> > > > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > > > >> lists_bind_fdt() > > > >> > > > >> Reverting just (1) or just (2) does not. Can you please take a > > > >> look? > > > >> Thanks. > > > > > > > > > > > > The failure is probably due to some drivers that Tegra uses are not > > > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > > > > relocation) until patch (1) & (2). Now these drivers get bound > > > > before > > > > relocation but they were never bound before (assume they were never > > > > required before relocation), so we should identify which driver were > > > > wrongly written, but as a quick solution, can you please enlarge the > > > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > > > > > > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > > > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > > > tegra186_gpio.c (depending on board/SoC) also solves this. > > > > > > I suppose the correct solution is to remove the DM flag from the > > > driver, > > > since if it never used to work before your patches, it's clear that > > > the > > > flag/feature is not actually required. > > > >>> > > > >>> > > > >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio > > > >>> driver. > > > > > > Thanks Bin, > > > > > > >> > > > >> > > > >> Ah, it turns out so many drivers/dts are mis-written ... > > > >> > > > >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > > > >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > > > >> have been added to workaround the DM bug (fixed in patch 1 & 2 > > > >> mentioned in this thread). But now since the DM bug has been fixed, > > > >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am > > > >> afraid I don't have the knowledge to clean up all of these. > > > >> > > > >> Of course, I've identified some additional drivers that have > > > >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have > > > >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the > > > >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. > > > > > > > > > > > > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the > > > > Tegra > > > > GPIO driver specifically, so I think a simple patch removing the > > > > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of > > > > course, I didn't look at any non-Tegra DTs, or at drivers other than > > > > Tegra > > > > GPIO. > > > > > > OK. > > > > > > I tend to
Re: [U-Boot] Please pull u-boot-dm
Hi Simon, On Fri, Oct 19, 2018 at 8:10 PM Tom Rini wrote: > > On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: > > Hi, > > > > On 17 October 2018 at 11:14, Stephen Warren wrote: > > > On 10/16/18 8:33 PM, Bin Meng wrote: > > >> > > >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > > >>> > > >>> > > >>> Hi Stephen, > > >>> > > >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > > >>> wrote: > > > > > > On 10/15/18 5:43 PM, Bin Meng wrote: > > > > > > Hi Stephen, > > > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > > wrote: > > >> > > >> > > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > > >>> > > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > > > > Hi Tom, > > > > The following changes since commit > > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > > > for you to fetch changes up to > > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > > > buildman: Add a --boards option to specify particular boards > > to > > build (2018-10-15 08:20:43 -0600) > > >>> > > >>> > > >>> There's something wrong with these patches; both Jetson TX1 and > > >>> Jetson > > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > > >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit > > >>> ARM > > >>> with SPL) and sandbox boot fine. > > >> > > >> > > >> Reverting the following solves the issue: > > >> > > >> 1) dm: core: Mirror the chosen node parse logic in the livetree > > >> scanning > > >> > > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > > >> lists_bind_fdt() > > >> > > >> Reverting just (1) or just (2) does not. Can you please take a look? > > >> Thanks. > > > > > > > > > The failure is probably due to some drivers that Tegra uses are not > > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > > > relocation) until patch (1) & (2). Now these drivers get bound before > > > relocation but they were never bound before (assume they were never > > > required before relocation), so we should identify which driver were > > > wrongly written, but as a quick solution, can you please enlarge the > > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > > > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > > tegra186_gpio.c (depending on board/SoC) also solves this. > > > > I suppose the correct solution is to remove the DM flag from the > > driver, > > since if it never used to work before your patches, it's clear that the > > flag/feature is not actually required. > > >>> > > >>> > > >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio > > >>> driver. > > > > Thanks Bin, > > > > >> > > >> > > >> Ah, it turns out so many drivers/dts are mis-written ... > > >> > > >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > > >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > > >> have been added to workaround the DM bug (fixed in patch 1 & 2 > > >> mentioned in this thread). But now since the DM bug has been fixed, > > >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am > > >> afraid I don't have the knowledge to clean up all of these. > > >> > > >> Of course, I've identified some additional drivers that have > > >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have > > >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the > > >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. > > > > > > > > > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the Tegra > > > GPIO driver specifically, so I think a simple patch removing the > > > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of > > > course, I didn't look at any non-Tegra DTs, or at drivers other than Tegra > > > GPIO. > > > > OK. > > > > I tend to agree that it is getting a bit late. I am considering > > delaying this pull request until the next merge window. I still have > > regmap and virtio to bring in. Tom, what do you think? > > > > Start the PR over and look for things it really makes sense to grab at > -rc2 (bugfixes, Kconfig migrations, etc) is what I think we need to do > at this point, thanks! I just realized that without my fix in
Re: [U-Boot] Please pull u-boot-dm
On Thu, Oct 18, 2018 at 09:27:49PM -0600, Simon Glass wrote: > Hi, > > On 17 October 2018 at 11:14, Stephen Warren wrote: > > On 10/16/18 8:33 PM, Bin Meng wrote: > >> > >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > >>> > >>> > >>> Hi Stephen, > >>> > >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > >>> wrote: > > > On 10/15/18 5:43 PM, Bin Meng wrote: > > > > Hi Stephen, > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > wrote: > >> > >> > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > >>> > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > > Hi Tom, > > The following changes since commit > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > for you to fetch changes up to > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > buildman: Add a --boards option to specify particular boards to > build (2018-10-15 08:20:43 -0600) > >>> > >>> > >>> There's something wrong with these patches; both Jetson TX1 and > >>> Jetson > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit > >>> ARM > >>> with SPL) and sandbox boot fine. > >> > >> > >> Reverting the following solves the issue: > >> > >> 1) dm: core: Mirror the chosen node parse logic in the livetree > >> scanning > >> > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > >> lists_bind_fdt() > >> > >> Reverting just (1) or just (2) does not. Can you please take a look? > >> Thanks. > > > > > > The failure is probably due to some drivers that Tegra uses are not > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > > relocation) until patch (1) & (2). Now these drivers get bound before > > relocation but they were never bound before (assume they were never > > required before relocation), so we should identify which driver were > > wrongly written, but as a quick solution, can you please enlarge the > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > tegra186_gpio.c (depending on board/SoC) also solves this. > > I suppose the correct solution is to remove the DM flag from the driver, > since if it never used to work before your patches, it's clear that the > flag/feature is not actually required. > >>> > >>> > >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio > >>> driver. > > Thanks Bin, > > >> > >> > >> Ah, it turns out so many drivers/dts are mis-written ... > >> > >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > >> have been added to workaround the DM bug (fixed in patch 1 & 2 > >> mentioned in this thread). But now since the DM bug has been fixed, > >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am > >> afraid I don't have the knowledge to clean up all of these. > >> > >> Of course, I've identified some additional drivers that have > >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have > >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the > >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. > > > > > > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the Tegra > > GPIO driver specifically, so I think a simple patch removing the > > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of > > course, I didn't look at any non-Tegra DTs, or at drivers other than Tegra > > GPIO. > > OK. > > I tend to agree that it is getting a bit late. I am considering > delaying this pull request until the next merge window. I still have > regmap and virtio to bring in. Tom, what do you think? > Start the PR over and look for things it really makes sense to grab at -rc2 (bugfixes, Kconfig migrations, etc) is what I think we need to do at this point, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi, On 17 October 2018 at 11:14, Stephen Warren wrote: > On 10/16/18 8:33 PM, Bin Meng wrote: >> >> On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: >>> >>> >>> Hi Stephen, >>> >>> On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren >>> wrote: On 10/15/18 5:43 PM, Bin Meng wrote: > > Hi Stephen, > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > wrote: >> >> >> On 10/15/18 3:53 PM, Stephen Warren wrote: >>> >>> On 10/15/18 2:17 PM, Simon Glass wrote: Hi Tom, The following changes since commit 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: Merge tag 'arc-more-updates-for-2018.11-rc2-2' of git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: buildman: Add a --boards option to specify particular boards to build (2018-10-15 08:20:43 -0600) >>> >>> >>> There's something wrong with these patches; both Jetson TX1 and >>> Jetson >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit >>> ARM >>> with SPL) and sandbox boot fine. >> >> >> Reverting the following solves the issue: >> >> 1) dm: core: Mirror the chosen node parse logic in the livetree >> scanning >> >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in >> lists_bind_fdt() >> >> Reverting just (1) or just (2) does not. Can you please take a look? >> Thanks. > > > The failure is probably due to some drivers that Tegra uses are not > properly written, ie: these drivers are declared via U_BOOT_DRIVER > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > relocation) until patch (1) & (2). Now these drivers get bound before > relocation but they were never bound before (assume they were never > required before relocation), so we should identify which driver were > wrongly written, but as a quick solution, can you please enlarge the > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or tegra186_gpio.c (depending on board/SoC) also solves this. I suppose the correct solution is to remove the DM flag from the driver, since if it never used to work before your patches, it's clear that the flag/feature is not actually required. >>> >>> >>> Thank you Stephen. I will prepare a patch to update the tegra*_gpio >>> driver. Thanks Bin, >> >> >> Ah, it turns out so many drivers/dts are mis-written ... >> >> For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts >> file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must >> have been added to workaround the DM bug (fixed in patch 1 & 2 >> mentioned in this thread). But now since the DM bug has been fixed, >> these "u-boot,dm-pre-reloc" properties are really unnecessary but I am >> afraid I don't have the knowledge to clean up all of these. >> >> Of course, I've identified some additional drivers that have >> DM_FLAG_PRE_RELOC flag set but dts file doesn't have >> "u-boot,dm-pre-reloc". These drivers should be updated to remove the >> DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. > > > I don't see any cases where u-boot,dm-pre-reloc exists in DT for the Tegra > GPIO driver specifically, so I think a simple patch removing the > DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of > course, I didn't look at any non-Tegra DTs, or at drivers other than Tegra > GPIO. OK. I tend to agree that it is getting a bit late. I am considering delaying this pull request until the next merge window. I still have regmap and virtio to bring in. Tom, what do you think? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 10/16/18 8:33 PM, Bin Meng wrote: On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: Hi Stephen, On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren wrote: On 10/15/18 5:43 PM, Bin Meng wrote: Hi Stephen, On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren wrote: On 10/15/18 3:53 PM, Stephen Warren wrote: On 10/15/18 2:17 PM, Simon Glass wrote: Hi Tom, The following changes since commit 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: Merge tag 'arc-more-updates-for-2018.11-rc2-2' of git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: buildman: Add a --boards option to specify particular boards to build (2018-10-15 08:20:43 -0600) There's something wrong with these patches; both Jetson TX1 and Jetson TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM with SPL) and sandbox boot fine. Reverting the following solves the issue: 1) dm: core: Mirror the chosen node parse logic in the livetree scanning 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt() Reverting just (1) or just (2) does not. Can you please take a look? Thanks. The failure is probably due to some drivers that Tegra uses are not properly written, ie: these drivers are declared via U_BOOT_DRIVER with flags DM_FLAG_PRE_RELOC yet it was never working (bound before relocation) until patch (1) & (2). Now these drivers get bound before relocation but they were never bound before (assume they were never required before relocation), so we should identify which driver were wrongly written, but as a quick solution, can you please enlarge the CONFIG_SYS_MALLOC_F_LEN of your board and have a try? Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or tegra186_gpio.c (depending on board/SoC) also solves this. I suppose the correct solution is to remove the DM flag from the driver, since if it never used to work before your patches, it's clear that the flag/feature is not actually required. Thank you Stephen. I will prepare a patch to update the tegra*_gpio driver. Ah, it turns out so many drivers/dts are mis-written ... For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must have been added to workaround the DM bug (fixed in patch 1 & 2 mentioned in this thread). But now since the DM bug has been fixed, these "u-boot,dm-pre-reloc" properties are really unnecessary but I am afraid I don't have the knowledge to clean up all of these. Of course, I've identified some additional drivers that have DM_FLAG_PRE_RELOC flag set but dts file doesn't have "u-boot,dm-pre-reloc". These drivers should be updated to remove the DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. I don't see any cases where u-boot,dm-pre-reloc exists in DT for the Tegra GPIO driver specifically, so I think a simple patch removing the DM_FLAG_PRE_RELOC flag from the two Tegra GPIO drivers would be fine. Of course, I didn't look at any non-Tegra DTs, or at drivers other than Tegra GPIO. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Oct 17, 2018 at 10:33 AM Bin Meng wrote: > > On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > > > > Hi Stephen, > > > > On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren > > wrote: > > > > > > On 10/15/18 5:43 PM, Bin Meng wrote: > > > > Hi Stephen, > > > > > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > > > wrote: > > > >> > > > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > > > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > > > Hi Tom, > > > > > > The following changes since commit > > > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > > > > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > > > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > > > > > for you to fetch changes up to > > > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > > > > > buildman: Add a --boards option to specify particular boards to > > > build (2018-10-15 08:20:43 -0600) > > > >>> > > > >>> There's something wrong with these patches; both Jetson TX1 and Jetson > > > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > > > >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM > > > >>> with SPL) and sandbox boot fine. > > > >> > > > >> Reverting the following solves the issue: > > > >> > > > >> 1) dm: core: Mirror the chosen node parse logic in the livetree > > > >> scanning > > > >> > > > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > > > >> lists_bind_fdt() > > > >> > > > >> Reverting just (1) or just (2) does not. Can you please take a look? > > > >> Thanks. > > > > > > > > The failure is probably due to some drivers that Tegra uses are not > > > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > > > > relocation) until patch (1) & (2). Now these drivers get bound before > > > > relocation but they were never bound before (assume they were never > > > > required before relocation), so we should identify which driver were > > > > wrongly written, but as a quick solution, can you please enlarge the > > > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > > > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > > > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > > > tegra186_gpio.c (depending on board/SoC) also solves this. > > > > > > I suppose the correct solution is to remove the DM flag from the driver, > > > since if it never used to work before your patches, it's clear that the > > > flag/feature is not actually required. > > > > Thank you Stephen. I will prepare a patch to update the tegra*_gpio driver. > > Ah, it turns out so many drivers/dts are mis-written ... > > For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts > file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must > have been added to workaround the DM bug (fixed in patch 1 & 2 > mentioned in this thread). But now since the DM bug has been fixed, > these "u-boot,dm-pre-reloc" properties are really unnecessary but I am > afraid I don't have the knowledge to clean up all of these. > I don't think we have enough time before release to address all of these issues. Let's go with the following: Simon, can you please just drop the 3 patches below: dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt() dm: core: Mirror the chosen node parse logic in the livetree scanning test: dm: core: Add a test case for driver marked with DM_FLAG_PRE_RELOC flag > Of course, I've identified some additional drivers that have > DM_FLAG_PRE_RELOC flag set but dts file doesn't have > "u-boot,dm-pre-reloc". These drivers should be updated to remove the > DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. > I will work with a complete patchset targeting next release to clean up these. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Oct 17, 2018 at 7:01 AM Bin Meng wrote: > > Hi Stephen, > > On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren wrote: > > > > On 10/15/18 5:43 PM, Bin Meng wrote: > > > Hi Stephen, > > > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > > wrote: > > >> > > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > > Hi Tom, > > > > The following changes since commit > > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > > > for you to fetch changes up to > > 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > > > buildman: Add a --boards option to specify particular boards to > > build (2018-10-15 08:20:43 -0600) > > >>> > > >>> There's something wrong with these patches; both Jetson TX1 and Jetson > > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > > >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM > > >>> with SPL) and sandbox boot fine. > > >> > > >> Reverting the following solves the issue: > > >> > > >> 1) dm: core: Mirror the chosen node parse logic in the livetree scanning > > >> > > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > > >> lists_bind_fdt() > > >> > > >> Reverting just (1) or just (2) does not. Can you please take a look? > > >> Thanks. > > > > > > The failure is probably due to some drivers that Tegra uses are not > > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > > > relocation) until patch (1) & (2). Now these drivers get bound before > > > relocation but they were never bound before (assume they were never > > > required before relocation), so we should identify which driver were > > > wrongly written, but as a quick solution, can you please enlarge the > > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > > tegra186_gpio.c (depending on board/SoC) also solves this. > > > > I suppose the correct solution is to remove the DM flag from the driver, > > since if it never used to work before your patches, it's clear that the > > flag/feature is not actually required. > > Thank you Stephen. I will prepare a patch to update the tegra*_gpio driver. Ah, it turns out so many drivers/dts are mis-written ... For example, the driver has the DM_FLAG_PRE_RELOC flag, and the dts file also has "u-boot,dm-pre-reloc". The "u-boot,dm-pre-reloc" must have been added to workaround the DM bug (fixed in patch 1 & 2 mentioned in this thread). But now since the DM bug has been fixed, these "u-boot,dm-pre-reloc" properties are really unnecessary but I am afraid I don't have the knowledge to clean up all of these. Of course, I've identified some additional drivers that have DM_FLAG_PRE_RELOC flag set but dts file doesn't have "u-boot,dm-pre-reloc". These drivers should be updated to remove the DM_FLAG_PRE_RELOC flag like the Tegra GPIO drivers. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Stephen, On Wed, Oct 17, 2018 at 12:27 AM Stephen Warren wrote: > > On 10/15/18 5:43 PM, Bin Meng wrote: > > Hi Stephen, > > > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren > > wrote: > >> > >> On 10/15/18 3:53 PM, Stephen Warren wrote: > >>> On 10/15/18 2:17 PM, Simon Glass wrote: > Hi Tom, > > The following changes since commit > 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > buildman: Add a --boards option to specify particular boards to > build (2018-10-15 08:20:43 -0600) > >>> > >>> There's something wrong with these patches; both Jetson TX1 and Jetson > >>> TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > >>> system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM > >>> with SPL) and sandbox boot fine. > >> > >> Reverting the following solves the issue: > >> > >> 1) dm: core: Mirror the chosen node parse logic in the livetree scanning > >> > >> 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > >> lists_bind_fdt() > >> > >> Reverting just (1) or just (2) does not. Can you please take a look? > >> Thanks. > > > > The failure is probably due to some drivers that Tegra uses are not > > properly written, ie: these drivers are declared via U_BOOT_DRIVER > > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > > relocation) until patch (1) & (2). Now these drivers get bound before > > relocation but they were never bound before (assume they were never > > required before relocation), so we should identify which driver were > > wrongly written, but as a quick solution, can you please enlarge the > > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? > > Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the > issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or > tegra186_gpio.c (depending on board/SoC) also solves this. > > I suppose the correct solution is to remove the DM flag from the driver, > since if it never used to work before your patches, it's clear that the > flag/feature is not actually required. Thank you Stephen. I will prepare a patch to update the tegra*_gpio driver. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 10/15/18 5:43 PM, Bin Meng wrote: Hi Stephen, On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren wrote: On 10/15/18 3:53 PM, Stephen Warren wrote: On 10/15/18 2:17 PM, Simon Glass wrote: Hi Tom, The following changes since commit 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: Merge tag 'arc-more-updates-for-2018.11-rc2-2' of git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: buildman: Add a --boards option to specify particular boards to build (2018-10-15 08:20:43 -0600) There's something wrong with these patches; both Jetson TX1 and Jetson TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM with SPL) and sandbox boot fine. Reverting the following solves the issue: 1) dm: core: Mirror the chosen node parse logic in the livetree scanning 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt() Reverting just (1) or just (2) does not. Can you please take a look? Thanks. The failure is probably due to some drivers that Tegra uses are not properly written, ie: these drivers are declared via U_BOOT_DRIVER with flags DM_FLAG_PRE_RELOC yet it was never working (bound before relocation) until patch (1) & (2). Now these drivers get bound before relocation but they were never bound before (assume they were never required before relocation), so we should identify which driver were wrongly written, but as a quick solution, can you please enlarge the CONFIG_SYS_MALLOC_F_LEN of your board and have a try? Yes, bumping CONFIG_SYS_MALLOC_F_LEN from 0x1800 to 0x1a90 solves the issue. Alternatively, removing DM_FLAG_PRE_RELOC in tegra_gpio.c or tegra186_gpio.c (depending on board/SoC) also solves this. I suppose the correct solution is to remove the DM flag from the driver, since if it never used to work before your patches, it's clear that the flag/feature is not actually required. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Oct 16, 2018 at 07:43:21AM +0800, Bin Meng wrote: > Hi Stephen, > > On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren wrote: > > > > On 10/15/18 3:53 PM, Stephen Warren wrote: > > > On 10/15/18 2:17 PM, Simon Glass wrote: > > >> Hi Tom, > > >> > > >> The following changes since commit > > >> 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > > >> > > >>Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > > >> git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > > >> > > >> are available in the Git repository at: > > >> > > >>git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > > >> > > >> for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > > >> > > >>buildman: Add a --boards option to specify particular boards to > > >> build (2018-10-15 08:20:43 -0600) > > > > > > There's something wrong with these patches; both Jetson TX1 and Jetson > > > TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > > > system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM > > > with SPL) and sandbox boot fine. > > > > Reverting the following solves the issue: > > > > 1) dm: core: Mirror the chosen node parse logic in the livetree scanning > > > > 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > > lists_bind_fdt() > > > > Reverting just (1) or just (2) does not. Can you please take a look? Thanks. > > The failure is probably due to some drivers that Tegra uses are not > properly written, ie: these drivers are declared via U_BOOT_DRIVER > with flags DM_FLAG_PRE_RELOC yet it was never working (bound before > relocation) until patch (1) & (2). Now these drivers get bound before > relocation but they were never bound before (assume they were never > required before relocation), so we should identify which driver were > wrongly written, but as a quick solution, can you please enlarge the > CONFIG_SYS_MALLOC_F_LEN of your board and have a try? and I'm going to hold off on this PR until we have this sorted out. Thanks all! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Stephen, On Tue, Oct 16, 2018 at 6:43 AM Stephen Warren wrote: > > On 10/15/18 3:53 PM, Stephen Warren wrote: > > On 10/15/18 2:17 PM, Simon Glass wrote: > >> Hi Tom, > >> > >> The following changes since commit > >> 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: > >> > >>Merge tag 'arc-more-updates-for-2018.11-rc2-2' of > >> git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) > >> > >> are available in the Git repository at: > >> > >>git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 > >> > >> for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: > >> > >>buildman: Add a --boards option to specify particular boards to > >> build (2018-10-15 08:20:43 -0600) > > > > There's something wrong with these patches; both Jetson TX1 and Jetson > > TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the > > system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM > > with SPL) and sandbox boot fine. > > Reverting the following solves the issue: > > 1) dm: core: Mirror the chosen node parse logic in the livetree scanning > > 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in > lists_bind_fdt() > > Reverting just (1) or just (2) does not. Can you please take a look? Thanks. The failure is probably due to some drivers that Tegra uses are not properly written, ie: these drivers are declared via U_BOOT_DRIVER with flags DM_FLAG_PRE_RELOC yet it was never working (bound before relocation) until patch (1) & (2). Now these drivers get bound before relocation but they were never bound before (assume they were never required before relocation), so we should identify which driver were wrongly written, but as a quick solution, can you please enlarge the CONFIG_SYS_MALLOC_F_LEN of your board and have a try? Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 10/15/18 3:53 PM, Stephen Warren wrote: On 10/15/18 2:17 PM, Simon Glass wrote: Hi Tom, The following changes since commit 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: Merge tag 'arc-more-updates-for-2018.11-rc2-2' of git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: buildman: Add a --boards option to specify particular boards to build (2018-10-15 08:20:43 -0600) There's something wrong with these patches; both Jetson TX1 and Jetson TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM with SPL) and sandbox boot fine. Reverting the following solves the issue: 1) dm: core: Mirror the chosen node parse logic in the livetree scanning 2) dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt() Reverting just (1) or just (2) does not. Can you please take a look? Thanks. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 10/15/18 2:17 PM, Simon Glass wrote: Hi Tom, The following changes since commit 6e7a186dc5d50f563e224e9ae7be70defff7ee0d: Merge tag 'arc-more-updates-for-2018.11-rc2-2' of git://git.denx.de/u-boot-arc (2018-10-15 07:20:07 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/pull-15oct-18 for you to fetch changes up to 02f2d266c75106a2fefd1f4e8e6f703fe00ed21d: buildman: Add a --boards option to specify particular boards to build (2018-10-15 08:20:43 -0600) There's something wrong with these patches; both Jetson TX1 and Jetson TX2 (both 64-bit ARM without SPL) fail to boot with this branch; the system hangs with no output at all from U-Boot. Jetson TK1 (32-bit ARM with SPL) and sandbox boot fine. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > Hi Tom, > > Here is my attempt at a signed pull request. I've brought in most of the > outstanding dm patches. Please let me know if it looks OK. Do you have my > public key? Is it on the public key servers? > > > The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: > > Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 > -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-9oct18 > > for you to fetch changes up to 41b781ddf1869f5349e05ace888979f3673fe8c6: > > dtoc: Fix the value of SetInt() (2018-10-09 04:40:27 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 9 October 2018 at 18:24, Simon Glass wrote: > > Hi Tom, > > Here is my attempt at a signed pull request. I've brought in most of the > outstanding dm patches. Please let me know if it looks OK. Do you have my > public key? > Build result here: https://travis-ci.org/sglass68/u-boot/builds/439071186 Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Jens and Simon,
ne 30. 9. 2018 v 22:07 odesílatel Simon Glass napsal:
> Hi Tom,
>
> Here are some binman and core driver-model enhancements.
>
> https://travis-ci.org/sglass68/u-boot/builds/435045761
>
> Re signed tags, I did read this link:
>
> http://web.mit.edu/git/www/howto/using-signed-tag-in-pull-request.html
>
> but I get:
>
> error: gpg failed to sign the data
> error: unable to sign the tag
> The tag message has been left in .git/TAG_EDITMSG
>
> I have tried for a while to get gpg going. I used to use it a long
> time again. Do you know any good instructions for that?
>
> Regards,
> Simon
>
>
> The following changes since commit
> bbef20d479441b01d62252cf127498c58078b2c3:
>
> Merge tag 'xilinx-for-v2018.11' of
> git://git.denx.de/u-boot-microblaze (2018-09-27 08:29:10 -0400)
>
> are available in the Git repository at:
>
> git://git.denx.de/u-boot-dm.git
>
> for you to fetch changes up to 31b8217e83a63d1c8c70edcdcdf5aff3b1791640:
>
> dm: test: Add "/firmware" node scan test (2018-09-29 11:49:35 -0600)
>
>
> Jens Wiklander (1):
> fdt: fdtdec_setup_memory_banksize() use livetree
>
>
This patch is breaking SPL at least on zynq board. I didn't test zynqmp but
I think situation will be very similar.
I am ending in this while loop and never come out of that.
1205 while (ofnode_read_resource(mem, reg++, )) {
1206 reg = 0;
1207 mem = get_next_memory_node(mem);
1208 if (!ofnode_valid(mem)) {
1209 if (bank)
1210 return 0;
1211 goto missing_node;
1212 }
1213 }
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom, On 1 October 2018 at 05:54, Tom Rini wrote: > On Sun, Sep 30, 2018 at 01:06:10PM -0700, Simon Glass wrote: > >> Hi Tom, >> >> Here are some binman and core driver-model enhancements. >> >> https://travis-ci.org/sglass68/u-boot/builds/435045761 >> >> Re signed tags, I did read this link: >> >> http://web.mit.edu/git/www/howto/using-signed-tag-in-pull-request.html >> >> but I get: >> >> error: gpg failed to sign the data >> error: unable to sign the tag >> The tag message has been left in .git/TAG_EDITMSG >> >> I have tried for a while to get gpg going. I used to use it a long >> time again. Do you know any good instructions for that? > > Have you fully switched to using gpg2 (as "gpg" even, or configured git > to know to use gpg2 instead) ? That might be it. OK I installed that, and it looks like I had configured the key wrongly with gitconfig. I think it is working now - thanks! - Simon [..] ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Sun, Sep 30, 2018 at 01:06:10PM -0700, Simon Glass wrote: > Hi Tom, > > Here are some binman and core driver-model enhancements. > > https://travis-ci.org/sglass68/u-boot/builds/435045761 > > Re signed tags, I did read this link: > > http://web.mit.edu/git/www/howto/using-signed-tag-in-pull-request.html > > but I get: > > error: gpg failed to sign the data > error: unable to sign the tag > The tag message has been left in .git/TAG_EDITMSG > > I have tried for a while to get gpg going. I used to use it a long > time again. Do you know any good instructions for that? Have you fully switched to using gpg2 (as "gpg" even, or configured git to know to use gpg2 instead) ? That might be it. > > Regards, > Simon > > > The following changes since commit bbef20d479441b01d62252cf127498c58078b2c3: > > Merge tag 'xilinx-for-v2018.11' of > git://git.denx.de/u-boot-microblaze (2018-09-27 08:29:10 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to 31b8217e83a63d1c8c70edcdcdf5aff3b1791640: > > dm: test: Add "/firmware" node scan test (2018-09-29 11:49:35 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Sep 18, 2018 at 06:13:24PM -0600, Simon Glass wrote: > Hi Tom, > > I was unable to get signed tags working, but here is a list of changes: I assume you read the link from before, can you talk about the issues a bit more? Thanks! > - MPC83xx device tree additions (CPU and RAM) > - Fix sandbox build error > - Sync bitrev with Linux > - Various ofnode/DT improvements > > > The following changes since commit 40e44c8bf516e7071c9b80113473be5757e8c3f3: > > Merge branch 'master' of git://git.denx.de/u-boot-coldfire (2018-09-16 > 10:32:33 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to 75629a25087cd9897305375421abe2248bc40e72: > > dm: uclass: Adding missing child_pre_probe description (2018-09-18 > 13:27:10 -0600) Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Sep 19, 2018 at 8:13 AM Simon Glass wrote: > > Hi Tom, > > I was unable to get signed tags working, but here is a list of changes: > Last time I wanted to have a try, but looks there was no enough documentation to start with. If we can have some detailed instructions about signed tags, that would be helpful. > - MPC83xx device tree additions (CPU and RAM) > - Fix sandbox build error > - Sync bitrev with Linux > - Various ofnode/DT improvements > > Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Stephen, On 17 July 2018 at 09:33, Stephen Warren wrote: > On 07/16/2018 10:40 PM, Simon Glass wrote: >> >> Hi Stephen, >> >> On 12 July 2018 at 15:26, Stephen Warren wrote: >>> >>> >>> On 07/12/2018 12:17 PM, Stephen Warren wrote: On 07/12/2018 09:52 AM, Stephen Warren wrote: > > > On 07/11/2018 06:12 PM, Simon Glass wrote: >> >> >> Hi Stephen, >> >> On 11 July 2018 at 16:01, Stephen Warren >> wrote: >>> >>> >>> On 07/10/2018 02:24 PM, Simon Glass wrote: Hi Stephen, On 10 July 2018 at 13:53, Stephen Warren wrote: > > > > On 07/10/2018 12:47 PM, Tom Rini wrote: >> >> >> >> >> On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: >> >>> Hi Tom. >>> >>> Here are some test-coverage and DM core enhancements. Also it >>> adds a >>> way to access the binman definition from U-Boot. >>> >>> >>> The following changes since commit >>> 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: >>> >>> Prepare v2018.07 (2018-07-09 10:24:14 -0400) >>> >>> are available in the Git repository at: >>> >>> git://git.denx.de/u-boot-dm.git >>> >>> for you to fetch changes up to >>> 16b8d6b76992690c65c58dc8b0591496cc5e46ef: >>> >>> binman: Support updating the device tree with calc'd info >>> (2018-07-09 09:11:00 -0600) > > > > > > This pull has caused intermittent/random build errors on my Jenkins > system. > The log shows: > >> LD spl/u-boot-spl >> OBJCOPY spl/u-boot-spl-nodtb.bin >> COPYspl/u-boot-spl.bin >> BINMAN u-boot-tegra.bin >> BINMAN u-boot-nodtb-tegra.bin >> BINMAN u-boot-dtb-tegra.bin >> binman: pylibfdt error -9: FDT_ERR_BADMAGIC >> >> >> >> /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: >> recipe for target 'u-boot-tegra.bin' failed >> make[1]: *** [u-boot-tegra.bin] Error 1 >> make[1]: *** Waiting for unfinished jobs >> make[1]: Leaving directory >> >> >> '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' >> Makefile:148: recipe for target 'sub-make' failed >> make: *** [sub-make] Error 2 >> make: Leaving directory >> >> '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' > > > > > > This doesn't happen every time; my Jenkins system builds 25 > Tegra/sandbox > boards, yet a varying set of boards fail each time I trigger the > build: > Just > beaver the first time, then just colibri_t20 and ventana, then just > medcom-wide. Note that the system performs incremental builds, if > that > matters. That might be the fdt_resize() problem which David Gibson has just sorted out upstream. If you can run binman -D (to get a stack trace) that might help. I should be able to do a patch if that is the problem. >>> >>> >>> >>> >>> Is this the backtrace you're looking for? >>> [swarren@swarren-lx1 u-boot]$ CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- sh -c "make O=build-beaver -s beaver_defconfig && make O=build-beaver -s -j8" arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property binman: pylibfdt error -9: FDT_ERR_BADMAGIC Traceback (most recent call last): File "../tools/binman/binman", line 120, in RunBinman ret_code = control.Binman(options, args) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py", line 128, in Binman dtb = fdt.FdtScan(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 459, in FdtScan dtb = Fdt(fname) File
Re: [U-Boot] Please pull u-boot-dm
On Thu, Aug 09, 2018 at 08:29:13AM -0600, Simon Glass wrote: > Hi Tom, > > This includes Bin's PCI improvements, a patman fix and moving pylibfdt over > to match upstream. > > > The following changes since commit b1aad8dbe28415695b290726199681ced969c118: > > zynqmp: Add avnet_ultra96_rev1_defconfig to the lits of boards > (2018-08-07 11:36:39 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to 41d7535cba42cd88f3b04f8fbd4409e5a479076f: > > patman: Correct unit test failure (2018-08-08 12:49:36 +0100) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm (take 2)
On Thu, Aug 02, 2018 at 10:55:52AM -0600, Simon Glass wrote: > Hi Tom, > > Here is another attempt. The build is here: > > https://travis-ci.org/sglass68/u-boot/builds/410948863 > > > > The following changes since commit 61523dde17d1539b8ea361e25909acfdfc465155: > > Merge tag 'arc-updates-for-2018.09-rc2' of > git://git.denx.de/u-boot-arc (2018-08-01 09:26:15 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to cee02e6ff422fdb8b543a8097b84a9682785f46d: > > binman: Adjust _GetPropTree() parameters (2018-08-01 16:30:48 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Wed, Aug 01, 2018 at 12:50:57PM -0600, Simon Glass wrote: > Hi Tom. > > On 31 July 2018 at 06:42, Tom Rini wrote: > > > > On Mon, Jul 30, 2018 at 02:10:44PM -0600, Simon Glass wrote: > > > > > Hi Tom, > > > > > > Here are the binman changes, with the rename of the 'pos' property to > > > 'offset'. > > > > > > > > > The following changes since commit > > > 0e8a8a311020d317fcfcf594e8e3fb1598134593: > > > > > > Merge git://git.denx.de/u-boot-fsl-qoriq (2018-07-27 13:09:30 -0400) > > > > > > are available in the Git repository at: > > > > > > git://git.denx.de/u-boot-dm.git > > > > > > for you to fetch changes up to e824c2422356cc9656d714335fc9b7907c3dace7: > > > > > > binman: Adjust _GetPropTree() parameters (2018-07-30 10:28:07 -0600) > > > > > > > NAK, this seems to be introducing some failures: > > binman: Section '/binman/image1': Symbol '_binman_u_boot_any_prop_pos' > >in entry '/binman/image1/u-boot-spl': No such property 'pos' > > /home/trini/work/u-boot/u-boot/Makefile:1240: recipe for target > > 'u-boot-tegra.bin' failed > > make[1]: *** [u-boot-tegra.bin] Error 1 > > make[1]: Leaving directory '/tmp/colibri_t30' > > Makefile:148: recipe for target 'sub-make' failed > > make: *** [sub-make] Error 2 > > I'm sorry about that. I saw the failure and thought it was device tree > stuff. Oops. > > Do you know what is happening with all the device-tree warnings? Are > they slowing going away? They're staying about constant. I looked before, and I guess these are also warnings in upstream Linux. In some cases a re-sync helps. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Tom. On 31 July 2018 at 06:42, Tom Rini wrote: > > On Mon, Jul 30, 2018 at 02:10:44PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > Here are the binman changes, with the rename of the 'pos' property to > > 'offset'. > > > > > > The following changes since commit 0e8a8a311020d317fcfcf594e8e3fb1598134593: > > > > Merge git://git.denx.de/u-boot-fsl-qoriq (2018-07-27 13:09:30 -0400) > > > > are available in the Git repository at: > > > > git://git.denx.de/u-boot-dm.git > > > > for you to fetch changes up to e824c2422356cc9656d714335fc9b7907c3dace7: > > > > binman: Adjust _GetPropTree() parameters (2018-07-30 10:28:07 -0600) > > > > NAK, this seems to be introducing some failures: > binman: Section '/binman/image1': Symbol '_binman_u_boot_any_prop_pos' >in entry '/binman/image1/u-boot-spl': No such property 'pos' > /home/trini/work/u-boot/u-boot/Makefile:1240: recipe for target > 'u-boot-tegra.bin' failed > make[1]: *** [u-boot-tegra.bin] Error 1 > make[1]: Leaving directory '/tmp/colibri_t30' > Makefile:148: recipe for target 'sub-make' failed > make: *** [sub-make] Error 2 I'm sorry about that. I saw the failure and thought it was device tree stuff. Oops. Do you know what is happening with all the device-tree warnings? Are they slowing going away? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Mon, Jul 30, 2018 at 02:10:44PM -0600, Simon Glass wrote: > Hi Tom, > > Here are the binman changes, with the rename of the 'pos' property to > 'offset'. > > > The following changes since commit 0e8a8a311020d317fcfcf594e8e3fb1598134593: > > Merge git://git.denx.de/u-boot-fsl-qoriq (2018-07-27 13:09:30 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to e824c2422356cc9656d714335fc9b7907c3dace7: > > binman: Adjust _GetPropTree() parameters (2018-07-30 10:28:07 -0600) > NAK, this seems to be introducing some failures: binman: Section '/binman/image1': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image1/u-boot-spl': No such property 'pos' /home/trini/work/u-boot/u-boot/Makefile:1240: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: Leaving directory '/tmp/colibri_t30' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Jul 26, 2018 at 06:36:12PM -0600, Simon Glass wrote: > Hi Tom, > > Just a few small things. > > > The following changes since commit 0dd1fc09bb16869fd8adaaad082cd554c60b2c1a: > > board/imgtec/boston: Add new defconfigs to the MAINTAINERS list > (2018-07-20 15:55:10 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to ab948cd21d25ba2f54832fc98a59eea90e680eba: > > fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS (2018-07-26 > 14:20:27 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 07/16/2018 10:40 PM, Simon Glass wrote: Hi Stephen, On 12 July 2018 at 15:26, Stephen Warren wrote: On 07/12/2018 12:17 PM, Stephen Warren wrote: On 07/12/2018 09:52 AM, Stephen Warren wrote: On 07/11/2018 06:12 PM, Simon Glass wrote: Hi Stephen, On 11 July 2018 at 16:01, Stephen Warren wrote: On 07/10/2018 02:24 PM, Simon Glass wrote: Hi Stephen, On 10 July 2018 at 13:53, Stephen Warren wrote: On 07/10/2018 12:47 PM, Tom Rini wrote: On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: Hi Tom. Here are some test-coverage and DM core enhancements. Also it adds a way to access the binman definition from U-Boot. The following changes since commit 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: Prepare v2018.07 (2018-07-09 10:24:14 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git for you to fetch changes up to 16b8d6b76992690c65c58dc8b0591496cc5e46ef: binman: Support updating the device tree with calc'd info (2018-07-09 09:11:00 -0600) This pull has caused intermittent/random build errors on my Jenkins system. The log shows: LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin BINMAN u-boot-nodtb-tegra.bin BINMAN u-boot-dtb-tegra.bin binman: pylibfdt error -9: FDT_ERR_BADMAGIC /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs make[1]: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' This doesn't happen every time; my Jenkins system builds 25 Tegra/sandbox boards, yet a varying set of boards fail each time I trigger the build: Just beaver the first time, then just colibri_t20 and ventana, then just medcom-wide. Note that the system performs incremental builds, if that matters. That might be the fdt_resize() problem which David Gibson has just sorted out upstream. If you can run binman -D (to get a stack trace) that might help. I should be able to do a patch if that is the problem. Is this the backtrace you're looking for? [swarren@swarren-lx1 u-boot]$ CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- sh -c "make O=build-beaver -s beaver_defconfig && make O=build-beaver -s -j8" arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property binman: pylibfdt error -9: FDT_ERR_BADMAGIC Traceback (most recent call last): File "../tools/binman/binman", line 120, in RunBinman ret_code = control.Binman(options, args) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py", line 128, in Binman dtb = fdt.FdtScan(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 459, in FdtScan dtb = Fdt(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 315, in __init__ self._fdt_obj = libfdt.Fdt(fd.read()) File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__ check_err(fdt_check_header(self._fdt)); File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err raise FdtException(val) FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC /home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs Thanks for that. But actually that is not something I have seen or can explain. Here it is reading the DT at the start and somehow failing in the check. That DT is created by the U-Boot build system. Is it possible that your system has its own libfdt installed? As it happened, the pylibfdt changes have been applied upstream today, so I'll prepare a patch to sync U-Boot up with that. Hopefully that will resolve any issues, but I am not sure. I have the standard Ubuntu 16.04 packages installed, but no non-standard local builds: device-tree-compiler 1.4.0+dfsg-2 libfdt1:amd641.4.0+dfsg-2 I suspect this is a missing dependency in the makefiles, or perhaps some process isn't waiting for its child to exit. The code that's finding the bad FDT magic appears to be reading from a file that hasn't yet been written
Re: [U-Boot] Please pull u-boot-dm
Hi Stephen, On 12 July 2018 at 15:26, Stephen Warren wrote: > > On 07/12/2018 12:17 PM, Stephen Warren wrote: >> >> On 07/12/2018 09:52 AM, Stephen Warren wrote: >>> >>> On 07/11/2018 06:12 PM, Simon Glass wrote: Hi Stephen, On 11 July 2018 at 16:01, Stephen Warren wrote: > > On 07/10/2018 02:24 PM, Simon Glass wrote: >> >> >> Hi Stephen, >> >> On 10 July 2018 at 13:53, Stephen Warren wrote: >>> >>> >>> On 07/10/2018 12:47 PM, Tom Rini wrote: On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: > Hi Tom. > > Here are some test-coverage and DM core enhancements. Also it adds a > way to access the binman definition from U-Boot. > > > The following changes since commit > 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: > > Prepare v2018.07 (2018-07-09 10:24:14 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to > 16b8d6b76992690c65c58dc8b0591496cc5e46ef: > > binman: Support updating the device tree with calc'd info > (2018-07-09 09:11:00 -0600) >>> >>> >>> >>> >>> This pull has caused intermittent/random build errors on my Jenkins >>> system. >>> The log shows: >>> LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin BINMAN u-boot-nodtb-tegra.bin BINMAN u-boot-dtb-tegra.bin binman: pylibfdt error -9: FDT_ERR_BADMAGIC /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs make[1]: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' >>> >>> >>> >>> >>> This doesn't happen every time; my Jenkins system builds 25 >>> Tegra/sandbox >>> boards, yet a varying set of boards fail each time I trigger the build: >>> Just >>> beaver the first time, then just colibri_t20 and ventana, then just >>> medcom-wide. Note that the system performs incremental builds, if that >>> matters. >> >> >> >> That might be the fdt_resize() problem which David Gibson has just >> sorted out upstream. If you can run binman -D (to get a stack trace) >> that might help. I should be able to do a patch if that is the >> problem. > > > > Is this the backtrace you're looking for? > >> [swarren@swarren-lx1 u-boot]$ >> CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- >> sh -c "make O=build-beaver -s beaver_defconfig && make O=build-beaver -s >> -j8" >> arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size): >> /i2c@7000d000/tps65911@2d/regulators: unnecessary >> #address-cells/#size-cells >> without "ranges" or child "reg" property >> arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size): >> /i2c@7000d000/tps65911@2d/regulators: unnecessary >> #address-cells/#size-cells >> without "ranges" or child "reg" property >> binman: pylibfdt error -9: FDT_ERR_BADMAGIC >> >> Traceback (most recent call last): >>File "../tools/binman/binman", line 120, in RunBinman >> ret_code = control.Binman(options, args) >>File >> "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py", >> line 128, in Binman >> dtb = fdt.FdtScan(fname) >>File >> "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", >> line 459, in FdtScan >> dtb = Fdt(fname) >>File >> "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", >> line 315, in __init__ >> self._fdt_obj = libfdt.Fdt(fd.read()) >>File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__ >> check_err(fdt_check_header(self._fdt)); >>File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err >> raise FdtException(val) >> FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC >> /home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244: >> recipe for target 'u-boot-tegra.bin' failed >> make[1]: *** [u-boot-tegra.bin] Error 1 >> make[1]: ***
Re: [U-Boot] Please pull u-boot-dm
On 07/12/2018 12:17 PM, Stephen Warren wrote:
On 07/12/2018 09:52 AM, Stephen Warren wrote:
On 07/11/2018 06:12 PM, Simon Glass wrote:
Hi Stephen,
On 11 July 2018 at 16:01, Stephen Warren wrote:
On 07/10/2018 02:24 PM, Simon Glass wrote:
Hi Stephen,
On 10 July 2018 at 13:53, Stephen Warren
wrote:
On 07/10/2018 12:47 PM, Tom Rini wrote:
On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote:
Hi Tom.
Here are some test-coverage and DM core enhancements. Also it
adds a
way to access the binman definition from U-Boot.
The following changes since commit
8c5d4fd0ec222701598a27b26ab7265d4cee45a3:
Prepare v2018.07 (2018-07-09 10:24:14 -0400)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to
16b8d6b76992690c65c58dc8b0591496cc5e46ef:
binman: Support updating the device tree with calc'd info
(2018-07-09 09:11:00 -0600)
This pull has caused intermittent/random build errors on my Jenkins
system.
The log shows:
LD spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
BINMAN u-boot-tegra.bin
BINMAN u-boot-nodtb-tegra.bin
BINMAN u-boot-dtb-tegra.bin
binman: pylibfdt error -9: FDT_ERR_BADMAGIC
/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244:
recipe for target 'u-boot-tegra.bin' failed
make[1]: *** [u-boot-tegra.bin] Error 1
make[1]: *** Waiting for unfinished jobs
make[1]: Leaving directory
'/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver'
Makefile:148: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
make: Leaving directory
'/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot'
This doesn't happen every time; my Jenkins system builds 25
Tegra/sandbox
boards, yet a varying set of boards fail each time I trigger the
build:
Just
beaver the first time, then just colibri_t20 and ventana, then just
medcom-wide. Note that the system performs incremental builds, if
that
matters.
That might be the fdt_resize() problem which David Gibson has just
sorted out upstream. If you can run binman -D (to get a stack trace)
that might help. I should be able to do a patch if that is the
problem.
Is this the backtrace you're looking for?
[swarren@swarren-lx1 u-boot]$
CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf-
sh -c "make O=build-beaver -s beaver_defconfig && make
O=build-beaver -s
-j8"
arch/arm/dts/tegra30-apalis.dtb: Warning
(avoid_unnecessary_addr_size):
/i2c@7000d000/tps65911@2d/regulators: unnecessary
#address-cells/#size-cells
without "ranges" or child "reg" property
arch/arm/dts/tegra30-beaver.dtb: Warning
(avoid_unnecessary_addr_size):
/i2c@7000d000/tps65911@2d/regulators: unnecessary
#address-cells/#size-cells
without "ranges" or child "reg" property
binman: pylibfdt error -9: FDT_ERR_BADMAGIC
Traceback (most recent call last):
File "../tools/binman/binman", line 120, in RunBinman
ret_code = control.Binman(options, args)
File
"/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py",
line 128, in Binman
dtb = fdt.FdtScan(fname)
File
"/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py",
line 459, in FdtScan
dtb = Fdt(fname)
File
"/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py",
line 315, in __init__
self._fdt_obj = libfdt.Fdt(fd.read())
File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__
check_err(fdt_check_header(self._fdt));
File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err
raise FdtException(val)
FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC
/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244:
recipe for target 'u-boot-tegra.bin' failed
make[1]: *** [u-boot-tegra.bin] Error 1
make[1]: *** Waiting for unfinished jobs
Thanks for that. But actually that is not something I have seen or can
explain. Here it is reading the DT at the start and somehow failing in
the check. That DT is created by the U-Boot build system. Is it
possible that your system has its own libfdt installed?
As it happened, the pylibfdt changes have been applied upstream today,
so I'll prepare a patch to sync U-Boot up with that. Hopefully that
will resolve any issues, but I am not sure.
I have the standard Ubuntu 16.04 packages installed, but no
non-standard local builds:
device-tree-compiler 1.4.0+dfsg-2
libfdt1:amd64 1.4.0+dfsg-2
I suspect this is a missing dependency in the makefiles, or perhaps some
process isn't waiting for its child to exit. The code that's finding the
bad FDT magic appears to be reading from a file that hasn't yet been
written yet:
[pid 26251] execve("../tools/binman/binman",
["../tools/binman/binman", "-d", "u-boot.dtb", "-O",
Re: [U-Boot] Please pull u-boot-dm
On 07/12/2018 09:52 AM, Stephen Warren wrote:
On 07/11/2018 06:12 PM, Simon Glass wrote:
Hi Stephen,
On 11 July 2018 at 16:01, Stephen Warren wrote:
On 07/10/2018 02:24 PM, Simon Glass wrote:
Hi Stephen,
On 10 July 2018 at 13:53, Stephen Warren wrote:
On 07/10/2018 12:47 PM, Tom Rini wrote:
On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote:
Hi Tom.
Here are some test-coverage and DM core enhancements. Also it adds a
way to access the binman definition from U-Boot.
The following changes since commit
8c5d4fd0ec222701598a27b26ab7265d4cee45a3:
Prepare v2018.07 (2018-07-09 10:24:14 -0400)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to
16b8d6b76992690c65c58dc8b0591496cc5e46ef:
binman: Support updating the device tree with calc'd info
(2018-07-09 09:11:00 -0600)
This pull has caused intermittent/random build errors on my Jenkins
system.
The log shows:
LD spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
BINMAN u-boot-tegra.bin
BINMAN u-boot-nodtb-tegra.bin
BINMAN u-boot-dtb-tegra.bin
binman: pylibfdt error -9: FDT_ERR_BADMAGIC
/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244:
recipe for target 'u-boot-tegra.bin' failed
make[1]: *** [u-boot-tegra.bin] Error 1
make[1]: *** Waiting for unfinished jobs
make[1]: Leaving directory
'/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver'
Makefile:148: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
make: Leaving directory
'/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot'
This doesn't happen every time; my Jenkins system builds 25
Tegra/sandbox
boards, yet a varying set of boards fail each time I trigger the
build:
Just
beaver the first time, then just colibri_t20 and ventana, then just
medcom-wide. Note that the system performs incremental builds, if that
matters.
That might be the fdt_resize() problem which David Gibson has just
sorted out upstream. If you can run binman -D (to get a stack trace)
that might help. I should be able to do a patch if that is the
problem.
Is this the backtrace you're looking for?
[swarren@swarren-lx1 u-boot]$
CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf-
sh -c "make O=build-beaver -s beaver_defconfig && make
O=build-beaver -s
-j8"
arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size):
/i2c@7000d000/tps65911@2d/regulators: unnecessary
#address-cells/#size-cells
without "ranges" or child "reg" property
arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size):
/i2c@7000d000/tps65911@2d/regulators: unnecessary
#address-cells/#size-cells
without "ranges" or child "reg" property
binman: pylibfdt error -9: FDT_ERR_BADMAGIC
Traceback (most recent call last):
File "../tools/binman/binman", line 120, in RunBinman
ret_code = control.Binman(options, args)
File
"/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py",
line 128, in Binman
dtb = fdt.FdtScan(fname)
File
"/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py",
line 459, in FdtScan
dtb = Fdt(fname)
File
"/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py",
line 315, in __init__
self._fdt_obj = libfdt.Fdt(fd.read())
File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__
check_err(fdt_check_header(self._fdt));
File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err
raise FdtException(val)
FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC
/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244:
recipe for target 'u-boot-tegra.bin' failed
make[1]: *** [u-boot-tegra.bin] Error 1
make[1]: *** Waiting for unfinished jobs
Thanks for that. But actually that is not something I have seen or can
explain. Here it is reading the DT at the start and somehow failing in
the check. That DT is created by the U-Boot build system. Is it
possible that your system has its own libfdt installed?
As it happened, the pylibfdt changes have been applied upstream today,
so I'll prepare a patch to sync U-Boot up with that. Hopefully that
will resolve any issues, but I am not sure.
I have the standard Ubuntu 16.04 packages installed, but no non-standard
local builds:
device-tree-compiler 1.4.0+dfsg-2
libfdt1:amd64 1.4.0+dfsg-2
I suspect this is a missing dependency in the makefiles, or perhaps some
process isn't waiting for its child to exit. The code that's finding the
bad FDT magic appears to be reading from a file that hasn't yet been
written yet:
[pid 26251] execve("../tools/binman/binman", ["../tools/binman/binman", "-d", "u-boot.dtb", "-O", ".", "-I", ".",
"-I", "../board/nvidia/beaver",
Re: [U-Boot] Please pull u-boot-dm
On 07/11/2018 06:12 PM, Simon Glass wrote: Hi Stephen, On 11 July 2018 at 16:01, Stephen Warren wrote: On 07/10/2018 02:24 PM, Simon Glass wrote: Hi Stephen, On 10 July 2018 at 13:53, Stephen Warren wrote: On 07/10/2018 12:47 PM, Tom Rini wrote: On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: Hi Tom. Here are some test-coverage and DM core enhancements. Also it adds a way to access the binman definition from U-Boot. The following changes since commit 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: Prepare v2018.07 (2018-07-09 10:24:14 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git for you to fetch changes up to 16b8d6b76992690c65c58dc8b0591496cc5e46ef: binman: Support updating the device tree with calc'd info (2018-07-09 09:11:00 -0600) This pull has caused intermittent/random build errors on my Jenkins system. The log shows: LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin BINMAN u-boot-nodtb-tegra.bin BINMAN u-boot-dtb-tegra.bin binman: pylibfdt error -9: FDT_ERR_BADMAGIC /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs make[1]: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' This doesn't happen every time; my Jenkins system builds 25 Tegra/sandbox boards, yet a varying set of boards fail each time I trigger the build: Just beaver the first time, then just colibri_t20 and ventana, then just medcom-wide. Note that the system performs incremental builds, if that matters. That might be the fdt_resize() problem which David Gibson has just sorted out upstream. If you can run binman -D (to get a stack trace) that might help. I should be able to do a patch if that is the problem. Is this the backtrace you're looking for? [swarren@swarren-lx1 u-boot]$ CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- sh -c "make O=build-beaver -s beaver_defconfig && make O=build-beaver -s -j8" arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property binman: pylibfdt error -9: FDT_ERR_BADMAGIC Traceback (most recent call last): File "../tools/binman/binman", line 120, in RunBinman ret_code = control.Binman(options, args) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py", line 128, in Binman dtb = fdt.FdtScan(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 459, in FdtScan dtb = Fdt(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 315, in __init__ self._fdt_obj = libfdt.Fdt(fd.read()) File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__ check_err(fdt_check_header(self._fdt)); File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err raise FdtException(val) FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC /home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs Thanks for that. But actually that is not something I have seen or can explain. Here it is reading the DT at the start and somehow failing in the check. That DT is created by the U-Boot build system. Is it possible that your system has its own libfdt installed? As it happened, the pylibfdt changes have been applied upstream today, so I'll prepare a patch to sync U-Boot up with that. Hopefully that will resolve any issues, but I am not sure. I have the standard Ubuntu 16.04 packages installed, but no non-standard local builds: device-tree-compiler 1.4.0+dfsg-2 libfdt1:amd641.4.0+dfsg-2 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Tue, Jul 10, 2018 at 02:58:16PM -0600, Simon Glass wrote: > Hi Tom, > > Here are some Python 3 fixes as mentioned on irc. I've left out the > two which cause problems. > > Travis run is here: > > https://travis-ci.org/sglass68/u-boot/builds/402281566 > > > The following changes since commit e3396ffd720877976141fa0b76a0b8ee9643d7d1: > > Merge git://git.denx.de/u-boot-dm (2018-07-10 10:29:14 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to 8793631ec13ee9e6c7189a7bdca38dde7b4390a8: > > test/py: vboot: Remove stderr redirect from openssl command > (2018-07-10 14:50:50 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
Hi Stephen, On 11 July 2018 at 16:01, Stephen Warren wrote: > On 07/10/2018 02:24 PM, Simon Glass wrote: >> >> Hi Stephen, >> >> On 10 July 2018 at 13:53, Stephen Warren wrote: >>> >>> On 07/10/2018 12:47 PM, Tom Rini wrote: On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: > Hi Tom. > > Here are some test-coverage and DM core enhancements. Also it adds a > way to access the binman definition from U-Boot. > > > The following changes since commit > 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: > > Prepare v2018.07 (2018-07-09 10:24:14 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to > 16b8d6b76992690c65c58dc8b0591496cc5e46ef: > > binman: Support updating the device tree with calc'd info > (2018-07-09 09:11:00 -0600) >>> >>> >>> >>> This pull has caused intermittent/random build errors on my Jenkins >>> system. >>> The log shows: >>> LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin BINMAN u-boot-nodtb-tegra.bin BINMAN u-boot-dtb-tegra.bin binman: pylibfdt error -9: FDT_ERR_BADMAGIC /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs make[1]: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' >>> >>> >>> >>> This doesn't happen every time; my Jenkins system builds 25 Tegra/sandbox >>> boards, yet a varying set of boards fail each time I trigger the build: >>> Just >>> beaver the first time, then just colibri_t20 and ventana, then just >>> medcom-wide. Note that the system performs incremental builds, if that >>> matters. >> >> >> That might be the fdt_resize() problem which David Gibson has just >> sorted out upstream. If you can run binman -D (to get a stack trace) >> that might help. I should be able to do a patch if that is the >> problem. > > > Is this the backtrace you're looking for? > >> [swarren@swarren-lx1 u-boot]$ >> CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- >> sh -c "make O=build-beaver -s beaver_defconfig && make O=build-beaver -s >> -j8" >> arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size): >> /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells >> without "ranges" or child "reg" property >> arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size): >> /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells >> without "ranges" or child "reg" property >> binman: pylibfdt error -9: FDT_ERR_BADMAGIC >> >> Traceback (most recent call last): >> File "../tools/binman/binman", line 120, in RunBinman >> ret_code = control.Binman(options, args) >> File >> "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py", >> line 128, in Binman >> dtb = fdt.FdtScan(fname) >> File >> "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", >> line 459, in FdtScan >> dtb = Fdt(fname) >> File >> "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", >> line 315, in __init__ >> self._fdt_obj = libfdt.Fdt(fd.read()) >> File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__ >> check_err(fdt_check_header(self._fdt)); >> File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err >> raise FdtException(val) >> FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC >> /home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244: >> recipe for target 'u-boot-tegra.bin' failed >> make[1]: *** [u-boot-tegra.bin] Error 1 >> make[1]: *** Waiting for unfinished jobs Thanks for that. But actually that is not something I have seen or can explain. Here it is reading the DT at the start and somehow failing in the check. That DT is created by the U-Boot build system. Is it possible that your system has its own libfdt installed? As it happened, the pylibfdt changes have been applied upstream today, so I'll prepare a patch to sync U-Boot up with that. Hopefully that will resolve any issues, but I am not sure. [..] Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 07/10/2018 02:24 PM, Simon Glass wrote: Hi Stephen, On 10 July 2018 at 13:53, Stephen Warren wrote: On 07/10/2018 12:47 PM, Tom Rini wrote: On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: Hi Tom. Here are some test-coverage and DM core enhancements. Also it adds a way to access the binman definition from U-Boot. The following changes since commit 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: Prepare v2018.07 (2018-07-09 10:24:14 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git for you to fetch changes up to 16b8d6b76992690c65c58dc8b0591496cc5e46ef: binman: Support updating the device tree with calc'd info (2018-07-09 09:11:00 -0600) This pull has caused intermittent/random build errors on my Jenkins system. The log shows: LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin BINMAN u-boot-nodtb-tegra.bin BINMAN u-boot-dtb-tegra.bin binman: pylibfdt error -9: FDT_ERR_BADMAGIC /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs make[1]: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' This doesn't happen every time; my Jenkins system builds 25 Tegra/sandbox boards, yet a varying set of boards fail each time I trigger the build: Just beaver the first time, then just colibri_t20 and ventana, then just medcom-wide. Note that the system performs incremental builds, if that matters. That might be the fdt_resize() problem which David Gibson has just sorted out upstream. If you can run binman -D (to get a stack trace) that might help. I should be able to do a patch if that is the problem. Is this the backtrace you're looking for? [swarren@swarren-lx1 u-boot]$ CROSS_COMPILE=/home/swarren/shared/gcc-linaro-7.2.1-2017.11-i686_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- sh -c "make O=build-beaver -s beaver_defconfig && make O=build-beaver -s -j8" arch/arm/dts/tegra30-apalis.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property arch/arm/dts/tegra30-beaver.dtb: Warning (avoid_unnecessary_addr_size): /i2c@7000d000/tps65911@2d/regulators: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property binman: pylibfdt error -9: FDT_ERR_BADMAGIC Traceback (most recent call last): File "../tools/binman/binman", line 120, in RunBinman ret_code = control.Binman(options, args) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/control.py", line 128, in Binman dtb = fdt.FdtScan(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 459, in FdtScan dtb = Fdt(fname) File "/home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/tools/binman/../dtoc/fdt.py", line 315, in __init__ self._fdt_obj = libfdt.Fdt(fd.read()) File "scripts/dtc/pylibfdt/libfdt.py", line 207, in __init__ check_err(fdt_check_header(self._fdt)); File "scripts/dtc/pylibfdt/libfdt.py", line 160, in check_err raise FdtException(val) FdtException: pylibfdt error -9: FDT_ERR_BADMAGIC /home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs Section '/binman/image1': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image1/u-boot-spl': insert _binman_u_boot_any_prop_pos, offset 592c, value 8011, length 4 Section '/binman/image1': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image1/u-boot-spl': insert _binman_u_boot_any_prop_pos, offset 592c, value 8011, length 4 Section '/binman/image2': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image2/u-boot-spl': insert _binman_u_boot_any_prop_pos, offset 592c, value 8011, length 4 Section '/binman/image2': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image2/u-boot-spl': insert _binman_u_boot_any_prop_pos, offset 592c, value 8011, length 4 Section '/binman/image3': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image3/u-boot-spl': insert _binman_u_boot_any_prop_pos, offset 592c, value 8011, length 4 Section '/binman/image3': Symbol '_binman_u_boot_any_prop_pos' in entry '/binman/image3/u-boot-spl': insert _binman_u_boot_any_prop_pos, offset 592c, value 8011, length 4 Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 ___ U-Boot mailing list
Re: [U-Boot] Please pull u-boot-dm
Hi Stephen, On 10 July 2018 at 13:53, Stephen Warren wrote: > On 07/10/2018 12:47 PM, Tom Rini wrote: >> >> On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: >> >>> Hi Tom. >>> >>> Here are some test-coverage and DM core enhancements. Also it adds a >>> way to access the binman definition from U-Boot. >>> >>> >>> The following changes since commit >>> 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: >>> >>>Prepare v2018.07 (2018-07-09 10:24:14 -0400) >>> >>> are available in the Git repository at: >>> >>>git://git.denx.de/u-boot-dm.git >>> >>> for you to fetch changes up to 16b8d6b76992690c65c58dc8b0591496cc5e46ef: >>> >>>binman: Support updating the device tree with calc'd info >>> (2018-07-09 09:11:00 -0600) > > > This pull has caused intermittent/random build errors on my Jenkins system. > The log shows: > >> LD spl/u-boot-spl >> OBJCOPY spl/u-boot-spl-nodtb.bin >> COPYspl/u-boot-spl.bin >> BINMAN u-boot-tegra.bin >> BINMAN u-boot-nodtb-tegra.bin >> BINMAN u-boot-dtb-tegra.bin >> binman: pylibfdt error -9: FDT_ERR_BADMAGIC >> >> /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: >> recipe for target 'u-boot-tegra.bin' failed >> make[1]: *** [u-boot-tegra.bin] Error 1 >> make[1]: *** Waiting for unfinished jobs >> make[1]: Leaving directory >> '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' >> Makefile:148: recipe for target 'sub-make' failed >> make: *** [sub-make] Error 2 >> make: Leaving directory >> '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' > > > This doesn't happen every time; my Jenkins system builds 25 Tegra/sandbox > boards, yet a varying set of boards fail each time I trigger the build: Just > beaver the first time, then just colibri_t20 and ventana, then just > medcom-wide. Note that the system performs incremental builds, if that > matters. That might be the fdt_resize() problem which David Gibson has just sorted out upstream. If you can run binman -D (to get a stack trace) that might help. I should be able to do a patch if that is the problem. That said, I'm working on getting the real pylibffdt applied upstream, hopefully will not be too much longer. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 07/10/2018 12:47 PM, Tom Rini wrote: On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote: Hi Tom. Here are some test-coverage and DM core enhancements. Also it adds a way to access the binman definition from U-Boot. The following changes since commit 8c5d4fd0ec222701598a27b26ab7265d4cee45a3: Prepare v2018.07 (2018-07-09 10:24:14 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git for you to fetch changes up to 16b8d6b76992690c65c58dc8b0591496cc5e46ef: binman: Support updating the device tree with calc'd info (2018-07-09 09:11:00 -0600) This pull has caused intermittent/random build errors on my Jenkins system. The log shows: LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin COPYspl/u-boot-spl.bin BINMAN u-boot-tegra.bin BINMAN u-boot-nodtb-tegra.bin BINMAN u-boot-dtb-tegra.bin binman: pylibfdt error -9: FDT_ERR_BADMAGIC /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/Makefile:1244: recipe for target 'u-boot-tegra.bin' failed make[1]: *** [u-boot-tegra.bin] Error 1 make[1]: *** Waiting for unfinished jobs make[1]: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/build/u-boot/beaver' Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Leaving directory '/var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot' This doesn't happen every time; my Jenkins system builds 25 Tegra/sandbox boards, yet a varying set of boards fail each time I trigger the build: Just beaver the first time, then just colibri_t20 and ventana, then just medcom-wide. Note that the system performs incremental builds, if that matters. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Mon, Jul 09, 2018 at 01:53:43PM -0600, Simon Glass wrote:
> Hi Tom.
>
> Here are some test-coverage and DM core enhancements. Also it adds a
> way to access the binman definition from U-Boot.
>
>
> The following changes since commit 8c5d4fd0ec222701598a27b26ab7265d4cee45a3:
>
> Prepare v2018.07 (2018-07-09 10:24:14 -0400)
>
> are available in the Git repository at:
>
> git://git.denx.de/u-boot-dm.git
>
> for you to fetch changes up to 16b8d6b76992690c65c58dc8b0591496cc5e46ef:
>
> binman: Support updating the device tree with calc'd info
> (2018-07-09 09:11:00 -0600)
>
Applied to u-boot/master, thanks!
That said, I see that this is a non-fatal error:
Checking: https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/
Traceback (most recent call last):
File "/home/trini/work/u-boot/u-boot/tools/buildman/test.py", line 426, in
testToolchainDownload
self.toolchains.LocateArchUrl('arm'))
AssertionError:
'https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz'
!=
'https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_arm-linux-gnueabi.tar.xz'
Which I think we should fix and make a fatal error. If it's a test and it
fails and it's not fatal, CI/etc won't catch it. Thanks!
--
Tom
signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On 9 July 2018 at 13:53, Simon Glass wrote: > Hi Tom. > > Here are some test-coverage and DM core enhancements. Also it adds a > way to access the binman definition from U-Boot. https://travis-ci.org/sglass68/u-boot/builds/401827625 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Sun, Jun 24, 2018 at 08:42:28PM -0600, Simon Glass wrote: > Hi Tom, > > A few patman enhancements. > > > The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392: > > Merge branch 'master' of git://git.denx.de/u-boot-uniphier > (2018-06-22 13:12:53 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to a60aedfd31722f835dc834f9f2f60882beb96991: > > patman: Support using a particular SMTP server (2018-06-23 08:03:43 -0600) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-dm
On Thu, Jun 07, 2018 at 03:18:29PM -0800, Simon Glass wrote: > Hi Tom, > > Here are the binman patches (support for hierarchical images and map > files), buildman environment support and a few test fixes. > > As you know there are more test fixes to come once we figure things out. > > > > The following changes since commit 3eceff642c01e03e055127c9cf21608faaff28ac: > > Merge branch 'master' of git://git.denx.de/u-boot-samsung > (2018-06-06 09:08:16 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to 844e5b20f2691eccce9ac8f7e3732bbb5d0ac757: > > binman: Mark 'align-end' as implemented (2018-06-07 11:25:08 -0800) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
