Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Goldschmidt]

On Wed, Jul 24, 2019 at 10:22 PM Tom Rini  wrote:
>
> On Wed, Jul 24, 2019 at 10:09:29PM +0200, Simon Goldschmidt wrote:
> > Am 24.07.2019 um 22:03 schrieb Simon Glass:
> > >Hi Tom,
> > >
> > >On Wed, 24 Jul 2019 at 10:13, Tom Rini  wrote:
> > >>
> > >>On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote:
> > >>
> > >>>Hi Tom,
> > >>>
> > >>>This includes the gitlab fix and also I updated ifwitool.c to drop the
> > >>>unused inline functions.
> > >>>
> > >>>
> > >>>The following changes since commit 
> > >>>ff8c23e784f57a7098e91a200ed7f5a48612b653:
> > >>>
> > >>>   Merge tag 'u-boot-stm32-20190723' of
> > >>>https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23
> > >>>14:16:21 -0400)
> > >>>
> > >>>are available in the Git repository at:
> > >>>
> > >>>   git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2
> > >>>
> > >>>for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2:
> > >>>
> > >>>   dm: device: make power domain calls optional (2019-07-23 20:27:58 
> > >>> -0700)
> > >>>
> > >>
> > >>We're still not there yet, sorry.  Taking a look at
> > >>https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running
> > >>things but ifwitool is failing.  Can you please take a look?  You will
> > >>need the patch I posted that brings us up to a newer image that has
> > >>lzma-alone. Thanks!
> > >
> > >OK, this is another update that is needed to the gitlab config, this
> > >time the --toolpath argument. Will send an update.
> > >
> > >I was rather hoping that pushing to gitlab u-boot-dm would start a
> > >build but it does not, for me. I probably need to do some more
> > >reading.
> > >
> > >BTW Is there an intent to shut down travis?
> >
> > Even if everyone seems to be switching to gitlab, can we keep the travis
> > config in the repository? That makes it easy for people (like me) creating a
> > github clone to ensure the world keeps building after a patch.
> >
> > Or is there a similar free and easy to use gitlab service comparable to
> > travis?
>
> So that's the rub.  There are free "runners" in GitLab terms for
> projects but they are limited in time to I think an hour per job, so we
> get back to the unmaintainable mess of splitting the build like we have
> on Travis.  Anyone can use their own machine as the runner, but that may
> or may not be faster or even slower than Travis is.

I can assure you using my own PC is not an option for me compared to Travis.
I don't know how many non-custodians there are using this (and I can probably
arrange with Marek to use socfpga custodian access), but having a free-to-use
CI seems worth much to me.

I don't know how much effort it is to keep and maintain the Travis config
files though...

Regards,
Simon

>
> --
> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Wed, Jul 24, 2019 at 10:09:29PM +0200, Simon Goldschmidt wrote:
> Am 24.07.2019 um 22:03 schrieb Simon Glass:
> >Hi Tom,
> >
> >On Wed, 24 Jul 2019 at 10:13, Tom Rini  wrote:
> >>
> >>On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote:
> >>
> >>>Hi Tom,
> >>>
> >>>This includes the gitlab fix and also I updated ifwitool.c to drop the
> >>>unused inline functions.
> >>>
> >>>
> >>>The following changes since commit 
> >>>ff8c23e784f57a7098e91a200ed7f5a48612b653:
> >>>
> >>>   Merge tag 'u-boot-stm32-20190723' of
> >>>https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23
> >>>14:16:21 -0400)
> >>>
> >>>are available in the Git repository at:
> >>>
> >>>   git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2
> >>>
> >>>for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2:
> >>>
> >>>   dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700)
> >>>
> >>
> >>We're still not there yet, sorry.  Taking a look at
> >>https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running
> >>things but ifwitool is failing.  Can you please take a look?  You will
> >>need the patch I posted that brings us up to a newer image that has
> >>lzma-alone. Thanks!
> >
> >OK, this is another update that is needed to the gitlab config, this
> >time the --toolpath argument. Will send an update.
> >
> >I was rather hoping that pushing to gitlab u-boot-dm would start a
> >build but it does not, for me. I probably need to do some more
> >reading.
> >
> >BTW Is there an intent to shut down travis?
> 
> Even if everyone seems to be switching to gitlab, can we keep the travis
> config in the repository? That makes it easy for people (like me) creating a
> github clone to ensure the world keeps building after a patch.
> 
> Or is there a similar free and easy to use gitlab service comparable to
> travis?

So that's the rub.  There are free "runners" in GitLab terms for
projects but they are limited in time to I think an hour per job, so we
get back to the unmaintainable mess of splitting the build like we have
on Travis.  Anyone can use their own machine as the runner, but that may
or may not be faster or even slower than Travis is.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Wed, Jul 24, 2019 at 01:03:20PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Wed, 24 Jul 2019 at 10:13, Tom Rini  wrote:
> >
> > On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote:
> >
> > > Hi Tom,
> > >
> > > This includes the gitlab fix and also I updated ifwitool.c to drop the
> > > unused inline functions.
> > >
> > >
> > > The following changes since commit 
> > > ff8c23e784f57a7098e91a200ed7f5a48612b653:
> > >
> > >   Merge tag 'u-boot-stm32-20190723' of
> > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23
> > > 14:16:21 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2
> > >
> > > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2:
> > >
> > >   dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700)
> > >
> >
> > We're still not there yet, sorry.  Taking a look at
> > https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running
> > things but ifwitool is failing.  Can you please take a look?  You will
> > need the patch I posted that brings us up to a newer image that has
> > lzma-alone. Thanks!
> 
> OK, this is another update that is needed to the gitlab config, this
> time the --toolpath argument. Will send an update.
> 
> I was rather hoping that pushing to gitlab u-boot-dm would start a
> build but it does not, for me. I probably need to do some more
> reading.

Take a look at the email I sent to the custodians list :)  You'll need
to flip a switch or two on the -dm tree for it to happen, and you can
provide more build power for just your tree in addition to the shared
runner we have currently.

> BTW Is there an intent to shut down travis?

As in remove the file?  Not immediately, no, there's still the question
of what to do about non-custodians being able to run CI before
submitting.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Goldschmidt]

Am 24.07.2019 um 22:03 schrieb Simon Glass:

Hi Tom,

On Wed, 24 Jul 2019 at 10:13, Tom Rini  wrote:


On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote:


Hi Tom,

This includes the gitlab fix and also I updated ifwitool.c to drop the
unused inline functions.


The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653:

   Merge tag 'u-boot-stm32-20190723' of
https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23
14:16:21 -0400)

are available in the Git repository at:

   git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2

for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2:

   dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700)



We're still not there yet, sorry.  Taking a look at
https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running
things but ifwitool is failing.  Can you please take a look?  You will
need the patch I posted that brings us up to a newer image that has
lzma-alone. Thanks!


OK, this is another update that is needed to the gitlab config, this
time the --toolpath argument. Will send an update.

I was rather hoping that pushing to gitlab u-boot-dm would start a
build but it does not, for me. I probably need to do some more
reading.

BTW Is there an intent to shut down travis?


Even if everyone seems to be switching to gitlab, can we keep the travis 
config in the repository? That makes it easy for people (like me) 
creating a github clone to ensure the world keeps building after a patch.


Or is there a similar free and easy to use gitlab service comparable to 
travis?


Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Glass]

Hi Tom,

On Wed, 24 Jul 2019 at 10:13, Tom Rini  wrote:
>
> On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote:
>
> > Hi Tom,
> >
> > This includes the gitlab fix and also I updated ifwitool.c to drop the
> > unused inline functions.
> >
> >
> > The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653:
> >
> >   Merge tag 'u-boot-stm32-20190723' of
> > https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23
> > 14:16:21 -0400)
> >
> > are available in the Git repository at:
> >
> >   git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2
> >
> > for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2:
> >
> >   dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700)
> >
>
> We're still not there yet, sorry.  Taking a look at
> https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running
> things but ifwitool is failing.  Can you please take a look?  You will
> need the patch I posted that brings us up to a newer image that has
> lzma-alone. Thanks!

OK, this is another update that is needed to the gitlab config, this
time the --toolpath argument. Will send an update.

I was rather hoping that pushing to gitlab u-boot-dm would start a
build but it does not, for me. I probably need to do some more
reading.

BTW Is there an intent to shut down travis?

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Tue, Jul 23, 2019 at 08:36:58PM -0700, Simon Glass wrote:

> Hi Tom,
> 
> This includes the gitlab fix and also I updated ifwitool.c to drop the
> unused inline functions.
> 
> 
> The following changes since commit ff8c23e784f57a7098e91a200ed7f5a48612b653:
> 
>   Merge tag 'u-boot-stm32-20190723' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2019-07-23
> 14:16:21 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-dm.git tags/dm-pull-23jul19-take2
> 
> for you to fetch changes up to 6e38047b66e37659b937cf301e0de37a90d9eaa2:
> 
>   dm: device: make power domain calls optional (2019-07-23 20:27:58 -0700)
> 

We're still not there yet, sorry.  Taking a look at
https://gitlab.denx.de/u-boot/u-boot/-/jobs/1464 we're now running
things but ifwitool is failing.  Can you please take a look?  You will
need the patch I posted that brings us up to a newer image that has
lzma-alone. Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Fri, Nov 30, 2018 at 12:29:18PM -0700, Simon Glass wrote:

> Hi Tom,
> 
> See:
> 
> https://travis-ci.org/sglass68/u-boot/builds/461837218?utm_medium=notification_source=email
> 
> 
> The following changes since commit e16c888fab5014b022d5781dc534f204460a073b:
> 
>   Merge branch '2018-11-28-master-imports' (2018-11-28 23:04:58 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-dm.git tags/pull-30nov18
> 
> for you to fetch changes up to 1678754f5e2cbc14f9612e953b39cc08ada66866:
> 
>   core: ofnode: Fix ofnode_get_addr_index function (2018-11-29 09:30:06
> -0700)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Thu, Aug 02, 2018 at 10:55:52AM -0600, Simon Glass wrote:

> Hi Tom,
> 
> Here is another attempt. The build is here:
> 
> https://travis-ci.org/sglass68/u-boot/builds/410948863
> 
> 
> 
> The following changes since commit 61523dde17d1539b8ea361e25909acfdfc465155:
> 
>   Merge tag 'arc-updates-for-2018.09-rc2' of
> git://git.denx.de/u-boot-arc (2018-08-01 09:26:15 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to cee02e6ff422fdb8b543a8097b84a9682785f46d:
> 
>   binman: Adjust _GetPropTree() parameters (2018-08-01 16:30:48 -0600)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Sun, Feb 04, 2018 at 05:36:33AM -0700, Simon Glass wrote:

> Hi Tom,
> 
> I've dropped sandbox64 for now and fixed the clang warnings.
> 
> 
> The following changes since commit b2153075f42c2d46d310778e226bcb11f0af47f5:
> 
>   Kconfig: usb: rockchip: Remove not needed *_defconfig USB/gadget
> entries (2018-02-02 07:13:48 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to 1973b381a1b3545783c3238080f566746579e923:
> 
>   log: add category LOGC_EFI (2018-02-03 10:09:28 -0700)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Wed, Dec 13, 2017 at 09:14:00AM -0700, Simon Glass wrote:

> Hi Tom,
> 
> I dropped the translation patch until Tegra can be fixed to work with
> it. This is storing up problems though, since in the meantime others
> might rely on the current behaviour.
> 
> https://travis-ci.org/sglass68/u-boot/builds/315684225
> 
> 
> The following changes since commit cf71338ee7a1dc16f13a4f1b89f32c624210df45:
> 
>   ata: Migrate CONFIG_MVSATA_IDE to Kconfig (2017-12-12 18:16:06 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to 854dfbf99b89c114ba100905e1500b8ace60e0f9:
> 
>   power: pmic/regulator: Add basic support for TPS65910 (2017-12-12
> 19:53:45 -0700)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Glass]

Hi Stephen,

On 13 December 2017 at 09:49, Stephen Warren  wrote:
> On 12/13/2017 09:14 AM, Simon Glass wrote:
>>
>> Hi Tom,
>>
>> I dropped the translation patch until Tegra can be fixed to work with
>> it. This is storing up problems though, since in the meantime others
>> might rely on the current behaviour.
>>
>> https://travis-ci.org/sglass68/u-boot/builds/315684225
>>
>>
>> The following changes since commit
>> cf71338ee7a1dc16f13a4f1b89f32c624210df45:
>>
>>ata: Migrate CONFIG_MVSATA_IDE to Kconfig (2017-12-12 18:16:06 -0500)
>>
>> are available in the Git repository at:
>>
>>git://git.denx.de/u-boot-dm.git
>>
>> for you to fetch changes up to 854dfbf99b89c114ba100905e1500b8ace60e0f9:
>>
>>power: pmic/regulator: Add basic support for TPS65910 (2017-12-12
>> 19:53:45 -0700)
>
>
> This version works fine for me.
>
> Note that I don't believe the Tegra code needs to be fixed to work with the
> translation patch. The Tegra code was working perfectly with the DT parsing
> code that existing before the conversion to livetree, and with the livetree
> code without the extra translation patch. I had to submit quite a few
> patches to fix the translation logic in the non-livetree DT parsing code to
> make sure it translated in the right circumstance and not in the others. The
> most likely issue is that the latest translation patch does the wrong thing.

OK I have replied on the thread for that patch:

"Add translation in live tree case"

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Glass]

Hi Tom,

On 14 December 2017 at 12:51, Tom Rini  wrote:
> On Wed, Dec 13, 2017 at 09:14:00AM -0700, Simon Glass wrote:
>
>> Hi Tom,
>>
>> I dropped the translation patch until Tegra can be fixed to work with
>> it. This is storing up problems though, since in the meantime others
>> might rely on the current behaviour.
>
> Is this building binman only when the board we're building for requires
> it?  Thanks!

binman itself doesn't need building (it is just Python). But it does
need the libfdt Python module. That is built if CONFIG_PYLIBFDT is
enabled, which it is if dtoc or binman are used. So I think it does
what you want.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Wed, Dec 13, 2017 at 09:14:00AM -0700, Simon Glass wrote:

> Hi Tom,
> 
> I dropped the translation patch until Tegra can be fixed to work with
> it. This is storing up problems though, since in the meantime others
> might rely on the current behaviour.

Is this building binman only when the board we're building for requires
it?  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Stephen Warren]

On 12/13/2017 09:14 AM, Simon Glass wrote:

Hi Tom,

I dropped the translation patch until Tegra can be fixed to work with
it. This is storing up problems though, since in the meantime others
might rely on the current behaviour.

https://travis-ci.org/sglass68/u-boot/builds/315684225


The following changes since commit cf71338ee7a1dc16f13a4f1b89f32c624210df45:

   ata: Migrate CONFIG_MVSATA_IDE to Kconfig (2017-12-12 18:16:06 -0500)

are available in the Git repository at:

   git://git.denx.de/u-boot-dm.git

for you to fetch changes up to 854dfbf99b89c114ba100905e1500b8ace60e0f9:

   power: pmic/regulator: Add basic support for TPS65910 (2017-12-12
19:53:45 -0700)


This version works fine for me.

Note that I don't believe the Tegra code needs to be fixed to work with 
the translation patch. The Tegra code was working perfectly with the DT 
parsing code that existing before the conversion to livetree, and with 
the livetree code without the extra translation patch. I had to submit 
quite a few patches to fix the translation logic in the non-livetree DT 
parsing code to make sure it translated in the right circumstance and 
not in the others. The most likely issue is that the latest translation 
patch does the wrong thing.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Mon, Oct 09, 2017 at 05:30:17PM -0600, Simon Glass wrote:

> Hi Tom,
> 
> Sorry for the delay with v2.
> 
> 
> The following changes since commit 0d3aaa35b87573c229d65bc79050ab13f39d8ec2:
> 
>   Travis-CI: Fix microblaze and xilinx jobs (2017-10-07 15:54:18 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to 04d0da51578e12bd7c490aa70ed581ee5f9dcfea:
> 
>   sandbox: avoid memory leak in os_dirent_ls (2017-10-08 20:41:09 -0600)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Fri, Jun 09, 2017 at 04:37:07PM -0600, Simon Glass wrote:

> Hi Tom,
> 
> This is without the two offending patches that broke BUILD_TAG. I'll figure
> out a sandbox test for this and resubmit those patches later.
> 
> 
> The following changes since commit 156d64fa55e9914b144c5e83f2a9e13d1223a4d3:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2017-06-08 12:14:11 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to 9620d87259572ef21f0df60988d9a932ca673779:
> 
>   cmd/fdt: support single value replacement within an array (2017-06-09
> 13:45:34 -0600)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Glass]

Hi Stephen,

On 9 June 2017 at 16:57, Stephen Warren  wrote:
> On 06/09/2017 04:37 PM, Simon Glass wrote:
>>
>> Hi Tom,
>>
>> This is without the two offending patches that broke BUILD_TAG. I'll
>> figure
>> out a sandbox test for this and resubmit those patches later.
>>
>>
>> The following changes since commit
>> 156d64fa55e9914b144c5e83f2a9e13d1223a4d3:
>>
>>Merge git://git.denx.de/u-boot-rockchip (2017-06-08 12:14:11 -0400)
>>
>> are available in the git repository at:
>>
>>git://git.denx.de/u-boot-dm.git
>>
>> for you to fetch changes up to 9620d87259572ef21f0df60988d9a932ca673779:
>>
>>cmd/fdt: support single value replacement within an array (2017-06-09
>> 13:45:34 -0600)
>
>
> This version passes my Jenkins tests OK.
>
> I did try to reproduce the issue in the original pull request, but wasn't
> able to immediately. It didn't seem to be solely/simply related to
> BUILD_TAG. Unfortunately, I have a few fire-fights going on so can't spend
> any more time on this today; perhaps next week.

Habeus corpus. I can repeat the problem on beaver - I don't get a
crash but I clearly see a stack overflow which I'm sure could cause a
crash.

The problem is that snprintf() returns the required buffer size rather
than the numberof bytes written to the buffer. I forgot about that.
I'll send an updated patch.

Of course the bigger problem is that my size is not large enough so I
will have to increase it (and thus hide the fault).

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Stephen Warren]

On 06/09/2017 04:37 PM, Simon Glass wrote:

Hi Tom,

This is without the two offending patches that broke BUILD_TAG. I'll figure
out a sandbox test for this and resubmit those patches later.


The following changes since commit 156d64fa55e9914b144c5e83f2a9e13d1223a4d3:

   Merge git://git.denx.de/u-boot-rockchip (2017-06-08 12:14:11 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-dm.git

for you to fetch changes up to 9620d87259572ef21f0df60988d9a932ca673779:

   cmd/fdt: support single value replacement within an array (2017-06-09
13:45:34 -0600)


This version passes my Jenkins tests OK.

I did try to reproduce the issue in the original pull request, but 
wasn't able to immediately. It didn't seem to be solely/simply related 
to BUILD_TAG. Unfortunately, I have a few fire-fights going on so can't 
spend any more time on this today; perhaps next week.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Tue, May 30, 2017 at 09:52:35PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On 28 May 2017 at 05:55, Tom Rini  wrote:
> > On Sat, May 27, 2017 at 04:01:29PM -0600, Simon Glass wrote:
> >
> >> Hi Tom,
> >>
> >> This is similar to the last attempt, but without this offending patch
> >> which will be replaced by a little series sent today: (I'll pull in
> >> that series later)
> >>
> >> 0a2980b dm: mmc: Avoid probing block devices in find_mmc_device()
> >>
> >>
> >> The following changes since commit 
> >> 380e86f361e4e2aef83295972863654fde157560:
> >>
> >>   Merge git://git.denx.de/u-boot-fsl-qoriq (2017-05-26 11:19:27 -0400)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-dm.git
> >>
> >> for you to fetch changes up to 40fcab41cbcace3ff5928f146dd15c1ee3bfac65:
> >>
> >>   sandbox: Move to use live tree (2017-05-27 10:38:13 -0600)
> >>
> >
> > Two problems.  First, you need to add this to "dm: gpio: Add live tree
> > support":
> >
> > diff --git a/board/st/stm32f746-disco/stm32f746-disco.c 
> > b/board/st/stm32f746-disco/stm32f746-disco.c
> > index aeaa31146a5a..addf82bbae8c 100644
> > --- a/board/st/stm32f746-disco/stm32f746-disco.c
> > +++ b/board/st/stm32f746-disco/stm32f746-disco.c
> > @@ -101,8 +101,8 @@ int board_late_init(void)
> > if (node < 0)
> > return -1;
> >
> > -   gpio_request_by_name_nodev(gd->fdt_blob, node, "led-gpio", 0, ,
> > -  GPIOD_IS_OUT);
> > +   gpio_request_by_name_nodev(offset_to_ofnode(node), "led-gpio", 0,
> > +  , GPIOD_IS_OUT);
> >
> > if (dm_gpio_is_valid()) {
> > dm_gpio_set_value(, 0);
> > @@ -115,8 +115,8 @@ int board_late_init(void)
> > if (node < 0)
> > return -1;
> >
> > -   gpio_request_by_name_nodev(gd->fdt_blob, node, "button-gpio", 0, 
> > ,
> > -  GPIOD_IS_IN);
> > +   gpio_request_by_name_nodev(offset_to_ofnode(node), "button-gpio", 0,
> > +  , GPIOD_IS_IN);
> >
> > if (dm_gpio_is_valid()) {
> > if (dm_gpio_get_value())
> 
> OK, added, thanks. For me that board fails to build since it has something 
> like:
> 
> for (int i = )
> 
> Is that allowed now?

It probably shouldn't have come in and should be fixed, oh well.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Simon Glass]

Hi Tom,

On 28 May 2017 at 05:55, Tom Rini  wrote:
> On Sat, May 27, 2017 at 04:01:29PM -0600, Simon Glass wrote:
>
>> Hi Tom,
>>
>> This is similar to the last attempt, but without this offending patch
>> which will be replaced by a little series sent today: (I'll pull in
>> that series later)
>>
>> 0a2980b dm: mmc: Avoid probing block devices in find_mmc_device()
>>
>>
>> The following changes since commit 380e86f361e4e2aef83295972863654fde157560:
>>
>>   Merge git://git.denx.de/u-boot-fsl-qoriq (2017-05-26 11:19:27 -0400)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-dm.git
>>
>> for you to fetch changes up to 40fcab41cbcace3ff5928f146dd15c1ee3bfac65:
>>
>>   sandbox: Move to use live tree (2017-05-27 10:38:13 -0600)
>>
>
> Two problems.  First, you need to add this to "dm: gpio: Add live tree
> support":
>
> diff --git a/board/st/stm32f746-disco/stm32f746-disco.c 
> b/board/st/stm32f746-disco/stm32f746-disco.c
> index aeaa31146a5a..addf82bbae8c 100644
> --- a/board/st/stm32f746-disco/stm32f746-disco.c
> +++ b/board/st/stm32f746-disco/stm32f746-disco.c
> @@ -101,8 +101,8 @@ int board_late_init(void)
> if (node < 0)
> return -1;
>
> -   gpio_request_by_name_nodev(gd->fdt_blob, node, "led-gpio", 0, ,
> -  GPIOD_IS_OUT);
> +   gpio_request_by_name_nodev(offset_to_ofnode(node), "led-gpio", 0,
> +  , GPIOD_IS_OUT);
>
> if (dm_gpio_is_valid()) {
> dm_gpio_set_value(, 0);
> @@ -115,8 +115,8 @@ int board_late_init(void)
> if (node < 0)
> return -1;
>
> -   gpio_request_by_name_nodev(gd->fdt_blob, node, "button-gpio", 0, 
> ,
> -  GPIOD_IS_IN);
> +   gpio_request_by_name_nodev(offset_to_ofnode(node), "button-gpio", 0,
> +  , GPIOD_IS_IN);
>
> if (dm_gpio_is_valid()) {
> if (dm_gpio_get_value())

OK, added, thanks. For me that board fails to build since it has something like:

for (int i = )

Is that allowed now?

>
> Second, the zynq_zc702 qemu instance is failing (and you need a new
> enough version of qemu, such as the one in .travis.yml, to be able to
> run it.  I need to upgrade my local qemu so I don't have the failure
> bisected atm).

OK I found that it was checking for -FDT_ERR_NOTFOUND which really
should not have been returned by a DM function.

I sent the two updated patches. Given that RC1 is coming out soon I'll
try to do a new pull after testing, but it won't be until the morning.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Sat, May 27, 2017 at 04:01:29PM -0600, Simon Glass wrote:

> Hi Tom,
> 
> This is similar to the last attempt, but without this offending patch
> which will be replaced by a little series sent today: (I'll pull in
> that series later)
> 
> 0a2980b dm: mmc: Avoid probing block devices in find_mmc_device()
> 
> 
> The following changes since commit 380e86f361e4e2aef83295972863654fde157560:
> 
>   Merge git://git.denx.de/u-boot-fsl-qoriq (2017-05-26 11:19:27 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to 40fcab41cbcace3ff5928f146dd15c1ee3bfac65:
> 
>   sandbox: Move to use live tree (2017-05-27 10:38:13 -0600)
> 

Two problems.  First, you need to add this to "dm: gpio: Add live tree
support":

diff --git a/board/st/stm32f746-disco/stm32f746-disco.c 
b/board/st/stm32f746-disco/stm32f746-disco.c
index aeaa31146a5a..addf82bbae8c 100644
--- a/board/st/stm32f746-disco/stm32f746-disco.c
+++ b/board/st/stm32f746-disco/stm32f746-disco.c
@@ -101,8 +101,8 @@ int board_late_init(void)
if (node < 0)
return -1;
 
-   gpio_request_by_name_nodev(gd->fdt_blob, node, "led-gpio", 0, ,
-  GPIOD_IS_OUT);
+   gpio_request_by_name_nodev(offset_to_ofnode(node), "led-gpio", 0,
+  , GPIOD_IS_OUT);
 
if (dm_gpio_is_valid()) {
dm_gpio_set_value(, 0);
@@ -115,8 +115,8 @@ int board_late_init(void)
if (node < 0)
return -1;
 
-   gpio_request_by_name_nodev(gd->fdt_blob, node, "button-gpio", 0, ,
-  GPIOD_IS_IN);
+   gpio_request_by_name_nodev(offset_to_ofnode(node), "button-gpio", 0,
+  , GPIOD_IS_IN);
 
if (dm_gpio_is_valid()) {
if (dm_gpio_get_value())

Second, the zynq_zc702 qemu instance is failing (and you need a new
enough version of qemu, such as the one in .travis.yml, to be able to
run it.  I need to upgrade my local qemu so I don't have the failure
bisected atm).

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-dm (take 2)

[Tom Rini]

On Sat, Dec 03, 2016 at 11:26:13AM -0700, Simon Glass wrote:

> Hi Tom,
> 
> (new version with more patches)
> 
> Here are some buildman enhancements, a new TPM driver, the beginnings
> of the USB gadget DM conversion along with a few fixes and improvements.
> 
> The following changes since commit 9ae0e14350758e6447c90615ff4df530549a45e2:
> 
>   Merge git://www.denx.de/git/u-boot-marvell (2016-12-01 09:24:02 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-dm.git
> 
> for you to fetch changes up to a2558e8729831e0bcef634ea2440e60425ef0ff6:
> 
>   cmd: crosec: Move cros_ec_decode_region helper to cmd/cros_ec.c
> (2016-12-02 21:04:48 -0700)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot