Re: [U-Boot] cmd: gpio: Remove dead code from do_gpio

2018-06-20 Thread Michal Simek
On 19.6.2018 20:40, Tom Rini wrote:
> On Wed, Jun 13, 2018 at 03:06:49PM +0200, Michal Simek wrote:
> 
>> gpio input/set/clear and toggle commands are already cover that's why
>> there is no any other case which should be handled.
>>
>> Signed-off-by: Michal Simek 
>> ---
>>
>> Reported by: Coverity (local)
>> Not sure how to report this properly without CID
> 
> NAK.  This raises:
> w+(e2220-1170) ../cmd/gpio.c: In function 'do_gpio':
> w+(e2220-1170) ../cmd/gpio.c:199:3: warning: enumeration value 'GPIO_INPUT' 
> not handled in switch [-Wswitch]
> 
> For all platforms that use cmd/gpio.c

Sorry I forget to reply. I found this out later too.

Thanks for dropping,
Michal


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] cmd: gpio: Remove dead code from do_gpio

2018-06-19 Thread Tom Rini
On Wed, Jun 13, 2018 at 03:06:49PM +0200, Michal Simek wrote:

> gpio input/set/clear and toggle commands are already cover that's why
> there is no any other case which should be handled.
> 
> Signed-off-by: Michal Simek 
> ---
> 
> Reported by: Coverity (local)
> Not sure how to report this properly without CID

NAK.  This raises:
w+(e2220-1170) ../cmd/gpio.c: In function 'do_gpio':
w+(e2220-1170) ../cmd/gpio.c:199:3: warning: enumeration value 'GPIO_INPUT' not 
handled in switch [-Wswitch]

For all platforms that use cmd/gpio.c

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot