[Ubuntu-apps-bugs] [Bug 1599184] Re: When switching to 2-column landscape mode, current conversations are closed
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Apps bug tracking, which is subscribed to messaging-app in Ubuntu. https://bugs.launchpad.net/bugs/1599184 Title: When switching to 2-column landscape mode, current conversations are closed Status in Canonical System Image: Fix Released Status in messaging-app package in Ubuntu: Fix Released Status in ubuntu-ui-toolkit package in Ubuntu: Invalid Bug description: messaging-app.qml has the following code: onColumnsChanged: { // we only have things to do here in case no thread is selected if (layout.columns == 2 && !application.findMessagingChild("emptyStatePage") && !application.findMessagingChild("fakeItem")) { layout.removePage(mainPage) emptyStack() } } This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.removePage(mainPage). To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1599184/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-apps-bugs Post to : ubuntu-apps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-apps-bugs More help : https://help.launchpad.net/ListHelp
[Ubuntu-apps-bugs] [Bug 1599184] Re: When switching to 2-column landscape mode, current conversations are closed
** Changed in: messaging-app (Ubuntu) Status: Confirmed => Fix Committed ** Changed in: messaging-app (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Apps bug tracking, which is subscribed to messaging-app in Ubuntu. https://bugs.launchpad.net/bugs/1599184 Title: When switching to 2-column landscape mode, current conversations are closed Status in Canonical System Image: Fix Committed Status in messaging-app package in Ubuntu: Fix Released Status in ubuntu-ui-toolkit package in Ubuntu: Invalid Bug description: messaging-app.qml has the following code: onColumnsChanged: { // we only have things to do here in case no thread is selected if (layout.columns == 2 && !application.findMessagingChild("emptyStatePage") && !application.findMessagingChild("fakeItem")) { layout.removePage(mainPage) emptyStack() } } This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.removePage(mainPage). To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1599184/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-apps-bugs Post to : ubuntu-apps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-apps-bugs More help : https://help.launchpad.net/ListHelp
[Ubuntu-apps-bugs] [Bug 1599184] Re: When switching to 2-column landscape mode, current conversations are closed
** Also affects: canonical-devices-system-image Importance: Undecided Status: New ** Changed in: canonical-devices-system-image Importance: Undecided => High ** Changed in: canonical-devices-system-image Status: New => Fix Committed ** Changed in: canonical-devices-system-image Assignee: (unassigned) => Bill Filler (bfiller) ** Changed in: canonical-devices-system-image Milestone: None => 13 -- You received this bug notification because you are a member of Ubuntu Apps bug tracking, which is subscribed to messaging-app in Ubuntu. https://bugs.launchpad.net/bugs/1599184 Title: When switching to 2-column landscape mode, current conversations are closed Status in Canonical System Image: Fix Committed Status in messaging-app package in Ubuntu: Confirmed Status in ubuntu-ui-toolkit package in Ubuntu: Invalid Bug description: messaging-app.qml has the following code: onColumnsChanged: { // we only have things to do here in case no thread is selected if (layout.columns == 2 && !application.findMessagingChild("emptyStatePage") && !application.findMessagingChild("fakeItem")) { layout.removePage(mainPage) emptyStack() } } This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.removePage(mainPage). To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1599184/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-apps-bugs Post to : ubuntu-apps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-apps-bugs More help : https://help.launchpad.net/ListHelp
[Ubuntu-apps-bugs] [Bug 1599184] Re: When switching to 2-column landscape mode, current conversations are closed
After some discussion we decided not to use the bottom edge animation when in two columns mode, so this problem is not going to happen anymore. At some point the SDK might need to have animated transitions in APL and PageStack, but that's out of scope for this bug, so I'll mark as Invalid for SDK. ** Branch linked: lp:~phablet-team/messaging-app/fix_bottom_edge ** Changed in: messaging-app (Ubuntu) Assignee: (unassigned) => Gustavo Pichorim Boiko (boiko) ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Apps bug tracking, which is subscribed to messaging-app in Ubuntu. https://bugs.launchpad.net/bugs/1599184 Title: When switching to 2-column landscape mode, current conversations are closed Status in messaging-app package in Ubuntu: Confirmed Status in ubuntu-ui-toolkit package in Ubuntu: Invalid Bug description: messaging-app.qml has the following code: onColumnsChanged: { // we only have things to do here in case no thread is selected if (layout.columns == 2 && !application.findMessagingChild("emptyStatePage") && !application.findMessagingChild("fakeItem")) { layout.removePage(mainPage) emptyStack() } } This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.removePage(mainPage). To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/messaging-app/+bug/1599184/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-apps-bugs Post to : ubuntu-apps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-apps-bugs More help : https://help.launchpad.net/ListHelp
[Ubuntu-apps-bugs] [Bug 1599184] Re: When switching to 2-column landscape mode, current conversations are closed
** Changed in: messaging-app (Ubuntu) Importance: Undecided => High ** Also affects: ubuntu-ui-toolkit (Ubuntu) Importance: Undecided Status: New ** Changed in: ubuntu-ui-toolkit (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Apps bug tracking, which is subscribed to messaging-app in Ubuntu. https://bugs.launchpad.net/bugs/1599184 Title: When switching to 2-column landscape mode, current conversations are closed Status in messaging-app package in Ubuntu: Confirmed Status in ubuntu-ui-toolkit package in Ubuntu: New Bug description: messaging-app.qml has the following code: onColumnsChanged: { // we only have things to do here in case no thread is selected if (layout.columns == 2 && !application.findMessagingChild("emptyStatePage") && !application.findMessagingChild("fakeItem")) { layout.removePage(mainPage) emptyStack() } } This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.removePage(mainPage). To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/messaging-app/+bug/1599184/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-apps-bugs Post to : ubuntu-apps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-apps-bugs More help : https://help.launchpad.net/ListHelp