(In reply to Eric Shepherd [:sheppy] from comment #112)
> Is this in Nightly or Aurora? It's flagged as Gecko 8, but someone
> documented it as Gecko 9. I'd like to confirm which it is.
It's currently in Aurora, but backout from gecko8 is in process. See bug
684467.
--
You received this bug noti
Created attachment 553150
part3: fix Get/SetCurrentDictionary signature
patch for the Get/SetCurrentDictionary signature, resolving issues
raised my Ms2ger.
> Same comment, and I think you're changing behaviour here if dictName is the
> empty string (can that happen?)
If SetCurrentDictionary ha
(In reply to Ehsan Akhgari [:ehsan] from comment #105)
> Comment on attachment 553143
> part2: do not override manually set dictionary
>
> >+ PRBool mUpdateDictionaryRunning;
> >+ PRBool mDictWasSetManually;
>
> Please use PRPackedBool.
>
> >+class UpdateDictionnaryHolder {
> >+ private:
> >+
I've tested both patches on try server, and they look correct
http://tbpl.mozilla.org/?tree=Try&rev=8300b6949f82
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select lang
Created attachment 553145
fix Get/SetCurrentDictionary signature
(In reply to Ms2ger from comment #97)
> > SetCurrentDictionary(NS_LITERAL_STRING("").get());
>
> Can we fix that signature, pretty please?
Here is a patch changing SetCurrentDictionary and GetCurrentDictionary
to use nsAString& in
Created attachment 553143
part2: do not override manually set dictionary
patch to fix issue described in comment 98.
This works by setting a boolean member mDictWasSetManually to PR_TRUE when
SetCurrentDictionary is called, but not from UpdateCurrentDictionary
Once that member is true, UpdateCurr
Created attachment 553025
part2: do not override user choice
quick wip patch. I'll try to add some tests tomorrow.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select l
Oups. Look like there's a serious bug in this patch :(
When user manually sets a non default dictionary, it's dismissed as soon as
editor is blured and focused again (because we go the UpdateCurrentDictionary
path again).
--
You received this bug notification because you are a member of Ubuntu
Created attachment 552655
patch v2.7
I fixed the reftest with kaze and volkmar help. We came to a better solution:
make the test and the reference exactly similar except the reference will have
spellcheck=false. Then, there's no need anymore to blur the editor.
I also modified another thing sinc
Created attachment 552033
patch v2.6
> But I just remembered that Android can't handle focus
> correctly yet. So, can you just mark the test as needs-focus in the reftest
> manifest? That should make Android skip the test.
What do you mean with: can't handle focus correctly ?
Because, if I unde
I run the test on my system before submitting a patch either here, or on
try server. Tests can succeed on my machine but fail in other
environments. For example, as I told in comment 78, this can be caused
by different font settings.
About, when the blur is made inside double timeout,
updateCurren
Created attachment 551030
patch v2.5
I fixed mochitest by focusing contenteditable at test starts.
Reftests failed because setting lang="testing-XX" on textarea changed
default font in some configurations. I fixed this by explicitly defining
a font-family.
Attached patch passes tests correctly:
Created attachment 550415
patch v2.4
Build failure was a typo.
about
http://tinderbox.mozilla.org/showlog.cgi?log=Try/1312356145.1312356574.28744.gz:
I modified test_bug484181.html to focus content editable area before checking
suggestion
about
http://tinderbox.mozilla.org/showlog.cgi?log=Try/
Created attachment 549553
patch v2.3
(In reply to comment #71)
Updateded patch with nsIContent::GetLang a const method, and with
reftests using focus listeners.
> r=me with the below comments fixed.
Should I mark this patch as r+ myself then ?
--
You received this bug notification because you
Comment on attachment 549230
patch v2.2
Sorry, I was mistaken
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select language for spell check based on user input
To manag
Comment on attachment 549230
patch v2.2
Something is wrong with the patch. I'll work on it again later.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select language for
Created attachment 549230
patch v2.2
(In reply to comment #67)
> (In reply to comment #66)
> > > Can you add another test here for the dynamic change case? You can put
> > > lang="en-US" on the textarea, then upon load change it to "testing-XX",
> > > then
> > > .focus() and .blur().
> >
> > Ac
> Can you add another test here for the dynamic change case? You can put
> lang="en-US" on the textarea, then upon load change it to "testing-XX", then
> .focus() and .blur().
Actually, this does not work. Calling SetCurrentDictionary to an invalid
language, does nothing. So an invalid language
Created attachment 548933
patch v2.1
(In reply to comment #64)
> Nit: succeed
fixed
> Technically, the -ref file is the reference rendering, and the other file is
> the thing to be tested. So, these two files should probably be swapped.
fixed
> Can you add another test here for the dynamic c
PRUnichar *previousDictionary = nsnull;
nsDependentString previousDictionaryStr;
if (NS_SUCCEEDED(mSpellCheck->GetCurrentDictionary(&previousDictionary))) {
previousDictionaryStr.Assign(previousDictionary);
}
I wonder if there's a better way to do that. May be
nsEditorSpellCheck::GetCurrentDi
Created attachment 548731
patch v2
new patch.
dictionary language is updated each time editor is focused. To implement this,
I mainly copied stuff from volkmar's patch. The main difference is I initiate a
full spell check (with SpellCheckRange) if language has changed.
Otherwise, first focus in
(In reply to comment #55)
> Created attachment 548559 [details] [review]
> wip
>
> wip patch:
> it deals with ehsan suggestions except for the html editor handling (ie:
> GetActiveEditingHost method).
> What needs to be done is call GetActiveEditingHost at the right moment
> (editor needs to be fo
Created attachment 548559
wip
wip patch:
it deals with ehsan suggestions except for the html editor handling (ie:
GetActiveEditingHost method).
What needs to be done is call GetActiveEditingHost at the right moment (editor
needs to be focused otherwise, result is wrong). ehsan suggested on irc t
Created attachment 547702
updated patch
updated patch.
This patch choose dictionary according to editor element @lang. @lang is
computed with html5 algorithm
http://www.whatwg.org/specs/web-apps/current-work/multipage/#language
If no @lang is set, try to use last selected dictionary, or diction
Many fonts (at least truetype fonts), when rendered with freetype, have
a point with a big thickness increase. For times new roman, that point
is between 13pt and 14pt.
This behaviour only happens when hinting is activated. When a glyph is
loaded in freetype without hinting (ie: with flag FT_LOAD
Hi,
I made new debian release of mozilla-noscript depend on iceweasel or
iceape-browser or firefox. Hope that will solve problem on Ubuntu.
arno
--
mozilla-noscript depends on not available package "iceweasel"
https://bugs.launchpad.net/bugs/178445
You received this bug notification because you
26 matches
Mail list logo
