[Bug 867424]

2020-05-08 Thread Continuation
I have no idea why this wouldn't show up before. I'm not an expert on PR_SetEnv, but all of the callers of SaveToEnv are passing in string constants, so it doesn't look to me that you actually need to do a strdup. The header for SetEnv just says that it has to be a "constant, persistent string",

[Bug 867424]

2020-05-08 Thread Continuation
Comment on attachment 8763602 (2/4) - Annotate deliberate leak in SaveToEnv Review of attachment 8763602: - Be sure to #include "mozilla/MemoryChecking.h" in this file please. -- You received this bug notification because you are

[Bug 867424]

2020-05-08 Thread Continuation
LSan treats things reachable from global variables as not being leaks, which is different than Valgrind. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox

[Bug 1398898]

2014-12-10 Thread Continuation
(In reply to Benjamin Kerensa [:bkerensa] from comment #29) This does not appear to meet the landing criteria for ESR: Security and some major stability fixes when they're landed/merged onto mozilla-beta, or fixes for regressions specific to the ESR. This patch fixes a crash that makes Firefox

[Bug 1398898]

2014-12-09 Thread Continuation
(In reply to Jacobo Pantoja from comment #26) Or this code is fed back to Thunderbird in any way? Yes, this will automatically be included in Thunderbird, once it lands on esr, I believe. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1398898]

2014-12-05 Thread Continuation
I'm not sure why 31 was marked wontfix, so I'm going to reset it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications

[Bug 1398898]

2014-12-05 Thread Continuation
Comment on attachment 8523413 Correct argument passing - backport for ESR31 ESR just needs a separate approval request. [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: Crashes on Debian builds of Firefox. User impact if declined: see

[Bug 286366]

2012-05-23 Thread Continuation
OOM check was added to PL_DHashTableOperate at some point in the past. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/286366 Title: segfault in GCGraphBuilder::AddNode To manage notifications about

[Bug 286366]

2012-05-23 Thread Continuation
*** Bug 466364 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/286366 Title: segfault in GCGraphBuilder::AddNode To manage notifications about this