[Bug 41179]

2019-02-20 Thread Gsvelto
(In reply to Jan Horak from comment #130) > [:gsvelto] are you willing to participate on the reviews? I'd love to help but I'm not a peer of this part of our codebase so I can't review patches for it. Reading Brian Smith's and Justin Dolske's comments I think that we'd like to address bug 973

[Bug 41179]

2013-08-19 Thread Gsvelto
(In reply to David Webb from comment #111) Does this sound reasonable? Yes, it sounds like a good idea but also material for a follow-up. Let's open a separate bug for that so that we don't make the patch here too large or we'll never be done with it :) -- You received this bug notification

[Bug 217300]

2013-08-19 Thread Gsvelto
(In reply to David Webb from comment #111) Does this sound reasonable? Yes, it sounds like a good idea but also material for a follow-up. Let's open a separate bug for that so that we don't make the patch here too large or we'll never be done with it :) -- You received this bug notification

[Bug 41179]

2013-08-15 Thread Gsvelto
Created attachment 790711 Refreshed patch (In reply to jhorak from comment #109) Okay, it seems that we're moving in circles. Who's going to decide which approach to choice? I can implement storing password to system keyrings but I won't do this without clear statement from Mozilla what they

[Bug 217300]

2013-08-15 Thread Gsvelto
Created attachment 790711 Refreshed patch (In reply to jhorak from comment #109) Okay, it seems that we're moving in circles. Who's going to decide which approach to choice? I can implement storing password to system keyrings but I won't do this without clear statement from Mozilla what they

[Bug 41179]

2013-08-04 Thread Gsvelto
Created attachment 785385 Refreshed patch This is a refreshed version of attachment 713868; the changes were fairly minimal as noted in comment 91 and comment 92. Besides adjusting a few rejections it was just a matter of importing nsIFile.h to get it working. I've done some light testing on my

[Bug 41179]

2013-08-04 Thread Gsvelto
(In reply to Brian Smith (:briansmith), was bsm...@mozilla.com (:bsmith) from comment #95) Shouldn't the users that care about protecting their passwords be using full-disk encryption with a system password already? Why don't we just remove the master password mechanism on Linux completely,

[Bug 41179]

2013-08-04 Thread Gsvelto
(In reply to Brian Smith (:briansmith), was bsm...@mozilla.com (:bsmith) from comment #94) 1) I see in the patch that this is a build option that is off by default. I would prefer it to be ON by default for all Linux desktop builds, and if libsecret isn't available at runtime, then we just

[Bug 217300]

2013-08-04 Thread Gsvelto
Created attachment 785385 Refreshed patch This is a refreshed version of attachment 713868; the changes were fairly minimal as noted in comment 91 and comment 92. Besides adjusting a few rejections it was just a matter of importing nsIFile.h to get it working. I've done some light testing on my

[Bug 217300]

2013-08-04 Thread Gsvelto
(In reply to Brian Smith (:briansmith), was bsm...@mozilla.com (:bsmith) from comment #95) Shouldn't the users that care about protecting their passwords be using full-disk encryption with a system password already? Why don't we just remove the master password mechanism on Linux completely,

[Bug 217300]

2013-08-04 Thread Gsvelto
(In reply to Brian Smith (:briansmith), was bsm...@mozilla.com (:bsmith) from comment #94) 1) I see in the patch that this is a build option that is off by default. I would prefer it to be ON by default for all Linux desktop builds, and if libsecret isn't available at runtime, then we just

[Bug 217300]

2013-01-16 Thread Gsvelto
I think the idea of using the native keyring to store the master password is sound. I'd be glad to try and implement it for gnome-keyring once I've got some spare time on my hands. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 41179]

2013-01-16 Thread Gsvelto
I think the idea of using the native keyring to store the master password is sound. I'd be glad to try and implement it for gnome-keyring once I've got some spare time on my hands. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug