[Bug 1799237] Re: mprotect fails on ext4 with dax

2018-11-30 Thread Marcin Ślusarz
To summarize: 4.15.0-20 is the last kernel where mprotect works, all kernels between 4.15.0-20 and 4.15.0-34 are not testable, 4.15.0-34 is the first kernel that boots correctly and mprotect fails. You have a test program, instructions how to run it and here's a guide how to set up pmem

[Bug 1799237] Re: mprotect fails on ext4 with dax

2018-10-24 Thread Marcin Ślusarz
This is purely kernel issue. It can be worked around in PMDK by code change, as those mprotects are only safety precautions, but I really wouldn't want to do this upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1799237] Re: mprotect fails on ext4 with dax

2018-10-24 Thread Marcin Ślusarz
** Also affects: pmdk (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1799237 Title: mprotect fails on ext4 with dax To manage notifications

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-08-07 Thread Marcin Ślusarz
PMDK packages look good. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages for NVDIMM support To manage notifications about this bug go to:

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-08-06 Thread Marcin Ślusarz
Yeah, we'll test pmdk packages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages for NVDIMM support To manage notifications about this bug go to:

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-07-16 Thread Marcin Ślusarz
In pmdk 1.4.1 NDCTL_ENABLE controls daxio only, so it's safe to build pmdk with this flag. The default value has been flipped to "detect", so if ndctl is installed in the system, there's no need to set it explicitly. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-07-12 Thread Marcin Ślusarz
Please backport the latest version of pmdk. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages for NVDIMM support To manage notifications about this bug go

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-05-23 Thread Marcin Ślusarz
I finally found why pcheck failed (https://github.com/pmem/pmdk/pull/2961). As soon as the fix will land on master I'll backport it for the next stable release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-05-18 Thread Marcin Ślusarz
util_file_create timed out because you used file system (PMEM/NON_PMEM_FS_DIR) that does not support fallocate syscall. glibc's posix_fallocate falls back to writing zeroes when fallocate is not supported, so test takes ages to complete. https://github.com/pmem/pmdk/pull/2939 adds code to detect

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-05-14 Thread Marcin Ślusarz
I'm looking into util_file_create failure. WRT pcheck, you had hit some bug in our build system. I know what's causing the error you are seeing (make tries to build pmemspoil twice, both processes write to the same file, which means creation of corrupted object file and that leads to failure

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-05-11 Thread Marcin Ślusarz
jemalloc: We can't upstream those changes, because jemalloc changed too much since we forked it. pmemcto makes this even harder problem, because any changes to jemalloc on-media layout would have to invalidate pmemcto pools and we don't have any mechanism to automatically do that. testing:

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-27 Thread Marcin Ślusarz
I tested pmdk 1.4 ppa1 with pmdk in-tree tests and with some small changes all tests pass. I'm in the process of upstreaming those changes (PR #2873 #2875 #2885 #2886) and once they are all on master I'll backport them to stable-1.4 branch. (next week I'm on vacation) -- You received this bug

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-24 Thread Marcin Ślusarz
If you want to disable building examples you have to remove both examples and benchmarks from src/Makefile ALL_TARGETS/RELEASE_TARGETS. BTW, why do you even need to that? Why are they included in development packages? -- You received this bug notification because you are a member of Ubuntu

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-24 Thread Marcin Ślusarz
Please don't build pmdk 1.4 with NDCTL_ENABLE=y. This variable enables much more than daxio and we are not ready to support that yet. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title:

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-24 Thread Marcin Ślusarz
Not a big issue, but I don't think shipping object files and Visual Studio project files with examples makes much sense :). Also shipped Makefiles are not self-contained (they source Makefile.inc, which is not included in the package) -- You received this bug notification because you are a

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-23 Thread Marcin Ślusarz
Packaging 1.4 sounds great :). You don't need to do anything for Valgrind support in 1.4. Nobody had considered that libvmmalloc.so would not be available. Our tests use libvmalloc.so (that's how I found this issue - https://github.com/pmem/pmdk/pull/2873) and today I found out that even our

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-20 Thread Marcin Ślusarz
One more issue which I haven't noticed earlier - missing Valgrind support. Bit of background: PMDK supports both regular upstream Valgrind tools (memcheck, helgrind and drd) and our pmemcheck tool (available at https://github.com/pmem/valgrind). To enable support for all tools you have to use

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-20 Thread Marcin Ślusarz
I tested ~ppa18 with PMDK in-tree tests and I realized that removal of .so files from nvml_dbg directory we discussed earlier breaks the assumption that you can just set LD_LIBRARY_PATH and everything will work correctly WHEN libvmmalloc is involved. This works: LD_PRELOAD=libvmmalloc.so ./app

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-04 Thread Marcin Ślusarz
For now you can create .version file in the top level directory. We are evaluating various options. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages for

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-04 Thread Marcin Ślusarz
We tracked one test failure in ppa7 version to debug libraries not having symbols, but I see ppa10 already have them. I don't see it mentioned in Changelog. What happened? (obj_convert test injects crashes in some specific places using gdb and see if consecutive open handles such pool correctly)

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-04-04 Thread Marcin Ślusarz
I don't think there is a need for -dev-debug packages. The interface between debug and release packages is the same by design, so nobody should ever need to link to debug libraries. Both debian/1.3.1-0ubuntu1_ppa5-43-g1b3d0af and nvml-1.3.1 are wrong. It should say 1.3.1. It seems we'll have to

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-29 Thread Marcin Ślusarz
I fixed this today. stable-1.3 fix: https://github.com/pmem/pmdk/commit/5cbd2be4ae1ae7541da5975c9071fa36b53cd835 Testing those packages is taking longer than I expected. I'll report back as soon as I get the results. However without minimum version check, pmemfile builds fine and its tests pass,

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-28 Thread Marcin Ślusarz
This is actually a bug in NVML/PMDK. It seems nobody tried to use pkg- config files with minimum version specified for packages built out of git tree. Temporarily you can work around it by creating ".version" file in the top level directory with "1.3.1" as content. -- You received this bug

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-28 Thread Marcin Ślusarz
I asked some people internally to test those packages. I think we'll get results tomorrow. While waiting on that I tried to build pmemfile project (https://github.com/pmem/pmemfile) and I got this: -- Checking for module 'libpmemobj>=1.3' -- Requested 'libpmemobj >= 1.3' but version of

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-26 Thread Marcin Ślusarz
I suggested it in the context of "libpmemobj++ documentation directory" problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages for NVDIMM support To

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-26 Thread Marcin Ślusarz
Alternatively you could add separate package for C++ headers, pkg-config file and documentation. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages for

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-23 Thread Marcin Ślusarz
It seems almost all problems were resolved. Thanks. The only missing part is libpmemobj++ documentation. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378 Title: Please add Userspace Packages

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-23 Thread Marcin Ślusarz
I understand your concern, but I'd like to ask you to not remove it yet, because: - it would make responding to bug reports and support requests a bit harder - shipped man pages mention those libraries But I think you are right, so I opened an issue with the proposal to get rid of

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-23 Thread Marcin Ślusarz
Files under nvml_dbg are builds with debugging symbols, logging, asserts and expensive checks that we normally don't want users to run with. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-07 Thread Marcin Ślusarz
1) Still nope. Non-dev packages now also include .so files... 10) New issue: libpmem-dev now contains all libraries in nvml_dbg directory. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752378

[Bug 1752378] Re: Please add Userspace Packages for NVDIMM support

2018-03-06 Thread Marcin Ślusarz
NVML: 1) Nope, for old packages only libpmem had this problem. Now it's even worse - none of the packages contain .so used for linking. 3) "detail" directory is still missing. 7) Already backported to stable-1.3 branch, will be part of 1.3.2: