[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-28 Thread Roger Leigh
You can now get 1.6.4-2 from Debian unstable or from git http://anonscm.debian.org/gitweb/?p=buildd-tools/schroot- dist.git;a=commit;h=8088a3b7e003546e3315957f6091553f4d2136ad http://anonscm.debian.org/gitweb/?p=buildd- tools/schroot.git;a=commit;h=5fbab5b020922a454a1a8824ee6920e0ea26e088

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-27 Thread Bug Watch Updater
** Changed in: schroot (Debian) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1070008 Title: schroot session recovery mounts $device, not $mount-device,

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-25 Thread Bug Watch Updater
** Changed in: schroot (Debian) Status: New = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1070008 Title: schroot session recovery mounts $device, not $mount-device, for LVM

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
Thanks. I can reproduce this with 1.6.3. Still working out where this is happening though. - it's set correctly in the session file (as you've shown) - it's also set correctly on loading (again with --config/--info, so no serialisation errors) So something subtle is happening after that, but

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
Unwanted side effect of cloning; triggered by the copy constructor chaining up to the block_device_base ctor, which calls set_device, which then calls chroot_facet_mountable::set_mount_device. (gdb) run --recover-session -c snaptest Starting program: /home/rleigh/schroot/bin/schroot/schroot

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
We do in fact already take steps to ensure we don't call this when using LVM snapshots to avoid the exact issue that you've reported. However, it looks like in your case this is not working. As you can see, set_mount_device should be called for all chroot types /except/ lvm- snapshot (where the

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
OK, so this check is failing. dynamic_cast() is returning null because this is being called from the constructor, and the vptr during this stage of construction does not contain the information about the derived class. So we end up setting the mount device inappropriately. This was working

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
This is now being tracked in Debian bug #691376. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1070008 Title: schroot session recovery mounts $device, not $mount-device, for LVM snapshots To

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Steve Langasek
** Bug watch added: Debian Bug tracker #691376 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691376 ** Also affects: schroot (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691376 Importance: Unknown Status: Unknown ** Changed in: schroot (Ubuntu) Status:

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
http://anonscm.debian.org/gitweb/?p=buildd- tools/schroot.git;a=commitdiff;h=02fa2aefc24e95852aa991f720b3c9dc53583d1c Note that this patch needs backporting to the schroot-1.6 branch and testing with all block-device-using chroot types before I would recommend applying it. **Please do not apply

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Roger Leigh
I'm not sure this is of low severity. I've marked this as serious in the Debian bug since it could allow a user to gain unauthorised root access to the source volume (if they were a root user for the snapshot), and potentially result in dataloss if the user didn't realise they were not using the

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Steve Langasek
Well, anyone relying on root access not leaking into the parent system is fooling themselves, so I don't think there's a security bug here. The risk for self-inflicted data loss probably makes it at least 'medium' though. ** Changed in: schroot (Ubuntu) Importance: Low = Medium -- You

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-24 Thread Bug Watch Updater
** Changed in: schroot (Debian) Status: Unknown = New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1070008 Title: schroot session recovery mounts $device, not $mount-device, for LVM

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-23 Thread Roger Leigh
Could you please provide the session file, from /var/lib/schroot/session? The original config from /etc/schroot would also be useful. schroot --config -c chroot:$origchroot -c session:$session will provide both of these. If it's not Ubuntu-specific, the Debian BTS would also be more

[Bug 1070008] Re: schroot session recovery mounts $device, not $mount-device, for LVM snapshots

2012-10-23 Thread Steve Langasek
I don't have the session file for the original one that was recovered because it's been reaped now, but here's the config for another instance of the same chroot. ** Attachment added: schroot-session-output