[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-04-22 Thread Launchpad Bug Tracker
This bug was fixed in the package aptdaemon - 0.43+bzr805-0ubuntu9 --- aptdaemon (0.43+bzr805-0ubuntu9) precise-proposed; urgency=low * debian/patches/fix-lp-1120322.patch: Resolve crash if configuration file changes are only one line long (LP: #1120322) -- Brian MurrayWed,

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-04-19 Thread Brian Murray
I test aptdaemon version 0.43+bzr805-0ubuntu9 from precise-proposed and confirm that DiffView's show_diff now works. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-26 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/precise-proposed/aptdaemon -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with UnboundLocalError in show_diff(): local variable 'li

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-26 Thread Chris Halse Rogers
Hello Fjatle, or anyone else affected, Accepted aptdaemon into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/aptdaemon/0.43+bzr805-0ubuntu9 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-20 Thread Brian Murray
** Changed in: aptdaemon (Ubuntu Precise) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with UnboundLocalError in show_dif

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-20 Thread Brian Murray
** Changed in: aptdaemon (Ubuntu Precise) Assignee: Barry Warsaw (barry) => Brian Murray (brian-murray) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-14 Thread Launchpad Bug Tracker
This bug was fixed in the package aptdaemon - 1.0-0ubuntu1 --- aptdaemon (1.0-0ubuntu1) raring; urgency=low * New stable bug fix release 1.0: - Add PEP8 compliance and a corresponding test - Fix PackageKit tests if an http proxy is set (LP: #1050799) - Fix crash for Pyth

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-11 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/raring-proposed/aptdaemon -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with UnboundLocalError in show_diff(): local variable 'lin

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-11 Thread Brian Murray
** Description changed: - At the same time as the crash appeared, I got a box for Keep/Renew Steam config file. + Test Case: + + 1) Create a file named a.txt in /tmp/ with the contents 'one' in it. + 2) Create a file named b.txt in /tmp/ with the contents 'onee' in it. + 3) In a terminal start

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-03-09 Thread Sebastian Heinlein
** Changed in: aptdaemon Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with UnboundLocalError in show_diff(): local v

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-28 Thread Barry Warsaw
-a.txt- one -a.txt- -b.txt- onee -b.txt- diff those two files and you'll hit the bug. I'll add a test case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Ti

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-28 Thread Robert Collins
So, this is the loop http://bazaar.launchpad.net/~aptdaemon- developers/aptdaemon/main/view/head:/aptdaemon/gtk3widgets.py#L1114 for line in difflib.unified_diff(from_lines, to_lines, lineterm=""): if line.startswith("@@"): match = re.match(self.REGEX_RANGE, lin

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-28 Thread Launchpad Bug Tracker
** Branch linked: lp:~barry/aptdaemon/lp1120322 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_numb

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-28 Thread Barry Warsaw
The odd part is that I'm not sure how to get difflib to produce a diff that doesn't start with the three lines: --- blah +++ blah @@ blah to trigger the bug. This is clearly unexpected in the code (hence the UnboundLocalError in the first place) and it it definitely not covered in the test suite

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-28 Thread Barry Warsaw
** Changed in: aptdaemon Assignee: (unassigned) => Barry Warsaw (barry) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title: update-manager crashed with UnboundLocalError in show_diff()

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-27 Thread Colin Watson
I suspect that it shouldn't enter those last two blocks unless line_number has been set properly yet, since diff hunks always start with @@. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1120322 Title

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-27 Thread Steve Langasek
** Changed in: aptdaemon (Ubuntu) Assignee: (unassigned) => Barry Warsaw (barry) ** Changed in: aptdaemon (Ubuntu Precise) Assignee: (unassigned) => Barry Warsaw (barry) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https:

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-26 Thread Brian Murray
** Also affects: aptdaemon Importance: Undecided Status: New ** Changed in: aptdaemon Status: New => Confirmed ** Tags added: rls-r-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-26 Thread Brian Murray
This seems to be happening to quite a few Precise users as we can see at errors.ubuntu.com: http://10.0.3.97/bucket/?id=%2Fusr%2Fbin%2Fupdate- manager%3AUnboundLocalError%3A_on_config_file_conflict%3Arun%3Ashow_diff -- You received this bug notification because you are a member of Ubuntu Bugs, w

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-26 Thread Brian Murray
There are two points in show_diff from aptdaemon/gtk3widgets.py where line_number is not defined: for line in difflib.unified_diff(from_lines, to_lines, lineterm=""): if line.startswith("@@"): match = re.match(self.REGEX_RANGE, line) if not match

[Bug 1120322] Re: update-manager crashed with UnboundLocalError in show_diff(): local variable 'line_number' referenced before assignment

2013-02-26 Thread Brian Murray
This is actually a bug in aptdaemon. ** Package changed: update-manager (Ubuntu) => aptdaemon (Ubuntu) ** Changed in: aptdaemon (Ubuntu) Importance: Medium => High ** Changed in: aptdaemon (Ubuntu) Status: Confirmed => Triaged ** Also affects: aptdaemon (Ubuntu Precise) Importance: