[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-11 Thread Martin Pitt
Synced libnotify with Debian. Will close once it propagated into vivid. ** Changed in: libnotify (Ubuntu) Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-11 Thread Martin Pitt
** Changed in: libnotify (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating issues for

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-09 Thread Launchpad Bug Tracker
This bug was fixed in the package unity8 - 8.02+15.04.20150109.2-0ubuntu1 --- unity8 (8.02+15.04.20150109.2-0ubuntu1) vivid; urgency=low [ Michał Sawicz ] * We don't need the SIGSTOP in main() any more. * Add a test to make sure the shell always starts disabled until it is

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-09 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/vivid-proposed/unity8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating issues for clients To manage

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-06 Thread Martin Pitt
This is the relevant GIR delta, for the record. ** Patch added: relevant GIR diff https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/1223401/+attachment/4292819/+files/gir.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-06 Thread Launchpad Bug Tracker
** Branch linked: lp:~pitti/unity8/notify-api-fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating issues for clients To manage

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-06 Thread Martin Pitt
So, this madness needs to stop at some point, so let's just fix the reverse dependencies and get back in sync. This should be much easier now that PyGObject makes tailing allow-none arguments optional and accepts not specifying them explicitly at all. However, we must pay attention as trailing

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2015-01-06 Thread Martin Pitt
** Changed in: unity8 (Ubuntu) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating issues for clients To

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-10-08 Thread John Stowers
And this crashes gnome-tweak-tool for the exact reasons Vadim mentioned. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating issues for clients

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-10-08 Thread Sebastien Bacher
well, that's what you get for changing apis in an incompatible ways, some of the clients use the old api, some the new one... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6]

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-10-08 Thread Martin Pitt
Do you have a recommendation on how to deal with the transition/make code work with both old and new api? Unity could try the new API first, catch the AttributeError (or whichever exception is thrown) and re-call with the old API. -- You received this bug notification because you are a member

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-09-17 Thread Vadim Rutkovsky
This change crashes gnome-music as it expects the function to have 5 arguments in libnotify 0.7.6 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-09-10 Thread Michał Sawicz
lp:~saviq/unity8/fix-new-libnotify fixes this for unity8, but it doesn't seem correct... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-09-10 Thread Sebastien Bacher
Hey Martin, can you help to answer to some of the questions we have there? ** Changed in: libnotify (Ubuntu) Importance: Undecided = High ** Changed in: libnotify (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-09-10 Thread Sebastien Bacher
It looks correct to me in the sense that the free_func is not an argument which should be exposed to Python. so it's normal that the signature changed from 6 arguments to 5 arguments? :/ Do you have a recommendation on how to deal with the transition/make code work with both old and new api? --

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-09-10 Thread Michał Sawicz
** Branch linked: lp:~saviq/unity8/fix-new-libnotify -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1223401 Title: [0.7.6] the add_action api changed creating issues for clients To manage

[Bug 1223401] Re: [0.7.6] the add_action api changed creating issues for clients

2013-09-10 Thread Martin Pitt
It looks correct to me in the sense that the free_func is not an argument which should be exposed to Python. pygobject itself needs to manage these to free the passed user_data (and its python wrapper). The bit that looks wrong to me is the dropping of the two (allow-none)s, I asked about that in