[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-10-17 Thread Daniel van Vugt
** Changed in: mir Status: Fix Committed = Fix Released ** Changed in: mir Milestone: phone-v1-freeze = None -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-10-10 Thread Daniel van Vugt
** Changed in: mir Status: Fix Released = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and fails if it's not something it

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-10-05 Thread Michał Sawicz
** Changed in: unity8 (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and fails if it's not something

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-30 Thread kevin gunn
** Changed in: unity8 (Ubuntu) Status: Confirmed = Fix Committed ** Changed in: mir Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title:

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-30 Thread Daniel van Vugt
** Changed in: mir Assignee: (unassigned) = Michael Terry (mterry) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and fails if it's not something it

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Alan Griffiths
In principle I don't think it is a good idea to ignore unrecognised arguments on the command line - that only leads to confusion when users misspell something. Having two separate parts of the program parsing them is the real problem Mir was coded on the misguided assumption that boost.Options was

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: unity8 (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title:

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Michael Terry
Looks like unity-mir would really need to re-implement mir::options::ProgramOption and pass our own version back in an overridden version of the_options(). ProgramOption actually makes the call to parse_command_line() internally, its variable_maps instance that holds all the parsed options is

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Michael Terry
Oh, but I guess we can't do that either, because parse_arguments() is only in mir::options::ProgramOption rather than mir::options::Option. So it's not something we could pass back with an overridden parse_arguments(). So we'd have to override both the_options() and parse_options(), duplicating a

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Michael Terry
Nope... argv and argc are private. I'm beginning to think this needs to be solved at the Mir level. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Michael Terry
(Sorry, misspoke. Obviously we could have access to argv or argc if we need them, they pass through our constructor. What I meant was that program_options is private, which holds the results of calls to add_option(), which is not virtual. Thus we can't reasonably parse argv ourselves. We need

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Launchpad Bug Tracker
** Branch linked: lp:~mterry/mir/unregistered-options -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and fails if it's not something it understands To

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Alan Griffiths
To be clear program_options may be private, but it is passed to parse_options() which could be overridden so that you can parse argv yourself. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread kevin gunn
needs a quick fix at least to unblock AP tests. currently available is this MP https://code.launchpad.net/~mterry/mir/unregistered-options/+merge/188125 (which needs to be retargeted to dev branch) -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread kevin gunn
** Changed in: unity-mir Status: Incomplete = Opinion ** Changed in: mir Milestone: None = phone-v1-freeze ** Changed in: unity-mir Milestone: None = phone-v1-freeze ** Changed in: unity8 (Ubuntu) Milestone: None = ubuntu-13.10 -- You received this bug notification because

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Launchpad Bug Tracker
** Branch linked: lp:~mterry/mir/dev-unregistered-options -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and fails if it's not something it understands

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread Michael Terry
To be clear program_options may be private, but it is passed to parse_options() which could be overridden so that you can parse argv yourself. Yes, you have access to the stated options. And you can access argv/argc yourself (if you save them, since they are private in

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-27 Thread PS Jenkins bot
Fix committed into lp:~mir-team/mir/development-branch at revision None, scheduled for release in mir, milestone Unknown ** Changed in: mir Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-26 Thread Gerry Boland
Well I'd request by default that Mir, as a library, only listens for the command line arguments it recognises, and ignores all others. Qt are GTK libraries which do this. While the Mir default behaviour can be overridden by unity-mir, I think it makes more sense for the change to be in Mir

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-20 Thread Robert Ancell
Existing Mir code uses mir::report_exception() to print exceptions out nicely. Discussed with Michał, the request on Mir is that it can ignore options it doesn't understand so Qt can be initialised with the option list after Mir has scanned it. ** Changed in: mir Importance: Undecided =

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-20 Thread Robert Ancell
This should be possible to solve since Mir revision 1069. You can override DefaultServerConfiguration::parse_options() and parse the arguments yourself without throwing an exception. You would need to copy some code from src/server/default_server_configuration.cpp to do this and keep the

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-20 Thread Robert Ancell
Relevant boost code to allow unknown options: http://www.boost.org/doc/libs/1_54_0/doc/html/program_options/howto.html#idp123440592 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title:

[Bug 1226227] Re: libmirserver parses arguments and fails if it's not something it understands

2013-09-16 Thread Gerry Boland
** Project changed: unity8 = unity-mir -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1226227 Title: libmirserver parses arguments and fails if it's not something it understands To manage