Bug 1324062 tracks the missing lua 5.2 support issue.
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nginx in Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
Bug 1324062 tracks the missing lua 5.2 support issue.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
After discussion between Adam Conrad, Thomas Ward, Dimitri John Ledkov,
and myself, we came to conclusion that we should not remove the nginx-
lua module from the distribution. So, we will re-promote lua5.1 to main
as a build dependency for nginx and continue building the nginx-lua
module so
Cleaned up teward's diff, seeded nginx, and sponsoring the upload as
soon as the archive catches up with some override changes, making it
buildable in main.
** Changed in: nginx (Ubuntu)
Status: Confirmed = Fix Committed
--
You received this bug notification because you are a member of
** Branch linked: lp:ubuntu/trusty-proposed/nginx
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nginx in Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
This bug was fixed in the package nginx - 1.4.6-1ubuntu3
---
nginx (1.4.6-1ubuntu3) trusty; urgency=medium
* Add new binary package for main, nginx-core, which contains only
source-tarball-included modules and no third-party modules.
* Changes to debian/ directory:
-
After discussion between Adam Conrad, Thomas Ward, Dimitri John Ledkov,
and myself, we came to conclusion that we should not remove the nginx-
lua module from the distribution. So, we will re-promote lua5.1 to main
as a build dependency for nginx and continue building the nginx-lua
module so
Cleaned up teward's diff, seeded nginx, and sponsoring the upload as
soon as the archive catches up with some override changes, making it
buildable in main.
** Changed in: nginx (Ubuntu)
Status: Confirmed = Fix Committed
--
You received this bug notification because you are a member of
** Branch linked: lp:ubuntu/trusty-proposed/nginx
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
This bug was fixed in the package nginx - 1.4.6-1ubuntu3
---
nginx (1.4.6-1ubuntu3) trusty; urgency=medium
* Add new binary package for main, nginx-core, which contains only
source-tarball-included modules and no third-party modules.
* Changes to debian/ directory:
-
Attached is a debdiff for this MIR based off of 1.4.6 which Adam Conrad
merged into Ubuntu.
Whomever needs to review this, please review. Thanks.
** Patch added: nginx-1.4.6 debdiff for the MIR
This debdiff here contains typos that sarnold found, and is in response
to this:
sarnold teward: hey :) nice debdiff, thanks; there is an UNRELEASED in the
changelog, and 'nginx-extra' typo in the Description: field for the nginx-core
package. otherwise it looks good to me. Thanks for taking
I meant it contains fixes for typos.
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nginx in Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
Attached is a debdiff for this MIR based off of 1.4.6 which Adam Conrad
merged into Ubuntu.
Whomever needs to review this, please review. Thanks.
** Patch added: nginx-1.4.6 debdiff for the MIR
This debdiff here contains typos that sarnold found, and is in response
to this:
sarnold teward: hey :) nice debdiff, thanks; there is an UNRELEASED in the
changelog, and 'nginx-extra' typo in the Description: field for the nginx-core
package. otherwise it looks good to me. Thanks for taking
I meant it contains fixes for typos.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
Valentin, regarding your comment in comment 7 about things being fixed
in mainline, that fix won't hit Ubuntu until Debian has mainline. As
of right now, I don't think they're switching to the mainline branch
yet.
To all: We're going to drop the Lua module from nginx-extras for the
MIR. If you
Attached is a possible debdiff that can be used to do following for this MIR:
(1) Adds an nginx-core package which contains only the modules that are shipped
with the nginx upstream source.
(2) Removes the Lua module from nginx-extras (because the liblua5.1-dev
build-dependency is not permitted
** Patch removed: Potential full debdiff for the MIR
https://bugs.launchpad.net/ubuntu/+source/nginx/+bug/1262710/+attachment/4015030/+files/NGINX_trusty_MIR.debdiff
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to nginx in Ubuntu.
Thanks to Adam Conrad, NGINX 1.4.6 is now in Trusty (see
https://bugs.launchpad.net/ubuntu/+source/nginx/+bug/1290063 )
I'll rebase my debdiff off 1.4.6 instead, as soon as I get to stable
internet again. (this might be tomorrow :/)
--
You received this bug notification because you are a
Valentin, regarding your comment in comment 7 about things being fixed
in mainline, that fix won't hit Ubuntu until Debian has mainline. As
of right now, I don't think they're switching to the mainline branch
yet.
To all: We're going to drop the Lua module from nginx-extras for the
MIR. If you
Attached is a possible debdiff that can be used to do following for this MIR:
(1) Adds an nginx-core package which contains only the modules that are shipped
with the nginx upstream source.
(2) Removes the Lua module from nginx-extras (because the liblua5.1-dev
build-dependency is not permitted
** Patch removed: Potential full debdiff for the MIR
https://bugs.launchpad.net/ubuntu/+source/nginx/+bug/1262710/+attachment/4015030/+files/NGINX_trusty_MIR.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Thanks to Adam Conrad, NGINX 1.4.6 is now in Trusty (see
https://bugs.launchpad.net/ubuntu/+source/nginx/+bug/1290063 )
I'll rebase my debdiff off 1.4.6 instead, as soon as I get to stable
internet again. (this might be tomorrow :/)
--
You received this bug notification because you are a
I guess that remains the most sane solution, drop the Lua module and
dependency, and leave it out of the package in Ubuntu. I'll add the
drop the Lua module changes to my debdiff after work today and drop
the debdiff here for review.
Note that this MIR also needs a FFe since FeatureFreeze is
Lua module's upstream people have suggested either static-link against
Lua 5.1, which still doesn't solve this problem, or to use
libluajit-5.1-dev (2.0.2+) as the dependency.
This *does* build with libluajit-5.1-dev. However, that is still in
Universe as well, and would need Main inclusion in
Strictly speaking, my role in the MIR is to provide an assessment of
what the security team believes is supportable for five years.
Maintaining a language's runtime support environment for five years is
no small undertaking. Lua 5.1 support is in a rough place -- it's
already two years obsolete,
teward and sarnold,
Do you two have what you need from NGINX as to answers to move this
forward?
sarah
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage
Sarah,
We're working on adding an 'nginx-core' package added that builds all
the modules that ship with the nginx source tarball. The other problem
is the optional Lua module in the universe package that we have to
figure out how to work with. It doesn't work with Lua 5.2 and that is
blocking
You can use the --help configure argument to get a list of all
available options. I've attached outputs for vanilla nginx 1.4.6 and
1.5.11.
The actual list of supported (optional and default) modules is follow in
alphabetical order:
1. Default HTTP modules (built by default, but can be switched
Sarah, thanks for the reminder; I had my one remaining outstanding
question answered to my satisfaction: http://mailman.nginx.org/pipermail
/nginx-devel/2014-February/005038.html -- in short, I hadn't realized
X509_NAME_oneline() would escape the ascii NUL character when converting
from ASN.1 to a
Seth,
Lua module upstream has outright said 5.2 isn't supported, I poked
around there for the Lua module and they said so.
I'm researching alternatives.
--
Thomas
*Sent from my iPhone. Please excuse any typos, as they are likely to
happen by accident.*
On Mar 5, 2014, at 14:44, Seth
for completeness -- https://github.com/chaoslawful/lua-nginx-
module/issues/343
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go
Thanks for the review.
Just a few quick comments:
- ngx_devpoll_process_events() is missing an argument for a format
specifier
Already fixed in mainline: http://hg.nginx.org/nginx/rev/6b479db5b52b
I'd love to see a static analyzer that can check for additional
errors.
We use Coverity on a
I spoke to sarnold on IRC briefly last night. They said they might
support a separate upstream-only binary or an added build that has
only upstream modules shipped with nginx.
I'll take a look tomorrow and see what I can do to accommodate this.
However, it stands to be noted that most users
Hmm, seems I was wrong, it's compiled but just isn't used.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
I reviewed nginx version 1.4.4-4ubuntu1 as checked into trusty. This
should not be considered a full security audit but rather a quick gauge
of maintainability.
The Debian nginx package provides both upstream nginx server as well
as third-party modules. Nginx is high-quality legible code,
** Changed in: nginx (Ubuntu)
Assignee: Jamie Strandboge (jdstrand) = Seth Arnold (seth-arnold)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage
I just realised that liblua5.2-dev is in main. Perhaps we can bump lua
in nginx in Ubuntu, and maybe see if Debian are OK to update, too.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
** Changed in: nginx (Ubuntu)
Milestone: None = ubuntu-14.04-beta-1
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go to:
This is for the supported seed?
Yes, that seems the most appropriate. Thanks.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
[MIR] nginx
To manage notifications about this bug go
This is for the supported seed? This has security implications, so I'll
assign to Jamie.
** Changed in: nginx (Ubuntu)
Assignee: (unassigned) = Jamie Strandboge (jdstrand)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: nginx (Ubuntu)
Status: New = Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1262710
Title:
It seems that we have to drop lua from the nginx build as a cost of
moving nginx to main. If we do this, then the following debdiff appears
to work. debian/control should also have the nginx-extras binary package
description changed to not claim that Lua is included.
** Patch added:
44 matches
Mail list logo
