[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-04-04 Thread Erick Brunzell
I opened bug 1565780 to address the missing nautilus preferences menu in Xenial. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title: Re-enable traditional titlebar on 'gnome-but-not-shell'

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-11 Thread Alberts Muktupāvels
On Fri, Mar 11, 2016 at 8:29 PM, Dmitry Shachnev wrote: > > I can update branch if needed, but I will do it only if I will know > that it will be merged. > > Actually, can you repeat this on your own merge proposal? The reviewers > don't receive mails about code changes by

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-11 Thread Dmitry Shachnev
> I can update branch if needed, but I will do it only if I will know that it will be merged. Actually, can you repeat this on your own merge proposal? The reviewers don't receive mails about code changes by default, only about comments. If you get no reply after that, I'll ping Lars elsewhere.

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-11 Thread Alberts Muktupāvels
On Fri, Mar 11, 2016 at 7:11 PM, Dmitry Shachnev wrote: > @Alberts, > > > P.S. The problem is not only with nautilus. Looks like Ambiance is and > will be Unity only theme. It not updated to support csd windows. It does > not work good with mutter, metacity - CSD windows are

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-11 Thread Dmitry Shachnev
@Alberts, > P.S. The problem is not only with nautilus. Looks like Ambiance is and will be Unity only theme. It not updated to support csd windows. It does not work good with mutter, metacity - CSD windows are not resizable, windows has problem with rounded corners... The problem for rounded

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-09 Thread Tim
On 09/03/16 18:57, Alberts Muktupāvels wrote: > What do you mean with input settings? Input sources? Than it is already > available, but disabled... input device settings, i.e. mouse, touchpad etc. These moved out of g-s-d mouse plugin, into a mutter libinput based backend, but as mentioned

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-09 Thread Alberts Muktupāvels
On Wed, Mar 9, 2016 at 9:27 AM, Tim wrote: > > That is right thing... GNOME Flashback should work with GNOME components > > not Unity. > OK, Flashback was set to unity, it did not have support for current GNOME > components > I know that. >> Does flashback have full

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Tim
On 09/03/16 16:59, Alberts Muktupāvels wrote: > Did you upload new nautilus package? When I wrote it it was about patches > in last uploaded version in xenial. Also it is not only about old > patches/code, same problem is with new patches/code - mostly it is simple > g_strcmp0... No I meant "needs

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Alberts Muktupāvels
On Wed, Mar 9, 2016 at 5:16 AM, Tim wrote: > The usage of XDG_CURRENT_DESKTOP in nautilus should be fixed. Most of > the patches predate the standardisation of XDG_CURRENT_DESKTOP which now > allows for multiple desktop names. > Did you upload new nautilus package? When I

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Khurshid Alam
Why don't we use it like gedit? i.e +static gboolean +in_desktop (const gchar *name) +{ + const gchar *desktop_name_list; + gchar **names; + gboolean in_list = FALSE; + gint i; + + desktop_name_list = g_getenv ("XDG_CURRENT_DESKTOP"); + if (!desktop_name_list)

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Tim
The usage of XDG_CURRENT_DESKTOP in nautilus should be fixed. Most of the patches predate the standardisation of XDG_CURRENT_DESKTOP which now allows for multiple desktop names. As for "GNOME-Flashback:Unity" vs "GNOME-Flashback:GNOME", switching would mean going back to

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Alberts Muktupāvels
In normal GNOME session preferences is available in appmenu, no? in GNOME by default that menu is displayed in top panel, but it is possible to change that so this appmenu is displayed by nautilus. At least it was possible in nautilus 3.18 and is still possible in nautilus 3.20. GNOME Flashback

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Erick Brunzell
@ Tim Lunn, there is another nautilus bug that affects both gnome-shell and gnome-flashback, bug #1554171. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title: Re-enable traditional

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Erick Brunzell
Since in a normal GNOME session you access "preferences" and some other things by right-clicking on the nautilus tab in the top bar when nautilus is open, how would that be accessible in gnome-flashback? -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-08 Thread Alberts Muktupāvels
GNOME Flashback in Ubuntu has "GNOME-Flashback:Unity" as XDG_CURRENT_DESKTOP so most likely it should use Unity settings, but nautilus has at least few patches that tries to detect Unity incorrectly... git_multiple_desktop_names.patch is only patch that correctly detects Unity. It is time to

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-07 Thread Erick Brunzell
Sorry Tim, I forgot to mention this is a flashback problem. I brought the issue up on their mailing list. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title: Re-enable traditional titlebar

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-07 Thread Tim
Lance, nautilus was reverted to the version from 15.10, so it should be the same as there. What desktop is this happening under? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title:

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2016-03-06 Thread Erick Brunzell
I notice that Nautilus > preferences can't be accessed in Xenial, sort of like Nautilus should be using the Unity style menus rather than those used by gnome-shell??? As far as I've seen ATM only Nautilus is affected by that in Xenial but I need to have a closer look at some of the other GNOME

Re: [Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-09 Thread Dmitry Shachnev
On Feb 9, 2014 8:50 AM, Tim t...@feathertop.org wrote: @Matthieu, I was discussing this mitya57 the other day with respect to -flashback. it seems that it would be best to move the GNOME2/Compiz sessions to using Unity, since that is far closer to the legacy environments that these sessions

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-09 Thread Alkis Georgopoulos
@Alkis: I think there is a typo in Ubuntu's patch. Can you stop nautilus (nautilus -n) and then try to launch it with: $ env XDG_CURRENT_DESKTOP=GNOMEF nautilus For some reason `nautilus -n` didn't do it, but `killall nautilus; nautilus` did the trick. I.e. after the `killall nautilus`

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Matthieu Baerts
@Alkis: I think there is a typo in Ubuntu's patch. Can you stop nautilus (nautilus -n) and then try to launch it with: $ env XDG_CURRENT_DESKTOP=GNOMEF nautilus -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Matthieu Baerts
Sorry for the delay... @Sebastien: Do you have any example of thing that would stop working if you changed your DesktopName to be cairo-dock? Yes, I guess that if we change the DesktopName to Cairo-Dock (or something else), we will have problems with programs which are launched at startup.

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Matthieu Baerts
@Tim: especially in cases where the default upstream GNOME3 behaviour has changed significantly Yes, I agree that Cairo-Dock and Flashback sessions can't be considered as a Gnome-Shell session and some changes in GNOME 3.10 apps are now too specific to Gnome-Shell. But I think it can be

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Matthieu Baerts
@Alkis Georgopoulos (alkisg): I guess you've this bug: LP #1277963 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Matthieu Baerts
Sorry: LP: #1277963 https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1277963 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title: Re-enable traditional titlebar on

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Tim
@Matthieu, I was discussing this mitya57 the other day with respect to -flashback. it seems that it would be best to move the GNOME2/Compiz sessions to using Unity, since that is far closer to the legacy environments that these sessions require. Things are just going to diverge further in the

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-08 Thread Matthieu Baerts
@Tim: yes, currently it's maybe the best solution if we don't have to patch .desktop/autostart files. But it can also be interesting to have a default mode for all sessions started with gnome-session (Unity, Cairo-Dock, Flashback, etc.) with some exceptions for Gnome-Shell (or Unity if it needs

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-02 Thread Tim
gnome2/compiz sessions such as flashback and cairo-dock, should really not be using GNOME, this is mostly gnome-shell specific. GNOME Classic, should probably be using GNOME since it is gnome-shell based. Although that makes it impossible to have different behaviour in classic vs gnome-shell.

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-02-01 Thread Alkis Georgopoulos
With gnome-flashback, I did the following change: $ grep DesktopName /usr/share/xsessions/gnome-fallback.desktop X-LightDM-DesktopName=FGNOME Logout/login, my environment now is: DESKTOP_SESSION=gnome-fallback SESSIONTYPE=gnome-session XDG_CURRENT_DESKTOP=FGNOME And, nautilus 1:3.10.1-0ubuntu2

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Sebastien Bacher
Thanks Matthieu, those bars should be enabled until under gnome-shell imho, I'm going to have a look to your changes today ** Changed in: nautilus (Ubuntu) Importance: Undecided = Low ** Changed in: nautilus (Ubuntu) Status: New = Confirmed -- You received this bug notification

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Sebastien Bacher
On my session, XDG_CURRENT_DESKTOP=GNOME that seems buggy, what is setting that variable? it should be set by gnome-session (if you use it) to whatever session you use, that's what we use to specify behaviours for GNOME and Unity specific differences. That seems a bug in your

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Matthieu Baerts
Yes this environment variable is set by gnome-session. In fact, this Cairo-Dock session is like the former Gnome Panel session but with another panel. So I guess we can see it as a Gnome Fallback session where XDG_CURRENT_DESKTOP=GNOME and DESKTOP_SESSION is not set to gnome (but gnome-fallback

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Sebastien Bacher
Only gnome-shell sessions should have XDG_CURRENT_DESKTOP=GNOME, are you sure gnome-fallback/panel session using that as well (that would be wrong). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Matthieu Baerts
Yes I think that they always use the same XDG_CURRENT_DESKTOP env variable but DESKTOP_SESSION is different. I can't test it right now but there you can see some reports by other users: http://ubuntuforums.org/showthread.php?t=2184682page=19 and

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Sebastien Bacher
The changes happened in the oneiric cycle, see https://launchpad.net/ubuntu/+source/gnome-session/3.1.3-0ubuntu6 * debian/patches/52_xdg_current_desktop.patch: - Set XDG_CURRENT_DESKTOP inside gnome-session based on a new key 'DesktopName' in gnome-session .desktop files. You are

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Sebastien Bacher
but it's also possible that since GNOME 3.10, they have change some env variables No, it's nothing new, we have used that variable for some cycles now, see e.g http://bazaar.launchpad.net/~ubuntu-desktop/nautilus/ubuntu/view/head:/debian/patches/16_unity_new_documents.patch#L108 -- You

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Matthieu Baerts
You are right that the GNOME classic session seems to use GNOME as a session name though, maybe that should be changed It depends of what we want to have :-) For me, it's better that GNOME Classic and Cairo-Dock sessions are considered as a GNOME session. We can change the value of

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-31 Thread Sebastien Bacher
Your definition of GNOME is not the one we have, some extra comments: - gnome-session setting XDG_CURRENT_DESKTOP is an Ubuntu feature, not an upstream one, we use it change behaviour between Unity/gnome-shell - the previous point means the things that use that variable are limited, they are

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-30 Thread Matthieu Baerts
** Summary changed: - Re-enable traditional titlebar on 'gnome-but-not-shell' sessions + Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too ** Description changed: Hello and thank you for maintaining Nautilus packages, I'm using Ubuntu on a Cairo-Dock session. With the

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-30 Thread Launchpad Bug Tracker
** Branch linked: lp:~matttbe/ubuntu/trusty/nautilus/lp1274740 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1274740 Title: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too To

[Bug 1274740] Re: Re-enable traditional titlebar on 'gnome-but-not-shell' sessions too

2014-01-30 Thread Matthieu Baerts
In fact, the question should be: do we have to re-enable the traditional titlebar on Gnome Fallback sessions too? I guess it's a question for Ubuntu Gnome, Ubuntu Desktop and/or Ubuntu Design teams, no? I'm proposing a patch (see the branch linked to this bug report) which currently only