[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Bug watch removed: Debian Bug tracker #832938 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832938 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

This bug was fixed in the package zfs-linux - 0.6.5.6-0ubuntu12 --- zfs-linux (0.6.5.6-0ubuntu12) xenial; urgency=medium * Change to include some important tools in zfsutils-linux build. - Add tools : arcstat.py, arc_summary.py & dbufstat.py in /usr/sbin. - Change utilities

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@scotte (lscotte), The .py removal will come separately, the package found in -proposed (Xenial) and -update (Yakkety) are for the original issue only: arcstat.py, arc_summary.py & dbufstat.py not ship in the Ubuntu zfsutils-linux DEB package. Another package version will include the .py suffix

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@slashd Sorry for not being more clear - I already tested from proposed (see comment #22). As far as I can tell, it hasn't changed since then but it is unclear to me if the renaming from .py from upstream will happen separately or as part of this issue. I'm fine with it either way, it just helps

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@rlaager, Thanks for the .debdiff, let's wait and see what will be done in Debian by Aron, and then cherry-pick what's needed to remove the .py suffix. Also instead of using "mv" to rename, I wonder if dh-exec can be put to use for renaming files during the dh_install phase. example :

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Hi scotte (lscotte), The xenial patched package can be found in the -proposed archive (AKA Fix Commited : last step before landing into stable release -update) if positive feedbacks from community. Here's the instruction on how to enable -proposed archive:

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

OOps, per my last comment regarding tracking issue upstream - that's the Debian bug you previously mentioned, https://bugs.debian.org/cgi- bin/bugreport.cgi?bug=832938, not further upstream from ZoL. Sorry for my misunderstanding. :-/ -- You received this bug notification because you are a

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

That's great news that upstream ZFS will get that fixed up - I didn't see a an issue for it at the ZoL github, are there plans to do so. Would be nice from a tracking perspective so this issue is tied in. Also, I see the Ubuntu update was published for Yakkety, but I'm not sure where Zenial is -

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and arc_summary.py with zfsutils-linux To manage notifications about this bug go to:

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Following a discussion with a ZFS debian maintainer He confirmed that he is going to put the python scripts into /usr/sbin and remove the .py suffix in the Debian package. Eric -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

This bug was fixed in the package zfs-linux - 0.6.5.7-0ubuntu5 --- zfs-linux (0.6.5.7-0ubuntu5) yakkety; urgency=medium * Change to include some important tools in zfsutils-linux build. - Add tools : arcstat.py, arc_summary.py & dbufstat.py in /usr/sbin. - Change utilities path

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Thanks lscotte, That good to know, not sure if this package is an official Debian package though, or more something ZoL have build to work Debian ? https://github.com/zfsonlinux/zfs/wiki/Debian "Although ZFS On Linux is now officially in the Debian GNU/Linux repository, we will continue to

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

To add to the confusion - arcstat.py and friends are already in /usr/sbin in the Debian packages I have on Debian Jessie... $ dpkg -S /usr/sbin/arcstat.py zfsutils: /usr/sbin/arcstat.py $ apt show zfsutils Package: zfsutils Source: zfs-linux Version: 0.6.5.7-8-jessie Maintainer: Debian ZFS on

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@lscotte, Keep in mind that depending on the discussion I'll have with Debian, the scripts location and naming is susceptible to change from what you see in "0.6.5.6-0ubuntu12". I'll update the bug when I have more details. Regards, Eric -- You received this bug notification because you are a

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Debian bug : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832938 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and arc_summary.py with zfsutils-linux To manage

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

I have reported a bug to Debian about 2 topics : * Python script location /usr/sbin or /usr/bin, but not /bin * Rename python scripts [arcstat, arc_summary * dbufstat] without .py extension as per Debian Policy 10.4 [1] [1] - https://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Sure, but ZoL is not bound by Ubuntu Policy. Ubuntu is. That said, I'll suggest they be fixed upstream too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Testing with 0.6.5.6-0ubuntu12 confirms the tools are now available as expected. Thank you! As far as names ending in .py - while it should be fixed, currently they come that way directly from zfsonlinux. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

I've attached a .debdiff to fix the filenames to comply with Policy 10.4, as @adconrad and I mentioned. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Patch added: "zfs-fix-filenames.debdiff" https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+attachment/4709820/+files/zfs-fix-filenames.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

The scripts shipped to fix this bug still violate Policy 10.4, namely: "When scripts are installed into a directory in the system PATH, the script name should not include an extension such as .sh or .pl that denotes the scripting language currently used to implement it." Ideally, this should be

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Hello Hajo, or anyone else affected, Accepted zfs-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs- linux/0.6.5.6-0ubuntu12 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

These tested OK, so lets get them sponsored and uploaded. I don't have upload rights, so I can't do that right now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@colin-king, I confirmed the correction works, zed is not complaining anymore : # Output of apt-get install # Fetched 905 kB in 2s (320 kB/s) Selecting previously unselected package zfs-doc. (Reading database ... 60137 files and directories currently installed.) Preparing to unpack

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Debdiff for Xenial V2 (16.04) ** Patch removed: "Debdiff for Xenial V2 (16.04)" https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708945/+files/zfs-linux-xenial-v2.debdiff ** Patch added: "Debdiff for Xenial V2 (16.04)"

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Debdiff for Xenial V2 (16.10) ** Patch added: "Debdiff for Xenial V2 (16.10)" https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708946/+files/zfs-linux-yakkety-v2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Debdiff for Xenial V2 (16.04) ** Patch added: "Debdiff for Xenial V2 (16.04)" https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708945/+files/zfs-linux-xenial-v2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@colin-king, I think I found the problem, instead of putting usr/sbin in zfsutils-linux.install. I'll need to specify them per script as follow: usr/sbin/arcstat.py usr/sbin/arc_sumamry.py usr/sbin/dbufstat.py I'll re-do the debdiff for both "Y" and "X". Eric -- You received this bug

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Hi Eric, I applied these patches, built them in a ppa and then did a clean install of zfsutils-linux from -proposed and then upgraded to the packages in the ppa. However, your patches break the upgrade: king@ubuntu:~$ dpkg -l | grep zfsutils-linux ii zfsutils-linux

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Debdiff for Xenial (16.04) ** Patch added: "Debdiff for Xenial (16.04)" https://bugs.launchpad.net/ubuntu/xenial/+source/zfs-linux/+bug/1574342/+attachment/4708833/+files/lp574342_xenial.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Debdiff for Yakkety (16.10) ** Patch added: "Debdiff for Yakkety (16.10)" https://bugs.launchpad.net/ubuntu/xenial/+source/zfs-linux/+bug/1574342/+attachment/4708820/+files/lp1574342_yakkety.debdiff ** Tags added: patch sts -- You received this bug notification because you are a member of

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Description changed: [Impact] zfsutils-linux missing some important tools. Python3 compatible scripts : arc_summary.py, arcstat.py and dbufstat.py found in src_code/cmd/ are not taken into account during compilation. * arc_summary.py : Provides a summary of the

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@rlaager, Neither debian src code or upstream (git) src code have manpage for arcstat.py, arc_summary.py and dbufstat.py. But arcstat have a manpage that can be found online : http://linux.die.net/man/1/arcstat @adconrad, Yes, my plan was to place them under /usr/sbin, and not like Debian did

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@rlageer, At least the program have a "--help" argument Example : --- $ /usr/sbin/arcstat.py --help --- Usage: arcstat.py [-hvx] [-f fields] [-o file] [-s string] [interval [count]] -h : Print this help message -v : List all possible field headers and definitions -x :

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Changed in: zfs-linux (Ubuntu Xenial) Status: New => In Progress ** Changed in: zfs-linux (Ubuntu Xenial) Importance: Undecided => Medium ** Changed in: zfs-linux (Ubuntu Xenial) Assignee: (unassigned) => Eric Desrochers (slashd) -- You received this bug notification because

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

These also should be in /usr/bin (or /usr/sbin), not /bin -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and arc_summary.py with zfsutils-linux To manage

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Also affects: zfs-linux (Ubuntu Yakkety) Importance: Medium Assignee: Eric Desrochers (slashd) Status: In Progress ** Also affects: zfs-linux (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

@slashd, did Debian drop the .py extensions per Policy? Did they write man pages? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

I'll be working on fixing this bugs, and then star the SRU for the fix to make its way to stable release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Description changed: + [Impact] + + zfsutils-linux missing some important tools. + + Python3 compatible scripts : arc_summary.py, arcstat.py and dbufstat.py + found in src_code/cmd/ are not taken into account during compilation. + + * arc_summary.py : Provides a summary of the

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

I looked at the Debian pkg, and it looks like everything is okay on the Debian side. Package: zfsutils-linux Source: zfs-linux Version: 0.6.5.7-1 Architecture: amd64 Maintainer: Debian ZFS on Linux maintainers --- $ dpkg -c

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Changed in: zfs-linux (Ubuntu) Assignee: Colin Ian King (colin-king) => Eric Desrochers (slashd) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title: Ship arcstat.py and

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

** Changed in: zfs-linux (Ubuntu) Status: Confirmed => In Progress ** Changed in: zfs-linux (Ubuntu) Importance: Undecided => Medium ** Changed in: zfs-linux (Ubuntu) Assignee: (unassigned) => Colin Ian King (colin-king) -- You received this bug notification because you are a

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: zfs-linux (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1574342 Title:

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

I think it is safe to "assume" python for the purposes of "is this pulling in more code?". It's not safe to "assume" python for the purposes of the actual dependencies in debian/control. That is, python will have to be listed as a dependency, but I don't think adding this dependency to