Public bug reported:

Wine should use the dosbox config file when launching DOS programs.
Otherwise, users can't control how Wine launches them

In my personal case, I like to set up the aspect option by default. It
works if I load the program directly with dosbox, but not when done via
wine.

There can be an easy way to accomplish this by passing the option
-userconf when launching dosbox. From dosbox's README:

  -userconf
        Start DOSBox with the users specific configuration file. Can be used 
together with multiple -conf parameters, but -userconf will always be loaded 
before them.

This option was added in dosbox 0.74, released more than 6 years ago.

Patch for it. Note that a dependency on dosbox >= 0.74 will need to be
in place too.

diff --git a/programs/winevdm/winevdm.c b/programs/winevdm/winevdm.c
index 290ad25..1662008 100644
--- a/programs/winevdm/winevdm.c
+++ b/programs/winevdm/winevdm.c
@@ -195,7 +195,7 @@ static void start_dosbox( const char *appname, const char 
*args )
         const char *args[4];
         char *config_file = wine_get_unix_file_name( config );
         args[0] = dosbox;
-        args[1] = "-conf";
+        args[1] = "-userconf -conf";
         args[2] = config_file;
         args[3] = NULL;
         ret = _spawnvp( _P_WAIT, args[0], args );

ProblemType: Bug
DistroRelease: Ubuntu 16.10
Package: wine1.6 1:1.6.2-0ubuntu15
ProcVersionSignature: Ubuntu 4.4.0-23.41-generic 4.4.10
Uname: Linux 4.4.0-23-generic x86_64
ApportVersion: 2.20.1-0ubuntu4
Architecture: amd64
CurrentDesktop: Unity
Date: Wed Jun  1 23:36:47 2016
EcryptfsInUse: Yes
InstallationDate: Installed on 2012-11-25 (1284 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Alpha amd64 (20120627)
ProcEnviron:
 LANGUAGE=en_SG:en
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_SG.UTF-8
 SHELL=/bin/bash
SourcePackage: wine1.6
UpgradeStatus: Upgraded to yakkety on 2015-03-14 (444 days ago)

** Affects: wine
     Importance: Unknown
         Status: Unknown

** Affects: dosbox (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: wine1.6 (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: amd64 apport-bug third-party-packages yakkety

** Bug watch added: Wine Bugzilla #40380
   https://bugs.winehq.org/show_bug.cgi?id=40380

** Also affects: wine via
   https://bugs.winehq.org/show_bug.cgi?id=40380
   Importance: Unknown
       Status: Unknown

** Summary changed:

- Wine should use dosbox's configuration instead of creating a new one
+ Wine should use dosbox's user config instead of creating a new one

** Description changed:

  Wine should use the dosbox config file when launching DOS programs.
  Otherwise, users can't control how Wine launches DOS programs
  
+ In my personal case, I like to set up the aspect option by default. It
+ works if I load the program directly with dosbox, but not when done via
+ wine.
  
- [reply] [−] Description shankao 2016-03-29 12:05:55 CDT
- The start_dosbox() function at programs/winevdm/winevdm.c should not start 
with an empty configuration file for dosbox, but take the currently used by the 
user. In a linux system, this is at ./dosbox/dosbox.conf
+ There can be an easy way to accomplish this by passing the option
+ -userconf when launching dosbox. From dosbox's README:
  
- With this, DOS programs loaded via wine will respect the options that
- the user has set up for dosbox, or allow him a way to indicate them.
- 
- In my personal case, I like to set up the aspect option by default. It works 
if I load the program directly with dosbox, but not when done via wine.
- [reply] [−] Comment 1 shankao 2016-06-01 10:34:00 CDT
- There can be an easy way to accomplish this by passing the option -userconf 
when launching dosbox. From dosbox's README:
- 
-   -userconf
-         Start DOSBox with the users specific configuration file. Can be used
-         together with multiple -conf parameters, but -userconf will always be
-         loaded before them.
+   -userconf
+         Start DOSBox with the users specific configuration file. Can be used
+         together with multiple -conf parameters, but -userconf will always be
+         loaded before them.
  
  This option has been added in dosbox 0.74, released more than 6 years
  ago.
  
  Patch for it. Note that a dependency on dosbox >= 0.74 will need to be
  in place too.
  
  diff --git a/programs/winevdm/winevdm.c b/programs/winevdm/winevdm.c
  index 290ad25..1662008 100644
  --- a/programs/winevdm/winevdm.c
  +++ b/programs/winevdm/winevdm.c
  @@ -195,7 +195,7 @@ static void start_dosbox( const char *appname, const char 
*args )
-          const char *args[4];
-          char *config_file = wine_get_unix_file_name( config );
-          args[0] = dosbox;
+          const char *args[4];
+          char *config_file = wine_get_unix_file_name( config );
+          args[0] = dosbox;
  -        args[1] = "-conf";
  +        args[1] = "-userconf -conf";
-          args[2] = config_file;
-          args[3] = NULL;
-          ret = _spawnvp( _P_WAIT, args[0], args );
+          args[2] = config_file;
+          args[3] = NULL;
+          ret = _spawnvp( _P_WAIT, args[0], args );
  
  ProblemType: Bug
  DistroRelease: Ubuntu 16.10
  Package: wine1.6 1:1.6.2-0ubuntu15
  ProcVersionSignature: Ubuntu 4.4.0-23.41-generic 4.4.10
  Uname: Linux 4.4.0-23-generic x86_64
  ApportVersion: 2.20.1-0ubuntu4
  Architecture: amd64
  CurrentDesktop: Unity
  Date: Wed Jun  1 23:36:47 2016
  EcryptfsInUse: Yes
  InstallationDate: Installed on 2012-11-25 (1284 days ago)
  InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Alpha amd64 (20120627)
  ProcEnviron:
-  LANGUAGE=en_SG:en
-  PATH=(custom, no user)
-  XDG_RUNTIME_DIR=<set>
-  LANG=en_SG.UTF-8
-  SHELL=/bin/bash
+  LANGUAGE=en_SG:en
+  PATH=(custom, no user)
+  XDG_RUNTIME_DIR=<set>
+  LANG=en_SG.UTF-8
+  SHELL=/bin/bash
  SourcePackage: wine1.6
  UpgradeStatus: Upgraded to yakkety on 2015-03-14 (444 days ago)

** Description changed:

  Wine should use the dosbox config file when launching DOS programs.
  Otherwise, users can't control how Wine launches DOS programs
  
  In my personal case, I like to set up the aspect option by default. It
  works if I load the program directly with dosbox, but not when done via
  wine.
  
  There can be an easy way to accomplish this by passing the option
  -userconf when launching dosbox. From dosbox's README:
  
    -userconf
-         Start DOSBox with the users specific configuration file. Can be used
-         together with multiple -conf parameters, but -userconf will always be
-         loaded before them.
+         Start DOSBox with the users specific configuration file. Can be used 
together with multiple -conf parameters, but -userconf will always be loaded 
before them.
  
- This option has been added in dosbox 0.74, released more than 6 years
- ago.
+ This option was added in dosbox 0.74, released more than 6 years ago.
  
  Patch for it. Note that a dependency on dosbox >= 0.74 will need to be
  in place too.
  
  diff --git a/programs/winevdm/winevdm.c b/programs/winevdm/winevdm.c
  index 290ad25..1662008 100644
  --- a/programs/winevdm/winevdm.c
  +++ b/programs/winevdm/winevdm.c
  @@ -195,7 +195,7 @@ static void start_dosbox( const char *appname, const char 
*args )
           const char *args[4];
           char *config_file = wine_get_unix_file_name( config );
           args[0] = dosbox;
  -        args[1] = "-conf";
  +        args[1] = "-userconf -conf";
           args[2] = config_file;
           args[3] = NULL;
           ret = _spawnvp( _P_WAIT, args[0], args );
  
  ProblemType: Bug
  DistroRelease: Ubuntu 16.10
  Package: wine1.6 1:1.6.2-0ubuntu15
  ProcVersionSignature: Ubuntu 4.4.0-23.41-generic 4.4.10
  Uname: Linux 4.4.0-23-generic x86_64
  ApportVersion: 2.20.1-0ubuntu4
  Architecture: amd64
  CurrentDesktop: Unity
  Date: Wed Jun  1 23:36:47 2016
  EcryptfsInUse: Yes
  InstallationDate: Installed on 2012-11-25 (1284 days ago)
  InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Alpha amd64 (20120627)
  ProcEnviron:
   LANGUAGE=en_SG:en
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_SG.UTF-8
   SHELL=/bin/bash
  SourcePackage: wine1.6
  UpgradeStatus: Upgraded to yakkety on 2015-03-14 (444 days ago)

** Also affects: dosbox (Ubuntu)
   Importance: Undecided
       Status: New

** Description changed:

  Wine should use the dosbox config file when launching DOS programs.
- Otherwise, users can't control how Wine launches DOS programs
+ Otherwise, users can't control how Wine launches them
  
  In my personal case, I like to set up the aspect option by default. It
  works if I load the program directly with dosbox, but not when done via
  wine.
  
  There can be an easy way to accomplish this by passing the option
  -userconf when launching dosbox. From dosbox's README:
  
    -userconf
          Start DOSBox with the users specific configuration file. Can be used 
together with multiple -conf parameters, but -userconf will always be loaded 
before them.
  
  This option was added in dosbox 0.74, released more than 6 years ago.
  
  Patch for it. Note that a dependency on dosbox >= 0.74 will need to be
  in place too.
  
  diff --git a/programs/winevdm/winevdm.c b/programs/winevdm/winevdm.c
  index 290ad25..1662008 100644
  --- a/programs/winevdm/winevdm.c
  +++ b/programs/winevdm/winevdm.c
  @@ -195,7 +195,7 @@ static void start_dosbox( const char *appname, const char 
*args )
           const char *args[4];
           char *config_file = wine_get_unix_file_name( config );
           args[0] = dosbox;
  -        args[1] = "-conf";
  +        args[1] = "-userconf -conf";
           args[2] = config_file;
           args[3] = NULL;
           ret = _spawnvp( _P_WAIT, args[0], args );
  
  ProblemType: Bug
  DistroRelease: Ubuntu 16.10
  Package: wine1.6 1:1.6.2-0ubuntu15
  ProcVersionSignature: Ubuntu 4.4.0-23.41-generic 4.4.10
  Uname: Linux 4.4.0-23-generic x86_64
  ApportVersion: 2.20.1-0ubuntu4
  Architecture: amd64
  CurrentDesktop: Unity
  Date: Wed Jun  1 23:36:47 2016
  EcryptfsInUse: Yes
  InstallationDate: Installed on 2012-11-25 (1284 days ago)
  InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Alpha amd64 (20120627)
  ProcEnviron:
   LANGUAGE=en_SG:en
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_SG.UTF-8
   SHELL=/bin/bash
  SourcePackage: wine1.6
  UpgradeStatus: Upgraded to yakkety on 2015-03-14 (444 days ago)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1587956

Title:
  Wine should use dosbox's user config instead of creating a new one

To manage notifications about this bug go to:
https://bugs.launchpad.net/wine/+bug/1587956/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to