[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2018-12-11 Thread Alfonso Sanchez-Beato
@tytso awesome, thanks for pointing out. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645232 Title: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL) To

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2018-12-11 Thread Theodore Ts'o
This was a regression that was reported at: https://bugs.launchpad.net/ubuntu/+source/e2fsprogs/+bug/1807288 ... a fix has been applied uptream and the fix has been cherry picked for Ubuntu. See the above bug for details. -- You received this bug notification because you are a member of

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2018-12-11 Thread Alfonso Sanchez-Beato
I am getting this in bionic, with e2fsprogs 1.44.1-1. In fact, I have tried with e2fsprogs upstream and happens as well. I have simply followed the instructions in the bug description to reproduce. So, somewhat, although part of the patch was included upstream, it did not fix completely the

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-31 Thread Theodore Ts'o
Fix is in e2fsprogs 1.43.4 ** Changed in: e2fsprogs (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645232 Title: e2fsprogs - could not preserve

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-29 Thread Shrawan Kumar
Thanks Theodore & Sojan!! Regards Shrawan -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645232 Title: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL) To

Re: [Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-29 Thread Shrawan Kumar
Thanks a lot !! Regards Shrawan On Sun, Jan 29, 2017 at 11:27 AM, Sojan James wrote: > Thank you Theodore. > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1645232 > > Title: > e2fsprogs -

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-28 Thread Sojan James
Thank you Theodore. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645232 Title: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL) To manage notifications

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-28 Thread Theodore Ts'o
I've committed a complete fix to the master branch of the e2fsprogs git tree. One of the reasons why I don't want to commit a partial fix is because the potential for corruption of production file systems by programs such as fuse2fs was extremely high. Users of mke2fs -d are generally embedded

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-18 Thread Sojan James
Hi Theodore, The write_xattrs_to_buffer is already doing other modifications to the xattrs, like sorting keys. (look for qsort). The changes I made are a logical extension to that. Further refinement might need a larger bunch of changes. I don't have the bandwidth for this now unfortunately.

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-15 Thread Theodore Ts'o
I was hoping you would be interested in further refining the patch which you put forward. But if you don't have the time or interest, that's fine, I'll put it on my queue of things on my todo list. (Or maybe someone from Canonical will be interested in picking this up.) -- You received this

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-15 Thread Sojan James
Hello Theodore, Thank you for the feedback. I only had mke2fs in mind when trying to look for a fix as this solves my immediate problem - to be able to preserve ACLs when creating a filesystem via the Yocto build system. I agree that the ext2fs_{read,write}_ functions may be a better place to

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-14 Thread Theodore Ts'o
Thanks for the patch; it definitely helps identify the problem. I don't think it is a completely correct change, however. The problem is that it's doing the translation in write_xattrs_to_buffer(), but it is not making the translation in the opposite direction in read_xattrs_to_buffer(). This

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-14 Thread Ubuntu Foundations Team Bug Bot
The attachment "0001-mke2fs-handle-ACL-in-xattrs-correctly.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2017-01-14 Thread Sojan James
Hello, I have a fix for this and the patch is attached. I couldn't find the right mailing list for e2fsprogs. Until I find that, this is a good place to upload the patch. mke2fs was copying the ACL in the POSIX extended attribute format. The attached patch converts it to for format expected by

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2016-12-05 Thread Shrawan Kumar
Hello All, As an additional info , I can see that POSIX capabilities and SMACK rules are getting preserved. The problem is only with ACL rules. Regards Shrawan -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2016-12-02 Thread Tyler Hicks
Hello and thanks for the bug report! I was tempted to mark this bug as invalid since you compiled e2fsprogs from git and aren't using Ubuntu's e2fsprogs. However, I see that yakkety (16.10) and zesty both have a new enough e2fsprogs to support the -d option. I tried your reproducer in yakkety,

[Bug 1645232] Re: e2fsprogs - could not preserve ACL permissions : The getxattr() returns with (EINVAL)

2016-12-02 Thread Tyler Hicks
Thanks for taking the time to report this bug and helping to make Ubuntu better. We appreciate the difficulties you are facing, but this appears to be a "regular" (non-security) bug. I have unmarked it as a security issue since this bug does not show evidence of allowing attackers to cross