This bug was fixed in the package autofs - 5.1.6-2ubuntu0.1
---
autofs (5.1.6-2ubuntu0.1) focal; urgency=medium
* Allow administrative shares to work (LP: #1680224):
- d/p/lp1680224-fix-double-quoting-in-auto_smb.patch
-- Rafael David Tinoco Wed, 03 Jun 2020
00:30:58 +
This bug was fixed in the package autofs - 5.1.2-1ubuntu3.2
---
autofs (5.1.2-1ubuntu3.2) bionic; urgency=medium
* Allow administrative shares to work (LP: #1680224):
- d/p/lp1680224-fix-double-quoting-in-auto_smb.patch
-
This bug was fixed in the package autofs - 5.1.5-1ubuntu2
---
autofs (5.1.5-1ubuntu2) eoan; urgency=medium
* Allow administrative shares to work (LP: #1680224):
- d/p/lp1680224-fix-double-quoting-in-auto_smb.patch
-- Rafael David Tinoco Wed, 03 Jun 2020
01:01:46 +
**
VERIFICATION
BIONIC
(k)rafaeldtinoco@autofslabb:~$ dpkg-query -f '${Package} ${Version}\n' -W
'autofs'
autofs 5.1.2-1ubuntu3.2
(k)rafaeldtinoco@autofslabb:~$ cat /cifs/localhost/myshare/myshare.txt
This is myshare.
(k)rafaeldtinoco@autofslabb:~$ cat /cifs/localhost/C$/c.txt
This is C.
Hello Mark, or anyone else affected,
Accepted autofs into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/autofs/5.1.6-2ubuntu0.1 in a few
hours, and then in the -proposed repository.
Please help us by testing this new package. See
** Changed in: autofs (Ubuntu Focal)
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680224
Title:
auto.smb fails on Windows administrative shares
To
Talking to @bdmurray there was a concern about SRU'ing the:
- d/p/lp1680224-fix-and-double-quoting-in-auto_smb.patch
to previous versions as this new SRU will require a new bug to be
opened.
I'm documenting it here so this is not forgotten.
--
You received this bug notification because you
This bug was fixed in the package autofs - 5.1.6-2ubuntu1
---
autofs (5.1.6-2ubuntu1) groovy; urgency=medium
[ Andreas Hasenack ]
* Allow administrative shares to work (LP: #1680224):
- d/p/lp1680224-fix-double-quoting-in-auto_smb.patch
-
(c)rafaeldtinoco@bionic:~/.../sources/ubuntu/autofs$ git ubuntu tag --upload
git: 'ubuntu' is not a git command. See 'git --help'.
(c)rafaeldtinoco@bionic:~/.../sources/ubuntu/autofs$ git describe --tags
upload/5.1.2-1ubuntu3.2
(c)rafaeldtinoco@bionic:~/.../sources/ubuntu/autofs$ git push pkg
I have uploaded fixes for:
Groovy
Focal
Eoan
and I'm uploading for Bionic.
Groovy contains the fix for "&" and "$"
Focal contains the fix for "$"
Eoan contains the fix for "$"
Bionic contains the fix for "$" (without the mem alloc changes since they're
not needed and SRU would likely not
** Merge proposal unlinked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/386265
** Merge proposal unlinked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/385013
--
You received this bug notification because you
** Merge proposal linked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/386264
** Merge proposal linked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/386265
** Merge proposal linked:
** Description changed:
+ [Impact]
+
+ - Unable to get windows admin share (C$) mounted through autofs
+ - All other shares seem to work fine
+ - Mount / command line work fine for admin shares
+
+ [Test Case]
+
+
+ #!/bin/bash
+
+ set -e
+ set -x
+
+ sudo apt update && sudo apt
Here is the new test script, with a case for "&":
#!/bin/bash
set -e
set -x
sudo apt update
sudo apt dist-upgrade -y
sudo apt install autofs samba smbclient cifs-utils -y
sudo mkdir /myshare /c /a\
echo "This is myshare." | sudo tee /myshare/myshare.txt
echo "This is C." | sudo tee /c/c.txt
echo
Let's also attach it
** Attachment added: "autofs-test.sh"
https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+attachment/5380061/+files/autofs-test.sh
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Same fix works for bionic's autofs 5.1.2.
/etc/auto.smb is already quoting the paths, so escaping these characters
before that quoting just makes the escape character "\" a literal, and
then things fail.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
The "C$" case is working with the patch, but "&" is still problematic. I
tried with groovy, which has autofs 5.1.6, and a share defined like the
below doesn't get mounted:
[a]
path = /ab
read only = yes
guest ok = yes
mount(generic): calling mount -t cifs -o guest
Here is a script for the test case:
#!/bin/bash
set -e
set -x
sudo apt update && sudo apt dist-upgrade -y
sudo apt install autofs samba smbclient cifs-utils -y
sudo mkdir /myshare /c
echo "This is myshare." | sudo tee /myshare/myshare.txt
echo "This is C." | sudo tee /c/c.txt
echo "
[myshare]
** Merge proposal linked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/385011
** Merge proposal linked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/385012
** Merge proposal linked:
** Also affects: autofs (Ubuntu Focal)
Importance: Undecided
Status: New
** Changed in: autofs (Ubuntu Focal)
Status: New => Confirmed
** Changed in: autofs (Ubuntu Focal)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of
Upstream just removed the \$$ gsub() handling in auto.smb:
commit a557e6261afc87d3849b557257185ff72be15a82 (HEAD -> upstream-master,
upstream/master)
Author: Ian Kent
Date: Sun May 31 08:47:29 2020 +0800
autofs-5.1.6 - fix double quoting in auto.smb
The example program mount
Ah, and I added an ubuntu user: sudo smbpasswd -a ubuntu
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680224
Title:
auto.smb fails on Windows administrative shares
To manage notifications about
To simplify testing next time, these are the configs I used:
smb.conf shares:
[myshare]
path = /myshare
read only = no
guest ok = no
[C$]
comment = test for windows administrative share
path = /c
read only = no
guest ok = no
I commented in the MP, but let me add something here too.
Groovy/focal with autofs 5.1.6-2 (same package as debian) show the same
problem. And the packages from the attached MP for bionic still won't work:
Jun 1 20:05:15 bionic-autofs kernel: [ 751.949808] CIFS VFS:
BAD_NETWORK_NAME:
Based on case history, to fully address this to all still supported
Ubuntu releases:
autofs | 5.1.2-1ubuntu3 | bionic |
autofs | 5.1.2-1ubuntu3.1 | bionic-updates |
autofs | 5.1.2-4ubuntu2 | disco |
autofs | 5.1.5-1ubuntu1 | eoan|
autofs | 5.1.6-2
Based on case history, to fully address this to all still supported
Ubuntu releases:
autofs | 5.1.2-1ubuntu3 | bionic |
autofs | 5.1.2-1ubuntu3.1 | bionic-updates |
autofs | 5.1.2-4ubuntu2 | disco |
autofs | 5.1.5-1ubuntu1 | eoan|
autofs | 5.1.6-2
** Merge proposal linked:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/autofs/+git/autofs/+merge/382338
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680224
Title:
auto.smb fails
** Also affects: autofs (Ubuntu Eoan)
Importance: Undecided
Status: New
** Also affects: autofs (Ubuntu Bionic)
Importance: Undecided
Status: New
** Changed in: autofs (Ubuntu Bionic)
Status: New => Confirmed
** Changed in: autofs (Ubuntu Eoan)
Status: New =>
** Also affects: autofs (Ubuntu Eoan)
Importance: Undecided
Status: New
** Also affects: autofs (Ubuntu Bionic)
Importance: Undecided
Status: New
** Changed in: autofs (Ubuntu Bionic)
Status: New => Confirmed
** Changed in: autofs (Ubuntu Eoan)
Status: New =>
I've retested this with autofs 5.1.5 (eoan), and @ahasenack's suggested
change to auto.smb is definitely required. With the $ escaped, mount
fails as it's given a literal \$ in the path.
For older versions of autofs, the following workaround works (tested with
autofs 5.1.2 on bionic):
I haven't revisited this yet due to lack of time. Whoever gets to this
next should check the current version of autofs, and also the list of
available patches for the version shipped in older ubuntu releases.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
I haven't revisited this yet due to lack of time. Whoever gets to this
next should check the current version of autofs, and also the list of
available patches for the version shipped in older ubuntu releases.
--
You received this bug notification because you are a member of Ubuntu
Server, which
I can't get it to work without also removing the quoting in the awk script in
/etc/auto.smb, i.e.:
@@ -76,7 +76,7 @@
loc = $2
# Enclose mount dir and location in quotes
# Double quote "$" in location as it is special
-
I can't get it to work without also removing the quoting in the awk script in
/etc/auto.smb, i.e.:
@@ -76,7 +76,7 @@
loc = $2
# Enclose mount dir and location in quotes
# Double quote "$" in location as it is special
-
I honestly don't know. The initial patches from April 12th of 2017 were all
I needed and I haven't messed with it since.
On Wed, Jun 6, 2018, 09:20 Andreas Hasenack,
wrote:
> @mark-fox, were those two patches the only changes you needed, or was
> the change to the awk script (removing the
@mark-fox, were those two patches the only changes you needed, or was
the change to the awk script (removing the quoting of $) also needed?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680224
@mark-fox, were those two patches the only changes you needed, or was
the change to the awk script (removing the quoting of $) also needed?
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
ok, the worker-thread patch I think was just a case of an incorrect
patch description in lp.
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1680224
Title:
auto.smb fails on Windows
ok, the worker-thread patch I think was just a case of an incorrect
patch description in lp.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680224
Title:
auto.smb fails on Windows administrative
And
https://mirrors.edge.kernel.org/pub/linux/daemons/autofs/v5/patches-5.1.3/autofs-5.1.2
-fix-offset-mount-location-multiple-expansion.patch, mentioned in
comment #10 too
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
I believe these are the upstream patches:
https://mirrors.edge.kernel.org/pub/linux/daemons/autofs/v5/patches-5.1.3/autofs-5.1.2-use-malloc-for-expanded-map-location.patch
I believe these are the upstream patches:
https://mirrors.edge.kernel.org/pub/linux/daemons/autofs/v5/patches-5.1.3/autofs-5.1.2-use-malloc-for-expanded-map-location.patch
And
https://mirrors.edge.kernel.org/pub/linux/daemons/autofs/v5/patches-5.1.3/autofs-5.1.2
-fix-offset-mount-location-multiple-expansion.patch, mentioned in
comment #10 too
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
In reviewing the first patch I've found another problem with
mapent_len possibly not being initialized.
Note the order of application of the patch is:
autofs-5.1.2 - use malloc for expanded map location
autofs-5.1.2 - fix offset mount location multiple expansion
and, although they are against
I have made a small change to the patch of comment #6.
I've added initialization of the malloc()ed pmapent variable.
While that wasn't a problem it can be on some architectures.
** Patch added: "Patch - increase worker thread per-thread stack size"
The two autofs patches Mark has attached aren't yet available on kernel.org
but I will (eventually) commit them to the autofs repo. and upload them.
The change will be included in autofs-5.1.3.
The only difference between what will be upstream and what has been posted
will be a single line
** Changed in: autofs (Ubuntu)
Importance: Undecided => Medium
** Tags added: zesty
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1680224
Title:
auto.smb fails on Windows administrative shares
The attachment "Patch 0 of 1" seems to be a patch. If it isn't, please
remove the "patch" flag from the attachment, remove the "patch" tag, and
if you are a member of the ~ubuntu-reviewers, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by
~brian-murray,
And the second part of the patch.
** Patch added: "Part 1/1"
https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+attachment/4860739/+files/patch_1.diff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Ian produced a patch that addresses the problem, at least as far as I've
tested it. Whether the target is properly escaped or quoted, it works as
expected.
The patches (to AutoFS 5.1.2, available from git.kernel.org) are
attached and will likely be integrated into AutoFS 5.1.3.
** Patch added:
Hi Mark! Thanks for following up and even reaching out to the
maintainer. Please do share what you find. I'm going to mark this
triaged for now.
** Changed in: autofs (Ubuntu)
Status: Incomplete => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs,
Thanks Josh. I actually tried using ASCII codes for the characters the
day I filed the report. No dice. I've managed to make contact with Ian,
an (the?) autofs maintainer. He thinks he's narrowed the problem down to
a particular commit. If we make any progress, I'll share it here.
--
You
@mark-fox, thanks for filing this report!
If I am reading your report correctly this appears to be specific to
autofs and when you do not escape certain characters? My suggestion was
going to be escaping these charachters or using the ASCII codes for
example:
DOLLARSIGN = \044
AMPERSAND = \046
Experimenting with this a bit, shares with spaces in their names work
fine, but anything with $ or & fails. Ampersands are particularly
troublesome, crashing the automounter if not escaped properly.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
54 matches
Mail list logo
