[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-23 Thread OpenStack Infra
Reviewed: https://review.openstack.org/608235 Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=1884c307a9502393d275e0d5c5b2e56343792908 Submitter: Zuul Branch:stable/rocky commit 1884c307a9502393d275e0d5c5b2e56343792908 Author: Corey Bryant Date: Thu Oct 4

[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-05 Thread OpenStack Infra
Reviewed: https://review.openstack.org/608064 Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=7ad146c48791bebee12fbdcdb1ac2427237343c3 Submitter: Zuul Branch:master commit 7ad146c48791bebee12fbdcdb1ac2427237343c3 Author: Corey Bryant Date: Thu Oct 4 15:29:36

[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-05 Thread Launchpad Bug Tracker
This bug was fixed in the package python-oslo.config - 1:6.4.0-0ubuntu2 --- python-oslo.config (1:6.4.0-0ubuntu2) cosmic; urgency=medium * d/p/py3-ensure-iter-list.patch: Ensure ConfigOpts __iter__ uses list(d.keys()) as d.keys() no longer returns a copy of keys in py3 (LP:

[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-04 Thread Ben Nemec
Weird. This code doesn't seem like it would alter the opts. Is it possible that another thread registered an opt on the config object during the iteration? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-04 Thread Ben Nemec
** Changed in: oslo.config Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796163 Title: py3 failure cfg.py - dictionary changed size during iteration To manage

[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-04 Thread Corey Bryant
I went with a minimal fix on this. There are other uses of d.keys() in oslo.config but I'm not sure which ones modify the dictionary during iteration. Could change all uses to list(d.keys()) but that would somewhat defeat the purpose of the PEP. -- You received this bug notification because you

[Bug 1796163] Re: py3 failure cfg.py - dictionary changed size during iteration

2018-10-04 Thread OpenStack Infra
Fix proposed to branch: master Review: https://review.openstack.org/608064 ** Changed in: oslo.config Status: New => In Progress ** Changed in: oslo.config Assignee: (unassigned) => Corey Bryant (corey.bryant) -- You received this bug notification because you are a member of Ubuntu