[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-06 Thread Erich Eickmeyer
** Changed in: lsp-plugins Status: Fix Committed => Fix Released ** Changed in: ubuntustudio Status: Fix Committed => Fix Released ** Changed in: ubuntu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, whic

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-04 Thread Erich Eickmeyer
** Changed in: lsp-plugins Status: In Progress => Fix Committed ** Changed in: ubuntustudio Status: In Progress => Fix Committed ** Changed in: ubuntu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which i

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-04 Thread Łukasz Zemczak
...since the debian/watch file still didn't quite work, I fixed it and pushed the changes to the repository. Now it's good to go! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1827288 Title: [Needs

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-04 Thread Łukasz Zemczak
Thanks for addressing all the issues! I also see that the new version of the package build successfully on the autobuild PPA, awesome. I think this is now good for upload and acceptance - let me do that now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is s

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Erich Eickmeyer
** Changed in: ubuntu Status: Fix Committed => In Progress ** Changed in: ubuntustudio Status: Fix Committed => In Progress ** Changed in: lsp-plugins Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which i

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Erich Eickmeyer
Working with the upstream developer, I was able to apply patches that fix the test suite issues. @sil2100's question 2) above (and the item frustrating myself and @vorlon) is fixed. Git repo is tagged for 1.1.9-0ubuntu1 release to eoan. -- You received this bug notification because you are a memb

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Erich Eickmeyer
Question from the upstream developer RE: sil2100's question 2): > Is it possible to run build again before running tests? I can change the > build scripts so the > binaries for tests will be built in a different folder (not .build but .test, > for example) > and can be launched from this folder.

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Erich Eickmeyer
Addendum to previous comment (sorry about the noise): > Or you can build both versions (test and non-test) on the build stage > (the 'release' will be in '.build' subdirectory, the 'test' will be in > '.test' subdirectory), then package all from the '.build' as a distribution > and launch tests fr

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Erich Eickmeyer
@sil2100 Thanks for the review! 1) Looks like it was looking in "tags" instead of "release" so I fixed accordingly. 2) Actually, it turns out I was never able to get the test suite to work. Seems to be broken upstream. I thought it was referring to actually testing to see if they work, so that wa

Re: [Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Steve Langasek
On Mon, Jun 03, 2019 at 05:03:53PM -, Łukasz Zemczak wrote: > 2) I still see that override_dh_auto_test disables tests. In comment #6 > you mentioned that you were somehow able to make those working. Do those > really not work currently? Of course if there's no way of running them > during buil

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Łukasz Zemczak
Thank you for your upload! I did a quick review of the package in the NEW queue and I do have a few things I'd like cleared out before we get this one accepted into universe: 1) debian/watch file seems to be incorrect? I would like this accepted before proceeding. At least when I tried running usc

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Thomas Ward
** Changed in: ubuntu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1827288 Title: [Needs Packaging] LSP-Plugins for Eoan To manage notifications about this bug

[Bug 1827288] Re: [Needs Packaging] LSP-Plugins for Eoan

2019-06-03 Thread Erich Eickmeyer
** Also affects: ubuntu Importance: Undecided Status: New ** Changed in: ubuntu Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1827288 Title: [Needs Pac