** Changed in: grub2 (Ubuntu Focal)
Status: Fix Released => Triaged
** Changed in: grub2 (Ubuntu Focal)
Status: Triaged => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Changed in: grub2 (Ubuntu Focal)
Status: Triaged => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub
Agreed. It is a multi-line problem (which by its nature includes a '\r')
not being handled. Happy to test the solution on my system.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Actually I think '\r' is a red herring. The problem is that if several
devices are used for a pool (raid, log or cache) grub-probe returns
several lines. Several are not handled properly when we generate the
line of metadata used to create the menu. The patch is to take the first
device returned
I'll strip the \r as a safety measure but I cannot reproduce this issue.
I created a mirror on 2 devices with log and cache devices on separate
partitions of a third disk like your setup and the line separator is
always a new line character (0x0a) without carriage return (0x0d).
--
You received
** Changed in: grub2 (Ubuntu)
Status: Confirmed => Triaged
** Changed in: grub2 (Ubuntu)
Assignee: (unassigned) => Jean-Baptiste Lallement (jibel)
** Also affects: grub2 (Ubuntu Focal)
Importance: Medium
Assignee: Jean-Baptiste Lallement (jibel)
Status: Triaged
--
** Changed in: grub2 (Ubuntu)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
The \r is an invisible return character, commonly returned by an echo.
However, here, we are executing grub_probe --target=device /boot
The code in 10_linux_zfs:
initrd_device=$(${grub_probe} --target=device "${boot_dir}")
The results are the same as above. For the specific entry, it is the
Thanks for digging into this and finding your root cause!
I'm really wondering what is causing this additional \r on that variable
compared to a standard installation, with multiple kernels and initrds,
which doesn't get this \r. Do you have any specific grub configuration
in /etc/default/grub*
I tested the fix propossed by jpb in #21 and it works for me.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
** Attachment added: "10_linux_zfs"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5299059/+files/10_linux_zfs
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Problem identified. The variable intrd_device contains a \r at the end
of the variable. When concatenating the variable with the subsequent
variables, it effectively truncates the subsequent data in the echo
return.
Preceding the if statement, I inserted the following:
# remove the
** Tags added: rls-ff-incoming
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications
The attachment "1848856.debdiff" seems to be a debdiff. The ubuntu-
sponsors team has been subscribed to the bug report so that they can
review and hopefully sponsor the debdiff. If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if
True, grub-probe will produce several lines. On my system it lists my
drives as my actual mirrors, followed by my logs and then the cache --
same order as zpool status rpool
grub-probe --target=device /boot
/dev/sdc1
/dev/sda1
/dev/nvme0n1p2
/dev/nvme0n1p4
I'm not seeing in 10_linux_zfs where
I have a similar setup, a ssd as a cache for the root partition. The
problem is grub-probe list multiple disks for the boot folder, which
caused the /etc/grub.d/10_linux_zfs script.
The 10_linux_zfs is expecting one disk, but the following commands will return
several lines.
/usr/sbin/grub-probe
Hi Rex - you essentially removed the line that set at_least_one_entry=1.
Yes, that removes an extra "}" but if you look at the generated script, the
linux line specifies no kernel image and the initrd line includes no file.
This will result in an unbootable system.
linux
I believe the invalid grub menu is caused by wrong "}", when there is
only a main section.
** Patch added: "1848856.debdiff"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298611/+files/1848856.debdiff
--
You received this bug notification because you are a member
My current work around is to manually maintain the grub.cfg in
/boot/grub. Using the version that was generated under 19.04, I have
simply updated the kernel and initrd to reflect the new modules.
This still means that any package I install that needs to regenerate the
grub.cfg will fail. So
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: grub2 (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Yes, my rpool is mirrored.
pool: rpool
state: ONLINE
status: Some supported features are not enabled on the pool. The pool can
still be used, but some features are unavailable.
action: Enable all features using 'zpool upgrade'. Once this is done,
the pool may no longer be
Is your rpool mirrored?
On a test enviroment if I detach one of the drives, I can run update-
grub. Reattaching the drive breaks update-grub.
I'm currently stuck in 19.04 because of this bug.
# zpool status
pool: zroot
state: ONLINE
scan: scrub repaired 0B in 2h59m with 0 errors on Sun
I'm getting closer to finding the problem. It looks like in function
get_dataset_info() in 10_linux_zfs the content of initrd_list,
kernel_list, and last_booted_kernel are not being echoed back on the
call. I don't know why yet. I haven't fully grasp the shell script.
--
You received this bug
zsys is currently not installed.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications
I modified 10_linux_zfs to comment out the set -e and add the variables
for pkgdatadir and the GRUB* variables from /etc/default/grub and ran it
to see the output.
Notice at the end the double brace, lack of initrd value and linux image
even though it was found at the beginning when it correctly
One more piece of information. I have 3 zfs pools defined:
rpool for my root
dpool for my data (virtualization and other)
bpool for my external usb backup device
So, my bpool is different than the 19.10 new bpool to support the boot
process. I don't know if this is a problem, but thought I'd
Looking closer at the 19.04 grub.cfg and the post19.10 grub.cfg.new I
see that the 19.04 version of update-grub was using 10_linux instead of
10_linux_zfs to generate the grub.cfg.new.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Attachment added: "Generaged Grub.cfg prior to 19.10"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298391/+files/grub.cfg.pre1910
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Attachment added: "update-grub.log"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298388/+files/update-grub.log
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
** Attachment added: "grub.cfg.new"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298389/+files/grub.cfg.new
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
** Attachment added: "grub"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298390/+files/grub
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade
31 matches
Mail list logo
