Public bug reported:

SRU Justification

Impact:
We recently backported SECCOMP_USER_NOTIF_FLAG_CONTINUE in 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1847744. On a kernel that 
supports SECCOMP_FILTER_FLAG_NEW_LISTENER but not 
SECCOMP_USER_NOTIF_FLAG_CONTINUE the selftests currently fail to compile. The 
reason is that the ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE is placed under 
the ifndef for SECCOMP_FILTER_FLAG_NEW_LISTENER.

Fix:
The ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE was placed under the
ifndef for the SECCOMP_FILTER_FLAG_NEW_LISTENER feature. This will not
work on systems that do support SECCOMP_FILTER_FLAG_NEW_LISTENER but do not
support SECCOMP_USER_NOTIF_FLAG_CONTINUE. So move the latter ifndef out of
the former ifndef's scope.

Regression Potential:
Limited to seccomp selftests.

Test Case:
Compile the selftests on a kernel that supports 
SECCOMP_FILTER_FLAG_NEW_LISTENER but does not support 
SECCOMP_USER_NOTIF_FLAG_CONTINUE and see that compilations succeeds.

Target Kernels: All current LTS kernels with access to a 5.0 kernel.

Patches:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/seccomp&id=2aa8d8d04ca29c3269154e1d48855e498be8882f

** Affects: linux (Ubuntu)
     Importance: Undecided
     Assignee: Christian Brauner (cbrauner)
         Status: In Progress

** Changed in: linux (Ubuntu)
       Status: New => In Progress

** Changed in: linux (Ubuntu)
     Assignee: (unassigned) => Christian Brauner (cbrauner)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1849281

Title:
  seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1849281/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to