** Description changed:
[Impact]
- nvme-cli in bionic lacks the toshiba-nvme plugin. This plugin provides
functionality unique to Toshiba NVME devices:
- $ sudo ./nvme toshiba
+ The version of nvme-cli in Bionic (1.5-ubuntu1) lacks support for
+ functionality unique to Toshiba NVMe
On Tue, Mar 10, 2020 at 3:50 PM Matthew Ruffell
<1866...@bugs.launchpad.net> wrote:
> Note, Dann, your patch is wrong, since you drop the wrong parameter. You
> are dropping data_len instead of cdw12.
Aha! Nice catch Matthew.
--
You received this bug notification because you are a member of
** Tags added: sts
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1866897
Title:
Add toshiba plugin support
To manage notifications about this bug go to:
After reviewing the code for adding the cdw12 parameter to
nvme_set_feature(), I believe it is safe to drop the parameter.
Analysis:
54f5e4a Add support for decoding IO Determinism features
@@ -477,13 +478,13 @@ int nvme_feature(int fd, __u8 opcode, __u32 nsid, __u32
cdw10, __u32 cdw11,
Cherry-picking the following commit causes a build failure:
3d52c76 Add toshiba plugin code and command documentation.
This is due to a change due to a since-added parameter to nvme_set_feature() in:
54f5e4a Add support for decoding IO Determinism features
Following the pattern of changes in
I also suggest we pull in:
5e9239e Fixes for log page access.
** Changed in: nvme-cli (Ubuntu Focal)
Status: New => Fix Released
** Changed in: nvme-cli (Ubuntu Eoan)
Status: New => Fix Released
** Changed in: nvme-cli (Ubuntu Bionic)
Status: New => Confirmed
--
You
