[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-10 Thread Launchpad Bug Tracker
This bug was fixed in the package nginx - 1.18.0-6ubuntu8 --- nginx (1.18.0-6ubuntu8) hirsute; urgency=medium * d/modules/control: Remove Lua module from definitions * d/tests/: - control: Remove Lua test, remove dependencies on any test which request

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-09 Thread Christian Ehrhardt 
The change that pulls this into main is in https://launchpad.net/ubuntu/+source/nginx/1.18.0-6ubuntu7 which is in hirsute-proposed now. The only deps are (as expected) Depends: nginx-common (= 1.18.0-6ubuntu7), libc6 (>= 2.33), libmaxminddb0 (>= 1.0.2) All of them are in main already.

Re: [Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-08 Thread Christian Ehrhardt 
> I think someone has failed hardcore on part 2 of that comment - there's > already a ./debian/modules/watch/http-geoip2 watch file containing the > following in Hirsute: Absolutely right, it is fine by now - sorry for missing it earlier. And to complete - also the second TODO is covered: 151

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-08 Thread Thomas Ward
Note that all the watches seem to be organized by ./debian/modules/watch/[MODULENAME] and match items in ./debian/modules/[MODULENAME]. That is inherited from Debian. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-08 Thread Thomas Ward
paelzer: I think someone has failed hardcore on part 2 of that comment - there's already a ./debian/modules/watch/http-geoip2 watch file containing the following in Hirsute: version=4 opts="dversionmangle=s/v//,filenamemangle=s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%libnginx-mod-http-geoip2-$1.tar.gz%"

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-07 Thread Christian Ehrhardt 
Thanks Steve, thereby almost everything seems to be ready now. @Teward when you add the dependency pulling libnginx-mod-http-geoip2 (from nginx-core I guess) into main just add the minimal TODOs we've had in comment #1 (small version bump to 3.3 and adding ./debian/modules/watch). Once done that

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-06 Thread Thomas Ward
Steve Beattie: This MIR is strictly for the http-geoip2 module and not stream-geoip2. I have not slated stream modules for Main inclusion as it is not something that we have tested in depth, therefore the stream configs and modules unless they are already in Main should be considered Universe

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-06 Thread Steve Beattie
I reviewed libnginx-mod-http-geoip2/nginx 1.18.0-6ubuntu4 (aka http-geoip2 3.3 upstream) as checked into hirsute. This shouldn't be considered a full audit but rather a quick gauge of maintainability. libnginx-mod-http-geoip2 is an nginx module registers variables on the connection based on the

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-01 Thread Thomas Ward
Discussed via IRC, but libmaxminddb is a dependency that needs to be in Main if we're going to get this third-party module (shipped inside src:nginx) binary-included in Main. The module is still actively reviewed by the third party developer but has not had any code changes to the underlying C

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2021-03-01 Thread Seth Arnold
teward, I'm a bit confused on the status of https://bugs.launchpad.net/ubuntu/+source/libmaxminddb/+bug/1861101 and this MIR -- can you let us know if there's a new module nginx module that still needs review because it's desired to move it into main? Thanks -- You received this bug

[Bug 1867198] Re: MIR: bin:libnginx-mod-http-geoip2 from src:nginx

2020-03-13 Thread Christian Ehrhardt 
This is a bit of a special review, the few packaging bits "on top of normal nginx" are just: - ./debian/libnginx-mod-http-geoip2.nginx - ./debian/libnginx-mod.conf/mod-http-geoip2.conf and a few entries in d/rules - debian/rules:16:http-geoip2 \ - debian/rules:122: