[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-10-26 Thread Launchpad Bug Tracker
This bug was fixed in the package golang-github-docker-go-connections - 0.4.0-2ubuntu0.21.04.1 --- golang-github-docker-go-connections (0.4.0-2ubuntu0.21.04.1) hirsute; urgency=medium * Fix FTBFS which is blocking runc migration (LP: #1930891). - d/p/0001-Skip-tests-which-use-e

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-10-21 Thread Lucas Kanashiro
The regressions are gone and now this is ready to land. The Test Plan section indicates this would need to build in Hirsute and here you go: https://launchpad.net/ubuntu/+source/golang-github-docker-go- connections/0.4.0-2ubuntu0.21.04.1/+build/21685532 ** Tags removed: verification-needed verifi

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-10-15 Thread Lucas Kanashiro
Sorry, the debdiff above is incorrect. The golang-github-containers- image package in hirsute was uploaded disabling LTO here: https://bugs.launchpad.net/ubuntu/bionic/+source/golang-github- containers-image/+bug/1938908/comments/28 Once this is accepted, we will be able to land this update which

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-10-15 Thread Lucas Kanashiro
This is hitting us again while backporting the container stack: https://bugs.launchpad.net/ubuntu/bionic/+source/golang-github- containers-image/+bug/1938908 I'll disable LTO to make it build fine on the failing architectures. Debdiff attached. ** Patch added: "golang-github-docker-go-connectio

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-16 Thread Lucas Kanashiro
The package is FTBFS on non-amd64 architectures (64-bits only) due to LTO. I could disable LTO in d/rules as well but since the runc SRU was unblocked (already landed) I am not sure if this is still an update we want to land. WDYT? -- You received this bug notification because you are a member of

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-11 Thread Brian Murray
Hello Lucas, or anyone else affected, Accepted golang-github-docker-go-connections into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-github-docker-go- connections/0.4.0-2ubuntu0.21.04.1 in a few hours, and then in the -proposed reposi

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-09 Thread Lucas Kanashiro
@Brian to be honest I also do not know how to mock the date in those tests. I tried some options that I found on some forums but none of them worked out. Upstream is still unresponsive and those same tests are also failing in their master branch. If you think this is not a suitable SRU I'd ask you

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-08 Thread Brian Murray
I'm not familiar with go but is there anything like datefudge (which was used in an SRU of gnutls28) or faketime that can be used to set the date to one that is before the date on which the certificate expired? I think it'd be better if we didn't skip tests which then might allow the package to reg

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Lucas Kanashiro
After further discussion within the team we decided that using ubuntu0.21.04.1 is the best option here. There is the unlikely but possible case where -3 is removed from impish-proposed and Impish gets released with -2. ** Attachment added: "debdiff3" https://bugs.launchpad.net/ubuntu/+source/g

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Lucas Kanashiro
Thanks for taking another look on this Utkarsh! We append ubuntu0.XX.YY.1 to the version string when we have the same version in 2 releases but in this case this version was released only in Hirsute, Impish was not released yet :) I'll be uploading the last debdiff I attached. -- You received t

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Utkarsh Gupta
Either way, +1 for the patch; go, go, go! \o/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930891 Title: FTBFS in Hirsute is blocking runc migration To manage notifications about this bug go to:

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Lucas Kanashiro
There you go, the attached debdiff has some DEP-3 headers in the added patch. ** Attachment added: "debdiff2" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+attachment/5502460/+files/debdiff2 -- You received this bug notification because you are a

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Utkarsh Gupta
Hey, how about we use 0.4.0-2ubuntu0.21.04.1 as the version number? impish (-release) has the same version atm; I now -3 is in -pocket but still, always helpful to use 0.21.04.X, I believe. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubun

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Lucas Kanashiro
I tried to just import the patch added by the Debian maintainer with no changes but I think it is better to add some DEP-3 headers as you mentioned. Checking the upstream bug tracker I noticed I filed this very same bug some months ago :) but no replies so far: https://github.com/docker/go-connect

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Utkarsh Gupta
This looks good! I'm wondering if that's worth raising an issue upstream? If there is already, probably, add this to the patch header. Except for the DEP3 thingy, it looks good! \o/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https

[Bug 1930891] Re: FTBFS in Hirsute is blocking runc migration

2021-06-04 Thread Lucas Kanashiro
The attached debdiff adds the patch to skip the tests as mentioned in the description and fixes the FTBFS. ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-go-connections/+bug/1930891/+attachment/5502458/+files/debdiff ** Description changed: + [I