[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-24 Thread Christian Ehrhardt 
https://launchpad.net/ubuntu/+source/nftables/1.0.2-1ubuntu2 migrated to Jammy-release And in additon the Debian PR was merged. LGTM, let us focus on what is left in the MIR bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-24 Thread Christian Ehrhardt 
FYI: new version started to build in Jammy https://launchpad.net/ubuntu/+source/nftables/1.0.2-1ubuntu2 Updated the Debian bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007888 Provided a matching salsa PR for Debian

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-24 Thread Christian Ehrhardt 
Thanks for the feedback, uploaded to Jammy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965464 Title: add debian symbols tracking for libnftables1 package To manage notifications about this bug

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-23 Thread Steve Beattie
Yes, that's correct, both commits are needed. The debdiff/merge request look good to me, please go ahead and upload them to jammy so we can have proper symbol versioning on the ibrary itself there. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-23 Thread Christian Ehrhardt 
@Steve After Seth asked me to have a look (see above comments) I tried to help as much as possible, therefore there now is: - a MR https://code.launchpad.net/~paelzer/ubuntu/+source/nftables/+git/nftables/+merge/417523 - PPA https://launchpad.net/~ci-train-ppa-

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-23 Thread Christian Ehrhardt 
Applying both changes seems to work fine for me and does not break due to LTO. I'll polish this for you to consider a follow-on upload ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965464 Title:

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-23 Thread Christian Ehrhardt 
At the moment you are kind of getting around the "wrong symbols" by not using the map (missing 1d507ce7f1d) and thereby not using the wrong symbols (nft_set_optimize/nft_get_optimize). But that explains (as you already know and said above) why it is all @base. -- You received this bug

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-23 Thread Christian Ehrhardt 
@Steve - don't you also need http://git.netfilter.org/nftables/commit/?id=e98a9b83cd52c7c75bedb3dad46539b197ed17ba ? And then an updated symbols file for it? As well as http://git.netfilter.org/nftables/commit/?id=1d507ce7f1d3c12481ee24bd1dcac2fc1984ee9f actually. You said you tried, but what

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-20 Thread Launchpad Bug Tracker
This bug was fixed in the package nftables - 1.0.2-1ubuntu1 --- nftables (1.0.2-1ubuntu1) jammy; urgency=medium * debian/libnftables1.symbols: - create a symbols file to ensure the API does not accidentally change over time (LP: #1965464) -- Steve Beattie Thu, 17 Mar

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-17 Thread Ubuntu Foundations Team Bug Bot
The attachment "nftables_1.0.2-1ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch"

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-17 Thread Bug Watch Updater
** Changed in: nftables (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965464 Title: add debian symbols tracking for libnftables1 package To manage

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-17 Thread Steve Beattie
Submitted patch to Debian: https://bugs.debian.org/cgi- bin/bugreport.cgi?bug=1007888 ** Bug watch added: Debian Bug tracker #1007888 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007888 ** Also affects: nftables (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007888

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-17 Thread Steve Beattie
Debdiff to fix in ubuntu attached ** Patch added: "nftables_1.0.2-1ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/nftables/+bug/1965464/+attachment/5570243/+files/nftables_1.0.2-1ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-17 Thread Steve Beattie
I attemped to fix it with the following patch: Index: b/src/Makefile.am === --- a/src/Makefile.am +++ b/src/Makefile.am @@ -91,7 +91,7 @@ libparser_la_CFLAGS = ${AM_CFLAGS} \ libnftables_la_LIBADD = ${LIBMNL_LIBS} ${LIBNFTNL_LIBS}

[Bug 1965464] Re: add debian symbols tracking for libnftables1 package

2022-03-17 Thread Steve Beattie
One concern with this is that the upstream symbol versioning is broken; generating the debian symbols file looks like so: libnftables.so.1 libnftables1 #MINVER# nft_ctx_add_include_path@Base 0.9.2 nft_ctx_add_var@Base 1.0.0 nft_ctx_buffer_error@Base 0.9.2 nft_ctx_buffer_output@Base 0.9.2