>> 4. 0001-utest-autopkgtest.patch is not needed. You can override it with
>> `make test LIBTRACEEVENT_STATIC="-ltraceevent"`
>
> This variable is *not* override-able without your patch -- it will just be
> assigned unconditionally in the Makefile.
I tested the attached patch and it is working.
This bug was fixed in the package libtraceevent - 1:1.8.2-1ubuntu2
---
libtraceevent (1:1.8.2-1ubuntu2) noble; urgency=medium
* No-change rebuild for CVE-2024-3094
-- William Grant Wed, 03 Apr 2024 22:46:23 +1100
** Changed in: libtraceevent (Ubuntu)
Status: Fix
Thanks, Paul! Looks good to me. I have sponsored this now.
** Changed in: libtraceevent (Ubuntu)
Status: Incomplete => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2055258
Updated patch with enr0n's fix to properly link against the installed
lib and avoid building and linking to the LIBTRACEEVENT_STATIC.
** Patch added: "libtraceevent_1.8.2-1ubuntu1.diff"
Here is a patch with your suggested changes:
- a friendly name on the autopkgtest
- the patch to override the LIBTRACEEVENT_STATIC var added back
- a note about the hijack of this var
- patches 0002 and 0003 forwarded upstream
- Forwarded headers added
autopkgtest is currently running in my
Hi Paul,
I think Benjamin led you astray with this comment:
> 4. 0001-utest-autopkgtest.patch is not needed. You can override it
with `make test LIBTRACEEVENT_STATIC="-ltraceevent"`
This variable is *not* override-able without your patch -- it will just
be assigned unconditionally in the
>> 2. Have you forwarded 0002-fail-unitest-when-test-fail.patch and
>> 0003-fix-tests-on-big-endian.patch to upstream?
>
> No, because I would rather be sure this is reviewed and validated before
> forwarding.
IMO it is better to have upstream feedback on the change before
uploading (in case
Correction of the previous patch using dpkg -L to get the lib path
again, because this is working and the previous method was not. Maybe we
can improve later.
** Patch added: "libtraceevent_1.8.2-1ubuntu1.diff"
Thanks for the review bdrung.
> 2. Have you forwarded 0002-fail-unitest-when-test-fail.patch and
0003-fix-tests-on-big-endian.patch to upstream?
No, because I would rather be sure this is reviewed and validated before
forwarding.
> 3. A newline at the end of debian/rules is missing.
Thanks,
** Changed in: libtraceevent (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2055258
Title:
No test suite run at built time nor as autopkgtest
To manage
1. You do not need to bump the package number as long as it wasn't
uploaded to the main archive. So 1:1.8.2-1ubuntu1 should be the version
number.
2. Have you forwarded 0002-fail-unitest-when-test-fail.patch and
0003-fix-tests-on-big-endian.patch to upstream? If yes, please add that
to the patch
Updated patch. Autopktests in progress, I will update this comment when
they are done.
** Patch added: "libtraceevent_1.8.2-1ubuntu12.diff"
https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2055258/+attachment/5755662/+files/libtraceevent_1.8.2-1ubuntu12.diff
--
You received this
Here is new patch. Thanks to mkukri for finding the root cause of the
failing tests on s390x.
sudipmuk I have split the change in 3 different patch so this will be
easier to upstream.
** Patch added: "libtraceevent_1.8.2-1ubuntu8.diff"
Current patch. 3 tests still fail.
** Patch added: "libtraceevent_1.8.2-1ubuntu7.diff"
https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2055258/+attachment/5750727/+files/libtraceevent_1.8.2-1ubuntu7.diff
--
You received this bug notification because you are a member of Ubuntu
I made some progress. It looks like part of the dataset used to run test
is adapted to big endian (via #if __BYTE_ORDER__ ==
__ORDER_LITTLE_ENDIAN__) but this is not needed (and even problematic).
I am not able to run 9 out of 11 tests successfully and I am still
trying to find a solution for the
sudipmuk do you happen to know if unit tests ever worked on s390x?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2055258
Title:
No test suite run at built time nor as autopkgtest
To manage
Hey sudipmuk. Thanks for the insight anyway, because I thought of
executing the samples at first, so I could have hit these issues.
By the way, If you have any idea why test on s390x fails, I am
interested!
So far I suspected the endianness in dyn_str_data (since s390x is big
endian) but it
The attachment "libtraceevent_1.8.2-1ubuntu5.diff" seems to be a
debdiff. The ubuntu-sponsors team has been subscribed to the bug report
so that they can review and hopefully sponsor the debdiff. If the
attachment isn't a patch, please remove the "patch" flag from the
attachment, remove the
few points.
1. libtraceevent will be using files from "/sys/kernel/debug/tracing/events"
which might or might not be available depending on debugfs is mounted or not.
2. The build is usually done in a schroot and the schroot will not have
its own kernel, so it will use /sys/kernel/ of the host
Ignore the above comment please, that was before seeing the diff. I
thought you were running the samples as a test. The unit tests should be
ok.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2055258
Failure on s390x https://autopkgtest.ubuntu.com/results/autopkgtest-
noble-upils-test-
ppa/noble/s390x/libt/libtraceevent/20240228_090511_c0996@/log.gz
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Current patch.
** Patch added: "libtraceevent_1.8.2-1ubuntu5.diff"
https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2055258/+attachment/5750087/+files/libtraceevent_1.8.2-1ubuntu5.diff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
Updated patch. The test binary will now return 1 if at least one test
failed.
I will run autopkgtest when the pkg is published, and I expect it will
fail (and correctly report this failure) for s390x. We should then
decide if this failure is blocking the MIR process or not.
The ppa:
23 matches
Mail list logo
