[Bug 264275] Re: bazaar internal error if adding file in a linked directory

** Also affects: brz Importance: Undecided Status: New ** Changed in: brz Status: New => Triaged ** Changed in: brz Importance: Undecided => Medium ** Tags removed: check-for-breezy ** Tags added: traceback -- You received this bug notification because you are a member of

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

** Tags added: check-for-breezy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/264275 Title: bazaar internal error if adding file in a linked directory To manage notifications about this bug go to:

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

** Changed in: bzr Importance: Undecided => Medium ** Changed in: bzr (Ubuntu) Importance: Undecided => Medium ** Changed in: bzr (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. http

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

** Changed in: bzr (Ubuntu) Assignee: Declan McGrath (declanmg) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/264275 Title: bazaar internal error if adding file in a linked dire

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

I'm guessing Declan didn't manage to follow up on this, so it shouldn't be considered "In Progress". It can be considered "patch available that needs some tweaking". ** Changed in: bzr Status: In Progress => Confirmed ** Tags added: patch-needswork symlink -- You received this bug notifi

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Hi Andrew, good to hear that the core problem leading to this is being fixed. I presume the recent work would supersede the work I did on my branch. If there still needs to be work done to fix the problem at a higher level, closer to the command line user interface, then it may be possible for me t

Re: [Bug 264275] Re: bazaar internal error if adding file in a linked directory

Unsubscribe -- bazaar internal error if adding file in a linked directory https://bugs.launchpad.net/bugs/264275 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubun

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

I think Martin and John's work on #192859 and maybe #128562 have improved the situation. Using the lp:bzr/2.0 branch (where those fixes have landed, they aren't yet on trunk or the other stable branches) the 'bzr add' now gives: $ bzr add testdir/one bzr: ERROR: bzrlib.errors.PathNotChild: Path

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Hi, I'm the person that submitted the patch. The last activity on it was just before Christmas when I submitted a request for feedback on the merge proposal (as can be seen in the last comment of the merge proposal). As far as I can remember, I don't think I got any feedback too unfortunately I go

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Cristian: See the merge proposal at for details about where this is up to. The summary seems to be that there's a patch, but it needs some more work before it's ready for inclusion in bzr. -- bazaar internal error if adding file

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Hi folks, i get the same bug with my repo but i see is not fixed yet, was set it in progress in 2009-11-24, and i am using 2.0 version. Will be fix it this? -- bazaar internal error if adding file in a linked directory https://bugs.launchpad.net/bugs/264275 You received this bug notification be

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

** Also affects: bzr Importance: Undecided Status: New ** Changed in: bzr Status: New => In Progress -- bazaar internal error if adding file in a linked directory https://bugs.launchpad.net/bugs/264275 You received this bug notification because you are a member of Ubuntu Bugs, w

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Thanks Andrew. I've just submitted a merge proposal as you suggested. Thanks again for the feedback. -- bazaar internal error if adding file in a linked directory https://bugs.launchpad.net/bugs/264275 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

> * I would now like to know is there anything else I need to do? Or can this changeset be formally submitted and a start made on getting this bug resolved? Yes, please submit a merge proposal for this branch: , it definite

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Update * Firstly, thanks for the feedback Andrew * I have refined the code and added appropriate tests to test_add.py under the blackbox tests * I chose to leave my changes at the builtins.py level (thus making the changes subject to blackbox tests rather than unit tests) as, with my current kno

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

1) pass retcode=3 to your run_bzr call 2) New errors classes should have a unit test in test_errors, yes. bzrlib/tests/blackbox is the right place for tests of the command implementations in builtins.py, such as messages that are expected to be printed and how various command-line options are h

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

I have updated my branch and added a python test (as opposed to bash script test) to bzrlib/tests/blackbox/test_add_symlink_wip.py however I get a return code error: AssertionError: Unexpected return code not equal: a = 0 b = 3 Some questions 1) Can someone please advise how to let the test know

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Thanks for the feedback, which I am currently using to help my updated implementation. My approach will be: For any file/directory asked to be added - Get the osutils.realpath() of its parent directory and ensure that this is inside [ie. osutils.is_inside()] the osutils.realpath() of the tree.b

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Your patch is currently failing to pass the whole test suite: 7 failures to be precise. These failures should help you go from your bash scripts to the python counterparts. Since you need the 'ln -s' command, you can't make use of the new shell-like facility, but since you already introduce a mo

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

Added some basic test cases around this bug as bash scripts as an attachment. ** Attachment added: "Basic Test Cases (bash scripts) around Bug #264275" http://launchpadlibrarian.net/33380772/264275_test_cases.tar.gz -- bazaar internal error if adding file in a linked directory https://bugs.la

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

I've had a look at fixing this bug and put the work on a branch of mine at https://code.launchpad.net/~declanmg/bzr/264275-fix I'll look into reorganising the code when I get the chance (am new to bzr and new to python) and adding some tests. Any feedback/advice would be great. ** Branch linked:

[Bug 264275] Re: bazaar internal error if adding file in a linked directory

** Changed in: bzr (Ubuntu) Status: New => Confirmed -- bazaar internal error if adding file in a linked directory https://bugs.launchpad.net/bugs/264275 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list