[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-12 Thread Martin Pitt
For the record: pitti curious - the place you patched out of osspec.c already tries to not overwrite the value with 'unknown' pitti this almost looks as if the inner if should be fixed pitti if (strcmp (hal_device_property_get_string (d, system.formfactor),

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-12 Thread Martin Pitt
hal (0.5.7.1-0ubuntu10) edgy; urgency=low . * Add debian/patches/00upstream-01-music-players-fdi.patch: Update 10-usb-music-players.fdi from GIT head to support many more music players (this supersedes the current 17-mp3-player-fdi.patch). Closes: LP#59022 *

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-12 Thread Martin Pitt
Reopening, upstream has a better patch: http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=f70301c8f426618d52a31d33c846989b1c8e7a52 ** Changed in: hal (Ubuntu) Status: Fix Released = Fix Committed -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 --

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-12 Thread Martin Pitt
Fixed in Ubuntu hal package bzr head, upload awaiting main freeze release (after Knot-3) -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-11 Thread VETSEL Patrice
laptop-detect also find that i'm on a laptop (/proc/acpi/battery test success). Hal already contain many differents tests in sources : /hald/linux2/ - apm.c pmu.c osspec.c and acpi.c) -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-11 Thread Martin Pitt
Patrice has a patch, will be fixed in Edgy soon. ** Changed in: hal (Ubuntu) Assignee: (unassigned) = Martin Pitt Status: Confirmed = In Progress -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-11 Thread VETSEL Patrice
All is in hald/linux2/osspec.c I'v added a test because i suspect that computer_probing_pcbios_helper_done is relaunched on computer object. So if system.formfactor has already be set (by pmu/acpi/dmi) it's not overwrited. ** Attachment added: ensure that system.formfactor is not overwrited if

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-08 Thread VETSEL Patrice
** Changed in: hal (Ubuntu) Status: Unconfirmed = Confirmed -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-08 Thread VETSEL Patrice
** Attachment added: output of lshal http://librarian.launchpad.net/4183328/lshal.txt -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-07 Thread VETSEL Patrice
dmidecode output ** Attachment added: output of dmidecode http://librarian.launchpad.net/4166331/dmidecode.txt -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-07 Thread VETSEL Patrice
For informations : as dmidecode don't find informations for the chassis (bad bios i think), there is a workaround in acpi.c This workaround look if there is a battery bay or a LID button, and if yes, set formfactor to laptop. In devicemanager i'v battery bay. -- hal don't find that I'm on a

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-07 Thread VETSEL Patrice
if i do a : sudo hal-set-property --udi /org/freedesktop/Hal/devices/computer --key system.formfactor --string laptop and relaunch gnome-power-manager, all is ok. ** Changed in: hal (Ubuntu) Importance: High = Medium -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342

[Bug 59342] Re: hal don't find that I'm on a laptop

2006-09-07 Thread John Dong
I've got the same problem on my Acer Aspire 5672, dmidecode also not being able to find info about the chasis. laptop-detect correctly detects I have a laptop, though... Maybe hal needs workarounds similar to what laptop-detect uses? -- hal don't find that I'm on a laptop