[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-02-15 Thread Launchpad Bug Tracker
This bug was fixed in the package udev - 166-0ubuntu1 --- udev (166-0ubuntu1) natty; urgency=low * New upstream release: - 8 keymap fixes, including LP: #702426 - Fix keymap tool to display scan codes in unexpected event order. (LP: #702407) - Bug fixes. * Merge

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-02-15 Thread Launchpad Bug Tracker
** Branch linked: lp:~ubuntu-core-dev/ubuntu/natty/udev/ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702407 Title: thinkpad_acpi generated EV_KEY events are mssing scancodes -- ubuntu-bugs

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-26 Thread Launchpad Bug Tracker
This bug was fixed in the package linux - 2.6.38-1.27 --- linux (2.6.38-1.27) natty; urgency=low [ Andy Whitcroft ] * ubuntu: AUFS -- update aufs-update to track new locations of headers * ubuntu: AUFS -- update to c5021514085a5d96364e096dbd34cadb2251abfd * SAUCE: ensure root

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-19 Thread Andy Whitcroft
** Changed in: linux (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702407 Title: thinkpad_acpi generated EV_KEY events are mssing scancodes -- ubun

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-18 Thread Seth Forshee
Attaching the patch for thinkpad_acpi that was submitted upstream. ** Patch added: "thinkpad-acpi-report-scancodes.patch" https://bugs.launchpad.net/ubuntu/+source/udev/+bug/702407/+attachment/1798121/+files/thinkpad-acpi-report-scancodes.patch -- You received this bug notification because y

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-17 Thread Seth Forshee
I've sent a patch for thinkpad_acpi to always produce scan codes upstream and received an ack from the maintainer. It also reverses the order of the codes so that versions of keymap without your new state machine will work with thinkpad_acpi as well. ** Changed in: linux (Ubuntu) Assignee: Ca

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-16 Thread Martin Pitt
Thanks Seth! I implemented the more robust state machine in http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=90f182c3d69a4451bb1ea6f79d8d7fe4895cdf89 now. I confirm that in the case of known key codes, the thinkpad_acpi driver is not reporting scan codes, but it should; otherwise you can

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-16 Thread Martin Pitt
** Also affects: udev (Ubuntu) Importance: Undecided Status: New ** Changed in: udev (Ubuntu) Importance: Undecided => Medium ** Changed in: udev (Ubuntu) Status: New => In Progress ** Changed in: udev (Ubuntu) Assignee: (unassigned) => Martin Pitt (pitti) -- You recei

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-14 Thread Martin Pitt
Ah, thanks Seth! I was never really clear that I actually need for a series of events and a SYN. If some drivers don't send SYN events, then it becomes highly nontrivial to do a correct operation then, as you'd need to wait for a SYN, some events before, and time out if no SYN arrives? -- You rec

Re: [Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-14 Thread Seth Forshee
On Fri, Jan 14, 2011 at 06:30:12PM -, Martin Pitt wrote: > > thinkpad_acpi does send scancodes, but only when it's reporting > KEY_UNKNOWN > > Ah, that would be part of the problem. In the reported cases, the faulty > keys didn't have an unknown, but a wrong key code assigned. Right, keymap j

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-14 Thread Martin Pitt
> thinkpad_acpi does send scancodes, but only when it's reporting KEY_UNKNOWN Ah, that would be part of the problem. In the reported cases, the faulty keys didn't have an unknown, but a wrong key code assigned. To be honest I'm not quite sure what you mean by the ordering issue. >From what I unde

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-14 Thread Seth Forshee
thinkpad_acpi does send scancodes, but only when it's reporting KEY_UNKNOWN, and then it sends the scancode after the keycode. keymap seems to expect that there's always a scancode and that it will always come before the keycode. Do you know if there's any requirement to send the scancode or for th

[Bug 702407] Re: thinkpad_acpi generated EV_KEY events are mssing scancodes

2011-01-13 Thread Martin Pitt
This is probably an one-line patch in thinkpad_acpi, and would allow me to provide much better hotkey support for ThinkPads, so I take the liberty to assign this to the kernel team (Andy confirmed that we really want to fix this keind of bugs). Thanks! ** Changed in: linux (Ubuntu) Status: