[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2018-02-01 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 4.0.0-1ubuntu1 --- libvirt (4.0.0-1ubuntu1) bionic; urgency=medium * Merged with Debian unstable (4.0) This closes several bugs: - Error generating apparmor profile when hostname contains spaces (LP: #77) - qemu 2.10

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2017-10-24 Thread ChristianEhrhardt
Actually this one has to wait for BB, not SRU worthy (especially after all the time hard to argument), but hey it will be resolved on the next merge for sure being upstream now. ** Tags added: libvirt-18.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2017-10-24 Thread ChristianEhrhardt
Related changes upstream now, will be picked no next merge. Likely consider picking in advance as soon as BB opens up. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/77 Title: Error generating

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2017-09-19 Thread ChristianEhrhardt
Did some experiments and dropping the space from the bad chars makes it work for me as well. Added a change for that and also enqueued the addition of quotes to the static rules. I still expect issues with spaces down the road in some parts of libvirt, but if spaces are going to be forbidden

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2017-06-13 Thread ChristianEhrhardt
** Tags removed: server-next -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/77 Title: Error generating apparmor profile when hostname contains spaces To manage notifications about this bug go

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2017-06-08 Thread ChristianEhrhardt
** Tags added: server-next ** Tags added: virt-aa-helper -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/77 Title: Error generating apparmor profile when hostname contains spaces To manage

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2016-03-29 Thread Serge Hallyn
@jdstrand indeed dropping space from the list in valid_name seems to fix it and work. i can virsh define/start/console/destroy with no problems. Do you have any suggestions for additional testing? This will have to wait until 16.10 opens so there's no real hurry... -- You received this bug

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2016-03-27 Thread James Thomas Moon
Still occurs on Ubuntu 14.04 using libvirt 1.2.2 . Here are my reproduction steps. Try with " " in : $ tar -xvf my-vm.tar.gz my-vm/ my-vm/my-vm-data.qcow2.md5 my-vm/my-vm.xml $ cd my-vm/ # has space $ grep -Fe '' -- my-vm.xml My VM $ sudo

Re: [Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2015-10-22 Thread Serge Hallyn
Well, while that may long-term be a good thing to look into, since effectively noone could have been using vms with spaces in the names successfully until now anyway, perhaps patching our libvirt to bail out earlier on spaces in vm names would be the better+safer approach. -- You received this

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2015-10-22 Thread Jamie Strandboge
The reason why it didn't allow it is because libvirt didn't handle spaces in the names well at the time. If libvirt handles it ok, then it would be ok to allow it in virt-aa-helper.c since libvirt quotes all its file rule paths in the .files (except I just noticed /dev/vhost-net-- it should

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2015-10-21 Thread Serge Hallyn
@jdstrand virt-aa-helper.c explicitly refuses to allow a space in the vm name (in valid_name()). Is there any way that would be relaxed, or is that deemed to dangerous/exploitable? If it can't be relaxed, then we should bail earlier / with a clearer message in libvirt. -- You received this

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2015-10-07 Thread Serge Hallyn
I've seen other problems with spaces in vm names. We could convert spaces to '-' in apparmor profiles, but I'm tempted to say let's just refuse to allow spaces in vm names. What do people think? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2015-10-07 Thread Serge Hallyn
Note that for lxd we've specifically disallowed anything that can cause problems with some dns servers (no '.', no ' '. no leading '-') -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/77 Title:

[Bug 799997] Re: Error generating apparmor profile when hostname contains spaces

2014-10-21 Thread Serge Hallyn
** Summary changed: - error happen when using virsh to start a vm internal error cannot generate AppArmor profile + Error generating apparmor profile when hostname contains spaces ** Changed in: libvirt (Ubuntu) Importance: High = Medium -- You received this bug notification because you