[Bug 95247] Re: Laptop mode fails to start without saying why

2009-12-02 Thread Steve Langasek
*** This bug is a duplicate of bug 244838 *** https://bugs.launchpad.net/bugs/244838 ** This bug has been marked a duplicate of bug 244838 remove laptop-mode settings from /etc/default/acpi-support -- Laptop mode fails to start without saying why https://bugs.launchpad.net/bugs/95247 You

[Bug 95247] Re: Laptop mode fails to start without saying why

2009-06-20 Thread Philip Muskovac
On second thought the right place to put the message is where the test for that is now: if [ x$ENABLE_LAPTOP_MODE = xfalse ]; then echo "You need to set ENABLE_LAPTOP_MODE=true in /etc/default/acpi-support" exit 0; fi -- Laptop mode fails to start without saying why https://bugs.l

[Bug 95247] Re: Laptop mode fails to start without saying why

2009-06-20 Thread Philip Muskovac
You have my support on this, but the message should not be shown if it's actually enabled. # FIXME: this shouldn't be configured there if [ -f /etc/default/acpi-support ]; then . /etc/default/acpi-support; if ! $ENABLE_LAPTOP_MODE; then echo "You need to set ENABLE_LAPTOP_MODE=true

[Bug 95247] Re: Laptop mode fails to start without saying why

2009-06-19 Thread Shermozle
This is trivially easy, just give the user some hints as to why this isn't enabled by default rather than silently fail. Also, perhaps this should be enabled for the netbook-remix variant, since these all use more modern hardware? Change this in /etc/init.d/laptop-mode: # FIXME: this shouldn't be

[Bug 95247] Re: Laptop mode fails to start without saying why

2007-11-15 Thread Tormod Volden
The point is that the /etc/init.d script is not meant to be a way to start and stop the "laptop mode". When AC adapters are (un)plugged etc, the /usr/sbin/laptop_mode script is run and turns on/off the mode (and adjusts settings) accordingly (only if laptop mode is enabled by the /var/run/laptop-mo

[Bug 95247] Re: Laptop mode fails to start without saying why

2007-11-11 Thread Joerg
Also /etc/init.d/laptop-mode status fails to report anything. It just returns silently. This and the original issue are due to a test for ENABLE_LAPTOP_MODE in line 32 in /etc/init.d./laptop-mode , which happens too early. Rather this test should only occur in the start) and restart) cases, IMHO.

[Bug 95247] Re: Laptop mode fails to start without saying why

2007-07-20 Thread Tormod Volden
I filed a patch for the missing "sudo update-rc.d laptop-mode defaults 99" in bug #127273. Anyway, rumours go that laptop-mode-tools is going to be ditched from Gutsy... -- Laptop mode fails to start without saying why https://bugs.launchpad.net/bugs/95247 You received this bug notification beca

[Bug 95247] Re: Laptop mode fails to start without saying why

2007-07-20 Thread Tormod Volden
Some more verbosity or documentation seems to be needed, so that users don't have to reverse-engineer a whole chain of scripts and files to get it going. ** Summary changed: - Laptop mode fails to start + Laptop mode fails to start without saying why ** Changed in: laptop-mode-tools (Ubuntu)