Re: [Bug 424849] Re: Launchpad should batch attachment notification emails

2011-04-27 Thread Robert Collins
What if you have an empty comment, or does it reject that? If it rejects it its probably a bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment

Re: [Bug 424849] Re: Launchpad should batch attachment notification emails

2011-04-27 Thread Graham Binns
On 27 April 2011 19:09, Brian Murray br...@ubuntu.com wrote: Well the api requires a comment when adding an attachment so it doesn't seem that there is a way to modify apport to prevent multiple email messages. Ah, see, here's the problem: Internally `comment` can be either a string or an

Re: [Bug 424849] Re: Launchpad should batch attachment notification emails

2011-04-27 Thread Robert Collins
Wouldn't hangling '' as the commentin the same way the 'add attachment' web form does be sane? Then the web form could be ajaxified too :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title:

Re: [Bug 424849] Re: Launchpad should batch attachment notification emails

2010-06-06 Thread Leo
Well, when there are many consecutive comments I have the impression that I get many consecutive e-mails? Is this wrong impression? The idea is that many comments sent in the same block of time don't result in many e-mails. I rarely see something batched. The most common is a status change

Re: [Bug 424849] Re: Launchpad should batch attachment notification emails

2010-06-06 Thread Graham Binns
On 6 June 2010 01:46, Deryck Hodge deryck.ho...@canonical.com wrote: Don't we batch in 5 minute (or some such) intervals now?  Except for comments and attachments, of course. I thought that was the point of this bug, to enable batching for attachments. We batch in five minute intervals but

Re: [Bug 424849] Re: Launchpad should batch attachment notification emails

2010-06-04 Thread Graham Binns
On 4 June 2010 20:10, Leo leonardo.ro...@gmail.com wrote: Is it simpler to detect and batch attachments than just replacing on- the-fly notifications by 5-minute-interval digests? At this point, yes. The bug notification code (which can be found in lib/canonical/launchpad/mailnotification.py