[Bug 434476]

2012-02-26 Thread Cpearce-t
(In reply to Markus Stange from comment #15) I was thinking we'd just use whatever API was implemented in bug 697132 to implement this feature. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/434476

[Bug 412647]

2012-03-15 Thread Cpearce-t
Comment on attachment 605705 nsBuiltinDecoder* based implementation Passing review to Chris Double, he's much more knowledgeable about GStreamer than I. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1051559]

2012-10-16 Thread Cpearce-t
We talked about this in Auckland, and we'd prefer to use our existing built-in backends for Ogg and WebM, since they've been fuzz tested and we know they're reliable. I'm going to change our decoder creation code in bug 799344 to not use GStreamer for Ogg and WebM. (And my GStreamer is whatever

[Bug 1051559]

2012-10-12 Thread Cpearce-t
Created attachment 670672 GStreamer backend mochitest failures (with GStreamer only playing H.264, not Ogg or WebM) Additionally, the mochitests fail with the GStreamer backend enabled. Currently the GStreamer backend takes over playback of Ogg and WebM resources when it's enabled, and Firefox

[Bug 1051559]

2012-10-22 Thread Cpearce-t
(In reply to Bryan Quigley from comment #24) (In reply to Chris Pearce (:cpearce) from comment #19) We talked about this in Auckland, and we'd prefer to use our existing built-in backends for Ogg and WebM, since they've been fuzz tested and we know they're reliable. Maybe I'm

[Bug 1051559]

2012-10-22 Thread Cpearce-t
(In reply to Chris Pearce (:cpearce) from comment #27) This decision also motivated by the fact that we know our built in decoders work reliably, and we know that the GStreamer backend has some problems; it fails our unit tests, so we know there are bugs either in GStreamer or in our use of

[Bug 1051559]

2012-10-30 Thread Cpearce-t
(In reply to Chris Pearce (:cpearce) from comment #31) One of the reasons I am interested in this bug is due to what seems to be much better video acceleration code in gStreamer vs Firefox. At least could it be be made an about:config option, pass all to gstreamer? Sure, I will

[Bug 1051559]

2013-06-15 Thread Cpearce-t
Comment on attachment 763014 Enable gstreamer by default, preffed off Review of attachment 763014: - r=cpearce for the changes other than those in configure.in. I'll leave that to khuey. ::: configure.in @@ +5754,5 @@ dnl

[Bug 1051559]

2013-03-18 Thread Cpearce-t
(In reply to Alessandro Decina from comment #46) In addition to that, we could potentially consider importing the ogg/webm/h264 gst plugins in m-c so there's even more control over those. I'd rather keep our existing backends/libraries for decoding Ogg and WebM unless there's a compelling

[Bug 1051559]

2013-03-18 Thread Cpearce-t
You can already set the pref media.prefer-gstreamer to true if you want to play WebM and Ogg with GStreamer in Firefox. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox

[Bug 1051559]

2013-03-20 Thread Cpearce-t
I built latest trunk on my Fedora box this morning with --enable- gstreamer, and I still get the following test failure in content/media/test/test_buffered.html: TEST-UNEXPECTED-FAIL| unknown test url | owl.mp3: First range end should be media end - got 3.368, expected 3.3698 (In reply to Henri

[Bug 1051559]

2013-03-21 Thread Cpearce-t
(In reply to Alessandro Decina from comment #55) Created attachment 727111 gst codec whitelist This patch makes the gst backend stop in ReadMetadata if the stream being decoded includes unsupported codecs. I'm not sure it's stopping in the right place, it makes playing

[Bug 1051559]

2013-03-21 Thread Cpearce-t
(In reply to Alessandro Decina from comment #56) (In reply to Chris Pearce (:cpearce) from comment #54) I built latest trunk on my Fedora box this morning with --enable-gstreamer, and I still get the following test failure in content/media/test/test_buffered.html: TEST-UNEXPECTED-FAIL|

[Bug 1051559]

2013-03-21 Thread Cpearce-t
Comment on attachment 727111 gst codec whitelist That looks fine, it behaves as expected and stops playback of the 3GPP container in particular. Mochitests timeout in test_buffered for me now though, and the fix I suggested of clamping the buffered ranges at duration didn't seem to fix the

[Bug 412647]

2012-06-11 Thread Cpearce-t
(In reply to Sid from comment #298) Just in case, SDK is out. http://gstreamer.com/ In the Windows installation instructions they recommend removing the client app's dependency on MSVC2010's runtime DLL and using the “basic” C runtime which comes in every Windows system since Windows XP, and is

[Bug 434476]

2014-02-06 Thread Cpearce-t
We should disable the screen save for non-fullscreen playback too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos To manage notifications

[Bug 434476]

2014-02-06 Thread Cpearce-t
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #32) Can we at least do that for videos which have started playback as a result of a user action? Sure, that sounds like a good idea. Reasonable even. We may need to wait for bug 966493 to be fixed

[Bug 434476]

2014-02-06 Thread Cpearce-t
We already use the power manager service to create a screen wake lock to disable the screen saver in HTMLVideoElement::WakeLockUpdate(), but the wake lock listener that actually disables the screen saver is only implemented for B2G and I think Android, but not on other platforms. I have a patch

[Bug 434476]

2014-02-06 Thread Cpearce-t
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #29) (In reply to comment #28) We should disable the screen save for non-fullscreen playback too. Why? Some websites use video as an element in their design these days (for example, as the page

[Bug 1051559]

2013-06-18 Thread Cpearce-t
Excellent, thanks Ralph. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support To manage notifications about this bug go to:

[Bug 1051559]

2013-06-20 Thread Cpearce-t
Comment on attachment 765205 Better error message Review of attachment 765205: - A build peer should review this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 434476]

2012-04-16 Thread Cpearce-t
*** Bug 745546 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos To manage notifications

[Bug 434476]

2012-04-16 Thread Cpearce-t
*** Bug 745519 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while playing HTML5 videos To manage notifications

[Bug 412647]

2012-04-03 Thread Cpearce-t
(In reply to Matthew Gregan [:kinetik] from comment #265) (In reply to Alessandro Decina from comment #263) I started running the mochi tests in content/media/ and fixed a good number of issues already. Not all the tests pass, but most of those that don't pass fail because gstreamer is

[Bug 434476]

2014-02-14 Thread Cpearce-t
The fix for this will ship on Windows in Firefox 30. Other platforms hopefully will make by Firefox 30 or soon after. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts

[Bug 434476]

2014-03-27 Thread Cpearce-t
(In reply to Lawrence Mandel [:lmandel] from comment #40) I discussed this issue with the desktop team (Chad, Madhava, Gavin). This is not a high priority for them right now. As such, dropping the tracking flag. From comment 36 I take it that this has already been fixed on Windows in another

[Bug 434476]

2014-04-07 Thread Cpearce-t
Comment on attachment 8401684 Implement WakeLockListener on Linux to disable screensaver while video is playing Review of attachment 8401684: - This is the behaviour we want (locking video irrespective of whether we're fullscreen

[Bug 434476]

2014-06-18 Thread Cpearce-t
I think you want the screen topic, and the locked-foreground state to denote when to disable the screen saver. HTMLMediaElement should already manage only disabling the screen saver when media is playing and in a foreground tab, and bug 1022669 is being worked on right now to ensure that we don't

[Bug 434476]

2014-06-18 Thread Cpearce-t
We want to inhibit the screensaver when video is playing, not when *fullscreen* video is playing. It looks like the patch above is trying to only inhibit the screensaver for fullscreen video. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 434476]

2014-06-09 Thread Cpearce-t
Because opinions differ. ;) We also want non-fullscreen video and webrtc chats to disable the screensaver. I, for one, find it very annoying when I'm watching a non- fullscreen video and the screensaver kicks in. FYI, there's code in HTMLMediaElement to ensure the screensaver is only disabled