[Bug 1768521]

2019-06-20 Thread Hjudt-l
Last time I worked on thunar code, that reload stuff was a big mess and did not even work for jobs (copying, moving files). What makes it more complicated is that there are folder reloads and file reloads. I couldn't fix it completely, and if you change one part, it often breaks the other parts. I

[Bug 1512120]

2018-06-08 Thread Hjudt-l
No, it's ok, I just wanted to state that the issue *might* be a different one than the crashes. Does it also happen with cut & paste, not only drag? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Hjudt-l
I believe the drag & drop issue you describe here has been there for a long time. I am not sure it has anything to do with this bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title:

[Bug 1512120]

2018-06-08 Thread Hjudt-l
Created attachment 6613 Check-if-a-thunar-file-is-still-valid-before-reloading.patch Deactivating SEND_MOVED code paths didn't help completely, thunar was still crashing on renaming sometimes (more often than not). Alternative workaround. Does fix all? crashes on my system - I hope this isn't

[Bug 1512120]

2018-06-08 Thread Hjudt-l
On a second thought, maybe these remaining update problems have existed in earlier versions too but simply went unnoticed. Anyway, here is a very simple test case to showcase the problem: 1) create files: for i in $(seq 1 10); do touch "$i.txt"; done 2) loop for renaming files every second:

[Bug 1512120]

2018-06-08 Thread Hjudt-l
The update problems are also evident when a script renames multiple files at once. Maybe a rewrite for the changes in glib is still needed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120

[Bug 1261369]

2015-11-18 Thread Hjudt-l
*** Bug 12303 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1261369 Title: No GUI way to enable menubar To manage notifications about this bug go

[Bug 1512120]

2015-11-18 Thread Hjudt-l
*** Bug 12312 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: thunar crashes on file renaming To manage notifications about this bug go

[Bug 1514912]

2015-11-15 Thread Hjudt-l
Likely a duplicate. *** This bug has been marked as a duplicate of bug 12264 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1514912 Title: Thunar crash while copying files (segfault / possible

[Bug 1512120]

2015-11-14 Thread Hjudt-l
Created attachment 6530 0001-Deactivate-SEND_MOVED-code-paths.patch For a start, deactivating the SEND_MOVED code paths seems to get rid of the crashes on my system with glib-2.46.2. Please try the patch attached and report back if it fixes the crashes for you too. Why this will not solve the

[Bug 1512120]

2015-11-14 Thread Hjudt-l
*** Bug 12260 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: thunar crashes on file renaming To manage notifications about this bug go

[Bug 1512120]

2015-11-14 Thread Hjudt-l
*** Bug 12290 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: thunar crashes on file renaming To manage notifications about this bug go

[Bug 1512120]

2015-11-14 Thread Hjudt-l
*** Bug 12283 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: thunar crashes on file renaming To manage notifications about this bug go

[Bug 1512120]

2015-11-14 Thread Hjudt-l
*** Bug 12253 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: thunar crashes on file renaming To manage notifications about this bug go

[Bug 1512120]

2015-11-14 Thread Hjudt-l
*** Bug 12293 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: thunar crashes on file renaming To manage notifications about this bug go

[Bug 1212577]

2015-06-27 Thread Hjudt-l
*** Bug 11997 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1212577 Title: Please keep the active thunar Window in focus when copying/moving files

[Bug 1179625]

2015-05-27 Thread Hjudt-l
No feedback, closing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1179625 Title: Filenames converts to numbers when copying files from Nexus 4 To manage notifications about this bug go to:

[Bug 880533]

2015-05-22 Thread Hjudt-l
Thanks for your report and test, so I will close this bug again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/880533 Title: Thunar and Trash Applet report that Trash is empty when it is not To

[Bug 880533]

2015-05-21 Thread Hjudt-l
The patch that I pushed to master and is included in thunar-1.6.9 has caused issues for other people (see bug #11913). I have pushed further patches to fix this, which should be included in the next bugfix release thunar-1.6.10. Could you please apply try these patches on thunar-1.6.9 in this

[Bug 1293754]

2015-05-19 Thread Hjudt-l
I suffered from this bug a while ago, but it seems fixed on my machine. Since I believe nothing in thunar has changed, this is very likely a problem in an external component, or maybe a configuration problem. I am not sure which component could have caused this, though. ntfs-3g[2228]: Version

[Bug 1261369]

2015-05-17 Thread Hjudt-l
Changed F10 to Alt_L in http://git.xfce.org/xfce/thunar/commit/?id=9283ed8fd5ff7c7cf7a089a528e26784a3a04eca This seems to be standard in other apps, and it makes more sense because Alt+key is usually used for menu mnemonics (which still works). Many users do not know about F10 nor will they

[Bug 1261369]

2015-05-17 Thread Hjudt-l
After some more testing, I found unfortunately there is a problem with the patch and I will need to revert it. When the menubar is hidden, shortcuts with the Alt modifier (like Alt + Left, Alt + Right) will perform their action correctly but toggle the menubar too, and it is not simple to prevent

[Bug 880533]

2015-05-17 Thread Hjudt-l
I've been looking into this a bit. As some have observed, it happens when the gvfsd-trash daemon has not spawned and thunar accesses the trash for the first time (yet causing it to spawn). So for the trash bin having the correct state it is necessary that the daemon has already spawned when

[Bug 880533]

2015-05-17 Thread Hjudt-l
Pushed to master: http://git.xfce.org/xfce/thunar/commit/?id=2d5567b2f6ae6223c8865547704797a5c785ec1f Reverted changes to session client: http://git.xfce.org/xfce/thunar/commit/?id=61e52c7d53bf612b532dd1b8d7d49352cee1597e Fixed icon in path entry not updated:

[Bug 880533]

2015-05-17 Thread Hjudt-l
Created attachment 6251 fix-loading-the-trash-bin-status-at-startup-bug-9513.patch Attached is a patch which fixes the issue for me. Please try it and report back if it fixes the issue for _you_ too. At the moment, I cannot think of a better solution. I hope it does not produce crashes. Maybe

[Bug 880533]

2015-05-17 Thread Hjudt-l
Created attachment 6252 fix-loading-the-trash-bin-status-at-startup-bug-9513.patch This is probably a better version of the patch. Instead of putting the checks into thunar_file_get, which could be called quite often for folders that contain a lot of files, put it into the main function which

[Bug 880533]

2015-05-14 Thread Hjudt-l
Is this still an issue? If it is, please reopen. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/880533 Title: Thunar and Trash Applet report that Trash is empty when it is not To manage

[Bug 1179625]

2015-05-13 Thread Hjudt-l
Last time I tried gvfs mtp everything was slow but worked correctly. Is this still a problem? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1179625 Title: Filenames converts to numbers when copying

[Bug 1031581]

2015-05-11 Thread Hjudt-l
Ok, lost this bug and found it again. From my tests, this patch only helps when thunar is used to copy the file, triggering the CHANGES_DONE_HINT at the end of the file operation. If it is changed from outside thunar - simply try cp -, the CHANGES_DONE_HINT will be triggered more often, so often

[Bug 1031581]

2015-05-11 Thread Hjudt-l
After a few tests, it should actually work for operations outside thunar too. But probably it depends on the operation itself, e.g. how big the chunks are that are copied, how often a changed / changes_done_hint event is emitted. The changes_done_hint is also emitted after an attribute_changed

[Bug 1346785]

2015-05-10 Thread Hjudt-l
Resolving duplicate. *** This bug has been marked as a duplicate of bug 4537 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1346785 Title: You can select both file icons and path in address bar

[Bug 1425700]

2015-04-24 Thread Hjudt-l
I have pushed the change and documented it on the wiki (still work-in- progress): http://docs.xfce.org/xfce/thunar/working-with-files-and- folders This should improve things a bit, though unfortunately fixing every aspect and making the view behave exactly as the other views is not a trivial

[Bug 1252655]

2015-04-24 Thread Hjudt-l
*** Bug 10955 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of deleted file when previous (e.g. original)

[Bug 1252655]

2015-04-24 Thread Hjudt-l
BTW: What has not been fixed yet is the issue described in bug #9245. It's a minor issue though and hitting F5 / reload is a usable workaround. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655

[Bug 1252655]

2015-04-24 Thread Hjudt-l
The patches have been merged to master. So far, all tests have turned up nothing bad, and the reload seems working fine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns

[Bug 899624]

2015-04-23 Thread Hjudt-l
The patch from some duplicate doesn't seem to work for me? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/899624 Title: thunar actions only on local drive To manage notifications about this bug go

[Bug 1327791]

2015-04-21 Thread Hjudt-l
*** Bug 7554 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1327791 Title: Security warning about just created Xubuntu desktop shortcut To manage

[Bug 1293754]

2015-04-20 Thread Hjudt-l
*** Bug 11248 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1293754 Title: permission related error when moving files to internal NTFS formated

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 5232 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To manage

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 10585 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 8852 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To manage

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 3386 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To manage

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 8875 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To manage

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 11219 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To

[Bug 1425700]

2015-04-20 Thread Hjudt-l
*** Bug 11218 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425700 Title: Drag Drop needs extra selection in Detailed List View in Thunar To

[Bug 1031581]

2015-04-20 Thread Hjudt-l
It looks like a good idea to apply that patch anyway. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1031581 Title: Tumblerd and Marlin use all available cpu and more To manage notifications about

[Bug 1423758]

2015-04-19 Thread Hjudt-l
I'm closing this as a duplicate of #11749, patch is already pushed to git master. Feel free to reopen if the bug reappears. *** This bug has been marked as a duplicate of bug 11749 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 510074]

2015-04-19 Thread Hjudt-l
Marking duplicate. *** This bug has been marked as a duplicate of bug 11605 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/510074 Title: [details view] drag file starts selection To manage

[Bug 1256110]

2015-04-18 Thread Hjudt-l
Resolving duplicate. *** This bug has been marked as a duplicate of bug 11605 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1256110 Title: Missing terminal and search in right click menu

[Bug 1252655]

2015-04-17 Thread Hjudt-l
*** Bug 11829 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of deleted file when previous (e.g. original)

[Bug 1252655]

2015-04-17 Thread Hjudt-l
*** Bug 9446 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of deleted file when previous (e.g. original)

[Bug 1252655]

2015-04-17 Thread Hjudt-l
*** Bug 9340 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of deleted file when previous (e.g. original)

[Bug 1423758]

2015-04-14 Thread Hjudt-l
Make sure you killed the running thunar daemon and started a new instance. -q doesn't seem to always work reliably for reasons unknown. Also, please give it a few more tries just to be sure it is not a nasty bug that only happens sometimes. -- You received this bug notification because you are a

[Bug 1423758]

2015-04-14 Thread Hjudt-l
I am sorry, I still cannot reproduce this here :-/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1423758 Title: Thunar: Open Terminal Here breaks when any directory is deleted To manage

[Bug 1423758]

2015-04-14 Thread Hjudt-l
Probably a duplicate of bug #11749. Please try the patch attached there and report if it fixes the issue. *** This bug has been marked as a duplicate of bug 11749 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1423758]

2015-04-14 Thread Hjudt-l
If you've tried the fix-bug-11008 branch and it fixes it, then this is a reload bug and doesn't have to do much with the custom actions themselves, the bug is only different symptoms. If you have build the master branch from there, then I have no clue which commit fixed it, and you will have to

[Bug 1423758]

2015-04-14 Thread Hjudt-l
To clarify: The other bug is not about disappearing custom actions, only their shortcuts have disappeared (if assigned). However, I noticed a similar issue as described here has been fixed with that patch. Now for this issue: I cannot reproduce the bug here, neither with the steps provided in the

[Bug 1409761]

2015-04-14 Thread Hjudt-l
xfdesktop exposes custom shortcuts in the context menu, for which there are no shortcuts. Maybe xfdesktop can support custom actions with shortcuts, but at the moment it does not. Anyway, this bug does not belong to thunar, therefore moving this to xfdesktop. -- You received this bug

[Bug 1256110]

2015-04-12 Thread Hjudt-l
*** Bug 2444 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1256110 Title: Missing terminal and search in right click menu (detail view) To manage

[Bug 1256110]

2015-04-12 Thread Hjudt-l
For the record, I have implemented an experimental patch for this here: http://git.xfce.org/users/hjudt/thunar/commit/?h=details-view-selectionid=89c7dc4aad1ecea7622a69fb6e57a8bd139dd699 However, it does more than that and also changes the dragdrop and rubber-band selection behaviour. -- You

[Bug 1252655]

2015-04-10 Thread Hjudt-l
Created attachment 6180 reload-files-changed-by-jobs-in-an-idle-loop.patch This builds on top of the other patches and obsoletes attachment #6118. With this, complicated changes to the closures system are unnecessary and all files will get scheduled for reload in idle before the new-files signal

[Bug 1252655]

2015-04-10 Thread Hjudt-l
A temporary repository with all necessary patches based on up-to-date master is here: http://git.xfce.org/users/hjudt/thunar/log/?h=fix- bug-11008 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655

[Bug 1252655]

2015-04-10 Thread Hjudt-l
A better solution than reloading the file info for all files in the new- files closure is to move/copy the file info in thunar-transfer-job.c for cached files only. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1252655]

2015-04-03 Thread Hjudt-l
An additional test case for verification (though it does not bring any new revelations): 1) Generate lots of files: for i in $(seq 1 1000); do echo $i $i.txt; done 2) Cut files using thunar Edit-Cut 3) Create a new directory test 4) Change dir to test in thunar 5) Paste files in thunar

[Bug 1252655]

2015-04-03 Thread Hjudt-l
I stand corrected, it also happens with copypaste. But I got a bit further to a solution: Indeed, this seems to be a timing problem. http://git.xfce.org/xfce/thunar/tree/thunar/thunar-job.c#n573 Adding sleep (1); before this line solves the problem for me: -- /* emit the new-files signal

[Bug 1252655]

2015-04-03 Thread Hjudt-l
*** Bug 11763 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of deleted file when previous (e.g. original)

[Bug 1252655]

2015-04-03 Thread Hjudt-l
The final piece of the puzzle: The new-files closure gets invalidated by thunar_standard_view_selection_changed while still being in use. Because of this, the signals sent by the job cannot be received and get lost. This also causes the g_object_ref/unref errors in comment #32. Treatment of the

[Bug 1252655]

2015-04-03 Thread Hjudt-l
Interestingly, with the sleep(1) https://bugzilla.xfce.org/attachment.cgi?id=6118 is rendered unnecessary, and the standard view is updated properly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6119 Fix-updating-file-info-for-moved-files-bug-11008.patch This patch is still necessary for updates caused by move operations. I have corrected one check so it should work properly now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1252655]

2015-03-27 Thread Hjudt-l
It seems the issues with filemonitor events not being triggered have to do with the shortcut side pane. Turning the sidepane off (but also switching to tree-view sidepane probably) will make the test cases work as expected. However, these new findings may not completely invalidate the previous

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6128 0003-Refactor-code-for-moving-thumbnail-cache-file-on-ren.patch Another patchset for reloading issues (3/3) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title:

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6118 Always-reload-info-for-files-that-might-have-been-changed-by-jobs.patch This patch obsoletes the previous patches (though parts of my previous patch might still be correct to apply) and fixes the update issues for me. -- You received this bug notification because you are

[Bug 1252655]

2015-03-27 Thread Hjudt-l
*** Bug 11734 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of deleted file when previous (e.g. original)

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6129 0004-Reload-parent-folder-of-changed-file.patch Fix update of parent folder in folder-monitor.c -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6127 0002-Rework-thunar_file_monitor-to-properly-register-move.patch Another patchset for reloading issues (2/3) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title:

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6126 0001-Add-function-to-reload-parent-file-of-a-file.patch Another patchset for reloading issues (1/3) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar

[Bug 1252655]

2015-03-27 Thread Hjudt-l
There is still the problem that the folder monitor does not receive any events for the following scenario: 1) touch x 2) mkdir test 3) open test in thunar 4) mv x test test is not updated to reflect the move. If you open another window with the source directory before 4), then the changes will

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Created attachment 6132 Fix-updating-file-info-for-moved-files-bug-11008.patch Update patch to protect against unreadable files. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar

[Bug 1252655]

2015-03-27 Thread Hjudt-l
(In reply to Harald Judt from comment #23) Unfortunately, there is another test case that doesn't work: 1) echo 2000 x; mkdir test; touch test/x 2) open thunar 3) cut x 4) change into test 5) select x 6) paste There are delete events for the source folder, but the destination folder

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Unfortunately, there is another test case that doesn't work: 1) echo 2000 x; mkdir test; touch test/x 2) open thunar 3) cut x 4) change into test 5) select x 6) paste There are delete events for the source folder, but the destination folder does not receive any events. Also, reloading the

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Comment on attachment 6129 0004-Reload-parent-folder-of-changed-file.patch This patch is bad and should not be applied. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns

[Bug 1252655]

2015-03-27 Thread Hjudt-l
Further observations: 1) File moves via cut paste into the same window do not receive the new_files signals, thus thunar_standard_view_new_files will NOT be called. Therefore, file info for an existing target file will not be updated. If the target file does not exist, the file will of course

[Bug 1252655]

2015-03-27 Thread Hjudt-l
thunar_file_monitor: event_path=/home/user/x, other_path=/home/user/(null)/x, file=user, event_type=7 This happens even without any of the patches, so it is not caused by them. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1252655]

2015-03-20 Thread Hjudt-l
Using both a file monitor and a dir monitor on both directories, and additionally a file monitor and a dir monitor on the moved file, it looks like everything is ok with gio. Just for the record, if SEND_MOVED was not used, the following gio bug could have been triggered, but thunar uses

[Bug 1252655]

2015-03-20 Thread Hjudt-l
Created attachment 6089 Fix-updating-file-info-for-moved-files-bug-11008.patch The previous solution in attachment #5903 causes crashes because of freeing and accessing file info in parallel threads, spawned by thunar jobs. An easy way to reproduce such a crash, or at least to create critical

[Bug 1252655]

2015-03-20 Thread Hjudt-l
GFileMonitor Test application: Download and compile https://gist.githubusercontent.com/dmatveev/2295597/raw/973da911a653550d762cffea20153db9ca52400b/gistfile1.c gcc -o gfilemonitor gistfile1.c $(pkg-config --cflags glib-2.0) $(pkg- config --libs glib-2.0) $(pkg-config --libs gio-2.0) Now for a

[Bug 1252655]

2015-03-20 Thread Hjudt-l
Pushed to master: http://git.xfce.org/xfce/thunar/commit/?id=cc8d1331e305f2af5842607d885eb96608b8fce7 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1252655 Title: Thunar assigns date stamp of

[Bug 1396716]

2015-03-09 Thread Hjudt-l
Pushed to master: http://git.xfce.org/xfce/thunar/commit/?id=03ed0b6fff9a740f2f8971770ba03d0d4f6af718 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1396716 Title: New Windows Launched From Desktop

[Bug 1082511]

2015-03-06 Thread Hjudt-l
Thanks for the patch. Pushed to master: http://git.xfce.org/xfce/thunar/commit/?id=cdfdb7290abb270f5f98c93089c3b6e3c35859bc -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1082511 Title: wrong drag

[Bug 1425716]

2015-03-02 Thread Hjudt-l
Fixed in master: http://git.xfce.org/xfce/thunar/commit/?id=c10e1ce9039245659edb2d6c0daab7b73078071b -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425716 Title: Thunar ignores the View new folders

[Bug 1078445]

2015-02-28 Thread Hjudt-l
As far as I understand, this is a bug in gparted which fails/failed to lock the partition/filesystem. This is a bug that cannot/shouldn't be fixed in thunar-vfs, hence closing invalid. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1078445]

2015-02-28 Thread Hjudt-l
Sorry, wanted to close it as won't fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1078445 Title: Xubuntu install fail due partition auto mount defeats Gparted To manage notifications about

[Bug 1397095]

2015-02-22 Thread Hjudt-l
*** Bug 11567 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1397095 Title: dragging applications in the task bar causes repaint errors To manage

[Bug 1303404]

2015-02-22 Thread Hjudt-l
As discovered and confirmed on IRC, this bug is still reproducible with combinations like these: Super-F12: xfce4-about F12: xfrun4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1303404 Title:

[Bug 1303404]

2015-02-22 Thread Hjudt-l
I have properly commented and applied the fix in http://git.xfce.org/xfce/libxfce4ui/commit/?id=b680e8b9f6b0cf1c706ed430a548590daa1f4565. Let's hope this does not break anything, and someone finds a proper solution one day. -- You received this bug notification because you are a member of

[Bug 1303404]

2015-02-15 Thread Hjudt-l
Simple steps for a start, best thing is to pay a visit to #xfce-dev on IRC and ask there in case of troubles: 0) Make sure you have all requirements installed (header packages etc.; autogen will tell you if something is missing, but often not exactly what and it depends on your distribution).

[Bug 1360991]

2015-02-02 Thread Hjudt-l
Fixed in http://git.xfce.org/xfce/thunar/commit/?id=e4519197b35824a82d57c45b354a1e5fd2c80b25 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1360991 Title: Setting wallpaper in thunar resets stretch