[Bug 1807797] Re: Split doesn't check for filetype

2018-12-12 Thread Maliat Manzur
** Patch added: "Patch for split b-chunk unit test"
   
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+attachment/5221711/+files/split_b_chunk_test.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1807797

Title:
  Split doesn't check for filetype

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1807797] Re: Split doesn't check for filetype

2018-12-12 Thread Maliat Manzur
Hello,

Following up on the patch: I had a chance to fix the unit tests as well.
I'm attaching the patches to the next four comments.

Thanks,
Maliat

** Patch added: "Patch for split filter unit test"
   
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+attachment/5221708/+files/split_filter_test.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1807797

Title:
  Split doesn't check for filetype

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1807797] Re: Split doesn't check for filetype

2018-12-12 Thread Maliat Manzur
** Patch added: "Patch for split l-chunk unit test"
   
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+attachment/5221709/+files/split_l_chunk_test.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1807797

Title:
  Split doesn't check for filetype

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1807797] Re: Split doesn't check for filetype

2018-12-12 Thread Maliat Manzur
** Patch added: "Patch for split r-chunk unit test"
   
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+attachment/5221710/+files/split_r_chunk_test.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1807797

Title:
  Split doesn't check for filetype

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1807797] [NEW] Split doesn't check for filetype

2018-12-10 Thread Maliat Manzur
Public bug reported:

Hello! I noticed that Split doesn't check for filetypes before it starts
splitting the file. As a result, it's possible to eat up CPU and Disk
memory by passing in a character device as input. I wanted to make Split
more robust by adding a patch to check for file type.

This patch do break some of the tests for Split. The tests that are
checking Split's ability to "elide empty files" by using /dev/null as
input fail with this patch, since /dev/null is a character device. I
would love to modify those tests to use a regular empty file, upon the
approval of this patch.

Thanks!

** Affects: coreutils (Ubuntu)
 Importance: Undecided
 Status: New


** Tags: filetype patch split

** Patch added: "Patch checks for filetype."
   
https://bugs.launchpad.net/bugs/1807797/+attachment/5220988/+files/split_filetype.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1807797

Title:
  Split doesn't check for filetype

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/1807797/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs