Created attachment 6767
Patch to thunar_folder_monitor to stop "files added" on "monitor move" event
The attached patch updates the code in thunar_folder_monitor with a fix
to prevent the rename crashes by stopping the "files added" on "monitor
move" event behaviour. I can no longer reproduce any
Created attachment 6801
Notes for patching Thunar on Ubuntu with patch #6779
I've successfully tested patch #6779 on Debian Stretch i386, Debian Stretch
amd64, Xubuntu 16.04 amd64 and Arch x86_64. Here are my notes for patching and
building Thunar on Ubuntu. I hope this works as well for you
Created attachment 6779
Handle folder change events with file info synchronization
Here's the latest set of changes that I have been testing which handle
folder change events and synchronize updates to file info by multiple
threads.
The patch contains the following changes to address the
(In reply to John Lindgren from comment #90)
> At one point, it seemed that the two patches from comment #14 (Harald) and
> comment #41 (Emil) were enough to fix two separate crashes: one triggered by
> rename, one triggered by drag-and-drop.
>
> Harald himself stated that his patch was not
(In reply to John Lindgren from comment #93)
> This is most likely due to multiple threads clobbering the GFileInfo within
> the same ThunarFile. At this point, I guess I would say that the basic
> design of sharing the common hash table of ThunarFiles between multiple
> threads is flawed.
(In reply to Roy Richardson from comment #71)
> After quite a bit of debugging and testing I have produced the following
> rename patch for Thunar.
>
> --- Thunar-1.6.10/thunar/thunar-io-jobs.c 2015-05-22 13:25:36.0
> +
> +++ Thunar-1.6.10-fix/thunar/thunar-io-jobs.c 2016-08-01
(In reply to Roy Richardson from comment #76)
> I'm suspicious of the following code fragment in thunar_folder_monitor which
> I have now bypassed on "file monitor move" events with the above patch.
>
> /* tell others about the new file */
> list.data = file; list.next = list.prev =
@slumbergod I have never triggered an desktop crash, but I have seen a
numerous seg faults from various types of move or rename operations.
@Kip This bug is definately elusive and has traits of a stack
corruption.
With debugging symbols enabled and NDEBUG defined to bypass the debugging
(In reply to Jan Havran from comment #0)
> thunar_file_compare_by_name() function is called even for only one file in
> working directory - both file_a->collate_key_nocase and
> file_b->collate_key_nocase are NULL. I noticed that sometimes this function
> is not called, but when it is (it is
After quite a bit of debugging and testing I have produced the following
rename patch for Thunar.
--- Thunar-1.6.10/thunar/thunar-io-jobs.c 2015-05-22 13:25:36.0
+
+++ Thunar-1.6.10-fix/thunar/thunar-io-jobs.c 2016-08-01 11:07:09.01668
+
@@ -1307,7 +1307,12 @@
{
10 matches
Mail list logo
