[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
Well shoot. If someone had told me about Ubuntu's 3-day weekend policy, I would have mentioned it yesterday when the seven day minimum was up. ;) Sorry. I'm being impatient--I know this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
I'm not pushing, I just want to make sure there's nothing else holding this back from being moved to -updates that I can help with. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
Good news. Thanks! So if no other problems arise, this will automatically move to -updates (after the 7 day minimum), correct? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
Looks like a flaky test, rather than a real regression to me: > : failure: timed out waiting for testbed to reboot > autopkgtest [08:11:33]: ERROR: testbed failure: cannot send to testbed: > [Errno 32] Broken pipe -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
I updated libqt5webengine5 and its dependencies to version 5.12.8+dfsg- 0ubuntu1.1 from focal-proposed and verified (with the originally provided test case) that the bug is indeed fixed. I also tested with the open-source project I maintain to verify that the upstream Live Editing breakage was fixed with the update. Changing the tag to "verification-done-focal" as requested. Thank you kindly for the assist. This would have affected any package that relied upon qtwebengine's Live Editing abilities, so it's much appreciated. If and when 20.04 moves to Qt5.12.9, the same patch will be necessary. Is there anything that can be done to make sure the pach doesn't get dropped in that situation? Thanks again. ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
> Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. > If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification- needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed. Will do. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
Fingers crossed. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
** Description changed: - Ununtu 20.04 LTS + Ubuntu 20.04 LTS QtWebEngine bad chrome 77->69 cherry-pick bug broke live editing in Qt 5.12.8 and Qt 5.12.9. The bad merge breaks styled markup traverse by accidentally inverting condition. Results in loss of content under certain conditions. Bug acknowledged: https://bugreports.qt.io/browse/QTBUG-85160 Official patch-set to fix: https://codereview.qt-project.org/c/qt /qtwebengine-chromium/+/305139 Please consider cherry-picking this official patch, so that the latest Ubuntu LTS release does not break apps that rely upon QtWebEngine's live-editing capabilities + + I co-maintain some open-source ebook editing software that allows users + to make basic wysiwyg edits to local xhtml files loaded in a + QWebEngineView using QWebEngine's live editing abilities. They basically + highlight paragraphs and convert them to ordered/unordered lists via + view->triggerPageAction(QWebEnginePage::InsertUnorderedList) and + view->triggerPageAction(QWebEnginePage::InsertOrderedList) accordingly. + + This all works in Qt5.12.7 and earlier, but when using Ubuntu 20.04's + 5.12.8 QWebEngine packages, the highlighted content is deleted and an + empty list is created (as per the aforementioned Qt bug confirmed and + patched by Qt). + + I've attached a small, focused, Qt project that clearly demonstrates the + issue. It can be built with the standard qmake / make commands which + will build a liveedit binary that loads a local xhtml file in a QWebView + for editing. If you want to load your own local html file or a remote + url, just pass the url as a parameter to ./liveedit: + + ./liveedit file:///home/user/localfile.html + ./liveedit https://www.lipsum.com/feed/html + + Otherwise, no parameter means the included xhtml file will be loaded. + + Once loaded, highlight all the paragraphs and use the "Tools->Create + List from selection" menu action to edit the rendered content. + + Qt5.12.7 and earlier will correctly create a list from the highlighted + paragraphs (as will Qt5.14.x and later), but Qt5.12.8/9 will incorrectly + delete the highlighted content and create an empty list (as per the + aforementioned Qt bug confirmed and patched by Qt). ** Attachment added: "Small Qt test case to demonstrate the issue" https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+attachment/5386530/+files/liveedit.tar.gz ** Description changed: Ubuntu 20.04 LTS QtWebEngine bad chrome 77->69 cherry-pick bug broke live editing in Qt 5.12.8 and Qt 5.12.9. The bad merge breaks styled markup traverse by accidentally inverting condition. Results in loss of content under certain conditions. Bug acknowledged: https://bugreports.qt.io/browse/QTBUG-85160 Official patch-set to fix: https://codereview.qt-project.org/c/qt /qtwebengine-chromium/+/305139 Please consider cherry-picking this official patch, so that the latest Ubuntu LTS release does not break apps that rely upon QtWebEngine's live-editing capabilities - I co-maintain some open-source ebook editing software that allows users - to make basic wysiwyg edits to local xhtml files loaded in a - QWebEngineView using QWebEngine's live editing abilities. They basically - highlight paragraphs and convert them to ordered/unordered lists via + I co-maintain some open-source ebook editing software + (https://github.com/sigil-ebook/pageedit) that allows users to make + basic wysiwyg edits to local xhtml files loaded in a QWebEngineView + using QWebEngine's live editing abilities. They basically highlight + paragraphs and convert them to ordered/unordered lists via view->triggerPageAction(QWebEnginePage::InsertUnorderedList) and view->triggerPageAction(QWebEnginePage::InsertOrderedList) accordingly. This all works in Qt5.12.7 and earlier, but when using Ubuntu 20.04's 5.12.8 QWebEngine packages, the highlighted content is deleted and an empty list is created (as per the aforementioned Qt bug confirmed and patched by Qt). I've attached a small, focused, Qt project that clearly demonstrates the issue. It can be built with the standard qmake / make commands which will build a liveedit binary that loads a local xhtml file in a QWebView for editing. If you want to load your own local html file or a remote url, just pass the url as a parameter to ./liveedit: ./liveedit file:///home/user/localfile.html ./liveedit https://www.lipsum.com/feed/html Otherwise, no parameter means the included xhtml file will be loaded. Once loaded, highlight all the paragraphs and use the "Tools->Create List from selection" menu action to edit the rendered content. Qt5.12.7 and earlier will correctly create a list from the highlighted paragraphs (as will Qt5.14.x and later), but Qt5.12.8/9 will incorrectly delete the highlighted content and create an empty list (as per the aforementioned Qt bug confirmed and patched by Qt).
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
Understood. I'll get something together as soon as I can. Thanks again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] Re: Live Editing broken in 5.12.8/9 upstream
I assumed that Qt's own acknowledgement of the issue, and subsequent official patch to correct it, would be sufficient to demonstrate the necessity of incorporating said fix into a package that's part of an Ubuntu LTS release. I'll see what I can do about putting together a small test case (for an already confirmed upstream mistake), but it may not be immediately. Thanks for looking into it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1884550] [NEW] Live Editing broken in 5.12.8/9 upstream
Public bug reported: Ununtu 20.04 LTS QtWebEngine bad chrome 77->69 cherry-pick bug broke live editing in Qt 5.12.8 and Qt 5.12.9. The bad merge breaks styled markup traverse by accidentally inverting condition. Results in loss of content under certain conditions. Bug acknowledged: https://bugreports.qt.io/browse/QTBUG-85160 Official patch-set to fix: https://codereview.qt-project.org/c/qt /qtwebengine-chromium/+/305139 Please consider cherry-picking this official patch, so that the latest Ubuntu LTS release does not break apps that rely upon QtWebEngine's live-editing capabilities ** Affects: qtwebengine-opensource-src (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1884550 Title: Live Editing broken in 5.12.8/9 upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/qtwebengine-opensource-src/+bug/1884550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
