Hi Olivier,
Thanks for the bug report. It has been a while since that patch was
landed so my memory may be a bit rusty, but I don't believe we
considered the use case of Linux distributions side-loading dictionaries
in this way...
Would it be a useful work-around to convert these dictionaries
(In reply to Jorg K (GMT+2) from comment #61)
> Hey Ehsan, thanks for your further comment. Let's face it: SeaMonkey is dead
> beyond the equivalent of mozilla60 (sixty, no typo), which they haven't even
> released yet. TB with about 10 staff has replaced all overlays, XBL bindings
> and are
(In reply to Jorg K (GMT+2) from comment #59)
> Thanks for your comments, Ehsan.
>
> If you want to deliberate about what the real/actual problem is, here's my
> view:
>
> The root issue is that storageAccessAPI permissions are stored for non-web
> origins, that is MailNews schemes like imap:
(In reply to Mike Hommey [:glandium] (VAC: 31 Dec - 11 Jan) from comment #32)
> The syntax is a triviality of the patch. The core problem here is that
> there's no one to review the patch so that it possibly lands.
Can I help review?
--
You received this bug notification because you are a
(In reply to Mike Hommey [:glandium] (VAC: 31 Dec - 11 Jan) from comment #32)
> The syntax is a triviality of the patch. The core problem here is that
> there's no one to review the patch so that it possibly lands.
Can I help review?
--
You received this bug notification because you are a
(In reply to maybe-the-one from comment #138)
Is there any way we can lobby for landing it in 38?
Please move that discussion to bug 1142879 or elsewhere. Thanks!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf414f68291c
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/584632
Title:
composer changes font mid email
To manage notifications about this
(In reply to Jorg K from comment #118)
Created attachment 8584620
Here comes another manual test.
Here some HTML to run a test by hand.
If clicking behind any of the eight lines in this test, DIV will be
returned in the current version of FF.
With the new behaviour clicking behind
Charles, this patch affects more than Thunderbird. I'm not sure what
the usual practices are with regards to stuff that are regression prone
in Thunderbird, but in Firefox, we are usually very conservative, and
prefer to give things more time to bake.
--
You received this bug notification
(In reply to Jorg K from comment #115)
Created attachment 8584346
Unified patch (code + test changes + twice revised new test)
Thank you very much for the review and all the additional explanation.
I hope I could address your questions in additional comments in the test.
Sadly switching
Comment on attachment 8584639
Unified patch (code + test changes + four times revised new test)
Review of attachment 8584639:
-
Thanks, looks great!
--
You received this bug notification because you are a member of Ubuntu
Bugs,
Comment on attachment 8583354
Test case (revised)
Review of attachment 8583354:
-
Looks like a great start! Did you intend to test the rest of the cases
in a separate patch?
::: layout/generic/test/test_bug756984.html
@@ +13,5 @@
(In reply to Charles from comment #128)
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from
comment #125)
Charles, this patch affects more than Thunderbird. I'm not sure what the
usual practices are with regards to stuff that are regression prone in
Thunderbird, but in
Comment on attachment 8584608
Unified patch (code + test changes + three times revised new test)
Review of attachment 8584608:
-
Can you please revise the commit message to explain what the patch does?
Something like: Bug 756984 -
Comment on attachment 8582633
Patch to fix all three problems: Click, end key, left arrow from start of
previous line (updated coding style)
Review of attachment 8582633:
-
This looks fine to me, and in fact I think it's ready for
Comment on attachment 8582701
Easy fix for test due to new selection behaviour (richtext2)
Review of attachment 8582701:
-
Fantastic! r=me.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
(In reply to Jorg K from comment #97)
These tests are a little mysterious. I wanted to look at
editor/libeditor/tests/test_selection_move_commands.xul first. Sadly
mach mochitest-plain editor/libeditor/tests/test_selection_move_commands.xul
doesn't work? I've run single tests before, but they
(In reply to Jorg K from comment #90)
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from
comment #88)
Nit: you don't need to mention bug numbers in comments. This information is
available through hg/git blame.
There are many bug numbers in the code (including some that
Cool, so yeah, a fix to those two additional cases + the unit tests is
probably all that we'd need here!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/584632
Title:
composer changes font mid email
BTW, Jorg, since your fix at least improves the situation where someone
clicks at the end of the line, I'd be fine with landing it with a test
case in this bug if you prefer to move the rest of the investigation and
the fixes into another bug. Whichever way you prefer is fine. :-)
--
You
(In reply to :Aryeh Gregor from comment #77)
For the record, from black-box testing of WebKit a few years ago, it looked
like it normalized the selection after every change. Even if you called
.addRange(), it copied the range and then stuck the selection endpoints
inside a nearby text node if
Looks like Aryeh answered your questions (thanks Aryeh!)
I realized that I forgot about another case that we need to test. br
frames are not the only reason for a line ending, we can also get line
breaks at block boundaries, for example: divblock 1brspannew line
here/spandivblock2/div/div We
Comment on attachment 8582360
Patch to fix all three problems: Click, end key, left arrow from start of
previous line
Review of attachment 8582360:
-
Some feedback on your patch so far.
::: layout/generic/nsFrame.cpp
@@ +3555,3 @@
Sorry for the delay here, somehow I failed to note the needinfo flag!
As Aryeh said, the current try results look great! And it seems like
fixing this is going to be much easier than I thought after all. :-)
The next step is to ensure that the selection is put in the exact same
place through
(In reply to Archaeopteryx [:aryx] from comment #70)
Pushed to Try:
https://treeherder.mozilla.org/#/jobs?repo=tryrevision=bb676357b6c9
Canceled this as it misses the most important part of the tests,
mochitests. Repushed:
https://treeherder.mozilla.org/#/jobs?repo=tryrevision=8b34acaf40c3
Comment on attachment 8576888
three line change to fix a 10 y/o problem ;-)
Review of attachment 8576888:
-
Good start, but this is still far from being ready for review. Did you
push this to the try server? Please include the
(In reply to Jorg K from comment #60)
The more conservative approach would be not to change the selection
behaviour but to maintain/re-establish the correct type in state after the
click. That is what IE does: The DIV is selected, but typing continues in
the correct font, see comment #54.
I don't think it's reasonable to start traversing the DOM tree every
time that we want to perform an editing operation to find the right
styles/properties to use. It's a lot of unnecessary work. It should be
a lot easier to normalize the selection in a sane way to prevent it from
going into
(In reply to Jorg K from comment #57)
Please confirm that you are happy to change FF's behaviour to be like
Chrome, Opera and Safari.
I read the last section of your comment (quote: ... Good luck!) as a
confirmation, but before you were rather careful saying (1):
If they all agree on
I added this change to the patches directory:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99814e9730de
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1322784
Title:
Firefox crashes in
(In reply to Jorg K from comment #51)
Sadly I don't understand some of what you wrote. Let me see what I
understood.
You're saying you want to check how other rendering engines behave. I ran
the test from comment #37 on Chrome and IE. Both continue text entry with
the font present on the
(In reply to Jorg K from comment #38)
Coming back to the suggestion from comment #25 and looking in
nsFrame::HandlePress.
I traced it down into ns[Text]Frame::GetChildFrameContainingOffset with a
call stack of:
nsFrame::GetChildFrameContainingOffset *or*
(In reply to Jorg K from comment #26)
Re. your last comment:
I _think_ to fix that part you need to get Thunderbird tell Gecko about how
to format the new paragraph.
I tried with a div contenteditable in Firefox. The editor handles
insertion of images by itself. So the question is: How
(In reply to Jorg K from comment #28)
Sorry to trouble you again. I have some more questions to understand how the
architecture hangs together. Let me summarise the questions from the
previous posts here:
Where is the mouse click translated into identifying a node of the DOM tree?
Your
(In reply to Jorg K from comment #23)
I could use some help to locate the code that translates the click into
identifying the element. Somewhere in ns(HTML)EditorEventListener.cpp, I
suppose.
nsFrame::HandlePress is called when you click on an element, and at
least part of the selection
(In reply to comment #31)
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
emailacopolypse) from comment #29)
(In reply to comment #28)
We should disable the screen save for non-fullscreen playback too.
Why? Some websites use video as an element in their design these
(In reply to comment #28)
We should disable the screen save for non-fullscreen playback too.
Why? Some websites use video as an element in their design these days
(for example, as the page background.) It seems counter intuitive for
such a website to disable the screen saver!
--
You received
Backed out because of mochitest-1 timeouts on Linux:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e1acd3b9ce8
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1051559
Title:
Build Firefox
This is not a regression and as far as I can tell, this has never worked
properly on Linux. The problem is that on Linux we have both the
selection and the global clipboards, so
nsClipboardPrivacyHandler::PrepareDataForClipboard gets called twice,
and the second call to
Created attachment 725915
Patch (v1)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1155934
Title:
Firefox does NOT copy images when History is set to 'Never remember'
To manage notifications about
(In reply to stevend811 from comment #3)
(In reply to Matthias Versen [:Matti] from comment #1)
The global private browsing mode got replaced by a per window private
browsing mode.
Could you test a nightly build from mozilla.org ?
I tested it on the nightly build and the bug is occurring
http://hg.mozilla.org/integration/mozilla-inbound/rev/f5bf6a0d04da
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1155934
Title:
Firefox does NOT copy images when History is set to 'Never remember'
*** Bug 772347 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
To manage notifications
Firefox 12 and 13 have shipped, no point in tracking this bug for them.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/788102
Title:
Firefox crashes or hangs on GMail
To manage notifications about
(In reply to garryb from comment #70)
Woot, I see this now in Firefox 12. (This is the main reason we're still
using a designMode iframe in G+)
Great! Please file new bugs if you see more problems blocking you from
moving to contenteditable elements.
--
You received this bug notification
https://hg.mozilla.org/mozilla-central/rev/c04a467c48ac
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/412647
Title:
Firefox is not able to play mp4 video tags
To manage notifications about this
If you have steps to reproduce, please file a new bug and we'll discuss
it there.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select language for spell check based on
(In reply to amai from comment #26)
BTW, if the code inside hunspell is responsible (it seems to be) shouldn't
we report on their project also??
We could do that too, but without somebody being able to reproduce this,
there is a little chance that it will get fixed.
--
You received this bug
Yes, I did install that package. I don't see a dictionaries directory
under /usr/lib64/firefox/extensions/langpack...@firefox.mozilla.org/ at
all. :/
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
(In reply to Alex Keybl [:akeybl] from comment #63)
Bug 696020 appears to have exacerbated this problem in 10 (see bug 702064).
The attached patch appears to be higher risk than we're comfortable for Beta
(please correct me if I'm wrong), but I'm wondering if this is a good
candidate for
*** Bug 702064 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/107247
Title:
Launchpad bug pages trigger caret browsing in Firefox and other Gecko
Neil, I think you need to add those commands back, and just make us not
use them... :(
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/107247
Title:
Launchpad bug pages trigger caret browsing in
Comment on attachment 570250
Fixed patch
Review of attachment 570250:
-
I'm not crazy about editor vs. editing controllers, but I couldn't
really think of anything better, so r=me.
Thanks a lot for your work on this, Neil, and
Comment on attachment 569554
Proposed patch
Review of attachment 569554:
-
Looks very good!
Does my test case pass with this patch?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
https://hg.mozilla.org/mozilla-central/rev/0a6b707742dd
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/602877
Title:
Position is not being updated when atk_text_set_caret_offset is used
To manage
Neil, does your patch make the test part of attachment 548924 pass? If
so, we can get them landed. :-)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/107247
Title:
Launchpad bug pages trigger
Ping?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/107247
Title:
Launchpad bug pages trigger caret browsing in Firefox and other Gecko
browsers
To manage notifications about this bug go to:
Try pinging him on IRC? He may not be watching his bugmail closely...
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/294712
Title:
Firefox does not display images when Show image is selected if
Couldn't we just suppress checking the blocking status inside
nsImageLoadingContent::LoadImage? This way we wouldn't need to modify
the content blocker service at all, we just wouldn't query it if we're
doing a force-reload.
--
You received this bug notification because you are a member of
http://hg.mozilla.org/mozilla-central/rev/471f4fbc9c85
http://hg.mozilla.org/releases/mozilla-aurora/rev/f020f92c79ca
http://hg.mozilla.org/releases/mozilla-beta/rev/f6dafd2dcc63
http://hg.mozilla.org/releases/mozilla-beta/rev/731b7bc62da3
Also: http://hg.mozilla.org/mozilla-central/rev/5319db188180
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/838322
Title:
Remove the exemptions for the Staat der Nederlanden root
To manage
Also: http://hg.mozilla.org/releases/mozilla-aurora/rev/a5a5c583c381
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/838322
Title:
Remove the exemptions for the Staat der Nederlanden root
To manage
http://hg.mozilla.org/releases/mozilla-beta/rev/01d409d49c6a
http://hg.mozilla.org/releases/mozilla-beta/rev/ff20a21364bb
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/838322
Title:
Remove the
http://hg.mozilla.org/releases/mozilla-release/rev/e65f4c8bd243
http://hg.mozilla.org/releases/mozilla-release/rev/5b6c2f8ff6da
http://hg.mozilla.org/releases/mozilla-release/rev/14452010e012
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/463dbdc80866
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d19ac6a6ef00
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/838322
Title:
Remove the
(In reply to n...@parkwaycc.co.uk from comment #24)
Is the editor attaching it's command controller to the document and not the
editable area?
Correct. There was some issue with attaching the commands to the editable
area which ehsan has pointed me towards several times but I still forget
Comment on attachment 553150
part3: fix Get/SetCurrentDictionary signature
This really belongs to another bug... but r=me nevertheless!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Followup patches landed:
http://hg.mozilla.org/mozilla-central/rev/e4a7c48aff3a
http://hg.mozilla.org/mozilla-central/rev/180442fd6448
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Comment on attachment 553143
part2: do not override manually set dictionary
+ PRBool mUpdateDictionaryRunning;
+ PRBool mDictWasSetManually;
Please use PRPackedBool.
+class UpdateDictionnaryHolder {
+ private:
+nsEditorSpellCheck* mSpellCheck;
+ public:
+
Comment on attachment 552655
patch v2.7
Review of attachment 552655:
-
This looks great! Thanks a lot for your hard work on this. :-)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
Landed on mozilla-inbound.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/303269
Title:
Automatically select language for spell check based on user input
To manage notifications about this bug go
(In reply to Dão Gottwald [:dao] from comment #72)
(In reply to comment #71)
::: layout/reftests/editor/338427-2.html
@@ +6,5 @@
+editor.focus();
+window.setTimeout(function() {
+editor.blur();
+document.documentElement.className = '';
+}, 1000); //
Comment on attachment 551030
patch v2.5
diff -r 61bb2bb510c9 editor/libeditor/html/tests/test_bug484181.html
function runTest() {
gMisspeltWords = [haz, cheezburger];
+ var edit = document.getElementById(edit);
+ edit.focus();
+ SimpleTest.executeSoon(function() {
(In reply to comment #89)
I run the test on my system before submitting a patch either here, or on try
server. Tests can succeed on my machine but fail in other environments. For
example, as I told in comment 78, this can be caused by different font
settings.
Hmm, I was talking about this
Folks, *please* do not comment on this bug in order to discuss other
bugs. This distracts the people who are working on this bug (like me
and Arno) and also makes the discussion impossible to find for somebody
who's looking at the other bug.
--
You received this bug notification because you are
(In reply to comment #20)
(In reply to comment #19)
Is this a regression in 6? How widespread is this likely to be? We're just a
few days from the final Beta of 6.
This is not a regression in 6, from what Ehsan said on IRC, but e.g.
planet.m.o is unusable using keys for several days now,
(In reply to comment #18)
Ehsan, does Neil's approach sound better to you? It does to me.
As I've said before, I don't understand the focus manager code, so if
Neil (Deakin) vouches on that, I'd be fine with Neil's approach. I'm
assuming that he's going to address the todo items in comment 13
Comment on attachment 548731
patch v2
Review of attachment 548731:
-
The patch looks very good, r=me on it with the comments below addressed.
Thanks a lot for working on this!
::: editor/composer/src/nsEditorSpellCheck.cpp
@@
(In reply to comment #66)
Can you add another test here for the dynamic change case? You can put
lang=en-US on the textarea, then upon load change it to testing-XX, then
.focus() and .blur().
Actually, this does not work. Calling SetCurrentDictionary to an invalid
language, does
Comment on attachment 549230
patch v2.2
Review of attachment 549230:
-
r=me with the below comments fixed.
::: content/base/public/nsIContent.h
@@ +948,5 @@
+ * Determing language. Look at the nearest ancestor element that has a
(In reply to comment #23)
Likely caused by the post that uses contenteditable.
Indeed.
*** This bug has been marked as a duplicate of bug 669026 ***
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
(In reply to comment #25)
I also noted that middle-clicking links on Planet Mozilla doesn't work.
Same bug?
No, please file one?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/107247
Title:
(In reply to comment #50)
For dynamic changes, let's see if bz has any ideas how to handle them
efficiently
So the goal here is that you want to be notified when the language of some
particular content node changes, right?
Yes.
--
You received this bug notification because you are a
(In reply to comment #52)
We don't have an existing notification system that would work for that.
We'd need to add something.
That said, you only care about this for things that have frames, no? Is
there a reason that GetStyleVisibility()-mLanguage (which is somewhat
different, in that I
(In reply to comment #56)
(In reply to comment #55)
Created attachment 548559 [details] [review]
wip
wip patch:
it deals with ehsan suggestions except for the html editor handling (ie:
GetActiveEditingHost method).
What needs to be done is call GetActiveEditingHost at the right
(In reply to comment #54)
Right; if the style property is good enough we could easily add a notification
when it changes.
If we modify it to match the HTML5 spec, that would probably work fine.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed
(In reply to comment #59)
The hard part there is xml:lang, since it needs to apply to all elements and
not just the ones that do attribute mapping...
Then maybe we can defer this part to another bug.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
Comment on attachment 547702
updated patch
Review of attachment 547702:
-
In general I like this patch. I'm minusing because of the GetLanguage
part, but the rest generally looks good.
About testing strategies, you can load
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2b1eb891d7fe
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/801778
Title:
Regression: Firefox 3.6.18 does not set cookie when talking to single
The ubuntu folks want this badly. Can we get the approval on this one
soon, please?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/801778
Title:
Regression: Firefox 3.6.18 does not set cookie when
I landed the m-c test on inbound. Please do not mark the bug as FIXED
when you merge to central.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/801778
Title:
Regression: Firefox 3.6.18 does not set
http://hg.mozilla.org/projects/cedar/rev/7c42f37e0284
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/539226
Title:
firefox(-gnome-support) should be compiled with Gio support instead
GnomeVFS
--
http://hg.mozilla.org/mozilla-central/rev/7c42f37e0284
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/539226
Title:
firefox(-gnome-support) should be compiled with Gio support instead
GnomeVFS
--
*** This bug has been marked as a duplicate of bug 424627 ***
--
Strange behavior when pasting a text in a text box with mouse cursor on the
edge of the text box and left mouse button pressed
https://bugs.launchpad.net/bugs/508969
You received this bug notification because you are a member of
94 matches
Mail list logo
