[Bug 1680224] Re: auto.smb fails on Windows administrative shares
In reviewing the first patch I've found another problem with mapent_len possibly not being initialized. Note the order of application of the patch is: autofs-5.1.2 - use malloc for expanded map location autofs-5.1.2 - fix offset mount location multiple expansion and, although they are against current upstream they should apply. If not then ask and I'll fix them. ** Patch added: "Patch - use malloc for expanded map location" https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+attachment/4867069/+files/autofs-5.1.2-use-malloc-for-expanded-map-location.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1680224 Title: auto.smb fails on Windows administrative shares To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1680224] Re: auto.smb fails on Windows administrative shares
I have made a small change to the patch of comment #6. I've added initialization of the malloc()ed pmapent variable. While that wasn't a problem it can be on some architectures. ** Patch added: "Patch - increase worker thread per-thread stack size" https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+attachment/4867068/+files/autofs-5.1.2-fix-offset-mount-location-multiple-expansion.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1680224 Title: auto.smb fails on Windows administrative shares To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1680224] Re: auto.smb fails on Windows administrative shares
The two autofs patches Mark has attached aren't yet available on kernel.org but I will (eventually) commit them to the autofs repo. and upload them. The change will be included in autofs-5.1.3. The only difference between what will be upstream and what has been posted will be a single line description added to the autofs CHANGELOG (since there hopefully won't be any further changes needed) and a Signed-off-by line in the description. The first patch is not strictly needed but the use of alloca() can be unreliable in stack overflow conditions as (I believe) it never returns a failure. So since it was used in the area that needed to be changed I thought it best to fix it as part of the change. The patch descriptions hopefully provide enough information for others to understand what the problem was and why the change fixes the problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1680224 Title: auto.smb fails on Windows administrative shares To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs