[Bug 1843036] Re: [regression] SNMP missing disks in hrStorageTable

2019-09-09 Thread Joseph Gooch
Confirmed working Xenial:
snmpd:
  Installed: 5.7.3+dfsg-1ubuntu4.4
  Candidate: 5.7.3+dfsg-1ubuntu4.4
  Version table:
 *** 5.7.3+dfsg-1ubuntu4.4 500
500 http://us.archive.ubuntu.com/ubuntu xenial-proposed/main amd64 
Packages
100 /var/lib/dpkg/status

And Bionic:
snmpd:
  Installed: 5.7.3+dfsg-1.8ubuntu3.3
  Candidate: 5.7.3+dfsg-1.8ubuntu3.3
  Version table:
 *** 5.7.3+dfsg-1.8ubuntu3.3 500
500 http://us.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 
Packages
100 /var/lib/dpkg/status

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1843036

Title:
  [regression] SNMP missing disks in hrStorageTable

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1843036] Re: [regression] SNMP missing disks in hrStorageTable

2019-09-06 Thread Joseph Gooch
Confirmed testpkg20190906b3 fixes the issue for me as well.

I imagine there will need to be a xenial backport too?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1843036

Title:
  [regression] SNMP missing disks in hrStorageTable

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-06 Thread Joseph Gooch
*** This bug is a duplicate of bug 1843036 ***
https://bugs.launchpad.net/bugs/1843036

Dev is apparently happening on this ticket FYI
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036


** This bug has been marked a duplicate of bug 1843036
   [regression] SNMP missing disks in hrStorageTable

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1843005] Re: disk usage not showing up in HOST-RESOURCES-MIB::hrStorageTable after latest update

2019-09-06 Thread Joseph Gooch
*** This bug is a duplicate of bug 1843036 ***
https://bugs.launchpad.net/bugs/1843036

** This bug is no longer a duplicate of bug 1842924
   hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3
** This bug has been marked a duplicate of bug 1843036
   [regression] SNMP missing disks in hrStorageTable

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1843005

Title:
  disk usage not showing up in HOST-RESOURCES-MIB::hrStorageTable after
  latest update

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843005/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1843036] Re: [regression] SNMP missing disks in hrStorageTable

2019-09-06 Thread Joseph Gooch
Docker test case attached - if you untar this, and
cd DockerTestCase
docker build .


It'll run through, download the pkg from your PPA and illustrate that OIDs 
above 30 are missing.

8ubuntu3.1 returns this:
iso.3.6.1.2.1.25.2.3.1.3.1 = STRING: "Physical memory"
iso.3.6.1.2.1.25.2.3.1.3.3 = STRING: "Virtual memory"
iso.3.6.1.2.1.25.2.3.1.3.6 = STRING: "Memory buffers"
iso.3.6.1.2.1.25.2.3.1.3.7 = STRING: "Cached memory"
iso.3.6.1.2.1.25.2.3.1.3.8 = STRING: "Shared memory"
iso.3.6.1.2.1.25.2.3.1.3.10 = STRING: "Swap space"
iso.3.6.1.2.1.25.2.3.1.3.34 = STRING: "/dev"
iso.3.6.1.2.1.25.2.3.1.3.37 = STRING: "/sys/fs/cgroup"
iso.3.6.1.2.1.25.2.3.1.3.51 = STRING: "/dev/shm"
iso.3.6.1.2.1.25.2.3.1.3.52 = STRING: "/etc/resolv.conf"
iso.3.6.1.2.1.25.2.3.1.3.53 = STRING: "/etc/hostname"
iso.3.6.1.2.1.25.2.3.1.3.54 = STRING: "/etc/hosts"
iso.3.6.1.2.1.25.2.3.1.3.60 = STRING: "/proc/acpi"
iso.3.6.1.2.1.25.2.3.1.3.61 = STRING: "/proc/kcore"
iso.3.6.1.2.1.25.2.3.1.3.62 = STRING: "/proc/keys"
iso.3.6.1.2.1.25.2.3.1.3.63 = STRING: "/proc/timer_list"
iso.3.6.1.2.1.25.2.3.1.3.64 = STRING: "/proc/sched_debug"
iso.3.6.1.2.1.25.2.3.1.3.65 = STRING: "/proc/scsi"
iso.3.6.1.2.1.25.2.3.1.3.66 = STRING: "/sys/firmware"

PPA:
iso.3.6.1.2.1.25.2.3.1.3.1 = STRING: "Physical memory"
iso.3.6.1.2.1.25.2.3.1.3.3 = STRING: "Virtual memory"
iso.3.6.1.2.1.25.2.3.1.3.6 = STRING: "Memory buffers"
iso.3.6.1.2.1.25.2.3.1.3.7 = STRING: "Cached memory"
iso.3.6.1.2.1.25.2.3.1.3.8 = STRING: "Shared memory"
iso.3.6.1.2.1.25.2.3.1.3.10 = STRING: "Swap space"

I did see you'll do another package, so when that's posted I'll just run
this again. :)


** Attachment added: "DockerTestCase.tar.gz"
   
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+attachment/5287148/+files/DockerTestCase.tar.gz

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1843036

Title:
  [regression] SNMP missing disks in hrStorageTable

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1843036] Re: [regression] SNMP missing disks in hrStorageTable

2019-09-06 Thread Joseph Gooch
Duplicate of https://bugs.launchpad.net/ubuntu/+source/net-
snmp/+bug/1842924

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1843036

Title:
  [regression] SNMP missing disks in hrStorageTable

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1843036] Re: [regression] SNMP missing disks in hrStorageTable

2019-09-06 Thread Joseph Gooch
Need this too if you haven't included it...


** Patch added: "fix_hrstorage_after_autofs.patch"
   
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+attachment/5287145/+files/fix_hrstorage_after_autofs.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1843036

Title:
  [regression] SNMP missing disks in hrStorageTable

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1843036/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-06 Thread Joseph Gooch
Patch provided on upstream bugreport 
https://sourceforge.net/p/net-snmp/patches/1350/

Here's the quilt version of the chatter...


** Patch added: "fix_hrstorage_after_autofs.patch"
   
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+attachment/5287144/+files/fix_hrstorage_after_autofs.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-06 Thread Joseph Gooch
Or not, I think I found it.

This line:
/* Skip AUTOFS entries */
if (entry->type == NETSNMP_FS_TYPE_AUTOFS)
continue;

Looks really innocuous until you run it through gcc -E:
if (entry->type == 7 | 0x1000 | 0x2000)
continue;

At which point you realize the | is going to make this if TRUE all the
time.

I need to find the define and add ()'s around it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-06 Thread Joseph Gooch
I removed
#if HAVE_GETFSSTAT
And
#endif /* HAVE_GETFSSTAT */


Based on looking at the Check_HR_FileSys_NFS function earlier in the file, it 
was structured like:
#if HAVE_GETFSSTAT
  something that looks nothing like the autofs function above with different 
constants
#else
  something that looks just like the autofs function above
#endif


BUT, I'm not sure if there should be a HAVE_GETFSSTAT section in this
function, and if so what it should be.  I'm basically poking around and
compiling and doing a lot of trial and error.  I played enough in GDB to
determine that netsnmp_fsys_arch_load IS finding all the correct
mountpoints, but I couldn't directly determine at what point the
physical ones were being thrown away.  The constants all over the code
made it very difficult to debug with GDB as it couldn't resolve the
precompiler directives, and I very quickly got sucked into a rabbit hole
of header spelunking.


I pinned the previous release on my servers to fix the immediate issue.  I may 
have more time to look later, but it's very likely it'll take the original 
patch author, or someone who has any experience working in the daemon far less 
time to resolve :)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-05 Thread Joseph Gooch
While that's wrong it must be more than that because changing it didn't
fix it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-05 Thread Joseph Gooch
This part looks questionable:
@@ -839,6 +839,27 @@ Check_HR_FileSys_NFS (void)
 return 0;  /* no NFS file system */
 }

+/* This function checks whether current file system is an AutoFs
+ * HRFS_entry must be valid prior to calling this function
+ * return 1 if AutoFs, 0 otherwise
+ */
+int
+Check_HR_FileSys_AutoFs(void)
+{
+#if HAVE_GETFSSTAT
+if (HRFS_entry->HRFS_type != NULL &&
+#if defined(MNTTYPE_AUTOFS)
+!strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS)
+#else
+!strcmp(HRFS_entry->HRFS_type, "autofs")
+#endif
+)
+#endif /* HAVE_GETFSSTAT */
+return 1;  /* AUTOFS */
+
+return 0; /* no AUTOFS */
+}
+


if HAVE_GETFSSTAT doesn't pass, we end up with:
return 1;
return 0;


In effect, ALL filesystems are autofs.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1842924] Re: hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

2019-09-05 Thread Joseph Gooch
Some behavior seen here, on Xenial but also on Bionic @
5.7.3+dfsg-1.8ubuntu3.2

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842924

Title:
  hrStorage Not Available In 5.7.3+dfsg-1ubuntu4.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1842924/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs