[Bug 734023] Re: Missing text and icons

2013-05-08 Thread Muhammad Haggag
Still broken in 13.04

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/734023

Title:
  Missing text and icons

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/audacity/+bug/734023/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1001556]

2012-08-06 Thread Muhammad Haggag
Confirmed. I'll be investigating it shortly.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1001556

Title:
  [Upstream] Word Count Characters (with spaces) incorrect with
  Numbering on

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1001556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 700971] Re: Minbar: Use indicator framework if available

2012-07-13 Thread Muhammad Haggag
عليكم السلام ،

(Apologies for the late reply--I didn't get a notification email)

 Yet, did you contact previous upstream maintainer of minbar before
assuming maintainership for the project ?

I tried, but he's not responding anymore. I tried both af...@djihed.com
(from djihed.com) andn dji...@gmail.com (from README) on May 18th and
Jun 21st respectively. His minbar homepage (djihed.com/minbar) isn't
there anymore, either, so I assumed he simply lost interest or moved on
and forked.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/700971

Title:
  Minbar: Use indicator framework if available

To manage notifications about this bug go to:
https://bugs.launchpad.net/ayatana-ubuntu/+bug/700971/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 789673] Re: About Minbar Prayer Times button

2012-07-13 Thread Muhammad Haggag
This is fixed on trunk (https://launchpad.net/minbar/trunk). I'll
resolve it once I figure out how to integrate my fixes.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/789673

Title:
  About Minbar Prayer Times button

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/minbar/+bug/789673/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 700971] Re: Minbar: Use indicator framework if available

2012-07-10 Thread Muhammad Haggag
So, I created a project based on the source package
(launchpad.net/minbar) and fixed a couple of issues, including this one
(currently fixed on trunk). Unfortunately, I'm new to launchpad so I'm
not sure how one's supposed to go about integrating the fixes or moving
forward. Any pointers?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/700971

Title:
  Minbar: Use indicator framework if available

To manage notifications about this bug go to:
https://bugs.launchpad.net/ayatana-ubuntu/+bug/700971/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 981033]

2012-06-14 Thread Muhammad Haggag
(In reply to comment #4)
 reproduced in 3.5.3 on Fedora 64 bit
 not reproduced in 3.3.4 , therefore regression
 problem only in  Tools-Word count, no problem in File-Properties-Statistics

Are you sure file statistics aren't suffering from the same problem?
It's showing 45 for me (same as the word count dialog and status bar).

Also, when you go ahead and save the document, it updates the statistics
differently from how the word count dialog does it--it actually counts
characters marked for deletion (286), and so the word count dialog shows
the same count (since it's seeded from the document statistics). As soon
as you start typing, the word count code is invoked and the number of
characters becomes 113 again.

The problem is that character counting masks text marked as deleted and
hidden text by replacing it with spaces, but all other word/character
counting code doesn't. It seems intentional, although the Why isn't
clear to me. See SwTxtNode::CountWords and its call to
lcl_MaskRedlinesAndHiddenText:
http://opengrok.libreoffice.org/xref/core/sw/source/core/txtnode/txtedt.cxx#1864

I tracked the change with 'git blame' to the following commit by John LeMoyne 
Castle:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bd28ba4c6d2af96bb6638b88635598e1bb88e8f

Unfortunately, the commit message doesn't explain why it's doing
character masking. A google search for John LeMoyne Castle character
count leads to fdo#30550:
https://bugs.freedesktop.org/show_bug.cgi?id=30550

It looks like the initial work was done by Mattias Johnsson, then John
fixed several bugs. It seems the intent of his commit was to fix the
selection case only. It might be that the character masking bit was
erroneously added, perhaps a left over from another commit.

My recommendation is to remove the masking of deleted characters, since
it'll be  a lot of work to get that working properly (and consistently)
with both word/character count and document statistics, for no obvious
benefit. If there's demand for such a feature, it should be filed and
tracked separately.

I'll be posting a patch shortly to remove the masking and make the
behavior consistent.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/981033

Title:
  [Upstream] Words and Character excluding spaces Word Count incorrect
  with Record Changes enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/981033/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 981033]

2012-06-14 Thread Muhammad Haggag
Created attachment 62923
Proposed patch.

After looking at the code closely, I change my recommendation. It's
actually straight-forward to get the word counting code to consistently
ignore deleted content. Patch attached.

One problem that remains with this patch is document statistics. When
you save the document, a gross word count is computed (including deleted
content), saved with the document, and seeded to the word count dialog.
The word count dialog (and status bar) show the incorrect count until
you edit the document (insert/delete something), at which point the
proper word counting logic is invoked and the count is corrected.

I won't post the patch for review/commit yet in the hopes that I can fix
the document statistics issue as well. If it looks complicated, I'll get
this committed and pursue the statistics issue separately.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/981033

Title:
  [Upstream] Words and Character excluding spaces Word Count incorrect
  with Record Changes enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/981033/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 981033]

2012-06-14 Thread Muhammad Haggag
Created attachment 62967
Updated patch.

The reason document statistics is broken comes down to the following
commit:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6af264883910fe31433b4164b1956f4f9ed75ecb

It disables redlining deleted changes (by removing the flag
REDLINE_SHOW_DELETE) when exporting (saving) documents, which leads to
SwTxtNode::CountWords counting the deleted changes instead of masking
them (since it only masks redlined content).

It appears that was done as a bug fix. Unfortunately, it was fixing a
bug from 2001, and information on such bugs are not available anymore.
The attached patch leaves the broken document statistics behavior as is,
and I'll file a separate bug to track it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/981033

Title:
  [Upstream] Words and Character excluding spaces Word Count incorrect
  with Record Changes enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/981033/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1001556]

2012-06-10 Thread Muhammad Haggag
Investigating.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1001556

Title:
  [Upstream] Word Count Characters (with spaces) incorrect with
  Numbering on

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1001556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1001556]

2012-06-10 Thread Muhammad Haggag
Created attachment 62850
Proposed patch.

Added a patch.

Note that if you were to test the patch using the attached test document
(61877), you have to type a character first to invoke the fixed
character counting code and show the correct count. The initial
character count for the document is loaded from the document statistics,
and is incorrect because it was calculated without the patch.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1001556

Title:
  [Upstream] Word Count Characters (with spaces) incorrect with
  Numbering on

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1001556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1001556]

2012-06-10 Thread Muhammad Haggag
Review thread on libreoffice-dev: http://nabble.documentfoundation.org
/PATCH-fdo-50141-Word-Count-Characters-with-spaces-incorrect-with-
Numbering-on-tp3989175.html

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1001556

Title:
  [Upstream] Word Count Characters (with spaces) incorrect with
  Numbering on

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1001556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 789673] Re: About Minbar Prayer Times button

2012-05-18 Thread Muhammad Haggag
** Changed in: minbar (Ubuntu)
   Status: New = Confirmed

** Changed in: minbar (Ubuntu)
 Assignee: (unassigned) = Muhammad Haggag (mhaggag)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/789673

Title:
  About Minbar Prayer Times button

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/minbar/+bug/789673/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs