[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
(In reply to Mike Hommey [:glandium] from comment #46) > The preferences code is being heavily refactored, and this needs to wait a > bit for things to settle first. That being said, I do think the ideal timing > for this would be to get it into 60. Nick, what do you think? If things go well with

[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
Created attachment 8956309 Bug 440908 - Remove gIsAnyPrefLocked. It optimizes Preferences::IsLocked(), but that function is called fewer than 200 times while starting the browser and opening a range of tabs. Review commit: https://reviewboard.mozilla.org/r/225182/diff/#index_header See other

[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
https://hg.mozilla.org/integration/mozilla-inbound/rev/edb57fbc6beac233b12486fa7d7381220339de0f Bug 440908 - Remove gIsAnyPrefLocked. r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/b82802657783b6188e320ba966183ae1eedabf62 Bug 440908 - Add support for `sticky` and `locked`

[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
> clang-format changed its mind, I guess? No, chutten changed that code in bug 1435753. I generally run `./mach clang-format -p modules/libpref`. Perhaps I should just run `./mach clang-format` instead... -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
Created attachment 8956311 Bug 440908 - Convert sticky prefs in default pref files to the new syntax. Review commit: https://reviewboard.mozilla.org/r/225186/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/225186/ -- You received this bug notification because you are a

[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
Created attachment 8956310 Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs. Sticky prefs are already specifiable with `sticky_pref`, but this is a more general attribute mechanism. The ability to specify a locked pref in the data file is new. The patch also adds

[Bug 541951]

2019-07-02 Thread Nicholas Nethercote
Comment on attachment 8931547 Bug 440908 - Allow preference files to set locked prefs. https://reviewboard.mozilla.org/r/202672/#review208008 As per our IRC discussion, I think this is a good feature, and the patch does a good job of implementing it. But before doing this I'd like to officially

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
https://hg.mozilla.org/integration/mozilla-inbound/rev/edb57fbc6beac233b12486fa7d7381220339de0f Bug 440908 - Remove gIsAnyPrefLocked. r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/b82802657783b6188e320ba966183ae1eedabf62 Bug 440908 - Add support for `sticky` and `locked`

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
Created attachment 8956311 Bug 440908 - Convert sticky prefs in default pref files to the new syntax. Review commit: https://reviewboard.mozilla.org/r/225186/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/225186/ -- You received this bug notification because you are a

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
> clang-format changed its mind, I guess? No, chutten changed that code in bug 1435753. I generally run `./mach clang-format -p modules/libpref`. Perhaps I should just run `./mach clang-format` instead... -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
Created attachment 8956310 Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs. Sticky prefs are already specifiable with `sticky_pref`, but this is a more general attribute mechanism. The ability to specify a locked pref in the data file is new. The patch also adds

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
(In reply to Mike Hommey [:glandium] from comment #46) > The preferences code is being heavily refactored, and this needs to wait a > bit for things to settle first. That being said, I do think the ideal timing > for this would be to get it into 60. Nick, what do you think? If things go well with

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
Comment on attachment 8931547 Bug 440908 - Allow preference files to set locked prefs. https://reviewboard.mozilla.org/r/202672/#review208008 As per our IRC discussion, I think this is a good feature, and the patch does a good job of implementing it. But before doing this I'd like to officially

[Bug 623844]

2019-07-01 Thread Nicholas Nethercote
Created attachment 8956309 Bug 440908 - Remove gIsAnyPrefLocked. It optimizes Preferences::IsLocked(), but that function is called fewer than 200 times while starting the browser and opening a range of tabs. Review commit: https://reviewboard.mozilla.org/r/225182/diff/#index_header See other

[Bug 1802520] Re: gnome-terminal prints gnome settings daemon log messages (?) every time I launch it

2019-02-27 Thread Nicholas Nethercote
I just upgraded to 18.10 and have the same problem. For me, the output when opening a single gnome-terminal is the following. # watch_fast: "/com/canonical/unity-gtk-module/" (establishing: 0, active: 0) # unwatch_fast: "/com/canonical/unity-gtk-module/" (active: 0, establishing: 1) #

[Bug 911540]

2014-09-03 Thread Nicholas Nethercote
The smaps reading code is long gone, so this shouldn't be a problem any more. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/911540 Title: about:memory displays a weird error due to lacking access

[Bug 1244021] Re: After upgrading to 13.10, clang and GCC erroneously look for GCC-4.7 headers

2014-07-04 Thread Nicholas Nethercote
FWIW, I just upgraded to 14.04 and hit exactly the same problem. This time I just had to rename /usr/include/x86_64-linux-gnu/c++/4.7/ to fix it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1244021

[Bug 1244021] [NEW] After upgrading to 13.10, clang and GCC erroneously look for GCC-4.7 headers

2013-10-23 Thread Nicholas Nethercote
Public bug reported: I'm a Firefox developer. 13.04 was working fine. I upgraded to 13.10 and now I can't compile Firefox with either clang or GCC. Here's a reduced test case: #include memory int main(void) {} If I compile this with clang I get this: [fjord:~/moz/mi5] clang++ a.cpp In