[Bug 867424]

2020-05-08 Thread Oliver-henshaw
(In reply to Andrew McCreight (PTO-ish) [:mccr8] from comment #52) > Comment on attachment 8763602 > (2/4) - Annotate deliberate leak in SaveToEnv > > Review of attachment 8763602: > - > > Be sure to #include

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8763602 (2/4) - Annotate deliberate leak in SaveToEnv glandium suggested using MOZ_LSAN_INTENTIONALLY_LEAK_OBJECT directly in the code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
A fairly reduced change is https://hg.mozilla.org/try/rev/def1122a86ba4a17de9da4ed6fa04323c819b753 (with the no-op https://hg.mozilla.org/try/rev/487f69ba0d14 as parent) - see https://treeherder.mozilla.org/#/jobs?repo=try=959751bdb468. I think setenv and putenv share some code in glibc - so

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
https://treeherder.mozilla.org/#/jobs?repo=try=76ba509b5927 shows the lsan annotation works. Is there any need to re-run the normal try tests from comment #34? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8763607 (4/4) - Drop unused Xatom.h include Another un-needed include, this one was left over after the removal of the N900 code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8763601 (1/4) - Change modelines to those recommended by coding style. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8763603 (3/4) - Stop using libgnome and libgnomeui on Linux v6. Minor change that I spotted while trying to track down the setenv problem - drop unneeded xlib.h include. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
toolkit/xre/nsAppRunner.cpp:SaveToEnv() intentionally leaks memory because it ends up calling putenv(3) which 'leaks' by design and by specification - this was suppressed for valgrind in bug #793534. But I don't understand why this doesn't trigger the leak sanitizer in the existing code - also

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8757425 (2/2) - Stop using libgnome and libgnomeui on Linux v5. Changes from v4 --- Made myself the author, since I deserve the blame even though I don't deserve the credit. Added a note that Chris Coulson wrote the original patch. If there's a better way to handle

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
https://treeherder.mozilla.org/#/jobs?repo=try=24c95faf3d3e is a compile-only try run. Not sure what tests, if any, are suitable. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title:

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8754795 (1/2) - Change modelines to those recommended by coding style -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8737263 Stop using libgnome and libgnomeui on Linux v3 Updated this patch again, and tested on master and on top of 45.0.1. It works with both gtk2 and gtk3 builds but I'd still like feedback about whether I'm doing the right thing with all the gtk plumbing. Solved Issues

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8754796 (2/2) - Stop using libgnome and libgnomeui on Linux v4 Changes from v3 --- * Rebase to master - Unbitrot to match "Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod" * Set client state to disconnected before

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
To expand on it not yet solving bug #557601 - on normal application quit I see New state = DISCONNECTED after phase "web-workers-shutdown"; on SM-triggered shutdown/quit I've seen it DISCONNECTED just after phase "profile-change-teardown".. -- You received this bug notification because you

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Actually, comment #14 is accurate.Calling SmcCloseConnection from ~nsNativeAppSupportUnix should always be safe, as all shutdown phases will have completed by this point (in the current code) I managed to understand the shutdown sequence a little better by attaching gdb and sprinkling some

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
(In reply to Bryan Quigley from comment #20) > I'm guessing libsm/libice won't work on wayland? > > Looks like we might be able to get shutdown (but not logout) support from > systemd. -https://wiki.freedesktop.org/www/Software/systemd/inhibit/ Well, the ICE protocol was deliberately

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
Created attachment 8605868 Stop using libgnome and libgnomeui on Linux v2 I've updated the patch above, and have had some success with it, but it still needs some work in order to disconnect from the SM at the right time. It's been compiled and tested a little on top of 37.0.1, it just needed a

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
As a minor aside, it would be desirable to do as much work as possible between SaveYourselfCB() and SmcSaveYourselfDone(), and as little as possible between DieCB() and SmcCloseConnection(). At least in KDE, the time-out for the first phase is slightly longer (15 seconds and configurable versus

[Bug 867424]

2020-05-08 Thread Oliver-henshaw
(In reply to desrt from comment #16) > There is really no good reason for this code to exist anymore. I ended up > with libgnome installed as a dependency for another old program and my > Firefox install started misbehaving as a (nearly untracable) sideeffect of > that. It took me quite a while

[Bug 1662281] Re: Firefox shows post-crash page after reboot or logoff

2017-02-27 Thread Oliver-henshaw
** Bug watch added: GNOME Bug Tracker #779306 https://bugzilla.gnome.org/show_bug.cgi?id=779306 ** Also affects: gnome-session via https://bugzilla.gnome.org/show_bug.cgi?id=779306 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member

[Bug 1662281] Re: Firefox shows post-crash page after reboot or logoff

2017-02-16 Thread Oliver-henshaw
This is probably due to gnome-session (mis-)behaviour: My test client gets a "Die" message from the xsm server and within a few tens of milliseconds receives an ICE io error (as the server has quit or broken the connection). According to

[Bug 1662281] Re: Firefox shows post-crash page after reboot or logoff

2017-02-06 Thread Oliver-henshaw
Is the environment variable $SESSION_MANAGER set? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662281 Title: Firefox shows post-crash page after reboot or logoff To manage notifications about

[Bug 474654]

2013-04-16 Thread Oliver-henshaw
The new screen locker should indeed resolve this; if you still see a problem in 4.10, please file a new bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/474654 Title: [SecurityRoadmap] Desktop

[Bug 1164876] Re: update xserver to fix broken XResetScreenSaver

2013-04-16 Thread Oliver-henshaw
** Summary changed: - KDE daemon crashes on wakeup from suspend + update xserver to fix broken XResetScreenSaver -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1164876 Title: update xserver to fix

[Bug 184682]

2013-04-12 Thread Oliver-henshaw
The kde 4.10 screen locker doesn't behave the same, so this shouldn't be happening any more IIRC. If anyone is encountering it on 4.10 and can reproduce it, I'd like to hear details. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 991885]

2013-04-10 Thread Oliver-henshaw
Is the lid actually closed when this happens, or is it open? If you can reproduce it, please enable kded [1] and 7020 kded4 in kdebugdialog and attach the output of 'tail -f .xsession-errors' when this happens. [1] If you can't see this entry first time in kdebugdialog then logout and try again.

[Bug 1164876] Re: KDE daemon crashes on wakeup from suspend

2013-04-05 Thread Oliver-henshaw
This fix is mainly important for https://bugs.kde.org/show_bug.cgi?id=310317 - the xserver bug may also help trigger the crash bug linked above. Ubuntu 13.04 has sufficiently new xorg-server packages to have the fix, it's just 12.10 that needs attention. ** Bug watch added: KDE Bug Tracking

[Bug 626321]

2012-12-23 Thread Oliver-henshaw
The discussion linked to from comment #3 certainly suggests that this is in scope for x11/randr. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/626321 Title: X.org server should keep track of and

[Bug 1072846] [NEW] can't select user from User Bar on live image

2012-10-29 Thread Oliver-henshaw
Public bug reported: When I log out of the kubuntu livecd I can't log in again. This seems to be a problem with the User Bar theme. 1. Boot into kubuntu-12.10-desktop-amd64.iso 2. Logout 3. Observe login screen Actual Results: No user icons, just a password field. Entering a blank password