(In reply to flocculant from comment #175)
> @pgkos:
>
> I've got thunar built with your new patch and the git one from a ppa.
>
> Moving the same files as before I had no crashes.
>
> Then I redid the same test, this time copying the files to 2 seperate
> locations on seperate drives.
>
>
Created attachment 6976
Fix crash and hang while renaming
A new version of my patch. This fixes both:
- the crash when renaming a file through the popup dialog
- the hang when renaming many files at once (e.g. using mv)
For the remaining crashes (while using mv command), please apply
Created attachment 6978
Fix crash and hang while renaming (2)
@flocculant I have updated the patch - please test.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1512120
Title:
[SRU] thunar crashes
The hangs may be caused by the multithreading bug from my previous
comment.
The problem is this: there is both a folder monitor and a file monitor.
Usually, the file monitor is registered before the folder monitor. If
that happens, when a file is renamed, the file monitor gets called and
the
Unfortunately, I have spotted yet another multithreading bug (I have
verified it in gdb).
Basically, thunar_file_finalize function in thunar-file.c is not thread
safe.
The reason why this function is bad is that when gobject's reference
count reaches 0 (inside Glib's g_object_unref, see
@x...@dirdi.name - thank you for the suggestions. Regarding the hangs,
I'm pretty certain that the hanging is not caused by my mutex -
thunar_folder_monitor is always called on the main thread (it is a slot
function). Also, I have experienced the same hang without the mutex.
--
You received this
@Simon Steinbeiss
My patch only prevents the crash, it does not affect the hanging at all
- Thunar also hangs during your test without my patch.
The hanging is a distinct issue.
If I have time I will try to fix that issue as well.
--
You received this bug notification because you are a member
@Martin Dauskardt
The patch is based on the git master.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1512120
Title:
[SRU] thunar crashes on file renaming
To manage notifications about this bug
Created attachment 6965
Fix race in thunar_file_rename and thunar_folder_monitor
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1512120
Title:
[SRU] thunar crashes on file renaming
To manage
I am sending a simple patch which wraps the renaming code and the folder
monitor code in a mutex.
I suppose that the main reason for the crash is that when we call in
thunar-file.c:1932:
g_file_set_display_name (file->gfile, name, cancellable, error);
this call sends a signal which is connected
10 matches
Mail list logo
