[Bug 1948434] Re: Check if secure boot is enabled with development keys

2021-11-15 Thread Shravan Kumar Ramani
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1948434 Title: Check if secure boot is enabled with development keys

[Bug 1948436] Re: Add RevID field to VPD info in EEPROM

2021-11-15 Thread Shravan Kumar Ramani
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1948436 Title: Add RevID field to VPD info in EEPROM To manage

[Bug 1948436] [NEW] Add RevID field to VPD info in EEPROM

2021-10-22 Thread Shravan Kumar Ramani
Public bug reported: SRU Justification: [Impact] Currently, the VPD info stored in the EEPROM does not include a Rev ID. This field is incremented when a PN goes through minor HW changes. Sometimes, SW needs to differentiate the two versions of the card. Hence, this field should be supported

[Bug 1948434] [NEW] Check if secure boot is enabled with development keys

2021-10-22 Thread Shravan Kumar Ramani
Public bug reported: SRU Justification: [Impact] Currently, there is no indication from mlx-bootctl when the user reads the lifecycle_state sysfs as to whether secure boot is enabled with development keys or production keys. In order to make this clear to the user, add a check in the driver.

[Bug 1931843] Re: Update mlx-bootctl to access new fields in EEPROM MFG

2021-07-30 Thread Shravan Kumar Ramani
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1931843 Title: Update mlx-bootctl to access new fields in EEPROM MFG

[Bug 1931981] Re: mlx-bootctl: Fix potential buffer overflow

2021-07-07 Thread Shravan Kumar Ramani
*** This bug is a duplicate of bug 1931843 *** https://bugs.launchpad.net/bugs/1931843 ** This bug has been marked a duplicate of bug 1931843 Update mlx-bootctl to access new fields in EEPROM MFG -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1933642] Re: mlx-bootctl: Fix exclusion issues around arm_smccc_smc

2021-07-07 Thread Shravan Kumar Ramani
*** This bug is a duplicate of bug 1931843 *** https://bugs.launchpad.net/bugs/1931843 ** This bug has been marked a duplicate of bug 1931843 Update mlx-bootctl to access new fields in EEPROM MFG -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1931984] Re: mlx-bootctl: Update license and version info

2021-07-07 Thread Shravan Kumar Ramani
*** This bug is a duplicate of bug 1931843 *** https://bugs.launchpad.net/bugs/1931843 ** This bug has been marked a duplicate of bug 1931843 Update mlx-bootctl to access new fields in EEPROM MFG -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1933642] [NEW] mlx-bootctl: Fix exclusion issues around arm_smccc_smc

2021-06-25 Thread Shravan Kumar Ramani
Public bug reported: SRU Justification: [Impact] Exclusion is being handled around arm_smccc_smc() only in the store functions. It should be implemented in the show functions also as this call might not be thread-safe. [Fix] Add mutex_lock/unlock around arm_smccc_smc calls in the show

[Bug 1931984] [NEW] mlx-bootctl: Update license and version info

2021-06-15 Thread Shravan Kumar Ramani
Public bug reported: SRU Justification: [Impact] License info needs to be updated since the current info is no longer accurate. Driver version needs to be incremented since new features have been added. [Fix] Update license info to "Dual BSD/GPL". Increment version to 1.4 [Test Plan] Verify

[Bug 1931981] [NEW] mlx-bootctl: Fix potential buffer overflow

2021-06-15 Thread Shravan Kumar Ramani
Public bug reported: SRU Justification: [Impact] The sysfs store/show functions use sprintf without specifying a size which could lead to potential buffer overflow. [Fix] Replace sprintf with snprintf to avoid buffer overflow. Also, remove the redundant strlen usage since count is already

[Bug 1931843] [NEW] Update mlx-bootctl to access new fields in EEPROM MFG

2021-06-14 Thread Shravan Kumar Ramani
Public bug reported: SRU Justification: [Impact] The EEPROM MFG partition on BlueField-2 has been updated to include the VPD information for each card. In order to access these newly added fields, the mlx-bootctl driver needs to be updated to provide an access mechanism. [Fix] Add support for

[Bug 1926424] Re: Use rate-limited prints for mlx-trio errors

2021-05-16 Thread Shravan Kumar Ramani
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926424 Title: Use rate-limited prints for mlx-trio errors To manage

[Bug 1926424] [NEW] Use rate-limited prints for mlx-trio errors

2021-04-28 Thread Shravan Kumar Ramani
Public bug reported: The mlx-trio module's IRQ handler prints errors and additional debug info in case of errors. However, these prints can be excessive in certain cases, thereby interfering with other functions. This patch limits the message amount. SRU Justification: [Impact] In cases where

[Bug 1916318] Re: ACPI table updated for bluefield_edac module

2021-03-10 Thread Shravan Kumar Ramani
** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1916318 Title: ACPI table updated for bluefield_edac module To

[Bug 1916318] [NEW] ACPI table updated for bluefield_edac module

2021-02-19 Thread Shravan Kumar Ramani
Public bug reported: The ACPI table entry now specifies whether access to the EMI (memory interface which is part of the memory sub-system) registers needs to be via secure calls. This requires the driver to be updated in order to add SMC support. SRU Justification: [Impact] Since secure calls