Re: [Bug 1343245] Re: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume'
Quoting Tero Marttila (te...@paivola.fi): A type=VIR_STORAGE_TYPE_VOLUME disk is not necessarily a virStoragePoolDefPtr.type=VIR_STORAGE_POOL_LOGICAL, and may or may not involve a /dev/... path; the logic for translating them into src paths seems to be somewhere like qemuTranslateDiskSourcePool() via virStorageVolGetPath(), and seems to also depend on the mode? I did see that code and was worried that might be the case. AFAICT the significant difference is between the persistent config and the live running config for a domain; the later contains the actual translated source dev='...' / paths directly. Ideally virt-aa-helper would be based off of the translated config? Doesn't seem to be, though there may be some way of doing that that I'm not aware of. Current virt-aa-helper just seems to only read the domain's xml and works purely based on that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1343245 Title: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1343245/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1343245] Re: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume'
A type=VIR_STORAGE_TYPE_VOLUME disk is not necessarily a virStoragePoolDefPtr.type=VIR_STORAGE_POOL_LOGICAL, and may or may not involve a /dev/... path; the logic for translating them into src paths seems to be somewhere like qemuTranslateDiskSourcePool() via virStorageVolGetPath(), and seems to also depend on the mode? AFAICT the significant difference is between the persistent config and the live running config for a domain; the later contains the actual translated source dev='...' / paths directly. Ideally virt-aa-helper would be based off of the translated config? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1343245 Title: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1343245/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1343245] Re: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume'
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1343245 Title: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1343245/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1343245] Re: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume'
This patch appears to fix the issue for me. I'll propose it (cleaned up) on the mailing list. ** Patch added: virtaahelper-storagevol.patch https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1343245/+attachment/4156494/+files/virtaahelper-storagevol.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1343245 Title: virt-aa-helper does not whitelist actual source dev='...' paths for domain disk type='volume' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1343245/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
