[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Bug Watch Updater]

** Changed in: debian
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

Confirming that lvm installation works as expected, closing the d-i
task.

I would have hoped that lvm without stand-alone /boot would have worked.

Let me open a new bug report to re-validate that.

** Changed in: debian-installer (Ubuntu)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

New bug is here:
https://bugs.launchpad.net/ubuntu/+source/s390-tools/+bug/1543514

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[bugproxy]

** Tags removed: targetmilestone-inin---
** Tags added: targetmilestone-inin1604

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Viktor Mihajlovski]

** Bug watch added: Debian Bug tracker #814076
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=814076

** Also affects: debian via
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=814076
   Importance: Unknown
   Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Bug Watch Updater]

** Changed in: debian
   Status: Unknown => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Phillip Susi]

Then I'd say that the bug is actually in the kernel: it should *not* be
passing down the dasd partition manipulation ioctls. Patching parted to
ignore it based on GETGEO works around the problem and stops parted from
crashing, but ultimately, you do not want to allow any partitioning tool
to mess about with the dasd disk label through the lens of device-
mapper.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Phillip Susi]

Why does it even try to activate the dasd code on a logical volume?  It
shouldn't be doing that at all as it should not know or care that the
logical volume is built on top of a dasd disk.  Unless... iirc there was
some special ioctl that dasd disks have and that is how parted knows it
is dasd...  maybe device-mapper is passing this ioctl down and so parted
really is talking to a dasd disk?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Viktor Mihajlovski]

The parted code is iterating all the label types and consequently is
probing for DASD. The weird thing is that on one hand the DASD ioctl is
passed down to the physical volume (and  I mean weird: what would have
happened if the logical volume was realised by extents on both DASD and
SCSI disks?) and on the other hand silently igores the
HDIO_GETGEO.(which I can understand). Currently trying out a patch
similar to the one posted by Colin.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Viktor Mihajlovski]

Regarding comment #6: this doesn't affect s390-tools. Please remove the
connection to the package.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

** Changed in: s390-tools (Ubuntu)
 Assignee: (unassigned) => Dimitri John Ledkov (xnox)

** Package changed: s390-tools (Ubuntu) => debian-installer (Ubuntu)

** Changed in: debian-installer (Ubuntu)
 Assignee: Dimitri John Ledkov (xnox) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Viktor Mihajlovski]

You might want to try out this patch which worked for me. I was able to
partition the logical volume on top of a DASD PV. If this solves the
problem in the installer I can follow up with upstream.

** Patch added: "0001-fdasd.c-Safeguard-against-geometry-misprobing.patch"
   
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+attachment/4563858/+files/0001-fdasd.c-Safeguard-against-geometry-misprobing.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Launchpad Bug Tracker]

This bug was fixed in the package parted - 3.2-14ubuntu1

---
parted (3.2-14ubuntu1) xenial; urgency=medium

  * Apply patch from mihajlov to ignore geometry-less DASD that is picked
up under otherwise innocent LVM volumes. LP: #1541510

 -- Dimitri John Ledkov   Thu, 04 Feb 2016 16:18:31
+

** Changed in: parted (Ubuntu)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Ubuntu Foundations Team Bug Bot]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[bugproxy]

--- Comment From ru...@us.ibm.com 2016-02-03 16:34 EDT---
---Problem Description---
parted crashes on lvm, on a dasd drive

---Steps to Reproduce---
Bus-ID Status Name Device Type BlkSz Size Blocks
0.0.0200 active dasda 94:0 ECKD 4096 7042MB 1802880
0.0.0201 active dasdb 94:4 ECKD 4096 42258MB 10818180
0.0.0202 active dasdc 94:8 ECKD 4096 42258MB 10818180

** Tags added: architecture-s39064 bugnameltc-136561 severity-high
targetmilestone-inin---

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

not sure, if dasdfmt would be also affected

** Also affects: s390-tools (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

vtoc_set_freespace (f4=, f5=0x2aa0003c0e0, f7=,
ch=, verbose=0, start=2, stop=4294967295, cyl=60101, trk=0)
at ../../../libparted/labels/vtoc.c:1321

vtoc_set_freespace is called with trk=0, yet

1321:y = (u_int16_t) ((stop - start + 1) / trk);

tries to divide by zero.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

** Attachment added: "test_lvm_drive.c"
   
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+attachment/4563122/+files/test_lvm_drive.c

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Colin Watson]

Maybe try bailing out of fdasd_set_geometry if HDIO_GETGEO returns 0 for
sectors or heads; then the probing logic should move onto other labels,
since this isn't really a DASD anyway.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

fdasd_check_volume calls vtoc_set_freespace with anc->geo.heads argument

fdasd_check_volume is called from dasd_probe

which before calling fdasd_check_volume called fdasd_get_geometry, which
did iocl call, and filled the geometry with:

Heads 0
Secotrs 0
Cylinders 1023
Start 4397693661968

thus in vtoc_set_freespace we end up with division by zero and blow up

** Changed in: parted (Ubuntu)
 Assignee: (unassigned) => Viktor Mihajlovski (mihajlov)

** Changed in: parted (Ubuntu)
   Status: New => Confirmed

** Changed in: parted (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

$ sudo ./test_lvm_drive 
Heads 0
Secotrs 0
Cylinders 1023
Start 4397693661968

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

** Patch added: "cjwatson.patch"
   
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+attachment/4563149/+files/cjwatson.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

 I think you're going to see the same thing upstream
 The more generic _device_probe_geometry has explicit checks for 
getting non-zero sectors and heads back from HDIO_GETGEO
 and if it doesn't get them it uses defaults
 But fdasd_get_geometry doesn't have quite the same checks around its 
use of HDIO_GETGEO
 You ought to compare with the relevant kernel code, but my suspicion 
is that you don't get a sensible geometry back for an LV
 This is all inside dasd_probe, and an LV isn't really a DASD
 So one thing I'd try is making that situation be an error from 
fdasd_get_geometry and seeing if that behaves reasonably
 Something like http://paste.ubuntu.com/14868640/ maybe?
 Ew is that file really tabstop=4?  Anyway
 xnox: ^- suggestions above for you BTW

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

$ uname -a
Linux devac03 4.4.0-2-generic #16-Ubuntu SMP Thu Jan 28 15:44:18 UTC 2016 s390x 
s390x s390x GNU/Linux

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Dimitri John Ledkov]

$ sudo parted /dev/mapper/new-lvol0 
GNU Parted 3.2
Using /dev/mapper/new-lvol0
Welcome to GNU Parted! Type 'help' to view a list of commands.
(parted) print
BUG: trk is zero in vtoc_set_freespace call
BUG: trk is zero in vtoc_set_freespace call
Model: Linux device-mapper (linear) (dm)
Disk /dev/mapper/new-lvol0: 2097MB
Sector size (logical/physical): 4096B/4096B
Partition Table: dasd
Disk Flags: 

Number  Start  End  Size  File system  Flags


with my patch to avoid SIGFPE in said call. However, I think something more 
sensible should be done there instead.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1541510] Re: parted crashes on lvm, on a dasd drive

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: s390-tools (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1541510

Title:
  parted crashes on lvm, on a dasd drive

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs